[ 
https://issues.apache.org/jira/browse/YETUS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712298#comment-15712298
 ] 

Peter Vary commented on YETUS-471:
----------------------------------

Thanks [~sacharya] for the review.

To tell the truth, I do not feel that I understand the personality/module 
structure where the personality overwrites the original function, but I have 
seen this in the code:
{code}
## @description  Dequeue maven modules that lack java sources
## @audience     private
## @stability    evolving
## @replaceable  no
function findbugs_maven_skipper
{code}

{code}
## @description  Run the maven findbugs plugin and record found issues in a bug 
database
## @audience     private
## @stability    evolving
## @replaceable  no
## @return       0 on success
## @return       1 on failure
## @param        repostatus
function findbugs_runner
{code}

And I have thought that {{## @replaceable  no}} means that the personality is 
not supposed to overwrite this function.
Is there any documentation which could help me understand this better?

Thanks,
Peter

> Add possibility to configure Findbugs source folders
> ----------------------------------------------------
>
>                 Key: YETUS-471
>                 URL: https://issues.apache.org/jira/browse/YETUS-471
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Test Patch
>    Affects Versions: 0.3.0
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>         Attachments: YETUS-471.00.patch, YETUS-471.01.patch
>
>
> Trying to add yetus as a pre-commit test for Hive (see HIVE-15051)
> Findbugs plugin currently expects the project structure to be the standard 
> maven one (/src/main/java, /src/test/java). In Hive some of the modules have 
> a different file layout. It would be good to have a parameter introduced to 
> enable changes in checking directories.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to