[GitHub] [zookeeper] enixon commented on a change in pull request #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions

2019-10-12 Thread GitBox
enixon commented on a change in pull request #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068#discussion_r334261022 ## File path: zookeeper-client/zookeeper-client-c/src/zookeeper.c ## @@ -1037,13

[GitHub] [zookeeper] enixon commented on a change in pull request #1110: ZOOKEEPER-2354. zookeeper fails to start because of inconsistent epoch

2019-10-12 Thread GitBox
enixon commented on a change in pull request #1110: ZOOKEEPER-2354. zookeeper fails to start because of inconsistent epoch URL: https://github.com/apache/zookeeper/pull/1110#discussion_r334261351 ## File path:

[GitHub] [zookeeper] enixon commented on a change in pull request #1108: ZOOKEEPER-2238: Support limiting the maximum number of connections/clients to a zookeeper server

2019-10-12 Thread GitBox
enixon commented on a change in pull request #1108: ZOOKEEPER-2238: Support limiting the maximum number of connections/clients to a zookeeper server URL: https://github.com/apache/zookeeper/pull/1108#discussion_r334261511 ## File path:

[GitHub] [zookeeper] enixon commented on a change in pull request #1108: ZOOKEEPER-2238: Support limiting the maximum number of connections/clients to a zookeeper server

2019-10-12 Thread GitBox
enixon commented on a change in pull request #1108: ZOOKEEPER-2238: Support limiting the maximum number of connections/clients to a zookeeper server URL: https://github.com/apache/zookeeper/pull/1108#discussion_r334261601 ## File path:

[GitHub] [zookeeper] enixon commented on a change in pull request #1108: ZOOKEEPER-2238: Support limiting the maximum number of connections/clients to a zookeeper server

2019-10-12 Thread GitBox
enixon commented on a change in pull request #1108: ZOOKEEPER-2238: Support limiting the maximum number of connections/clients to a zookeeper server URL: https://github.com/apache/zookeeper/pull/1108#discussion_r334261656 ## File path:

[GitHub] [zookeeper] enixon commented on issue #822: ZOOKEEPER-3281:Add a new CLI:watch

2019-10-12 Thread GitBox
enixon commented on issue #822: ZOOKEEPER-3281:Add a new CLI:watch URL: https://github.com/apache/zookeeper/pull/822#issuecomment-541384541 I like this. Code looks good to me - my only thought for improvement is whether we can move the action on the watch firing into the callback so that

[GitHub] [zookeeper] jhuan31 opened a new pull request #1115: ZOOKEEPER-3574: Close quorum socket asynchronously to avoid server sh…

2019-10-12 Thread GitBox
jhuan31 opened a new pull request #1115: ZOOKEEPER-3574: Close quorum socket asynchronously to avoid server sh… URL: https://github.com/apache/zookeeper/pull/1115 …utdown stalled by long socket closing time This is an

[GitHub] [zookeeper] jhuan31 opened a new pull request #1116: ZOOKEEPER-3575: Moving sending packets in Learner to a separate thread

2019-10-12 Thread GitBox
jhuan31 opened a new pull request #1116: ZOOKEEPER-3575: Moving sending packets in Learner to a separate thread URL: https://github.com/apache/zookeeper/pull/1116 This is an automated message from the Apache Git Service. To