[GitHub] [zookeeper] yaojingguo commented on issue #1128: Fix comment

2019-11-03 Thread GitBox
yaojingguo commented on issue #1128: Fix comment URL: https://github.com/apache/zookeeper/pull/1128#issuecomment-549113823 Add more comment updates. This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [zookeeper] maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341837641 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md ## @@ -575,6 +581,

[GitHub] [zookeeper] maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341837525 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ## @@ -3028,6 +314

[GitHub] [zookeeper] maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341838130 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/PersistentRecursiveWatcherTest.java

[GitHub] [zookeeper] maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341841836 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ## @@ -3142,74 +31

[GitHub] [zookeeper] maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341837313 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ## @@ -373,6 +405,

[GitHub] [zookeeper] maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341837830 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/PathParentIteratorTest.java

[GitHub] [zookeeper] maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341839250 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md ## @@ -575,6 +581,

[GitHub] [zookeeper] maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341838827 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/Helpers.java ## @@ -0,0 +1,34

[GitHub] [zookeeper] maoling commented on issue #1108: ZOOKEEPER-2238: Support limiting the maximum number of connections/clients to a zookeeper server

2019-11-03 Thread GitBox
maoling commented on issue #1108: ZOOKEEPER-2238: Support limiting the maximum number of connections/clients to a zookeeper server URL: https://github.com/apache/zookeeper/pull/1108#issuecomment-549123064 Looking This is an a

[GitHub] [zookeeper] maoling commented on issue #1098: ZOOKEEPER-3560: Add response cache to serve get children (2) requests.

2019-11-03 Thread GitBox
maoling commented on issue #1098: ZOOKEEPER-3560: Add response cache to serve get children (2) requests. URL: https://github.com/apache/zookeeper/pull/1098#issuecomment-549133371 Since this PR has got 2+ votes, please ignore me and go ahead. @anmolnar @eolivelli -

[GitHub] [zookeeper] Randgalt commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
Randgalt commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341852741 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ## @@ -373,6 +405

[GitHub] [zookeeper] Randgalt commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
Randgalt commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341852861 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md ## @@ -575,6 +581

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
eolivelli commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341853430 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md ## @@ -575,6 +58

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
eolivelli commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341853498 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ## @@ -373,6 +40

[GitHub] [zookeeper] Randgalt commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
Randgalt commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341853753 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/Helpers.java ## @@ -0,0 +1,3

[GitHub] [zookeeper] Randgalt commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
Randgalt commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341853788 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ## @@ -3142,74 +3

[GitHub] [zookeeper] Randgalt commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
Randgalt commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341854227 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ## @@ -3142,74 +3

[GitHub] [zookeeper] anmolnar commented on issue #1105: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-03 Thread GitBox
anmolnar commented on issue #1105: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1105#issuecomment-549175745 @arshadmohammad PR hasn't been updated for 24 days. How are you getting on? I'm still happy to take this over and move forward.

[GitHub] [zookeeper] asfgit closed pull request #1129: ZOOKEEPER-3593: fix the default value of jute.maxbuffer in client side and an optimization for the documentation

2019-11-03 Thread GitBox
asfgit closed pull request #1129: ZOOKEEPER-3593: fix the default value of jute.maxbuffer in client side and an optimization for the documentation URL: https://github.com/apache/zookeeper/pull/1129 This is an automated messa

[GitHub] [zookeeper] maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
maoling commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341887556 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ## @@ -3182,6 +318

[GitHub] [zookeeper] Randgalt commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-03 Thread GitBox
Randgalt commented on a change in pull request #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341887772 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ## @@ -3182,6 +31

[GitHub] [zookeeper] maoling commented on a change in pull request #1128: Various code clean-upsFix comment

2019-11-03 Thread GitBox
maoling commented on a change in pull request #1128: Various code clean-upsFix comment URL: https://github.com/apache/zookeeper/pull/1128#discussion_r341897810 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/client/StaticHostProvider.java ## @@ -331,7 +3