Re: [PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Justus Winter
Hi :) Olly wrote: >It is hard to say if calling close() is actually useful here from just >seeing the patch. Huh? I provided a test case... Quoting Austin Clements (2012-02-29 23:17:54) >Quoth Olly Betts on Feb 29 at 9:19 pm: >> On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote: >

[PATCH] emacs: Mention race condition safety in user visible documentation

2012-02-29 Thread David Bremner
On Tue, 21 Feb 2012 10:15:08 +0100, Michal Sojka wrote: > -- >8 -- > Subject: [PATCH] emacs: Clarify description of thread manipulating functions > > It is not clear whether the term "thread" refers to the thread in the > database or to the thread currently shown in a buffer. Those two > meanings

[PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Olly Betts
On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote: > Quoth Justus Winter on Feb 29 at 10:19 am: > > Formerly the xapian database object was deleted and closed in its > > destructor once the object was garbage collected. Explicitly call > > close() so that the database and the associat

[alot] nottoomuch-addresses.sh config

2012-02-29 Thread Patrick Totzke
Quoting Philippe LeCavalier (2012-02-29 16:31:40) >I had nottoomuch-addresses.sh working perfectly in emacs and I'm trying >to get it going in alot. Here's[1] what I've got so far. One things that >really confusing me is the brackets in the help file[2]. As soon as I >put double brackets alot can't

Re: [PATCH] emacs: Mention race condition safety in user visible documentation

2012-02-29 Thread David Bremner
On Tue, 21 Feb 2012 10:15:08 +0100, Michal Sojka wrote: > -- >8 -- > Subject: [PATCH] emacs: Clarify description of thread manipulating functions > > It is not clear whether the term "thread" refers to the thread in the > database or to the thread currently shown in a buffer. Those two > meanings

[PATCH 5/5] test: mark exclude tests broken for 0.12

2012-02-29 Thread Mark Walters
--- test/search |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/test/search b/test/search index 414be35..c55522b 100755 --- a/test/search +++ b/test/search @@ -130,6 +130,7 @@ output=$(notmuch search "b?d?" | notmuch_search_sanitize) test_expect_equal "$output" "thread:X

[PATCH 4/5] cli: temporarily remove exclude tag support for 0.12

2012-02-29 Thread Mark Walters
--- notmuch-count.c |8 +--- notmuch-search.c |8 +--- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/notmuch-count.c b/notmuch-count.c index 63459fb..f86cb40 100644 --- a/notmuch-count.c +++ b/notmuch-count.c @@ -35,9 +35,6 @@ notmuch_count_command (void *ctx, in

[PATCH 3/5] man: remove search.exclude_tags from notmuch-config.1 for 0.12

2012-02-29 Thread Mark Walters
--- man/man1/notmuch-config.1 |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/man/man1/notmuch-config.1 b/man/man1/notmuch-config.1 index 0260eb7..36e09f4 100644 --- a/man/man1/notmuch-config.1 +++ b/man/man1/notmuch-config.1 @@ -85,14 +85,6 @@ directory hierarchy.

[PATCH 2/5] NEWS: revert NEWS item for exclude tags for 0.12

2012-02-29 Thread Mark Walters
--- NEWS | 18 -- 1 files changed, 0 insertions(+), 18 deletions(-) diff --git a/NEWS b/NEWS index b2bec04..5fa8043 100644 --- a/NEWS +++ b/NEWS @@ -11,24 +11,6 @@ Reply to sender to all. The feature is available through the new command line option --reply-to=(all|sender).

[PATCH 1/5] config: disable addition of exclude tags for 0.12

2012-02-29 Thread Mark Walters
This disables the addition of search_exclude_tags in notmuch-setup and notmuch-config. --- notmuch-config.c |3 +-- notmuch-setup.c | 19 +-- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/notmuch-config.c b/notmuch-config.c index e9b2750..61fda3e 100644 ---

[PATCH 0/5] Disable search.exclude_tags for 0.12

2012-02-29 Thread Mark Walters
As requested by David (Bremner) on irc here is a patch series disabling the search.exclude_tags feature as a temporary measure for the 0.12 release. There are two options: The first is to disable the addition of the new search.exclude_tags item to the config file and stop setup from asking for it

Replacing my name/email with "me" (or similar) in author lists

2012-02-29 Thread Austin Clements
On Wed, 29 Feb 2012 10:50:46 -0500, Jesse Rosenthal wrote: > On Wed, 29 Feb 2012 10:36:57 -0500, Austin Clements > wrote: > > What if the output of search (say, specifically the JSON format) > > included information on each message in the thread such as the > > 'message' production from devel/s

info about notmuch gui 'alot'

2012-02-29 Thread Patrick Totzke
Hi! The config syntax changed recently, when I switched from configparser to configobj. To clarify: * the new config syntax is explained in the user docs at http://alot.rtfd.org. These are auto-generated at each commit and correspond to the `testing` branch, which is where the bleeding edge

[PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Austin Clements
Quoth Olly Betts on Feb 29 at 9:19 pm: > On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote: > > Quoth Justus Winter on Feb 29 at 10:19 am: > > > Formerly the xapian database object was deleted and closed in its > > > destructor once the object was garbage collected. Explicitly call >

Re: Replacing my name/email with "me" (or similar) in author lists

2012-02-29 Thread Austin Clements
On Wed, 29 Feb 2012 10:50:46 -0500, Jesse Rosenthal wrote: > On Wed, 29 Feb 2012 10:36:57 -0500, Austin Clements wrote: > > What if the output of search (say, specifically the JSON format) > > included information on each message in the thread such as the > > 'message' production from devel/schem

Re: [PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Austin Clements
Quoth Olly Betts on Feb 29 at 9:19 pm: > On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote: > > Quoth Justus Winter on Feb 29 at 10:19 am: > > > Formerly the xapian database object was deleted and closed in its > > > destructor once the object was garbage collected. Explicitly call >

Re: [PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Olly Betts
On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote: > Quoth Justus Winter on Feb 29 at 10:19 am: > > Formerly the xapian database object was deleted and closed in its > > destructor once the object was garbage collected. Explicitly call > > close() so that the database and the associat

[alot] nottoomuch-addresses.sh config

2012-02-29 Thread Philippe LeCavalier
Hi. I had nottoomuch-addresses.sh working perfectly in emacs and I'm trying to get it going in alot. Here's[1] what I've got so far. One things that really confusing me is the brackets in the help file[2]. As soon as I put double brackets alot can't read the account. Am I misunderstanding somethi

Re: [alot] nottoomuch-addresses.sh config

2012-02-29 Thread Patrick Totzke
Quoting Philippe LeCavalier (2012-02-29 16:31:40) >I had nottoomuch-addresses.sh working perfectly in emacs and I'm trying >to get it going in alot. Here's[1] what I've got so far. One things that >really confusing me is the brackets in the help file[2]. As soon as I >put double brackets alot can't

Replacing my name/email with "me" (or similar) in author lists

2012-02-29 Thread Jesse Rosenthal
On Wed, 29 Feb 2012 10:36:57 -0500, Austin Clements wrote: > What if the output of search (say, specifically the JSON format) > included information on each message in the thread such as the > 'message' production from devel/schemata minus the body field? Then > the frontend would have loads of i

[PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Austin Clements
Quoth Justus Winter on Feb 29 at 10:19 am: > Formerly the xapian database object was deleted and closed in its > destructor once the object was garbage collected. Explicitly call > close() so that the database and the associated lock is released > immediately. Interesting. Is this a bug in Xapian

Replacing my name/email with "me" (or similar) in author lists

2012-02-29 Thread Austin Clements
Quoth Jesse Rosenthal on Feb 29 at 10:05 am: > On Sun, 26 Feb 2012 16:59:53 -0500, Tom Prince > wrote: > > It is probably overkill for any one feature, but it does seem like > > something useful to have. So maybe it would be worthwhile to create > > for this one feature, even it it is overkill. >

[PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Justus Winter
Formerly the xapian database object was deleted and closed in its destructor once the object was garbage collected. Explicitly call close() so that the database and the associated lock is released immediately. Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> --- lib/database.cc

fix notmuch_database_close

2012-02-29 Thread Justus Winter
Pazz mentioned a problem wrt reopening a notmuch database immediately after it has been closed. The problem can be reproduced with this test case: ~~~ snip ~~~ import os import notmuch db_path = os.path.expanduser('~/Maildir') for i in range(2): with notmuch.Database(db_path, mode=notmuch.Da

[PATCH 5/5] test: mark exclude tests broken for 0.12

2012-02-29 Thread Mark Walters
--- test/search |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/test/search b/test/search index 414be35..c55522b 100755 --- a/test/search +++ b/test/search @@ -130,6 +130,7 @@ output=$(notmuch search "bödý" | notmuch_search_sanitize) test_expect_equal "$output" "thread:X

[PATCH 4/5] cli: temporarily remove exclude tag support for 0.12

2012-02-29 Thread Mark Walters
--- notmuch-count.c |8 +--- notmuch-search.c |8 +--- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/notmuch-count.c b/notmuch-count.c index 63459fb..f86cb40 100644 --- a/notmuch-count.c +++ b/notmuch-count.c @@ -35,9 +35,6 @@ notmuch_count_command (void *ctx, in

[PATCH 2/5] NEWS: revert NEWS item for exclude tags for 0.12

2012-02-29 Thread Mark Walters
--- NEWS | 18 -- 1 files changed, 0 insertions(+), 18 deletions(-) diff --git a/NEWS b/NEWS index b2bec04..5fa8043 100644 --- a/NEWS +++ b/NEWS @@ -11,24 +11,6 @@ Reply to sender to all. The feature is available through the new command line option --reply-to=(all|sender).

[PATCH 3/5] man: remove search.exclude_tags from notmuch-config.1 for 0.12

2012-02-29 Thread Mark Walters
--- man/man1/notmuch-config.1 |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/man/man1/notmuch-config.1 b/man/man1/notmuch-config.1 index 0260eb7..36e09f4 100644 --- a/man/man1/notmuch-config.1 +++ b/man/man1/notmuch-config.1 @@ -85,14 +85,6 @@ directory hierarchy.

[PATCH 1/5] config: disable addition of exclude tags for 0.12

2012-02-29 Thread Mark Walters
This disables the addition of search_exclude_tags in notmuch-setup and notmuch-config. --- notmuch-config.c |3 +-- notmuch-setup.c | 19 +-- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/notmuch-config.c b/notmuch-config.c index e9b2750..61fda3e 100644 ---

[PATCH 0/5] Disable search.exclude_tags for 0.12

2012-02-29 Thread Mark Walters
As requested by David (Bremner) on irc here is a patch series disabling the search.exclude_tags feature as a temporary measure for the 0.12 release. There are two options: The first is to disable the addition of the new search.exclude_tags item to the config file and stop setup from asking for it

Replacing my name/email with "me" (or similar) in author lists

2012-02-29 Thread Jesse Rosenthal
On Sun, 26 Feb 2012 16:59:53 -0500, Tom Prince wrote: > It is probably overkill for any one feature, but it does seem like > something useful to have. So maybe it would be worthwhile to create > for this one feature, even it it is overkill. I can think of other features where some layer like thi

Re: info about notmuch gui 'alot'

2012-02-29 Thread Patrick Totzke
Hi! The config syntax changed recently, when I switched from configparser to configobj. To clarify: * the new config syntax is explained in the user docs at http://alot.rtfd.org. These are auto-generated at each commit and correspond to the `testing` branch, which is where the bleeding edge

[PATCH v5] News for Make buttons for attachments allow viewing as well as saving

2012-02-29 Thread Mark Walters
On Sat, 21 Jan 2012 09:09:58 -0400, David Bremner wrote: > On Fri, 20 Jan 2012 09:44:06 +, Mark Walters gmail.com> wrote: > > Define a keymap for attachment buttons to allow multiple actions. > > Define 3 possible actions: > > save attachment: exactly as currently, > > view attachmen

[Patch v6 12/13] emacs: show: recognize the exclude flag.

2012-02-29 Thread Mark Walters
The rest of the series still applies to master (bf28c60b9) but this patch needed rebasing/restructuring to fit with the Austin's keep-state patch. I attach the new patch below. Of course, if it is easier I can resend the whole series. Best wishes Mark >From 8324bc91e43d04e4c2813fa2a714766bcd0

[alot] nottoomuch-addresses.sh config

2012-02-29 Thread Philippe LeCavalier
Hi. I had nottoomuch-addresses.sh working perfectly in emacs and I'm trying to get it going in alot. Here's[1] what I've got so far. One things that really confusing me is the brackets in the help file[2]. As soon as I put double brackets alot can't read the account. Am I misunderstanding somethi

[PATCH v6 1/3] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

2012-02-29 Thread David Bremner
On Tue, 28 Feb 2012 19:40:04 +0100, Pieter Praet wrote: > > Though I couldn't help but notice (it's a curse...) that patch #3 > seems to have gained an extra space in its commit message subject: > > Original (id:"1329684627-10708-4-git-send-email-pieter at praet.org"): > emacs: add `notmuc

[PATCH 1/2] Convert non-UTF-8 parts to UTF-8 before indexing them

2012-02-29 Thread David Bremner
On Fri, 24 Feb 2012 08:36:22 +0100, Michal Sojka wrote: > This fixes a bug that didn't allow to search for non-ASCII words such > parts. The code here was copied from show_text_part_content(), because > the show command already does the needed conversion when showing the > message. pushed both,

[PATCH] test: Add test for searching of uncommonly encoded messages

2012-02-29 Thread David Bremner
On Fri, 24 Feb 2012 01:33:15 +0100, Michal Sojka wrote: > Emails that are encoded differently than as ASCII or UTF-8 are not > indexed properly by notmuch. It is not possible to search for non-ASCII > words within those messages. pushed d

[PATCH] doc: minor corrections in notmuch-config.1

2012-02-29 Thread David Bremner
On Tue, 28 Feb 2012 19:42:03 +0100, Pieter Praet wrote: > * man/man1/notmuch-config.1 pushed d

Re: Replacing my name/email with "me" (or similar) in author lists

2012-02-29 Thread Jesse Rosenthal
On Wed, 29 Feb 2012 10:36:57 -0500, Austin Clements wrote: > What if the output of search (say, specifically the JSON format) > included information on each message in the thread such as the > 'message' production from devel/schemata minus the body field? Then > the frontend would have loads of i

Re: [PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Austin Clements
Quoth Justus Winter on Feb 29 at 10:19 am: > Formerly the xapian database object was deleted and closed in its > destructor once the object was garbage collected. Explicitly call > close() so that the database and the associated lock is released > immediately. Interesting. Is this a bug in Xapian

Re: Replacing my name/email with "me" (or similar) in author lists

2012-02-29 Thread Austin Clements
Quoth Jesse Rosenthal on Feb 29 at 10:05 am: > On Sun, 26 Feb 2012 16:59:53 -0500, Tom Prince > wrote: > > It is probably overkill for any one feature, but it does seem like > > something useful to have. So maybe it would be worthwhile to create > > for this one feature, even it it is overkill. >

[PATCH v5] News for Make buttons for attachments allow viewing as well as saving

2012-02-29 Thread David Bremner
> > Here is a News patch for this feature. > Also pushed. The commit message comes out slightly eccentric, but I decided to leave it. d

Re: Replacing my name/email with "me" (or similar) in author lists

2012-02-29 Thread Jesse Rosenthal
On Sun, 26 Feb 2012 16:59:53 -0500, Tom Prince wrote: > It is probably overkill for any one feature, but it does seem like > something useful to have. So maybe it would be worthwhile to create > for this one feature, even it it is overkill. I can think of other features where some layer like this

Re: [PATCH v6 1/3] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

2012-02-29 Thread David Bremner
On Tue, 28 Feb 2012 19:40:04 +0100, Pieter Praet wrote: > > Though I couldn't help but notice (it's a curse...) that patch #3 > seems to have gained an extra space in its commit message subject: > > Original (id:"1329684627-10708-4-git-send-email-pie...@praet.org"): > emacs: add `notmuch-s

Re: [PATCH 1/2] Convert non-UTF-8 parts to UTF-8 before indexing them

2012-02-29 Thread David Bremner
On Fri, 24 Feb 2012 08:36:22 +0100, Michal Sojka wrote: > This fixes a bug that didn't allow to search for non-ASCII words such > parts. The code here was copied from show_text_part_content(), because > the show command already does the needed conversion when showing the > message. pushed both,

Re: [PATCH] test: Add test for searching of uncommonly encoded messages

2012-02-29 Thread David Bremner
On Fri, 24 Feb 2012 01:33:15 +0100, Michal Sojka wrote: > Emails that are encoded differently than as ASCII or UTF-8 are not > indexed properly by notmuch. It is not possible to search for non-ASCII > words within those messages. pushed d ___ notmuch m

Re: [PATCH] doc: minor corrections in notmuch-config.1

2012-02-29 Thread David Bremner
On Tue, 28 Feb 2012 19:42:03 +0100, Pieter Praet wrote: > * man/man1/notmuch-config.1 pushed d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v5] News for Make buttons for attachments allow viewing as well as saving

2012-02-29 Thread David Bremner
> > Here is a News patch for this feature. > Also pushed. The commit message comes out slightly eccentric, but I decided to leave it. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v5] News for Make buttons for attachments allow viewing as well as saving

2012-02-29 Thread Mark Walters
On Sat, 21 Jan 2012 09:09:58 -0400, David Bremner wrote: > On Fri, 20 Jan 2012 09:44:06 +, Mark Walters > wrote: > > Define a keymap for attachment buttons to allow multiple actions. > > Define 3 possible actions: > > save attachment: exactly as currently, > > view attachment: uses

[PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Justus Winter
Formerly the xapian database object was deleted and closed in its destructor once the object was garbage collected. Explicitly call close() so that the database and the associated lock is released immediately. Signed-off-by: Justus Winter <4win...@informatik.uni-hamburg.de> --- lib/database.cc |

fix notmuch_database_close

2012-02-29 Thread Justus Winter
Pazz mentioned a problem wrt reopening a notmuch database immediately after it has been closed. The problem can be reproduced with this test case: ~~~ snip ~~~ import os import notmuch db_path = os.path.expanduser('~/Maildir') for i in range(2): with notmuch.Database(db_path, mode=notmuch.Da

Re: [Patch v6 12/13] emacs: show: recognize the exclude flag.

2012-02-29 Thread Mark Walters
The rest of the series still applies to master (bf28c60b9) but this patch needed rebasing/restructuring to fit with the Austin's keep-state patch. I attach the new patch below. Of course, if it is easier I can resend the whole series. Best wishes Mark >From 8324bc91e43d04e4c2813fa2a714766bcd0