[Joerg Jaspert] Bug#666027: notmuch: get a quiet option

2012-03-27 Thread David Bremner
An embedded message was scrubbed... From: Joerg Jaspert Subject: Bug#666027: notmuch: get a quiet option Date: Tue, 27 Mar 2012 23:36:33 +0200 Size: 5189 URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120327/ca0134fa/attachment.mht>

[PATCH v3 0/4] cli: notmuch tag/restore refactoring

2012-03-27 Thread Tomi Ollila
On Tue, Mar 27 2012, Jani Nikula wrote: > v3 of id:"cover.1332702915.git.jani at nikula.org" with the following > mostly non-functional changes: > > - add test for the current tagging behaviour in patch 1, and change the >test in patch 2 when the behaviour is changed > - handle the no tag c

[Joerg Jaspert] Bug#666027: notmuch: get a quiet option

2012-03-27 Thread David Bremner
--- Begin Message --- Package: notmuch Version: 0.12-1 Severity: wishlist Dear Maintainer, a feature wish to get to upstream: as the subject says, it would be nice if notmuch gets a "quiet" option. Especially for "notmuch new" that is. Its printing out lots of "Note: Ignoring blah" and "Processe

[PATCH v2 3/3] reply: Move reply citation printing to the recursive MIME walk

2012-03-27 Thread Austin Clements
This makes more logical sense, since it makes the recursive printer responsible for the entire reply body and lets it start at the root of the MIME tree instead of the first child. (We could move reply header creation in there, too, but if we ever support proper reply to multiple messages, we'll w

[PATCH v2 2/3] reply: Convert default reply format to self-recursive style

2012-03-27 Thread Austin Clements
This re-arranges the default reply formatter code to use the mime_node_t abstraction. There are no semantic changes. --- notmuch-reply.c | 123 +-- 1 files changed, 47 insertions(+), 76 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply

[PATCH v2 1/3] show/reply: Unify the code that extracts text parts

2012-03-27 Thread Austin Clements
Previously, show and reply had separate implementations of decoding and printing text parts. Now both use show's implementation, which was more complete. Show's implementation has been extended with an option to add reply quoting to the extracted part (this is implemented as a named flag to avoid

[PATCH v2 0/3] Rewrite default reply format

2012-03-27 Thread Austin Clements
This version fixes two minor formatting issues that Tomi pointed out [1]. There are no other changes. [1] id:"m2d382ia9d.fsf at guru.guru-group.fi"

[PATCH 0/3] Rewrite default reply format

2012-03-27 Thread Austin Clements
Thanks for the review. New version coming shortly... Quoth Tomi Ollila on Mar 24 at 12:06 pm: > Austin Clements writes: > > > The default reply format is the last bastion of the old message > > formatter style. This series converts it to the new self-recursive > > style. After this, there wil

bug in emacs reply code?

2012-03-27 Thread Jani Nikula
Hi all, just upgraded from 0.11 to master on one machine, and emacs reply started failing as follows. The four tests fail, all others pass. $ emacs --version GNU Emacs 23.2.1 $ make test [...] emacs: Testing emacs interface [...] FAIL Reply within emacs --- emacs.24.expected 2012-03-

[PATCH v2 1/3] show/reply: Unify the code that extracts text parts

2012-03-27 Thread Austin Clements
Previously, show and reply had separate implementations of decoding and printing text parts. Now both use show's implementation, which was more complete. Show's implementation has been extended with an option to add reply quoting to the extracted part (this is implemented as a named flag to avoid

[PATCH v2 2/3] reply: Convert default reply format to self-recursive style

2012-03-27 Thread Austin Clements
This re-arranges the default reply formatter code to use the mime_node_t abstraction. There are no semantic changes. --- notmuch-reply.c | 123 +-- 1 files changed, 47 insertions(+), 76 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply

[PATCH v2 3/3] reply: Move reply citation printing to the recursive MIME walk

2012-03-27 Thread Austin Clements
This makes more logical sense, since it makes the recursive printer responsible for the entire reply body and lets it start at the root of the MIME tree instead of the first child. (We could move reply header creation in there, too, but if we ever support proper reply to multiple messages, we'll w

[PATCH v2 0/3] Rewrite default reply format

2012-03-27 Thread Austin Clements
This version fixes two minor formatting issues that Tomi pointed out [1]. There are no other changes. [1] id:"m2d382ia9d@guru.guru-group.fi" ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 0/3] Rewrite default reply format

2012-03-27 Thread Austin Clements
Thanks for the review. New version coming shortly... Quoth Tomi Ollila on Mar 24 at 12:06 pm: > Austin Clements writes: > > > The default reply format is the last bastion of the old message > > formatter style. This series converts it to the new self-recursive > > style. After this, there wil

Goto command for existing search windows

2012-03-27 Thread Mark Anderson
I was looking for a function which would find a buffer based on one of my saved searches, and perform the search if it didn't exist. I've gotten it a bit closer, if I perform the search that matches a saved search, then this routine will find it because of the magic in notmuch-search-buffer-title,

Goto command for existing search windows

2012-03-27 Thread Mark Anderson
I was looking for a function which would find a buffer based on one of my saved searches, and perform the search if it didn't exist. I've gotten it a bit closer, if I perform the search that matches a saved search, then this routine will find it because of the magic in notmuch-search-buffer-title,

Re: [PATCH v3 0/4] cli: notmuch tag/restore refactoring

2012-03-27 Thread Tomi Ollila
On Tue, Mar 27 2012, Jani Nikula wrote: > v3 of id:"cover.1332702915.git.j...@nikula.org" with the following > mostly non-functional changes: > > - add test for the current tagging behaviour in patch 1, and change the >test in patch 2 when the behaviour is changed > - handle the no tag chan

[PATCH 1/7] Split notmuch_database_close into two functions

2012-03-27 Thread Justus Winter
Formerly notmuch_database_close closed the xapian database and destroyed the talloc structure associated with the notmuch database object. Split notmuch_database_close into notmuch_database_close and notmuch_database_destroy. This makes it possible for long running programs to close the xapian dat

[RFC] Split notmuch_database_close into two functions

2012-03-27 Thread Justus Winter
You're right of course, updated patch sent as a follow up. Justus

[PATCH 0/2] Escape message ID queries in Emacs

2012-03-27 Thread Tomi Ollila
On Tue, Mar 27 2012, Austin Clements wrote: > Currently, Emacs does not escape message ID queries and is > inconsistent about quoting them. This patch centralizes this in one > function that always produces a properly quoted and escaped message ID > query. > > With this, Emacs no longer gets conf

[PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

2012-03-27 Thread Tomi Ollila
On Tue, Mar 27 2012, Austin Clements wrote: > Previously, this function took an argument called "message-id", even > though it was a general query, rather than a message ID. This changes > it to "query". > --- +1 Tomi > emacs/notmuch-lib.el |4 ++-- > 1 files changed, 2 insertions(+),

bug in emacs reply code?

2012-03-27 Thread Jani Nikula
Hi all, just upgraded from 0.11 to master on one machine, and emacs reply started failing as follows. The four tests fail, all others pass. $ emacs --version GNU Emacs 23.2.1 $ make test [...] emacs: Testing emacs interface [...] FAIL Reply within emacs --- emacs.24.expected 2012-03-

Unofficial notmuch wiki concerns

2012-03-27 Thread David Bremner
A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 315 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120327/6c524d7b/attachment.pgp>

Re: Unofficial notmuch wiki concerns

2012-03-27 Thread David Bremner
On Mon, 26 Mar 2012 12:39:47 -0500, Kyle Sexton wrote: > > My goal is to make a site where the documentation is easy to update, > and attractive. My concern is having too many places out there for > information. I tried to assuage that with the disclaimer pointing to > the canonical site. Does

[PATCH 0/2] Escape message ID queries in Emacs

2012-03-27 Thread Austin Clements
On Tue, 27 Mar 2012, Tomi Ollila wrote: > On Tue, Mar 27 2012, Austin Clements wrote: > >> Currently, Emacs does not escape message ID queries and is >> inconsistent about quoting them. This patch centralizes this in one >> function that always produces a properly quoted and escaped message ID >>

[PATCH 1/7] Split notmuch_database_close into two functions

2012-03-27 Thread Justus Winter
Formerly notmuch_database_close closed the xapian database and destroyed the talloc structure associated with the notmuch database object. Split notmuch_database_close into notmuch_database_close and notmuch_database_destroy. This makes it possible for long running programs to close the xapian dat

Re: [RFC] Split notmuch_database_close into two functions

2012-03-27 Thread Justus Winter
You're right of course, updated patch sent as a follow up. Justus ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v3 4/4] cli: refactor "notmuch restore" message tagging into a separate function

2012-03-27 Thread Jani Nikula
Refactor to make tagging code easier to reuse in the future. No functional changes. Signed-off-by: Jani Nikula --- notmuch-restore.c | 148 - 1 files changed, 78 insertions(+), 70 deletions(-) diff --git a/notmuch-restore.c b/notmuch-restore.

[PATCH v3 3/4] cli: refactor "notmuch tag" query tagging into a separate function

2012-03-27 Thread Jani Nikula
Refactor to make tagging code easier to reuse in the future. No functional changes. Signed-off-by: Jani Nikula --- notmuch-tag.c | 104 + 1 files changed, 60 insertions(+), 44 deletions(-) diff --git a/notmuch-tag.c b/notmuch-tag.c index

[PATCH v3 2/4] cli: refactor "notmuch tag" data structures for tagging operations

2012-03-27 Thread Jani Nikula
To simplify code, keep all tagging operations in a single array instead of separate add and remove arrays. Apply tag changes in the order specified on the command line, instead of first removing and then adding the tags. This results in a minor functional change: If a tag is both added and removed

[PATCH v3 1/4] test: add test for both adding and removing a tag at the same time

2012-03-27 Thread Jani Nikula
The current behaviour is that regardless of the order in which the addition and removal of a tag are specified, the tag is added. Signed-off-by: Jani Nikula --- test/tagging |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/test/tagging b/test/tagging index 77202bf.

[PATCH v3 0/4] cli: notmuch tag/restore refactoring

2012-03-27 Thread Jani Nikula
v3 of id:"cover.1332702915.git.jani at nikula.org" with the following mostly non-functional changes: - add test for the current tagging behaviour in patch 1, and change the test in patch 2 when the behaviour is changed - handle the no tag changes case in _optimize_tag_query() in patch 2 - ad

Re: [PATCH 0/2] Escape message ID queries in Emacs

2012-03-27 Thread Austin Clements
On Tue, 27 Mar 2012, Tomi Ollila wrote: > On Tue, Mar 27 2012, Austin Clements wrote: > >> Currently, Emacs does not escape message ID queries and is >> inconsistent about quoting them. This patch centralizes this in one >> function that always produces a properly quoted and escaped message ID >>