Jameson Graef Rollins writes:
> +diff OUTPUT.{text,html} >OUTPUT.diff
> +cat +7,9c7,10
> +< [ text/html (not shown) ]
> +< [ text/plain ]
> +< This is the text/plain part of a multipart/alternative.
> +---
> +> [ text/html ]
> +> This is the text/html part of a
Peter Wang writes:
> Update tests to expect content-length and content-transfer-encoding
> fields in show --format=json output, for leaf parts with omitted body
> content.
These three patches all look fine to me, except for the following
problem.
> diff --git a/test/json b/test/json
> index
Peter Wang writes:
> If a leaf part's body content is omitted, return the content length in
> --format=json output. This information may be used by the consumer,
> e.g. to decide whether to download a large attachment over a slow link.
It looks like this patch series was thoroughly reviewed
Mark Walters writes:
> Split out the json parser into a utility function.
> ---
>
> Most of this patch is code movement: but I don't see how to arrange the
> patch to show that.
Hi! This looks like a straightforward patch and if it will make
notmuch-pick more efficient, I'm in favor.
I tagged
Daniel Bergey writes:
> From a show buffer, bbdb/notmuch-snarf-from imports the sender into
> bbdb. bbdb/notmuch-snarf-to attempts to import all recipients. BBDB
> displays a buffer with each contact; C-g displays the next contact, or
> returns to the notmuch-show buffer.
>
> This is my first
Ethan Glasser-Camp writes:
> It looks like you have better wording for patch 4/8 so I'd like to see
> you resend it.
>
> I'm marking patches 3, 4, and 7 as moreinfo. Please resubmit!
It turns out that patch 4 already has a v2 in the thread, but I didn't
see it due to some kind of selective
Mark Walters writes:
> Some messages are sent as multipart/alternative but the alternatives
> contain different information. This allows the user to cycle which
> part to view. By default this is bound to 'W'.
> ---
>
> This version at least uses the notmuch escaping for message-id which
> makes
Users who relied on notmuch-show-all-multipart/alternative-parts
might need to know that it is now buffer-local.
Signed-off-by: Ethan Glasser-Camp
---
Hi! I'm trying to figure out the status of this patch series, which
seems to have fallen through the cracks. It looks like Jani's solution
exists
On Wed, 17 Oct 2012, Adrien Bustany wrote:
> The code of the patches in unchanged, but the formatting issues are now
> hopefully fixed.
Hi Adrien, please check at what version flush and reopen have been
introduced to xapian. If they are new-ish (I don't know, didn't have the
time to check),
Peter Wang writes:
> Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can
> cover all four values of search --exclude in the cli.
This series looks good to me. It's a nice clean up and a nice new
feature. Patches all apply.
However, I'm getting test failures like:
FAIL Search,
Adrien Bustany writes:
> This makes notmuch appropriately free the underlying notmuch C objects
> when garbage collecting their Go wrappers. To make sure we don't break
> the underlying links between objects (for example, a notmuch_messages_t
> being GC'ed before a notmuch_message_t belonging to
ccx at webprojekty.cz writes:
> Hello, for quite some time my set of scripts just lied in my repo and
> waited for polish before release. So tonight I finally managed to update
> the docs, remove old stuff, rewrite some unfortunate things etc.
>
> One notable addition is slrn2maildir script which
Adrien Bustany writes:
> The code of the patches in unchanged, but the formatting issues are now
> hopefully fixed.
These look fine to me, and they're pretty trivial.
Ethan
On Wed, 17 Oct 2012, Adrien Bustany adr...@bustany.org wrote:
The code of the patches in unchanged, but the formatting issues are now
hopefully fixed.
Hi Adrien, please check at what version flush and reopen have been
introduced to xapian. If they are new-ish (I don't know, didn't have the
time
Users who relied on notmuch-show-all-multipart/alternative-parts
might need to know that it is now buffer-local.
Signed-off-by: Ethan Glasser-Camp et...@betacantrips.com
---
Hi! I'm trying to figure out the status of this patch series, which
seems to have fallen through the cracks. It looks like
Mark Walters markwalters1...@gmail.com writes:
Some messages are sent as multipart/alternative but the alternatives
contain different information. This allows the user to cycle which
part to view. By default this is bound to 'W'.
---
This version at least uses the notmuch escaping for
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes:
It looks like you have better wording for patch 4/8 so I'd like to see
you resend it.
I'm marking patches 3, 4, and 7 as moreinfo. Please resubmit!
It turns out that patch 4 already has a v2 in the thread, but I didn't
see it due to
Daniel Bergey ber...@alum.mit.edu writes:
From a show buffer, bbdb/notmuch-snarf-from imports the sender into
bbdb. bbdb/notmuch-snarf-to attempts to import all recipients. BBDB
displays a buffer with each contact; C-g displays the next contact, or
returns to the notmuch-show buffer.
This
Mark Walters markwalters1...@gmail.com writes:
Split out the json parser into a utility function.
---
Most of this patch is code movement: but I don't see how to arrange the
patch to show that.
Hi! This looks like a straightforward patch and if it will make
notmuch-pick more efficient, I'm
Peter Wang noval...@gmail.com writes:
If a leaf part's body content is omitted, return the content length in
--format=json output. This information may be used by the consumer,
e.g. to decide whether to download a large attachment over a slow link.
It looks like this patch series was
Peter Wang noval...@gmail.com writes:
Update tests to expect content-length and content-transfer-encoding
fields in show --format=json output, for leaf parts with omitted body
content.
These three patches all look fine to me, except for the following
problem.
diff --git a/test/json
Jameson Graef Rollins jroll...@finestructure.net writes:
+diff OUTPUT.{text,html} OUTPUT.diff
+cat EOF EXPECTED.diff
+7,9c7,10
+ [ text/html (not shown) ]
+ [ text/plain ]
+ This is the text/plain part of a multipart/alternative.
+---
+ [ text/html ]
+ This is the text/html part of a
da...@tethera.net writes:
This obsoletes the series at:
id:134431-4301-1-git-send-email-brem...@debian.org
Changes since v2:
- clean up new test-binaries and objects
- remove the set -o pipefail leftover from debugging. Possibly this
makes sense as a global setting, but in a
23 matches
Mail list logo