[PATCH v2 0/2] emacs: Shortcut keys to saved searches

2014-07-15 Thread Mark Walters
On Tue, 15 Jul 2014, Austin Clements wrote: > This is version 2 of > id:1405353735-26244-1-git-send-email-amdragon at mit.edu and addresses > Mark's comments in id:87egxnd4aq.fsf at qmul.ac.uk. > > The diff from v1 is below. This version gets a +1 from me. I would have a slight preference for

[PATCH 4/4] nmbug: Add an 'init' command

2014-07-15 Thread David Bremner
"W. Trevor King" writes: > +sub do_init { > + my $tempwork = tempdir ('/tmp/nmbug-init.XX', CLEANUP => 1); > + system ('git', 'init', '--separate-git-dir', $NMBGIT, $tempwork) == 0 > +or die "'git init' exited with nonzero value\n"; > + git ('config', '--unset', 'core.worktree'); > +

[PATCH 3/4] nmbug: Catch stderr in is_unmerged

2014-07-15 Thread David Bremner
"W. Trevor King" writes: > + if ($dir eq '-2|') { > +$dir = '-|'; > + } > + I think I'd prefer an extra flag, rather than making new syntax. The existing syntax is not pretty, but it is standard perl

[PATCH 2/4] nmbug: Handle missing @upstream in is_unmerged

2014-07-15 Thread David Bremner
"W. Trevor King" writes: > - my $fetch_head = git ('rev-parse', $commit); > + my ($fetch_head, $status) = git_with_status ('rev-parse', $commit); > + if ($status) { > +return 0; > + } Could there be other errors here, other than @{upstream} not existing? At first glance it seems like

[PATCH] emacs: tree/show remove duplicate function

2014-07-15 Thread David Bremner
Mark Walters writes: > On Tue, 15 Jul 2014, David Bremner wrote: >> Mark Walters writes: >>> + (cond ((eq major-mode 'notmuch-show-mode) >>> + (notmuch-show-get-message-properties)) >>> +((eq major-mode 'notmuch-tree-mode) >>> +

[PATCH v2 0/6] nmbug-status fixups from notmuch-to-html

2014-07-15 Thread David Bremner
"W. Trevor King" writes: > Changes from v1 [1] > > * Tweaked the license commit message (1/6) [2] with Carl's permission > [3]. > * Squashed v1's footer commits (old 2/5, 3/5, and 6/5, now 3/6) [4]. > * Squashed v1's description commits (old 4/5 and 5/5, now 2/6) [4]. > * Added commits 4/6,

[PATCH] emacs: search archive tweak

2014-07-15 Thread David Bremner
Mark Walters writes: > notmuch-search-archive-thread moves to the next line after tagging. In > the normal case this makes sense, but if the region is active, it tags > the whole region and then it doesn't really. Thus only move to the > next line if region is not active. > --- pushed to

[PATCH v2 2/2] emacs: Expand default saved searches and add shortcut keys

2014-07-15 Thread David Bremner
Austin Clements writes: > This should help new users off to a better start with the addition of > more sensible saved searches and default shortcut keys. Most existing > users have probably customized this variable and won't be affected. I didn't have a chance to review the code, but I like

notmuch-reply date format

2014-07-15 Thread Sime Ramov
Hi, * Austin Clements [2014-07-15 16:14 +0200]: > Close. For whatever reason, localtime takes a pointer to a time_t, > not a time_t (even though time_t is just a number). You'll need > something like > > [...] Thank you *so much*, everything is in order now! Finally a nice attribution line :)

[PATCH 3/4] nmbug: Catch stderr in is_unmerged

2014-07-15 Thread W. Trevor King
P digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140715/5641a03a/attachment.pgp>

[PATCH 4/4] nmbug: Add an 'init' command

2014-07-15 Thread W. Trevor King
nuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140715/c652b5c9/attachment.pgp>

[PATCH 2/4] nmbug: Handle missing @upstream in is_unmerged

2014-07-15 Thread W. Trevor King
ment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140715/023b1ed3/attachment-0001.pgp>

[PATCH v2 2/2] emacs: Expand default saved searches and add shortcut keys

2014-07-15 Thread Austin Clements
This should help new users off to a better start with the addition of more sensible saved searches and default shortcut keys. Most existing users have probably customized this variable and won't be affected. --- emacs/notmuch-hello.el | 9 +++--

[PATCH v2 1/2] emacs: Introduce notmuch-jump: shortcut keys to saved searches

2014-07-15 Thread Austin Clements
This introduces notmuch-jump, which is like a user-friendly, user-configurable global prefix map for saved searches. This provides a non-modal and much faster way to access saved searches than notmuch-hello. A user configures shortcut keys in notmuch-saved-searches, which are immediately

[PATCH v2 0/2] emacs: Shortcut keys to saved searches

2014-07-15 Thread Austin Clements
This is version 2 of id:1405353735-26244-1-git-send-email-amdragon at mit.edu and addresses Mark's comments in id:87egxnd4aq.fsf at qmul.ac.uk. The diff from v1 is below. diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el index cb1ae10..9cb1e6a 100644 --- a/emacs/notmuch-jump.el +++

notmuch-reply date format

2014-07-15 Thread Sime Ramov
Hello, * Austin Clements [Mon, 14 Jul 2014 09:04:31 -0400]: > Assuming the CLI is the right place for you to change this, you > probably want to call notmuch_message_get_date, then localtime, then > strftime. Tried to get this working to no avail. Not a programmer obviously :) I cobbled this

[PATCH] emacs: tree/show remove duplicate function

2014-07-15 Thread Mark Walters
On Tue, 15 Jul 2014, David Bremner wrote: > Mark Walters writes: >> + (cond ((eq major-mode 'notmuch-show-mode) >> + (notmuch-show-get-message-properties)) >> + ((eq major-mode 'notmuch-tree-mode) >> +

[PATCH 1/2] emacs: Introduce notmuch-jump: shortcut keys to saved searches

2014-07-15 Thread Mark Walters
On Tue, 15 Jul 2014, Austin Clements wrote: > Quoth Mark Walters on Jul 14 at 10:22 pm: >> >> On Mon, 14 Jul 2014, Austin Clements wrote: >> > This introduces notmuch-jump, which is like a user-friendly, >> > user-configurable global prefix map for saved searches. This provides >> > a

nevermore

2014-07-15 Thread David Bremner
Trevor Jim writes: > Nevermore is an experimental emacs email interface for Notmuch. > It provides: > > * Interactive search > * Snooze > * Tag editing with autocompletion > * Mail address completion (via company-mode) > * Junk mail filtering (via bogofilter) At least the interactive search and

[PATCH] emacs: tree/show remove duplicate function

2014-07-15 Thread David Bremner
Mark Walters writes: > > Plausibly a comment and an explicit nil case would be clearer for the other > modes. > Your call. d

[PATCH 1/2] emacs: Introduce notmuch-jump: shortcut keys to saved searches

2014-07-15 Thread Austin Clements
Quoth Mark Walters on Jul 14 at 10:22 pm: > > On Mon, 14 Jul 2014, Austin Clements wrote: > > This introduces notmuch-jump, which is like a user-friendly, > > user-configurable global prefix map for saved searches. This provides > > a non-modal and much faster way to access saved searches than

Re: [PATCH 1/2] emacs: Introduce notmuch-jump: shortcut keys to saved searches

2014-07-15 Thread Mark Walters
On Tue, 15 Jul 2014, Austin Clements amdra...@mit.edu wrote: Quoth Mark Walters on Jul 14 at 10:22 pm: On Mon, 14 Jul 2014, Austin Clements amdra...@mit.edu wrote: This introduces notmuch-jump, which is like a user-friendly, user-configurable global prefix map for saved searches. This

Re: [PATCH] emacs: tree/show remove duplicate function

2014-07-15 Thread Mark Walters
On Tue, 15 Jul 2014, David Bremner da...@tethera.net wrote: Mark Walters markwalters1...@gmail.com writes: + (cond ((eq major-mode 'notmuch-show-mode) + (notmuch-show-get-message-properties)) + ((eq major-mode 'notmuch-tree-mode) +

Re: notmuch-reply date format

2014-07-15 Thread Sime Ramov
Hello, * Austin Clements amdra...@mit.edu [Mon, 14 Jul 2014 09:04:31 -0400]: Assuming the CLI is the right place for you to change this, you probably want to call notmuch_message_get_date, then localtime, then strftime. Tried to get this working to no avail. Not a programmer obviously :) I

Re: [PATCH] emacs: tree/show remove duplicate function

2014-07-15 Thread David Bremner
Mark Walters markwalters1...@gmail.com writes: Plausibly a comment and an explicit nil case would be clearer for the other modes. Your call. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: nevermore

2014-07-15 Thread David Bremner
Trevor Jim t...@mac.com writes: Nevermore is an experimental emacs email interface for Notmuch. It provides: * Interactive search * Snooze * Tag editing with autocompletion * Mail address completion (via company-mode) * Junk mail filtering (via bogofilter) At least the interactive search

[PATCH v2 2/2] emacs: Expand default saved searches and add shortcut keys

2014-07-15 Thread Austin Clements
This should help new users off to a better start with the addition of more sensible saved searches and default shortcut keys. Most existing users have probably customized this variable and won't be affected. --- emacs/notmuch-hello.el | 9 +++--

[PATCH v2 1/2] emacs: Introduce notmuch-jump: shortcut keys to saved searches

2014-07-15 Thread Austin Clements
This introduces notmuch-jump, which is like a user-friendly, user-configurable global prefix map for saved searches. This provides a non-modal and much faster way to access saved searches than notmuch-hello. A user configures shortcut keys in notmuch-saved-searches, which are immediately

Re: [PATCH] dump: make dump take Xapian write lock

2014-07-15 Thread David Bremner
Mark Walters markwalters1...@gmail.com writes: Discussion with Olly on irc indicates that this is currently the best solution: in xapian trunk there may be better possibilities using snapshots but they need to make it to a release and propogate out to users before we can switch approach. I

Re: notmuch-reply date format

2014-07-15 Thread Austin Clements
Quoth Sime Ramov on Jul 15 at 9:35 am: Hello, * Austin Clements amdra...@mit.edu [Mon, 14 Jul 2014 09:04:31 -0400]: Assuming the CLI is the right place for you to change this, you probably want to call notmuch_message_get_date, then localtime, then strftime. Tried to get this working

[PATCH v2 0/2] emacs: Shortcut keys to saved searches

2014-07-15 Thread Austin Clements
This is version 2 of id:1405353735-26244-1-git-send-email-amdra...@mit.edu and addresses Mark's comments in id:87egxnd4aq@qmul.ac.uk. The diff from v1 is below. diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el index cb1ae10..9cb1e6a 100644 --- a/emacs/notmuch-jump.el +++

Re: notmuch-reply date format

2014-07-15 Thread Sime Ramov
Hi, * Austin Clements amdra...@mit.edu [2014-07-15 16:14 +0200]: Close. For whatever reason, localtime takes a pointer to a time_t, not a time_t (even though time_t is just a number). You'll need something like [...] Thank you *so much*, everything is in order now! Finally a nice

Re: [PATCH v2 0/2] emacs: Shortcut keys to saved searches

2014-07-15 Thread Mark Walters
On Tue, 15 Jul 2014, Austin Clements amdra...@mit.edu wrote: This is version 2 of id:1405353735-26244-1-git-send-email-amdra...@mit.edu and addresses Mark's comments in id:87egxnd4aq@qmul.ac.uk. The diff from v1 is below. This version gets a +1 from me. I would have a slight preference

Re: [PATCH v2 2/2] emacs: Expand default saved searches and add shortcut keys

2014-07-15 Thread David Bremner
Austin Clements amdra...@mit.edu writes: This should help new users off to a better start with the addition of more sensible saved searches and default shortcut keys. Most existing users have probably customized this variable and won't be affected. I didn't have a chance to review the code,

Re: [PATCH v2 0/6] nmbug-status fixups from notmuch-to-html

2014-07-15 Thread David Bremner
W. Trevor King wk...@tremily.us writes: Changes from v1 [1] * Tweaked the license commit message (1/6) [2] with Carl's permission [3]. * Squashed v1's footer commits (old 2/5, 3/5, and 6/5, now 3/6) [4]. * Squashed v1's description commits (old 4/5 and 5/5, now 2/6) [4]. * Added commits

Re: [PATCH] emacs: tree/show remove duplicate function

2014-07-15 Thread David Bremner
Mark Walters markwalters1...@gmail.com writes: On Tue, 15 Jul 2014, David Bremner da...@tethera.net wrote: Mark Walters markwalters1...@gmail.com writes: + (cond ((eq major-mode 'notmuch-show-mode) + (notmuch-show-get-message-properties)) +

Re: [PATCH 2/4] nmbug: Handle missing @upstream in is_unmerged

2014-07-15 Thread David Bremner
W. Trevor King wk...@tremily.us writes: - my $fetch_head = git ('rev-parse', $commit); + my ($fetch_head, $status) = git_with_status ('rev-parse', $commit); + if ($status) { +return 0; + } Could there be other errors here, other than @{upstream} not existing? At first glance it

Re: [PATCH 3/4] nmbug: Catch stderr in is_unmerged

2014-07-15 Thread David Bremner
W. Trevor King wk...@tremily.us writes: + if ($dir eq '-2|') { +$dir = '-|'; + } + I think I'd prefer an extra flag, rather than making new syntax. The existing syntax is not pretty, but it is standard perl ___ notmuch mailing list

Re: [PATCH 4/4] nmbug: Add an 'init' command

2014-07-15 Thread David Bremner
W. Trevor King wk...@tremily.us writes: +sub do_init { + my $tempwork = tempdir ('/tmp/nmbug-init.XX', CLEANUP = 1); + system ('git', 'init', '--separate-git-dir', $NMBGIT, $tempwork) == 0 +or die 'git init' exited with nonzero value\n; + git ('config', '--unset',

Re: [PATCH 2/4] nmbug: Handle missing @upstream in is_unmerged

2014-07-15 Thread W. Trevor King
On Tue, Jul 15, 2014 at 08:44:53PM -0300, David Bremner wrote: W. Trevor King writes: - my $fetch_head = git ('rev-parse', $commit); + my ($fetch_head, $status) = git_with_status ('rev-parse', $commit); + if ($status) { +return 0; + } Could there be other errors here, other

Re: [PATCH 4/4] nmbug: Add an 'init' command

2014-07-15 Thread W. Trevor King
On Tue, Jul 15, 2014 at 08:54:28PM -0300, David Bremner wrote: W. Trevor King wk...@tremily.us writes: +sub do_init { + my $tempwork = tempdir ('/tmp/nmbug-init.XX', CLEANUP = 1); + system ('git', 'init', '--separate-git-dir', $NMBGIT, $tempwork) == 0 +or die 'git init' exited

Re: [PATCH 3/4] nmbug: Catch stderr in is_unmerged

2014-07-15 Thread W. Trevor King
On Tue, Jul 15, 2014 at 08:49:58PM -0300, David Bremner wrote: W. Trevor King wk...@tremily.us writes: + if ($dir eq '-2|') { +$dir = '-|'; + } + I think I'd prefer an extra flag, rather than making new syntax. The existing syntax is not pretty, but it is standard perl There