Re: [RFC 3/5] cli: support shell globbing patterns in new.ignore

2016-04-09 Thread David Bremner
Jani Nikula writes: > Keep the existing strcmp on the basename for backwards compatibility, > and additionally use the new.ignore entries as fnmatch(3) patterns on > the absolute filename. Note that it's not enough to add e.g. "foo*bar" > to the list; you will need to do "*/foo*bar" to match the

Re: [RFC 2/5] cli: don't call _entry_in_ignore_list twice in count files debug

2016-04-09 Thread David Bremner
Jani Nikula writes: > Split file ignores in count_files to fixed and user configured in > order to not have to call _entry_in_ignore_list twice when debugging > is enabled. Minor detail. this change (and patch) seems harmless. d ___ notmuch mailing li

Re: [PATCH] emacs: make use of `message-make-from'

2016-04-09 Thread David Bremner
ae...@posteo.de writes: > -(push (cons 'From (concat > -(notmuch-user-name) " <" (notmuch-user-primary-email) > ">")) other-headers)) > +(push (cons 'From (message-make-from > +(notmuch-user-name) (notmuch-user-primary-email))) > other-headers)) L

Re: Breaking a really long thread

2016-04-09 Thread Mark Walters
Hi On Sat, 09 Apr 2016, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> On Tue 2016-04-05 01:28:43 -0400, David Mazieres wrote: >>> Arguably, I would say either both the In-Reply-To and the References >>> header should be hidden or neither. Otherwise, what was happening is >>> that I w

Re: [PATCH 4/4] test: cope with glass backend file naming variations

2016-04-09 Thread David Bremner
Tomi Ollila writes: > On Sat, Apr 09 2016, David Bremner wrote: > >> ... > >> diff --git a/test/T150-tagging.sh b/test/T150-tagging.sh >> index 8adcabc..6fd6a18 100755 >> --- a/test/T150-tagging.sh >> +++ b/test/T150-tagging.sh >> @@ -287,9 +287,9 @@ test_expect_code 1 "Empty tag names" 'notmuch

Re: [PATCH 4/4] test: cope with glass backend file naming variations

2016-04-09 Thread Tomi Ollila
On Sat, Apr 09 2016, David Bremner wrote: > ... > diff --git a/test/T150-tagging.sh b/test/T150-tagging.sh > index 8adcabc..6fd6a18 100755 > --- a/test/T150-tagging.sh > +++ b/test/T150-tagging.sh > @@ -287,9 +287,9 @@ test_expect_code 1 "Empty tag names" 'notmuch tag + One' > test_expect_code

Re: [PATCH v2 1/2] emacs: Always insert crypto buttons.

2016-04-09 Thread David Bremner
David Edmondson writes: > When no decryption or signature examination is > happening (i.e. `notmuch-crypto-process-mime' is `nil') insert buttons > that indicate this, rather than remaining silent. Looks OK, and seems to work. I think I'd rather apply these squashed into one patch so there is no

Re: [PATCH v3] emacs: Allow part preferences to depend on message content.

2016-04-09 Thread David Bremner
David Edmondson writes: > Currently the preference for which sub-part of a multipart/alternative > part is shown is global. Allow to the user to override the settings on a > per-message basis by providing the ability to call a function that has > access to the message to return the discouraged ty

Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists

2016-04-09 Thread David Bremner
Daniel Kahn Gillmor writes: >> Other than that, and my bug in ghost-report, the series looks good to >> me. > > cool! do you need another rev of the series from me, or is that > something you're up for applying directly? > >--dkg I'm ok to apply directly if no objects in the next day or

Re: notmuch-emacs replying produces excessive indenting on multipart/signed or multipart/mixed amil?

2016-04-09 Thread David Bremner
Daniel Kahn Gillmor writes: > > Does anyone else see this behavior? If you're using notmuch-emacs, try > replying to this message and looking at the attributed text. > > --dkg Hi Daniel; I don't see it in "0.21+99~gd93d377" with emacs -q. Can you try that, and if there is some settings

Re: Breaking a really long thread

2016-04-09 Thread David Bremner
Daniel Kahn Gillmor writes: > On Tue 2016-04-05 01:28:43 -0400, David Mazieres wrote: >> Arguably, I would say either both the In-Reply-To and the References >> header should be hidden or neither. Otherwise, what was happening is >> that I was deleting the In-Reply-To header as it was the only o

Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists

2016-04-09 Thread Daniel Kahn Gillmor
On Sat 2016-04-09 07:31:47 -0400, David Bremner wrote: > Daniel Kahn Gillmor writes: > > >> +status = _notmuch_message_delete (message); >> +if (status) /* we'll report the last failure we see; >> + * if there is more than one failure, we >> +

Re: Breaking a really long thread

2016-04-09 Thread Daniel Kahn Gillmor
On Tue 2016-04-05 01:28:43 -0400, David Mazieres wrote: > Arguably, I would say either both the In-Reply-To and the References > header should be hidden or neither. Otherwise, what was happening is > that I was deleting the In-Reply-To header as it was the only one I saw, > and figuring that maybe

notmuch-emacs replying produces excessive indenting on multipart/signed or multipart/mixed amil?

2016-04-09 Thread Daniel Kahn Gillmor
Hey all-- I'm running from the head of notmuch development right now, and when i reply to multipart/signed or multipart/mixed mail in notmuch-emacs, i'm noticing that the attributed text now has excessive indentation (it did not when running from the latest release). to be clear, i'm talking abou

Re: Order of messages

2016-04-09 Thread David Bremner
Laurence Rochfort writes: > Thanks Alex, > > I tried that and it seemed to only affect the search results. I there > anyway to set the ordering everywhere, so in threaded and message view for > instance? > As far as I know, threads are always displayed in "thread order", with replies after the t

Re: Distribute manual page directly?

2016-04-09 Thread David Bremner
Chunyang Xu writes: > Hello, > > I installed notmuch via Homebrew and didn't get manual page. It looks > like python-sphinx is required to produce the manual page. My question > is: can you distribute the manual page directly in the tarball? so we > don't have to install python-sphinx. > Hi Chun

Re: Search mail from people with different addresses and incorrectly configured clients

2016-04-09 Thread David Bremner
Sebastian Fischmeister writes: > > Has anyone found a good way to use tags to aggregate emails from the > same person? Will it have some disadvantages? It sounds straightforward, > but the management of this would be quite an effort. > > The alternative is to create long search strings that encom

[PATCH] emacs: make use of `message-make-from'

2016-04-09 Thread aeuii
Please put my address in CC when replying. Thanks! >From 4b9ab261a0ea8a31065e310c5150f522be86d37b Mon Sep 17 00:00:00 2001 From: stefan Date: Fri, 8 Apr 2016 22:47:06 +0200 Subject: [PATCH] emacs: make use of `message-make-from' Will respect `mail-from-style'. --- emacs/notmuch-mua.el | 6 +++-

Distribute manual page directly?

2016-04-09 Thread Chunyang Xu
Hello, I installed notmuch via Homebrew and didn't get manual page. It looks like python-sphinx is required to produce the manual page. My question is: can you distribute the manual page directly in the tarball? so we don't have to install python-sphinx. -- 徐春阳 __

Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists

2016-04-09 Thread David Bremner
Daniel Kahn Gillmor writes: > + status = _notmuch_message_delete (message); > + if (status) /* we'll report the last failure we see; > + * if there is more than one failure, we > + * forget about previous ones */ > +

Re: [PATCH v4 1/7] test: add test-binary to print the number of ghost messages

2016-04-09 Thread David Bremner
Daniel Kahn Gillmor writes: > +if (argc < 2) { > + std::cerr << "usage: ghost-report xapian-dir" << std::endl; > +} > + > +Xapian::Database db(argv[1]); > +std::cout << db.get_termfreq("Tghost") << std::endl; > +} It's completely my fault, but this should have an exit(1) aft