Daniel Kahn Gillmor writes:
> This is the third revision of the series that cleans up legacy-display
> protected headers parts so that notmuch users only have to look at one
> subject line.
>
> version 2 can be found at id:20190531075907.17035-1-...@fifthhorseman.net
> version 1 can be found at
Daniel Kahn Gillmor writes:
> This is a utility function designed to make it easier to
> "fast-forward" past a legacy-display part associated with a
> cryptographic envelope, and show the user the intended message body.
>
> The bulk of the ugliness in here is in the test function
>
Daniel Kahn Gillmor writes:
> This is a code reorganization that should have no functional effect,
> but will make future changes simpler, because a future commit will
> reuse the _mime_node_set_up_part functionality without touching
> _mime_node_create.
>
> In the course of splitting out this
Daniel Kahn Gillmor writes:
> Ping! If there is a reason that this trivial patch has languished, i'd
> be happy to receive critical feedback. Or maybe we can just merge it?
>
>--dkg
Looks good to me!
--
https://jb55.com
___
notmuch mailing list
When we notice a legacy-display part during indexing, it makes more
sense to avoid indexing it as part of the message body.
Given that the protected subject will already be indexed, there is no
need to index this part at all, so we skip over it.
If this happens during indexing, we set a property
This is a utility function designed to make it easier to
"fast-forward" past a legacy-display part associated with a
cryptographic envelope, and show the user the intended message body.
The bulk of the ugliness in here is in the test function
_notmuch_crypto_payload_has_legacy_display, which
Our _notmuch_message_crypto_potential_payload implementation could
only return a failure if bad arguments were passed to it. It is an
internal function, so if that happens it's an entirely internal bug
for notmuch.
It will be more useful for this function to return whether or not the
part is in
This is the third revision of the series that cleans up legacy-display
protected headers parts so that notmuch users only have to look at one
subject line.
version 2 can be found at id:20190531075907.17035-1-...@fifthhorseman.net
version 1 can be found at
Make use of the previous changes to fast-forward past any
legacy-display parts during "notmuch show" and "notmuch reply".
Signed-off-by: Daniel Kahn Gillmor
---
mime-node.c| 11 ++-
test/T356-protected-headers.sh | 2 --
2 files changed, 10 insertions(+), 3
Ping! If there is a reason that this trivial patch has languished, i'd
be happy to receive critical feedback. Or maybe we can just merge it?
--dkg
On Mon 2019-06-10 04:44:39 +0300, Daniel Kahn Gillmor wrote:
> Debian's lintian has an informational alert
> desktop-entry-lacks-keywords-entry,
This adds no functionality directly, but is a useful starting point
for adding new repair functionality.
Signed-off-by: Daniel Kahn Gillmor
---
doc/man7/notmuch-properties.rst | 12
lib/notmuch-private.h | 1 +
notmuch-client.h| 1 +
util/Makefile.local
Enigmail generates a "legacy-display" part when it sends encrypted
mail with a protected Subject: header. This part is intended to
display the Subject for mail user agents that are capable of
decryption, but do not know how to deal with embedded protected
headers.
This part is the first child of
This is a code reorganization that should have no functional effect,
but will make future changes simpler, because a future commit will
reuse the _mime_node_set_up_part functionality without touching
_mime_node_create.
In the course of splitting out this function, I noticed a comment in
the
Signed-off-by: Daniel Kahn Gillmor
---
notmuch-show.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/notmuch-show.c b/notmuch-show.c
index 9779cfa5..21792a57 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -492,7 +492,7 @@ format_part_text (const void *ctx,
On Mon 2019-06-24 21:44:13 +0300, Tomi Ollila wrote:
> If this suite speedup is merged, I'd suggest using original David's patch
> 2/2 due to consistency reasons -- $gen_test_filename is used likewise in
> other test_expect_code cases. and, unless $TEST_DIRECTORY contains '"'s,
> '$'s or '`'s it
* Daniel Kahn Gillmor:
> Do you think we could go ahead and apply these patches on master now
> anyway, and fix them up subsequently to make sure they apply to MacOS?
I still have not been able to set up any macOS based tests, because
contractual work has kept me busy. I suggest you go ahead
On Mon, Jun 24 2019, Daniel Kahn Gillmor wrote:
> On Fri 2019-06-14 08:16:14 -0300, David Bremner wrote:
>> Ralph Seichter writes:
>>
>>> * Daniel Kahn Gillmor:
>>>
Perhaps Ralph Seichter (explicitly cc'ed above) could comment on how
it'll affect homebrew?
>>>
>>> MacPorts, actually.
On Fri 2019-06-14 08:16:14 -0300, David Bremner wrote:
> Ralph Seichter writes:
>
>> * Daniel Kahn Gillmor:
>>
>>> Perhaps Ralph Seichter (explicitly cc'ed above) could comment on how
>>> it'll affect homebrew?
>>
>> MacPorts, actually. ;-) I have not yet been able to look into this patch
>>
18 matches
Mail list logo
