Re: [PATCH v1] emacs: Allow part preferences to depend on message content.

2016-01-19 Thread Aaron Ecay
+ (subject (plist-get headers :Subject)) > + (to (plist-get headers :To)) > + (cc (plist-get headers :Cc))) > + > +(eval directive))) This code is not compatible with lexical binding in emacs >= 24, which I assume notmuch will eventually want to adopt. What’s so bad about

Re: elisp completion patches v6

2015-10-25 Thread Aaron Ecay
. Maybe you could use a combination of ‘make-obsolete’ (for byte-compiler warnings) and ‘display-warning’ (for runtime)? I understand the desire to phase the function out eventually rather than have an eternal stub, but intentionally breaking .emacs is a really drastic ste

Re: elisp + company completion patches, v7

2015-10-25 Thread Aaron Ecay
prevent peoples emacs startup > from failing. Guess who wrote a reply before catching up on all the list mail. :P -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2] emacs: Add support for saved search accelerators

2014-05-10 Thread Aaron Ecay
for a different purpose. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] test/README: mention the test_expect_equal_json and *sanitize* functions

2013-03-05 Thread Aaron Ecay
also fix one typo --- test/README | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/test/README b/test/README index 81c232d..d12cff2 100644 --- a/test/README +++ b/test/README @@ -178,11 +178,18 @@ library for your script to use. test_expect_equal_file

[PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-03-05 Thread Aaron Ecay
Presently, the code which finds the parent of a message as it is being added to the database assumes that the first Message-ID-like substring of the In-Reply-To header is the parent Message ID. Some mail clients, however, put stuff other than the Message-ID of the parent in the In-Reply-To

[PATCH 1/2] test: add tests for the handling of References and In-Reply-To headers

2013-03-05 Thread Aaron Ecay
-replies new file mode 100755 index 000..a902691 --- /dev/null +++ b/test/thread-replies @@ -0,0 +1,144 @@ +#!/usr/bin/env bash +# +# Copyright (c) 2013 Aaron Ecay +# + +test_description='test of proper handling of in-reply-to and references headers + +This test makes sure that the thread structure

[PATCH 1/2] test: add tests for the handling of References and In-Reply-To headers

2013-03-05 Thread Aaron Ecay
-replies new file mode 100755 index 000..a902691 --- /dev/null +++ b/test/thread-replies @@ -0,0 +1,144 @@ +#!/usr/bin/env bash +# +# Copyright (c) 2013 Aaron Ecay +# + +test_description='test of proper handling of in-reply-to and references headers + +This test makes sure that the thread structure

[PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-03-05 Thread Aaron Ecay
Presently, the code which finds the parent of a message as it is being added to the database assumes that the first Message-ID-like substring of the In-Reply-To header is the parent Message ID. Some mail clients, however, put stuff other than the Message-ID of the parent in the In-Reply-To

[RFC] [PATCH] lib/database.cc: change how the parent of a message is calculated

2013-03-03 Thread Aaron Ecay
- next part ------ -- Aaron Ecay

[RFC] [PATCH] lib/database.cc: change how the parent of a message is calculated

2013-02-26 Thread Aaron Ecay
essage would be best. Here?s a message from the notmuch list that has passed through gmane, which inserts References but not In-Reply-To headers: id:877h0sa207.fsf at fester.com . Here?s a link to one with a borked In-Reply-To header: http://article.gmane.org/gmane.emacs.orgmode/66616/raw -- Aaron Ecay

[RFC] [PATCH] lib/database.cc: change how the parent of a message is calculated

2013-02-25 Thread Aaron Ecay
Presently, the code which finds the parent of a message as it is being added to the database assumes that the first Message-ID-like substring of the In-Reply-To header is the parent Message ID. Some mail clients, however, put stuff other than the Message-ID of the parent in the In-Reply-To

[RFC] [PATCH] lib/database.cc: change how the parent of a message is calculated

2013-02-25 Thread Aaron Ecay
Presently, the code which finds the parent of a message as it is being added to the database assumes that the first Message-ID-like substring of the In-Reply-To header is the parent Message ID. Some mail clients, however, put stuff other than the Message-ID of the parent in the In-Reply-To

[PATCH v2] emacs: display tags in notmuch-show with links

2012-11-18 Thread Aaron Ecay
ve #' on lambdas (that is, there are 0 instances of #'(lambda ...) in the code base). IMO that?s correct: the unnecessary #' is just line-noise-ish. -- Aaron Ecay

Re: [PATCH v2] emacs: display tags in notmuch-show with links

2012-11-18 Thread Aaron Ecay
(that is, there are 0 instances of #'(lambda ...) in the code base). IMO that’s correct: the unnecessary #' is just line-noise-ish. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

bug related to ical

2012-09-26 Thread Aaron Ecay
t-buffer (find-file-noselect file)) (setq result (buffer-substring (point-min) (point-max))) (set-buffer-modified-p nil) (kill-buffer (current-buffer)) - cut here ----- -- Aaron Ecay

Re: bug related to ical

2012-09-26 Thread Aaron Ecay
(find-file-noselect file)) (setq result (buffer-substring (point-min) (point-max))) (set-buffer-modified-p nil) (kill-buffer (current-buffer)) - cut here - -- Aaron Ecay ___ notmuch mailing list notmuch

[PATCH 2/2] emacs: Quote MML tags in replies

2012-01-29 Thread Aaron Ecay
Emacs message-mode uses certain text strings to indicate how to attach files to outgoing mail. If these are present in the text of an email, and a user is tricked into replying to the message, the user?s files could be exposed. --- NEWS | 18 ++

[PATCH 1/2] emacs: Add tests for quoting of MML tags in replies

2012-01-28 Thread Aaron Ecay
The test is broken at this time; the next commit will introduce a fix. --- Thanks for the reminder, Austin. Things got hectic, and it took a little bludgeoning to get the test suite to behave. I *think* I got it, although I am by no means confident. Specifically, I am seeing some unrelated(?)

[PATCH 2/2] emacs: Quote MML tags in replies

2012-01-28 Thread Aaron Ecay
Emacs message-mode uses certain text strings to indicate how to attach files to outgoing mail. If these are present in the text of an email, and a user is tricked into replying to the message, the user’s files could be exposed. --- NEWS | 18 ++

tach.el: an attachment interface for message mode.

2012-01-20 Thread Aaron Ecay
files to email very often, but I?ll let you know how it works out. Thanks a lot, -- Aaron Ecay

[PATCH v3 5/5] emacs: Use message-citation-line-format in reply

2012-01-20 Thread Aaron Ecay
On Thu, 19 Jan 2012 21:46:46 -0700, Adam Wolfe Gordon <awg+notmuch at xvx.ca> wrote: > On Thu, Jan 19, 2012 at 11:45, Aaron Ecay wrote: > > Shouldn?t this just use message-insert-formatted-citation-line? > > Yes, good idea. I just tried this and it almost wor

Re: tach.el: an attachment interface for message mode.

2012-01-20 Thread Aaron Ecay
files to email very often, but I’ll let you know how it works out. Thanks a lot, -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] emacs: Quote MML tags in replies

2012-01-19 Thread Aaron Ecay
that case is a security hole, then the hole is in the user?s brain and not in notmuch. :) -- Aaron Ecay

[PATCH] emacs: Quote MML tags in replies

2012-01-19 Thread Aaron Ecay
sn?t mean that we should break that usage. > > > > > (defun notmuch-mua-forward-message () > >(message-forward) > > Speaking of future-proofing, it would be good to have a test. It would. ;) I?ll work on one. -- Aaron Ecay

[PATCH] emacs: Quote MML tags in replies

2012-01-19 Thread Aaron Ecay
ding the reply will produce the original single-quoted tag again. -- Aaron Ecay

[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Aaron Ecay
show buffer that says: - 6 messages hidden - instead of the 6 (or however many) individual messages. -- Aaron Ecay

[PATCH v3 5/5] emacs: Use message-citation-line-format in reply

2012-01-19 Thread Aaron Ecay
So to mitigate this, whatever reply mechanism winds up being used should call mml-quote-region on the reply text (as message-cite-original does). I just sent a patch to the list to do this in the current version of notmuch, which should show up in id:"1326998589-37187-1-git-send-email-aaronecay at gmail.com" . -- Aaron Ecay

[PATCH] emacs: Make the part content available to `mm-inlinable-p'.

2012-01-19 Thread Aaron Ecay
> to inline. > > This fixes the display of attached image/jpeg parts, for example. I had suggested the same approach in a message that only Dmitry got (accursed new reply bindings!) LGTM. -- Aaron Ecay

[PATCH] emacs: Quote MML tags in replies

2012-01-19 Thread Aaron Ecay
Emacs message-mode uses certain text strings to indicate how to attach files to outgoing mail. If these are present in the text of an email, and a user is tricked into replying to the message, the user’s files could be exposed. --- To demonstrate this, open a reply to this message then remove

Re: [PATCH v3 5/5] emacs: Use message-citation-line-format in reply

2012-01-19 Thread Aaron Ecay
show up in id:1326998589-37187-1-git-send-email-aarone...@gmail.com . -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Aaron Ecay
messages hidden - instead of the 6 (or however many) individual messages. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: Quote MML tags in replies

2012-01-19 Thread Aaron Ecay
. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: Quote MML tags in replies

2012-01-19 Thread Aaron Ecay
, but that doesn’t mean that we should break that usage. (defun notmuch-mua-forward-message () (message-forward) Speaking of future-proofing, it would be good to have a test. It would. ;) I’ll work on one. -- Aaron Ecay ___ notmuch mailing

Re: [PATCH] emacs: Quote MML tags in replies

2012-01-19 Thread Aaron Ecay
. If that case is a security hole, then the hole is in the user’s brain and not in notmuch. :) -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v3 5/5] emacs: Use message-citation-line-format in reply

2012-01-19 Thread Aaron Ecay
On Thu, 19 Jan 2012 21:46:46 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: On Thu, Jan 19, 2012 at 11:45, Aaron Ecay e...@sas.upenn.edu wrote: Shouldn’t this just use message-insert-formatted-citation-line? Yes, good idea. I just tried this and it almost works. The only issue

[PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread Aaron Ecay
for allowing runtime use.) Aaron Footnotes: [1] He specifically objects to the way that the cl package uses keyword arguments, calling it un-Elisp-like. He has resisted past efforts to merge cl functions into Elisp core, although they are slowly diffusing across the barrier. -- Aaron Ecay

Re: [PATCH] emacs: Improved printing support.

2012-01-18 Thread Aaron Ecay
- the comments were very useful in improving things - thanks! You’re welcome! The patch LGTM. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread Aaron Ecay
runtime use.) Aaron Footnotes: [1] He specifically objects to the way that the cl package uses keyword arguments, calling it un-Elisp-like. He has resisted past efforts to merge cl functions into Elisp core, although they are slowly diffusing across the barrier. -- Aaron Ecay

[PATCH 1/1] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Aaron Ecay
r id part-number #'notmuch-show-part-button-whatever-worker)) It would be the latter function that the key would be bound to. If a macro is used, the split between the worker and glue fns can be abandoned, and only one function is needed: (defun notmuch-show-part-button-whatever () (notmuch-with-temp-part-buffer ;; do stuff... )) A further advantage is if interactive arguments (e.g. C-u prefix) are needed for the function, there is no need to thread them through as arguments of notmuch-with-temp-part-buffer. -- Aaron Ecay

[PATCH] emacs: have notmuch-search-archive-thread use -next-thread function

2012-01-17 Thread Aaron Ecay
+1 -- Aaron Ecay

[PATCH 3/6] emacs: add message archiving functions

2012-01-17 Thread Aaron Ecay
\"unarchived\" (ie. the \"inbox\" tag will be added instead of > +removed)." > + (interactive) If this function uses the prefix arg, its interactive call should be ?(interactive "P")?. This applies equally to the -thread variant in patch 2/6, but I made the comment here because that diff doesn?t show the function contiguously. -- Aaron Ecay

[PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

2012-01-17 Thread Aaron Ecay
tags will be removed instead of added. This should be a docstring instead of a comment. (This applies equally to the old version) -- Aaron Ecay

show-mode message/thread archiving improvements

2012-01-17 Thread Aaron Ecay
+1 on this series from me. (Minor comments on a couple of the patches to follow.) -- Aaron Ecay

Infinite loop in emacs interface

2012-01-17 Thread Aaron Ecay
if it seems like this is the case.) If you do: M-x set-variable RET debug-on-quit RET t RET then trigger the loop and press C-g, you should get a buffer showing a backtrace of the lisp stack. What does that say? Thanks, -- Aaron Ecay

Re: Infinite loop in emacs interface

2012-01-17 Thread Aaron Ecay
if it seems like this is the case.) If you do: M-x set-variable RET debug-on-quit RET t RET then trigger the loop and press C-g, you should get a buffer showing a backtrace of the lisp stack. What does that say? Thanks, -- Aaron Ecay ___ notmuch mailing

Re: show-mode message/thread archiving improvements

2012-01-17 Thread Aaron Ecay
+1 on this series from me. (Minor comments on a couple of the patches to follow.) -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

2012-01-17 Thread Aaron Ecay
equally to the old version) -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: have notmuch-search-archive-thread use -next-thread function

2012-01-17 Thread Aaron Ecay
+1 -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/1] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Aaron Ecay
) are needed for the function, there is no need to thread them through as arguments of notmuch-with-temp-part-buffer. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

2012-01-17 Thread Aaron Ecay
a comment instead of a documentation string, | but that is no longer the case--documentation strings now take up | very little space in a running Emacs. ` -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman

[PATCH 0/4] Quoting HTML-only emails in replies redux

2012-01-16 Thread Aaron Ecay
On Mon, 16 Jan 2012 08:39:30 +, David Edmondson wrote: > On Mon, 16 Jan 2012 02:38:38 -0500, Aaron Ecay wrote: > > - Greater flexibility in the construction of address lists. For example, > > there are some email lists where I want replies to list mail to go only &g

[PATCH] emacs: Truncate lines and do not enable visual-line-mode in notmuch-show buffers.

2012-01-16 Thread Aaron Ecay
`visual-line-mode' were that it wrapped long lines > in received messages. With `notmuch-wash-wrap-long-lines' now default > behaviour, this is no longer required. +1 -- Aaron Ecay

[PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state

2012-01-16 Thread Aaron Ecay
ikely to be a very frequent problem with email messages that are not on this listserv :), it would be nice to fix it. Maybe you could change the regex that matches id:?s to require a little more structure ? an at-sign, perhaps. Or even requiring more than (say) 5 non-space characters after the message id would

[PATCH] emacs: Improved printing support.

2012-01-16 Thread Aaron Ecay
> ((looking-at "[Tt]o:") > @@ -760,6 +806,8 @@ current buffer, if possible." >(overlay-put headers-overlay 'priority 10)) > (overlay-put (make-overlay body-start body-end) 'invisible > message-invis-spec) > > +(plist-put msg :depth depth) > + > ;; Save the properties for this message. Currently this saves the > ;; entire message (augmented it with other stuff), which seems > ;; like overkill. We might save a reduced subset (for example, not > @@ -,6 +1159,9 @@ Some useful entries are: > (defun notmuch-show-get-to () >(notmuch-show-get-header :To)) > > +(defun notmuch-show-get-depth () > + (notmuch-show-get-prop :depth)) > + > (defun notmuch-show-set-tags (tags) >"Set the tags of the current message." >(notmuch-show-set-prop :tags tags) > -- > 1.7.7.3 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch -- Aaron Ecay

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread Aaron Ecay
and are the right color. I haven?t reloaded the notmuch *.el files since this change landed, but I agree with Pieter that the overlays were nice. -- Aaron Ecay

[PATCH 0/4] Quoting HTML-only emails in replies redux

2012-01-16 Thread Aaron Ecay
macs). So, a +1 from me on this idea, from a different perspective. -- Aaron Ecay

Re: [PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state

2012-01-16 Thread Aaron Ecay
that are not on this listserv :), it would be nice to fix it. Maybe you could change the regex that matches id:’s to require a little more structure – an at-sign, perhaps. Or even requiring more than (say) 5 non-space characters after the message id would cut down sharply on the false positive rate. -- Aaron

Re: [PATCH] emacs: Truncate lines and do not enable visual-line-mode in notmuch-show buffers.

2012-01-16 Thread Aaron Ecay
-mode' were that it wrapped long lines in received messages. With `notmuch-wash-wrap-long-lines' now default behaviour, this is no longer required. +1 -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman

Re: [PATCH 0/4] Quoting HTML-only emails in replies redux

2012-01-16 Thread Aaron Ecay
On Mon, 16 Jan 2012 08:39:30 +, David Edmondson d...@dme.org wrote: On Mon, 16 Jan 2012 02:38:38 -0500, Aaron Ecay aarone...@gmail.com wrote: - Greater flexibility in the construction of address lists. For example, there are some email lists where I want replies to list mail to go only

Re: [PATCH 0/4] Quoting HTML-only emails in replies redux

2012-01-15 Thread Aaron Ecay
on this idea, from a different perspective. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v3 2/4] emacs: add support for replying just to the sender

2012-01-11 Thread Aaron Ecay
list query-string What about using ?format?: (let (... (args (format "reply --reply-to=%s %s %s" (if reply-all "all" "sender") (if notmuch-show-process-crypto "--decrypt" "") query-string))) ...) It?s still not beautiful, but maybe it is better? -- Aaron Ecay

[PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging

2012-01-11 Thread Aaron Ecay
the clear to bikeshed about its calling convention. :) It?s your patch, though, so it?s your call if you feel that the goes best in a new change. -- Aaron Ecay

Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging

2012-01-10 Thread Aaron Ecay
think I’m in the clear to bikeshed about its calling convention. :) It’s your patch, though, so it’s your call if you feel that the optional goes best in a new change. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org

[PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging

2012-01-09 Thread Aaron Ecay
On Sun, 08 Jan 2012 18:49:56 -0800, Jameson Graef Rollins wrote: > Thanks so much for the review, Aaron. > > On Sun, 08 Jan 2012 20:08:59 -0500, Aaron Ecay wrote: > > A couple of comments on the arguments: > > - It would be good to make show-next This will enable code

[PATCH 0/4] Quoting HTML-only emails in replies redux

2012-01-08 Thread Aaron Ecay
ible values 'text, 'html, and 'both. This requires the emacs reply functionality to distinguish between html parts that are part of a multipart/alternative and those which are not, which (AFAICT) the current code doesn?t do. I haven?t tested the patch yet, but it looks very promising. Thanks! -- Aaron Ecay

[PATCH 4/4] emacs: Use the new JSON reply format.

2012-01-08 Thread Aaron Ecay
; notmuch-mua-hidden-headers)) > > +(defun w3m-region (start end)) ;; From `w3m.el'. What is the purpose of the above line? If it is to make the compiler aware of the function, you should use ?declare-function? instead. Defun will erase the original definition of the w3m-region function. -- Aaron Ecay

[PATCH 1/4] emacs: new customization variable to exclude "deleted" messages from search

2012-01-08 Thread Aaron Ecay
line) > (set 'notmuch-search-continuation continuation) > +(when (and notmuch-search-exclude-deleted > +(not (string-match "tag:deleted[ )]*" query))) ?is:? is a synonym for ?tag:? in searches ? so this section of the code should look for it too. -- Aaron Ecay

[PATCH 2/4] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

2012-01-08 Thread Aaron Ecay
> + (kill-this-buffer) > + (switch-to-buffer parent-buffer) > + (forward-line 1)) > + (goto-char (point-max)) > > (defun notmuch-show-previous-open-message () >"Show the previous message." > -- > 1.7.7.3 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch -- Aaron Ecay

[PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging

2012-01-08 Thread Aaron Ecay
r notmuch-show-parent-buffer)) > + (notmuch-kill-this-buffer) > + (if parent-buffer > + (progn > + (switch-to-buffer parent-buffer) > + (forward-line) > + (if show-next > + (notmuch-search-show-thread))) -- Aaron Ecay

[PATCH] emacs: call "notmuch tag" only once when archiving a thread

2012-01-08 Thread Aaron Ecay
ple think it would be useful, I can work on a patch to implement this approach. Footnotes: [1] Or having its tags changed generally. -- Aaron Ecay

Re: [PATCH] emacs: call notmuch tag only once when archiving a thread

2012-01-08 Thread Aaron Ecay
think it would be useful, I can work on a patch to implement this approach. Footnotes: [1] Or having its tags changed generally. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging

2012-01-08 Thread Aaron Ecay
+ (notmuch-search-show-thread))) -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 2/4] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

2012-01-08 Thread Aaron Ecay
-char (point-max)) (defun notmuch-show-previous-open-message () Show the previous message. -- 1.7.7.3 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch -- Aaron Ecay

Re: [PATCH 1/4] emacs: new customization variable to exclude deleted messages from search

2012-01-08 Thread Aaron Ecay
:” in searches – so this section of the code should look for it too. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

2012-01-08 Thread Aaron Ecay
of the above line? If it is to make the compiler aware of the function, you should use ‘declare-function’ instead. Defun will erase the original definition of the w3m-region function. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http

Re: [PATCH 0/4] Quoting HTML-only emails in replies redux

2012-01-08 Thread Aaron Ecay
. This requires the emacs reply functionality to distinguish between html parts that are part of a multipart/alternative and those which are not, which (AFAICT) the current code doesn’t do. I haven’t tested the patch yet, but it looks very promising. Thanks! -- Aaron Ecay

Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging

2012-01-08 Thread Aaron Ecay
On Sun, 08 Jan 2012 18:49:56 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Thanks so much for the review, Aaron. On Sun, 08 Jan 2012 20:08:59 -0500, Aaron Ecay aarone...@gmail.com wrote: A couple of comments on the arguments: - It would be good to make show-next optional

[PATCH] emacs: call "notmuch tag" only once when archiving a thread

2012-01-05 Thread Aaron Ecay
ag -inbox thread:000whatever -- Aaron Ecay

Re: [PATCH] emacs: call notmuch tag only once when archiving a thread

2012-01-05 Thread Aaron Ecay
thread:000whatever -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] Update NEWS for change by Aaron Ecay

2011-12-30 Thread Aaron Ecay
On Fri, 30 Dec 2011 22:54:30 -0400, David Bremner wrote: > pushed, although I had to mess with it a fair amount. Maybe it was > against master, rather than release? It was. I didn?t realize that the patch should be against the release branch; sorry about that... :-| -- Aaron Ecay

[notmuch] [PATCH] Calls to notmuch get queued and executed asynchronously.

2011-12-30 Thread Aaron Ecay
problems, though. Daniel, if you want to un-conflict (and squash) the patches from James that might be useful, at least to compare the two approaches. Aaron -cut-here- >From f0a0fe04254d9b5e17c873b293c6a5a270cb909a Mon Sep 17 00:00:00 2001 From: Aaron Ecay <aarone...@gmail.com>

[PATCH] Update NEWS for change by Aaron Ecay

2011-12-30 Thread Aaron Ecay
--- NEWS | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index eaed960..3688944 100644 --- a/NEWS +++ b/NEWS @@ -20,6 +20,16 @@ Automatic tag query optimization exclude messages whose tags won't change. In the past, we've suggested that people

[PATCH 1/4] emacs: unify search mechanisms

2011-12-30 Thread Aaron Ecay
e notmuch-hello, but when I do, I press `s' then look to the bottom of the screen and am always confused not to see a minibuffer prompt. -- Aaron Ecay

Re: [PATCH 1/4] emacs: unify search mechanisms

2011-12-30 Thread Aaron Ecay
use notmuch-hello, but when I do, I press `s' then look to the bottom of the screen and am always confused not to see a minibuffer prompt. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] Update NEWS for change by Aaron Ecay

2011-12-30 Thread Aaron Ecay
--- NEWS | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index eaed960..3688944 100644 --- a/NEWS +++ b/NEWS @@ -20,6 +20,16 @@ Automatic tag query optimization exclude messages whose tags won't change. In the past, we've suggested that people

Re: [notmuch] [PATCH] Calls to notmuch get queued and executed asynchronously.

2011-12-30 Thread Aaron Ecay
-conflict (and squash) the patches from James that might be useful, at least to compare the two approaches. Aaron -cut-here- From f0a0fe04254d9b5e17c873b293c6a5a270cb909a Mon Sep 17 00:00:00 2001 From: Aaron Ecay aarone...@gmail.com Date: Mon, 19 Dec 2011 12:14:31 -0500 Subject: [PATCH] [emacs

Re: [PATCH] Update NEWS for change by Aaron Ecay

2011-12-30 Thread Aaron Ecay
On Fri, 30 Dec 2011 22:54:30 -0400, David Bremner da...@tethera.net wrote: pushed, although I had to mess with it a fair amount. Maybe it was against master, rather than release? It was. I didn’t realize that the patch should be against the release branch; sorry about that... :-| -- Aaron

[RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-28 Thread Aaron Ecay
C/DEL. The former moves by messages, and the latter by screenfuls (with the added complication that the screenful movement commands also stop at intervening message boundaries). I?d prefer to maintain that symmetry. -- Aaron Ecay

Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-28 Thread Aaron Ecay
by messages, and the latter by screenfuls (with the added complication that the screenful movement commands also stop at intervening message boundaries). I’d prefer to maintain that symmetry. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH v3 1/4] emacs: Let the user choose where to compose new mails

2011-12-25 Thread Aaron Ecay
which emacs versions/configurations show undesired behavior ? this is a useful patch and it should be included once we can be sure it will work correctly. Thanks, -- Aaron Ecay

[PATCH] emacs: Don't signal an error when reaching the end of the search results.

2011-12-25 Thread Aaron Ecay
common case. > > Moreover, it's very annoying when `debug-on-error' is t. +1 from me on this change. I had added this to `debug-ignored-errors' long ago, and forgotten how annoying it was. -- Aaron Ecay

[RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-25 Thread Aaron Ecay
- ;; screen - scroll. > > - ((or (= start-of-message start-of-window) > > - (< start-of-message start-of-window)) > > + ((= start-of-message (point)) > > + ;; The cursor is at the start of the current message - move to > > + ;; the previous open message. > > + (notmuch-show-previous-open-message)) > > This will jump to the beginning of the previous message if I'm at the > beginning of a message. I would expect rewind to show me the end of > the previous message in this case. Agreed. I would like to see this case move back one screenful of text or to the previous beginning-of-message, whichever is shorter. Something like this should do the trick (replacing the notmuch-show-prev-msg call): (let ((last-msg-point (save-excursion (notmuch-show-goto-message-previous) (point (scroll-down) (if (> last-msg-point (window-start)) (goto-char last-msg-point) (goto-char (window-start))) (notmuch-show-message-adjust)) Thanks, -- Aaron Ecay

Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-25 Thread Aaron Ecay
) (if ( last-msg-point (window-start)) (goto-char last-msg-point) (goto-char (window-start))) (notmuch-show-message-adjust)) Thanks, -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman

Re: [PATCH] emacs: Don't signal an error when reaching the end of the search results.

2011-12-25 Thread Aaron Ecay
, as this is the common case. Moreover, it's very annoying when `debug-on-error' is t. +1 from me on this change. I had added this to `debug-ignored-errors' long ago, and forgotten how annoying it was. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http

Re: [PATCH v3 1/4] emacs: Let the user choose where to compose new mails

2011-12-25 Thread Aaron Ecay
– this is a useful patch and it should be included once we can be sure it will work correctly. Thanks, -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[RFC][PATCH v2] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-22 Thread Aaron Ecay
David, Would the problem you had with previous-s-c-prop-change be fixed by the patch to the original function I sent in the thread starting at id:"m2y5u5cykp.fsf at kcals.intra.maillard.im" ? -- Aaron Ecay

[PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-22 Thread Aaron Ecay
Text properties change between characters; prev-s-c-property-change returns the position after the change. Thus, it is still inside the invisible region. --- emacs/notmuch-show.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-show.el

[PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-22 Thread Aaron Ecay
Text properties change between characters; prev-s-c-property-change returns the position after the change. Thus, it is still inside the invisible region. --- emacs/notmuch-show.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-show.el

Re: [RFC][PATCH v2] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-22 Thread Aaron Ecay
David, Would the problem you had with previous-s-c-prop-change be fixed by the patch to the original function I sent in the thread starting at id:m2y5u5cykp@kcals.intra.maillard.im ? -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org

  1   2   >