[PATCH v2 04/10] test: add support for external executable dependencies

There is existing support for general prerequisites in the test suite. But it is not very convenient to use: every test case has to keep track for it's dependencies and they have to be explicitly listed. The patch aims to add better support for a particular type of external dependencies: external

[PATCH v2 05/10] test: fix "skipping test" verbose output

--- test/test-lib.sh |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 625d19b..ce7576a 100755 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -635,41 +635,42 @@ test_skip () { test_report_skip_ "$@"

[PATCH v2 03/10] test: add test state reset to test_expect_* functions that did not have it

--- test/test-lib.sh |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index ff85848..f21e45e 100755 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -622,82 +622,85 @@ test_skip () { test_reset_state_ say

[PATCH v2 02/10] test: set EMACS_SERVER variable only after dtach(1) was successfully started

Otherwise, we can set the EMACS_SERVER and return with an error. And subsequent calls to test_emacs would assume that emacs server is running. --- test/test-lib.sh |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 222b5e4..ff858

[PATCH v2 01/10] test: move subtest variables reset into a dedicated function

Currently, there is only one such variable test_subtest_known_broken_. But more will be added in the future. --- test/test-lib.sh | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 1ea7fa9..222b5e4 100755 --- a/test/test-li

[PATCH v2 00/10] test: (hopefully) better test prerequisites

New version of [1] patch series. Changes: v2 since v1: * Add test_require_external_prereq function to explicitly check for external dependencies, use it in test_emacs. * Indenting fixes. * Use $binary instead of $1 in test_declare_external_prereq. Regards, Dmitry

Re: [PATCH 0/9] test: (hopefully) better test prerequisites

On Thu, 17 Nov 2011 10:46:58 +0100, Thomas Jost wrote: > On Thu, 17 Nov 2011 05:56:17 +0400, Dmitry Kurochkin > wrote: > > Hi all. > > > > The following patch series is an attempt to introduce proper > > dependencies for external binaries in a less intrusive way

Re: [PATCH 0/9] test: (hopefully) better test prerequisites

Hi Jameson. On Thu, 17 Nov 2011 01:14:07 -0800, Jameson Graef Rollins wrote: > On Thu, 17 Nov 2011 05:56:17 +0400, Dmitry Kurochkin > wrote: > > The following patch series is an attempt to introduce proper > > dependencies for external binaries in a less intrusive way

Re: [PATCH 8/9] test: check if emacs is available in the beginning of test_emacs

On Thu, 17 Nov 2011 11:43:36 +0200, Tomi Ollila wrote: > On Thu, 17 Nov 2011 05:56:25 +0400, Dmitry Kurochkin > wrote: > > Unfortunately, this is needed to avoid the emacs waiting loop. > > --- > > > test/test-lib.sh |4 > > 1 files chan

Re: [PATCH 2/9] test: set EMACS_SERVER variable only after dtach(1) was successfully started

On Thu, 17 Nov 2011 01:14:13 -0800, Jameson Graef Rollins wrote: > On Thu, 17 Nov 2011 05:56:19 +0400, Dmitry Kurochkin > wrote: > > Otherwise, we can set the EMACS_SERVER and return with an error. And > > subsequent calls to test_emacs would assume that emacs server is

[PATCH 2/2] NEWS entry for id-links

On Wed, 16 Nov 2011 18:53:13 +0100, Daniel Schoepe wrote: > This adds a NEWS entry for commit 4a4ada73b751b1916c5dc4d408a8056411566e38 > --- > NEWS |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/NEWS b/NEWS > index ff12ca6..a2fa69f 100644 > --- a/NEWS > +++ b

[PATCH 9/9] test: fix "Stashing in notmuch-search" test when emacs is not available

If emacs is not available, test_expect_equal would be called with only one argument. The patch fixes this by quoting the (possibly empty) $(cat OUTPUT) argument. --- test/emacs |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/emacs b/test/emacs index 75a0a74..9883f40

[PATCH 8/9] test: check if emacs is available in the beginning of test_emacs

Unfortunately, this is needed to avoid the emacs waiting loop. --- test/test-lib.sh |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 840c86c..5bd5bd6 100755 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -858,40 +858,44 @@ expo

[PATCH 7/9] test: declare external dependencies for the tests

That are: dtach(1), emacs(1), emacsclient(1), gdb(1) and gpg(1). --- test/test-lib.sh |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index c11493d..840c86c 100755 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -1101,20 +1101,27

[PATCH 6/9] test: skip all subtests if external dependencies are missing during init

Some tests (e.g. crypto) do a common initialization required for all subtests. The patch adds a check for missing external dependencies during this initialization. If any prerequisites are missing, all subtests are skipped. The check is run on the first call of test_reset_state_ function, so no

[PATCH 4/9] test: add support for external executable dependencies

There is existing support for general prerequisites in the test suite. But it is not very convenient to use: every test case has to keep track for it's dependencies and they have to be explicitly listed. The patch aims to add better support for a particular type of external dependencies: external

[PATCH 5/9] test: fix "skipping test" verbose output

--- test/test-lib.sh |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index ab8c6fd..acac8ca 100755 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -635,41 +635,42 @@ test_skip () { test_report_skip_ "$@"

[PATCH 3/9] test: add test state reset to test_expect_* functions that did not have it

--- test/test-lib.sh |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index ff85848..f21e45e 100755 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -622,82 +622,85 @@ test_skip () { test_reset_state_ say

[PATCH 2/9] test: set EMACS_SERVER variable only after dtach(1) was successfully started

Otherwise, we can set the EMACS_SERVER and return with an error. And subsequent calls to test_emacs would assume that emacs server is running. --- test/test-lib.sh |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 222b5e4..ff858

[PATCH 1/9] test: move subtest variables reset into a dedicated function

Currently, there is only one such variable test_subtest_known_broken_. But more will be added in the future. --- test/test-lib.sh | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 1ea7fa9..222b5e4 100755 --- a/test/test-li

[PATCH 0/9] test: (hopefully) better test prerequisites

Hi all. The following patch series is an attempt to introduce proper dependencies for external binaries in a less intrusive way than [1]. The primary aim was to avoid changing every subtest that uses external binaries. There are still failing tests if a dependency is missing (e.g. "Verify that s

Re: [PATCH 2/2] NEWS entry for id-links

On Wed, 16 Nov 2011 18:53:13 +0100, Daniel Schoepe wrote: > This adds a NEWS entry for commit 4a4ada73b751b1916c5dc4d408a8056411566e38 > --- > NEWS |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/NEWS b/NEWS > index ff12ca6..a2fa69f 100644 > --- a/NEWS > +++ b/

[PATCH] add `tag:' prefix to `--output=tags' results

On Sun, 13 Nov 2011 15:00:56 -0800, Jameson Graef Rollins wrote: > On Sat, 12 Nov 2011 10:17:30 -0500, David Bremner > wrote: > > What do people think about this change? Personally I will have change > > some scripts to not add "tag:", but it isn't that big of a deal. > > I would actually prefe

Re: [PATCH] add `tag:' prefix to `--output=tags' results

On Sun, 13 Nov 2011 15:00:56 -0800, Jameson Graef Rollins wrote: > On Sat, 12 Nov 2011 10:17:30 -0500, David Bremner wrote: > > What do people think about this change? Personally I will have change > > some scripts to not add "tag:", but it isn't that big of a deal. > > I would actually prefer

[PATCH] test: do not hide test_emacs errors

On Sat, 12 Nov 2011 09:57:53 -0500, David Bremner wrote: > On Fri, 1 Jul 2011 06:23:48 +0400, Dmitry Kurochkin gmail.com> wrote: > > Do not redirect test_emacs stderr to /dev/null. Test_emacs uses > > emacsclient(1) now and it does not print unwanted messages (like > >

[PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

On Sat, 12 Nov 2011 23:07:38 +0200, Tomi Ollila wrote: > On Sat, 12 Nov 2011 10:41:28 -0500, Austin Clements > wrote: > > > > Actually, since sending mail is synchronous, there shouldn't be any > > issues with buffering or timing. If Emacs successfully sends the > > message, it will wait for t

Re: [PATCH] test: do not hide test_emacs errors

On Sat, 12 Nov 2011 09:57:53 -0500, David Bremner wrote: > On Fri, 1 Jul 2011 06:23:48 +0400, Dmitry Kurochkin > wrote: > > Do not redirect test_emacs stderr to /dev/null. Test_emacs uses > > emacsclient(1) now and it does not print unwanted messages (like > > those f

Re: [PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

On Sat, 12 Nov 2011 23:07:38 +0200, Tomi Ollila wrote: > On Sat, 12 Nov 2011 10:41:28 -0500, Austin Clements wrote: > > > > Actually, since sending mail is synchronous, there shouldn't be any > > issues with buffering or timing. If Emacs successfully sends the > > message, it will wait for the

[PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

Hi all. Any objections to this trivial patch? Can we get it pushed? Regards, Dmitry

[PATCH] test: use dtach(1) instead of screen(1) in emacs tests

On Fri, 11 Nov 2011 22:48:13 +0200, Tomi Ollila wrote: > dtach is simpler than screen and is not setuid/setgid program so > TMPDIR does not get cleared by dynamic loader when executed. > --- > > Updated version after discussion with DmitryKurochkin and amdragon > on IRC. Thank you. > Looks good

[PATCH] test: use dtach(1) instead of screen(1) in emacs tests.

On Fri, 11 Nov 2011 13:29:48 +0200, Tomi Ollila wrote: > On Fri, 11 Nov 2011 12:41:11 +0400, Dmitry Kurochkin gmail.com> wrote: > > Hi Tomi. > > > > On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins > finestructure.net> wrote: > > > From: Tomi Oll

Re: [PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

Hi all. Any objections to this trivial patch? Can we get it pushed? Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] test: use dtach(1) instead of screen(1) in emacs tests

On Fri, 11 Nov 2011 22:48:13 +0200, Tomi Ollila wrote: > dtach is simpler than screen and is not setuid/setgid program so > TMPDIR does not get cleared by dynamic loader when executed. > --- > > Updated version after discussion with DmitryKurochkin and amdragon > on IRC. Thank you. > Looks good

[PATCH] test: use dtach(1) instead of screen(1) in emacs tests.

Hi Tomi. On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins wrote: > From: Tomi Ollila > > dtach is lighter than screen and is not setuid/setgid program so > TMPDIR does not get reset by dynamic loader when executed. > > Signed-off-by: Jameson Graef Rollins > --- > This tweaks the orig

Re: [PATCH] test: use dtach(1) instead of screen(1) in emacs tests.

On Fri, 11 Nov 2011 13:29:48 +0200, Tomi Ollila wrote: > On Fri, 11 Nov 2011 12:41:11 +0400, Dmitry Kurochkin > wrote: > > Hi Tomi. > > > > On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins > > wrote: > > > From: Tomi Ollila > > >

Re: [PATCH] test: use dtach(1) instead of screen(1) in emacs tests.

Hi Tomi. On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins wrote: > From: Tomi Ollila > > dtach is lighter than screen and is not setuid/setgid program so > TMPDIR does not get reset by dynamic loader when executed. > > Signed-off-by: Jameson Graef Rollins > --- > This tweaks the ori

[PATCH] emacs: Use a single buffer invisibility spec to fix quadratic search cost.

Hi Austin. The patch looks good to me. Thanks for it! A very nice optimization! Regards, Dmitry

Re: [PATCH] emacs: Use a single buffer invisibility spec to fix quadratic search cost.

Hi Austin. The patch looks good to me. Thanks for it! A very nice optimization! Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] tag: Automatically limit to messages whose tags will actually change.

Hi Austin. On Mon, 7 Nov 2011 22:55:23 -0500, Austin Clements wrote: > This optimizes the user's tagging query to exclude messages that won't > be affected by the tagging operation, saving computation and IO for > redundant tagging operations. > > For example, > notmuch tag +notmuch to:notmuc

Re: [PATCH] tag: Automatically limit to messages whose tags will actually change.

Hi Austin. On Mon, 7 Nov 2011 22:55:23 -0500, Austin Clements wrote: > This optimizes the user's tagging query to exclude messages that won't > be affected by the tagging operation, saving computation and IO for > redundant tagging operations. > > For example, > notmuch tag +notmuch to:notmuc

[PATCH v3 4/4] emacs: remove unused `point-invisible-p' function

`point-invisible-p' does not work correctly when `invisible' property is a list. There are standard `invisible-p' and related functions that should be used instead. --- emacs/notmuch-lib.el | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/emacs/notmuch-lib.e

[PATCH v3 3/4] emacs: remove no longer used functions from notmuch-show.el

Remove `notmuch-show-move-past-invisible-backward' and `notmuch-show-move-past-invisible-forward' functions which are unused. --- emacs/notmuch-show.el |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index b70dbfb..aaf69

[PATCH v3 2/4] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive

Use `previous-single-char-property-change' instead of going through each character by hand and testing it's visibility. This fixes `notmuch-show-advance-and-archive' to work for the last message in thread with hidden signature. --- emacs/notmuch-show.el | 17 + 1 files changed,

[PATCH v3 1/4] test: `notmuch-show-advance-and-archive' with invisible signature

Add Emacs test to check that `notmuch-show-advance-and-archive' works for the last message in thread with invisible signature. --- test/emacs | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index 0303d7d..1aa5299 100755 --- a/test/emac

[PATCH v2 4/7] test: `notmuch-show-advance-and-archive' with invisible signature

Hi David. On Sat, 05 Nov 2011 22:06:47 -0300, David Bremner wrote: > On Fri, 1 Jul 2011 08:55:19 +0400, Dmitry Kurochkin gmail.com> wrote: > > Add Emacs test to check that `notmuch-show-advance-and-archive' > > works for the last message in thread with invisible signa

[PATCH v3 4/4] emacs: remove unused `point-invisible-p' function

`point-invisible-p' does not work correctly when `invisible' property is a list. There are standard `invisible-p' and related functions that should be used instead. --- emacs/notmuch-lib.el | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/emacs/notmuch-lib.e

[PATCH v3 3/4] emacs: remove no longer used functions from notmuch-show.el

Remove `notmuch-show-move-past-invisible-backward' and `notmuch-show-move-past-invisible-forward' functions which are unused. --- emacs/notmuch-show.el |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index b70dbfb..aaf69

[PATCH v3 2/4] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive

Use `previous-single-char-property-change' instead of going through each character by hand and testing it's visibility. This fixes `notmuch-show-advance-and-archive' to work for the last message in thread with hidden signature. --- emacs/notmuch-show.el | 17 + 1 files changed,

[PATCH v3 1/4] test: `notmuch-show-advance-and-archive' with invisible signature

Add Emacs test to check that `notmuch-show-advance-and-archive' works for the last message in thread with invisible signature. --- test/emacs | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index 0303d7d..1aa5299 100755 --- a/test/emac

Re: [PATCH v2 4/7] test: `notmuch-show-advance-and-archive' with invisible signature

Hi David. On Sat, 05 Nov 2011 22:06:47 -0300, David Bremner wrote: > On Fri, 1 Jul 2011 08:55:19 +0400, Dmitry Kurochkin > wrote: > > Add Emacs test to check that `notmuch-show-advance-and-archive' > > works for the last message in thread with invisible signature. &g

output file argument to notmuch dump.

On Thu, 06 Oct 2011 21:20:40 -0300, David Bremner wrote: > > I'd like to add a search term argument to notmuch dump (see > id:"87wrcijn1w.fsf at zancas.localnet" and followup for context). The > "notmuch" way would be to have > > notmuch dump > > do the right thing, and that is easy enough

Re: output file argument to notmuch dump.

On Thu, 06 Oct 2011 21:20:40 -0300, David Bremner wrote: > > I'd like to add a search term argument to notmuch dump (see > id:"87wrcijn1w.fsf@zancas.localnet" and followup for context). The > "notmuch" way would be to have > > notmuch dump > > do the right thing, and that is easy enough _e

Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part

Hi Thomas. On Mon, 03 Oct 2011 14:39:36 +0200, Thomas Jost wrote: > On Sun, 02 Oct 2011 05:45:53 +0400, Dmitry Kurochkin > wrote: > > BTW there were patches to support tmux (or maybe it was dtach). IIRC > > the consensus was that supporting it does not worth complicatin

[PATCH 3/3] test: add emacs test for hiding a message following an HTML part

Hi Thomas. On Mon, 03 Oct 2011 14:39:36 +0200, Thomas Jost wrote: > On Sun, 02 Oct 2011 05:45:53 +0400, Dmitry Kurochkin gmail.com> wrote: > > BTW there were patches to support tmux (or maybe it was dtach). IIRC > > the consensus was that supporting it does not worth complic

[PATCH 3/3] test: add emacs test for hiding a message following an HTML part

Hi David. On Sat, 01 Oct 2011 08:51:20 -0300, David Bremner wrote: > On Mon, 26 Sep 2011 21:25:08 +0400, Dmitry Kurochkin gmail.com> wrote: > > Most likely the test passes because emacs is run in server mode and > > visibility stuff works differently. I sent a patch series [1

Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part

Hi David. On Sat, 01 Oct 2011 08:51:20 -0300, David Bremner wrote: > On Mon, 26 Sep 2011 21:25:08 +0400, Dmitry Kurochkin > wrote: > > Most likely the test passes because emacs is run in server mode and > > visibility stuff works differently. I sent a patch series [1] t

[PATCH 3/3] test: add emacs test for hiding a message following an HTML part

Hi David. On Mon, 26 Sep 2011 08:01:16 -0300, David Bremner wrote: > On Mon, 4 Jul 2011 05:59:03 +0400, Dmitry Kurochkin gmail.com> wrote: > > Result: nothing happens except for "No URL at point" message > > > > Expected result: the second message is shown/

Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part

Hi David. On Mon, 26 Sep 2011 08:01:16 -0300, David Bremner wrote: > On Mon, 4 Jul 2011 05:59:03 +0400, Dmitry Kurochkin > wrote: > > Result: nothing happens except for "No URL at point" message > > > > Expected result: the second message is shown/hidden

[PATCH] test: reset test_subtest_known_broken_ after each success/failure.

On Mon, 12 Sep 2011 23:41:54 -0300, david at tethera.net wrote: > From: David Bremner > > This means that test_subtest_known_broken needs to be called before > every known broken subtest, which is no different than what is > documented for the test_begin_subtest case. > > The assumption is that

Re: [PATCH] test: reset test_subtest_known_broken_ after each success/failure.

On Mon, 12 Sep 2011 23:41:54 -0300, da...@tethera.net wrote: > From: David Bremner > > This means that test_subtest_known_broken needs to be called before > every known broken subtest, which is no different than what is > documented for the test_begin_subtest case. > > The assumption is that eve

[PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file

On Sun, 11 Sep 2011 20:51:47 -0300, David Bremner wrote: > On Mon, 12 Sep 2011 03:30:54 +0400, Dmitry Kurochkin gmail.com> wrote: > > Hi David. > > IMHO this is not a good idea, because: > > > > 1. It introduces multiple places where the flag is reset. If new >

[PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file

Hi David. On Sun, 11 Sep 2011 20:11:54 -0300, david at tethera.net wrote: > From: David Bremner > > Commit 4cc6727 introduced the library function > test_subtest_known_broken which sets a variable > test_subtest_known_broken_ . Unfortunately this variable is not reset > if test_begin_subtest is

Re: [PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file

On Sun, 11 Sep 2011 20:51:47 -0300, David Bremner wrote: > On Mon, 12 Sep 2011 03:30:54 +0400, Dmitry Kurochkin > wrote: > > Hi David. > > IMHO this is not a good idea, because: > > > > 1. It introduces multiple places where the flag is reset. If new > >

Re: [PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file

Hi David. On Sun, 11 Sep 2011 20:11:54 -0300, da...@tethera.net wrote: > From: David Bremner > > Commit 4cc6727 introduced the library function > test_subtest_known_broken which sets a variable > test_subtest_known_broken_ . Unfortunately this variable is not reset > if test_begin_subtest is not

[PATCH v2 5/7] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive

On Wed, 07 Sep 2011 09:13:22 +, Jani Nikula wrote: > On Fri, 1 Jul 2011 08:55:20 +0400, Dmitry Kurochkin gmail.com> wrote: > > Use `previous-single-char-property-change' instead of going > > through each character by hand and testing it's visibility. This >

Re: [PATCH v2 5/7] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive

On Wed, 07 Sep 2011 09:13:22 +, Jani Nikula wrote: > On Fri, 1 Jul 2011 08:55:20 +0400, Dmitry Kurochkin > wrote: > > Use `previous-single-char-property-change' instead of going > > through each character by hand and testing it's visibility. This > &g

[PATCH] Do not attept to output part raw if part is not GMimePart.

Hi Jamie. On Tue, 06 Sep 2011 09:43:00 -0700, Jameson Graef Rollins wrote: > On Fri, 3 Jun 2011 10:01:06 -0700, Jameson Graef Rollins finestructure.net> wrote: > > This was a minor oversite in checking of part type when outputing > > content raw. This was causing gmime was to throw an exceptio

Re: [PATCH] Do not attept to output part raw if part is not GMimePart.

Hi Jamie. On Tue, 06 Sep 2011 09:43:00 -0700, Jameson Graef Rollins wrote: > On Fri, 3 Jun 2011 10:01:06 -0700, Jameson Graef Rollins > wrote: > > This was a minor oversite in checking of part type when outputing > > content raw. This was causing gmime was to throw an exception to > > stderr

[PATCH] test: run emacs inside tmux if screen is not available

On Wed, 20 Jul 2011 20:12:55 +0200, Thomas Jost wrote: > On Wed, 20 Jul 2011 10:28:38 -0700, Jameson Graef Rollins finestructure.net> wrote: > Non-text part: multipart/signed > > On Wed, 20 Jul 2011 17:37:35 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > On W

[PATCH] test: run emacs inside tmux if screen is not available

Hi Thomas. On Wed, 20 Jul 2011 14:36:36 +0200, Thomas Jost wrote: > Before this change, the test suite reported many failed tests on machines > where > screen is not installed (which is the case of many *BSD systems). This patch > makes the test suite try to use tmux, another terminal multiplex

Re: [PATCH] test: run emacs inside tmux if screen is not available

On Wed, 20 Jul 2011 20:12:55 +0200, Thomas Jost wrote: > On Wed, 20 Jul 2011 10:28:38 -0700, Jameson Graef Rollins > wrote: > Non-text part: multipart/signed > > On Wed, 20 Jul 2011 17:37:35 +0400, Dmitry Kurochkin > > wrote: > > > On Wed, 20 Jul 2011 14:36:36 +0

Re: [PATCH] test: run emacs inside tmux if screen is not available

Hi Thomas. On Wed, 20 Jul 2011 14:36:36 +0200, Thomas Jost wrote: > Before this change, the test suite reported many failed tests on machines > where > screen is not installed (which is the case of many *BSD systems). This patch > makes the test suite try to use tmux, another terminal multiplexe

[PATCH] Emacs: Add variable to toggle message indentation in a thread

gards, Dmitry > I didn't change the "when" though--not because of personal reasons > ;)--but because it is used for determining indentation of multi-parts. > > > Cheers, > Felix > > > > On Mon, 11 Jul 2011 12:53:04 +0400, Dmitry Kurochkin gmail.com&

[PATCH] Emacs: Add variable to toggle message indentation in a thread

Hi Felix. On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller wrote: > Hi, > > I added a variable to toggle message indentation in Emacs. > > Please let me know what you think. > I like the change. Though I do not think I would use it without chronological sorting. Comments on the code below.

Re: [PATCH] Emacs: Add variable to toggle message indentation in a thread

gards, Dmitry > I didn't change the "when" though--not because of personal reasons > ;)--but because it is used for determining indentation of multi-parts. > > > Cheers, > Felix > > > > On Mon, 11 Jul 2011 12:53:04 +0400, Dmitry Kurochkin > wro

Re: [PATCH] Emacs: Add variable to toggle message indentation in a thread

Hi Felix. On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller wrote: > Hi, > > I added a variable to toggle message indentation in Emacs. > > Please let me know what you think. > I like the change. Though I do not think I would use it without chronological sorting. Comments on the code below.

[PATCH v2] emacs: Turn id:"" elements into buttons for notmuch searches

On Thu, 07 Jul 2011 10:15:47 +0200, Daniel Schoepe wrote: > Hi Dmitry, > > On Thu, 07 Jul 2011 11:16:03 +0400, Dmitry Kurochkin gmail.com> wrote: > > Why do we need to remove `goto-address-mode' overlays if it is not > > enabled ((goto-address-mode t) is below is

[PATCH v2] emacs: Turn id:"" elements into buttons for notmuch searches

Hi Daniel. On Wed, 6 Jul 2011 16:18:01 +0200, Daniel Schoepe wrote: > This fixes the minor annoyance that message ids were parsed as mail > addresses by goto-address-mode in notmuch-show buffers. I did not try it yet but it looks like a nice feature. Though I have some questions on the code be

Re: [PATCH v2] emacs: Turn id:"" elements into buttons for notmuch searches

On Thu, 07 Jul 2011 10:15:47 +0200, Daniel Schoepe wrote: > Hi Dmitry, > > On Thu, 07 Jul 2011 11:16:03 +0400, Dmitry Kurochkin > wrote: > > Why do we need to remove `goto-address-mode' overlays if it is not > > enabled ((goto-address-mode t) is below is removed

Re: [PATCH v2] emacs: Turn id:"" elements into buttons for notmuch searches

Hi Daniel. On Wed, 6 Jul 2011 16:18:01 +0200, Daniel Schoepe wrote: > This fixes the minor annoyance that message ids were parsed as mail > addresses by goto-address-mode in notmuch-show buffers. I did not try it yet but it looks like a nice feature. Though I have some questions on the code b

[PATCH 2/2] emacs: skip forward to visible text in notmuch-show-message-extent

On Sun, 3 Jul 2011 08:28:06 +0400, Dmitry Kurochkin wrote: > The patch rewrites `notmuch-show-message-extent' to be more > robust. The main goal is to make it work as expected if point is > invisible. Besides, there are no more point movements and > property search functions

Re: [PATCH 2/2] emacs: skip forward to visible text in notmuch-show-message-extent

On Sun, 3 Jul 2011 08:28:06 +0400, Dmitry Kurochkin wrote: > The patch rewrites `notmuch-show-message-extent' to be more > robust. The main goal is to make it work as expected if point is > invisible. Besides, there are no more point movements and > property search functions

[PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

On Mon, 04 Jul 2011 10:55:21 +0200, Pieter Praet wrote: > On Mon, 4 Jul 2011 12:27:04 +0400, Dmitry Kurochkin gmail.com> wrote: > > It is very convenient when C-e (bound to `widget-end-of-line') ignores > > trailing spaces inside the search widget. But it only does so

[PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

It is very convenient when C-e (bound to `widget-end-of-line') ignores trailing spaces inside the search widget. But it only does so if a widget is not followed by a newline (that is why it works in the saved search widgets). The patch just adds an insisible space after the search widget to get t

[PATCH] emacs: add insisible space after the search widget field in notmuch-hello

On Mon, 04 Jul 2011 09:24:17 +0200, Pieter Praet wrote: > On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin gmail.com> wrote: > > It is very convenient when C-e (bound to `widget-end-of-line') ignores > > trailing spaces inside the search widget. But it only does so

[PATCH] emacs: add insisible space after the search widget field in notmuch-hello

It is very convenient when C-e (bound to `widget-end-of-line') ignores trailing spaces inside the search widget. But it only does so if a widget is not followed by a newline (that is why it works in the saved search widgets). The patch just adds an insisible space after the search widget to get t

[PATCH v2 3/3] test: add emacs test for hiding a message following an HTML part

Human-friendly scenario: * open a thread where a message which ends with an HTML part is followed by another message * make the first message visible * goto the beginning of the second message (first line, first colon) * hit "RET" Result: nothing happens except for "No URL at point" message

[PATCH v2 2/3] test: improve known broken tests support

There is existing support for broken tests. But it is not convenient to use. The primary issue is that we have to maintain a set of test_expect_*_failure functions which are equivalent to the normal test_expect_* counterparts except for what functions are called for result reporting. The patch a

[PATCH v2 1/3] test: update documentation for test_emacs in test/README

Update test_emacs documentation in test/README according to the latest changes in emacs tests. Move the note regarding setting variables from test/emacs to test/README. --- test/README | 10 +++--- test/emacs |5 - 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/test

[PATCH v2 0/3] improved broken tests support and test for a bug

This version implements suggestions by Austin. Regards, Dmitry

[PATCH 2/3] test: improve known broken tests support

> Oh. I hope atomicity will be there soon. > Three minor comments below. > > On Sun, Jul 3, 2011 at 9:59 PM, Dmitry Kurochkin > wrote: > > There is existing support for broken tests. ?But it is not convenient > > to use. ?The primary issue is that we have to m

[PATCH 3/3] test: add emacs test for hiding a message following an HTML part

Human-friendly scenario: * open a thread where a message which ends with an HTML part is followed by another message * make the first message visible * goto the beginning of the second message (first line, first colon) * hit "RET" Result: nothing happens except for "No URL at point" message

[PATCH 2/3] test: improve known broken tests support

There is existing support for broken tests. But it is not convenient to use. The primary issue is that we have to maintain a set of test_expect_*_failure functions which are equivalent to the normal test_expect_* counterparts except for what functions are called for result reporting. The patch a

[PATCH 1/3] test: update documentation for test_emacs in test/README

Update test_emacs documentation in test/README according to the latest changes in emacs tests. Move the note regarding setting variables from test/emacs to test/README. --- test/README | 10 +++--- test/emacs |5 - 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/test

Re: [PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

On Mon, 04 Jul 2011 10:55:21 +0200, Pieter Praet wrote: > On Mon, 4 Jul 2011 12:27:04 +0400, Dmitry Kurochkin > wrote: > > It is very convenient when C-e (bound to `widget-end-of-line') ignores > > trailing spaces inside the search widget. But it only does so if a >

[PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

It is very convenient when C-e (bound to `widget-end-of-line') ignores trailing spaces inside the search widget. But it only does so if a widget is not followed by a newline (that is why it works in the saved search widgets). The patch just adds an insisible space after the search widget to get t

Re: [PATCH] emacs: add insisible space after the search widget field in notmuch-hello

On Mon, 04 Jul 2011 09:24:17 +0200, Pieter Praet wrote: > On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin > wrote: > > It is very convenient when C-e (bound to `widget-end-of-line') ignores > > trailing spaces inside the search widget. But it only does so if a >

[PATCH] emacs: add insisible space after the search widget field in notmuch-hello

It is very convenient when C-e (bound to `widget-end-of-line') ignores trailing spaces inside the search widget. But it only does so if a widget is not followed by a newline (that is why it works in the saved search widgets). The patch just adds an insisible space after the search widget to get t

[PATCH v2 3/3] test: add emacs test for hiding a message following an HTML part

Human-friendly scenario: * open a thread where a message which ends with an HTML part is followed by another message * make the first message visible * goto the beginning of the second message (first line, first colon) * hit "RET" Result: nothing happens except for "No URL at point" message

[PATCH v2 2/3] test: improve known broken tests support

There is existing support for broken tests. But it is not convenient to use. The primary issue is that we have to maintain a set of test_expect_*_failure functions which are equivalent to the normal test_expect_* counterparts except for what functions are called for result reporting. The patch a

<    5   6   7   8   9   10   11   12   13   >