[PATCH] configure: add workaround for systems without zlib.pc

2014-05-11 Thread Felipe Contreras
Some systems (e.g. FreeBSD) might not have installed the appropriate pkg-config file as they should. We can workaround the issue by creating the .pc file they should have distributed. Signed-off-by: Felipe Contreras --- compat/.gitignore| 1 + compat/gen_zlib_pc.c | 18

[PATCH] build: fix order of rpath

2014-05-11 Thread Felipe Contreras
chance of screwing the build. Signed-off-by: Felipe Contreras --- Makefile.local | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Makefile.local b/Makefile.local index fa07d81..af79b5c 100644 --- a/Makefile.local +++ b/Makefile.local @@ -46,15 +46,16 @@ PV_FILE=binding

Fix notmuchmail.org/emacstips/

2014-05-11 Thread Felipe Contreras
ut why it wasn't working :( Cheers. -- Felipe Contreras

[PATCH] configure: add workaround for systems without zlib.pc

2014-05-11 Thread Felipe Contreras
Some systems (e.g. FreeBSD) might not have installed the appropriate pkg-config file as they should. We can workaround the issue by creating the .pc file they should have distributed. Signed-off-by: Felipe Contreras --- compat/.gitignore| 1 + compat/gen_zlib_pc.c | 18

[PATCH] build: fix order of rpath

2014-05-11 Thread Felipe Contreras
chance of screwing the build. Signed-off-by: Felipe Contreras --- Makefile.local | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Makefile.local b/Makefile.local index fa07d81..af79b5c 100644 --- a/Makefile.local +++ b/Makefile.local @@ -46,15 +46,16 @@ PV_FILE=binding

Fix notmuchmail.org/emacstips/

2014-05-11 Thread Felipe Contreras
ut why it wasn't working :( Cheers. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] ruby: Add wrapper for notmuch_query_count_threads

2014-05-10 Thread Felipe Contreras
Wael M. Nasreddine wrote: > --- > bindings/ruby/defs.h | 3 +++ > bindings/ruby/init.c | 1 + > bindings/ruby/query.c | 19 +++ > 3 files changed, 23 insertions(+) LGTM. -- Felipe Contreras

[PATCH] ruby: Add wrapper for notmuch_query_count_threads

2014-05-10 Thread Felipe Contreras
Wael M. Nasreddine wrote: > This patch exposes query.cc::notmuch_query_count_threads to Ruby, the > benchmark on 85k emails is amazing: I meant to do this but forgot. Thanks! -- Felipe Contreras

[PATCH 1/2] configure: add a fallback check for zlib

2014-05-10 Thread Felipe Contreras
Tomi Ollila wrote: > On Sun, May 11 2014, Felipe Contreras wrote: > > > X?c? wrote: > >> Since zlib is part of the base system, FreeBSD chose not to register it > >> in pkg-config through zlib.pc. As a fallback test, configure will build > >> and run a zlib

[PATCH 1/2] configure: add a fallback check for zlib

2014-05-10 Thread Felipe Contreras
r on zlib.pc, this way the configure script would be cleaner. -- Felipe Contreras

RE: [PATCH] ruby: Add wrapper for notmuch_query_count_threads

2014-05-10 Thread Felipe Contreras
Wael M. Nasreddine wrote: > --- > bindings/ruby/defs.h | 3 +++ > bindings/ruby/init.c | 1 + > bindings/ruby/query.c | 19 +++ > 3 files changed, 23 insertions(+) LGTM. -- Felipe Contreras ___ notmuch maili

RE: [PATCH] ruby: Add wrapper for notmuch_query_count_threads

2014-05-10 Thread Felipe Contreras
Wael M. Nasreddine wrote: > This patch exposes query.cc::notmuch_query_count_threads to Ruby, the > benchmark on 85k emails is amazing: I meant to do this but forgot. Thanks! -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.or

RE: [PATCH 1/2] configure: add a fallback check for zlib

2014-05-10 Thread Felipe Contreras
Tomi Ollila wrote: > On Sun, May 11 2014, Felipe Contreras wrote: > > > Xīcò wrote: > >> Since zlib is part of the base system, FreeBSD chose not to register it > >> in pkg-config through zlib.pc. As a fallback test, configure will build > >> and run a zlib

RE: [PATCH 1/2] configure: add a fallback check for zlib

2014-05-10 Thread Felipe Contreras
r on zlib.pc, this way the configure script would be cleaner. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Github?

2014-05-10 Thread Felipe Contreras
Tomi Ollila wrote: > BTW: does .travis.yml support comment lines ? It's YAML. So, yes. -- Felipe Contreras

Re: Github?

2014-05-10 Thread Felipe Contreras
Tomi Ollila wrote: > BTW: does .travis.yml support comment lines ? It's YAML. So, yes. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

pkg-config zlib check in 3c13bc

2014-05-09 Thread Felipe Contreras
ch motivated him to roll his own. Personally I > don't really think any of the alternatives are convincingly better than > autoconf. Of course it's one of those very subjective things. I think Makefiles are superior to autoconf. What we have is fine. -- Felipe Contreras

Re: pkg-config zlib check in 3c13bc

2014-05-09 Thread Felipe Contreras
ch motivated him to roll his own. Personally I > don't really think any of the alternatives are convincingly better than > autoconf. Of course it's one of those very subjective things. I think Makefiles are superior to autoconf. Wha

[PATCH] Add Travis-CI config file.

2014-05-09 Thread Felipe Contreras
Wael M. Nasreddine wrote: > On Fri, May 9, 2014 at 8:24 AM, Felipe Contreras > wrote: > > I had to manually find the build. In case anybody wants to check it out: > > > > https://travis-ci.org/notmuch/notmuch/builds > > To be specific it's build #2 you see th

[PATCH] Add Travis-CI config file.

2014-05-09 Thread Felipe Contreras
Wael Nasreddine wrote: > On Travis Zlib is old and notmuch configure script exits with a > failure, please see the Travis build #1 Please do not top-post. I had to manually find the build. In case anybody wants to check it out: https://travis-ci.org/notmuch/notmuch/builds -- Felipe Contreras

[PATCH] Add Travis-CI config file.

2014-05-09 Thread Felipe Contreras
iles/zlib1g_1.2.8.dfsg-1ubuntu1_amd64.deb' > + - sudo dpkg -i zlib1g-dev_1.2.8.dfsg-1ubuntu1_amd64.deb > zlib1g_1.2.8.dfsg-1ubuntu1_amd64.deb What's wrong with zlib? > + - sudo apt-get install -f > + - sudo apt-get install dtach libxapian-dev libgmime-2.6-dev libtalloc-dev > python-sphinx > + > +script: make test -- Felipe Contreras

Re: [PATCH] Add Travis-CI config file.

2014-05-09 Thread Felipe Contreras
Wael M. Nasreddine wrote: > On Fri, May 9, 2014 at 8:24 AM, Felipe Contreras > wrote: > > I had to manually find the build. In case anybody wants to check it out: > > > > https://travis-ci.org/notmuch/notmuch/builds > > To be specific it's build #2 you see th

RE: [PATCH] Add Travis-CI config file.

2014-05-09 Thread Felipe Contreras
Wael Nasreddine wrote: > On Travis Zlib is old and notmuch configure script exits with a > failure, please see the Travis build #1 Please do not top-post. I had to manually find the build. In case anybody wants to check it out: https://travis-ci.org/notmuch/notmuch/builds -- Felipe Con

Submodules for language bindings (was: Github?)

2014-05-09 Thread Felipe Contreras
Suvayu Ali wrote: > On Fri, May 09, 2014 at 07:40:27AM -0500, Felipe Contreras wrote: > > Suvayu Ali wrote: > > > > > To explain my point with RPM specifics, if I were to > > > use separate spec files, python-notmuch would have: > > > > > >

RE: [PATCH] Add Travis-CI config file.

2014-05-09 Thread Felipe Contreras
iles/zlib1g_1.2.8.dfsg-1ubuntu1_amd64.deb' > + - sudo dpkg -i zlib1g-dev_1.2.8.dfsg-1ubuntu1_amd64.deb > zlib1g_1.2.8.dfsg-1ubuntu1_amd64.deb What's wrong with zlib? > + - sudo apt-get install -f > + - sudo apt-get install dtach libxapian-dev lib

Submodules for language bindings (was: Github?)

2014-05-09 Thread Felipe Contreras
gt; version dependencies, this becomes quite cumbersome; No, it doesn't: %package notmuch-ruby Requires: notmuch = %{version}-%{release}, ruby -- Felipe Contreras

Github?

2014-05-09 Thread Felipe Contreras
Amadeusz ?o?nowski wrote: > The same goes for Travis. There's already a build bot. Why bother > with Travis? I've never seen any buildbot results. TravisCI's interface is just simple and easy. And all it requires is one file. -- Felipe Contreras

Re: Submodules for language bindings (was: Github?)

2014-05-09 Thread Felipe Contreras
Suvayu Ali wrote: > On Fri, May 09, 2014 at 07:40:27AM -0500, Felipe Contreras wrote: > > Suvayu Ali wrote: > > > > > To explain my point with RPM specifics, if I were to > > > use separate spec files, python-notmuch would have: > > > > > >

Re: Submodules for language bindings (was: Github?)

2014-05-09 Thread Felipe Contreras
gt; version dependencies, this becomes quite cumbersome; No, it doesn't: %package notmuch-ruby Requires: notmuch = %{version}-%{release}, ruby -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: Github?

2014-05-09 Thread Felipe Contreras
Amadeusz Żołnowski wrote: > The same goes for Travis. There's already a build bot. Why bother > with Travis? I've never seen any buildbot results. TravisCI's interface is just simple and easy. And all it requires is one file.

Github?

2014-05-08 Thread Felipe Contreras
[1] without adding new ones. I disagree. There's absolutely zero chance of a problem adding a 'travis-ci' branch, which adds a single file, which would conflict with upstream in anyway. -- Felipe Contreras

Github?

2014-05-08 Thread Felipe Contreras
Wael Nasreddine wrote: > Actually you can't have the .Travis.yml file in a separate branch, > Travis require it present in the context that it is testing (commits > to all branches) Yes, so? The 'travis-ci' branch can merge from upstream, and then upstream would be tested. -- Felipe Contreras

Github?

2014-05-08 Thread Felipe Contreras
ike the plague. Source: I'm a Git developer. -- Felipe Contreras

Github?

2014-05-08 Thread Felipe Contreras
Wael Nasreddine wrote: > Would you be willing to add Travis.yml upstream? I would. After all we have packaging stuff which are not strictly part of notmuch. -- Felipe Contreras

Github?

2014-05-08 Thread Felipe Contreras
\ >C---o---o some-feature That wouldn't be a problem if HEAD didn't point to 'master' but to 'upstream' which would be 'notmuch/master'. Or if the branch with the modifications was called something else, like 'travis-ci'. -- Felipe Contreras

Github?

2014-05-08 Thread Felipe Contreras
vis.yml file :) I actually think we should have GitHub repo, and a .travis.yml file. However, the travis stuff can live in a 'travis-ci' branch. -- Felipe Contreras

Re: Github?

2014-05-08 Thread Felipe Contreras
[1] without adding new ones. I disagree. There's absolutely zero chance of a problem adding a 'travis-ci' branch, which adds a single file, which would conflict with upstream in anyway. -- Felipe Contreras ___ notmuch mailing list notm

Re: Github?

2014-05-08 Thread Felipe Contreras
Wael Nasreddine wrote: > Actually you can't have the .Travis.yml file in a separate branch, > Travis require it present in the context that it is testing (commits > to all branches) Yes, so? The 'travis-ci' branch can merge from upstream, and then upstream would be teste

Re: Github?

2014-05-08 Thread Felipe Contreras
ike the plague. Source: I'm a Git developer. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: Github?

2014-05-08 Thread Felipe Contreras
Wael Nasreddine wrote: > Would you be willing to add Travis.yml upstream? I would. After all we have packaging stuff which are not strictly part of notmuch. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.

Re: Github?

2014-05-08 Thread Felipe Contreras
\ >C---o---o some-feature That wouldn't be a problem if HEAD didn't point to 'master' but to 'upstream' which would be 'notmuch/master'. Or if the branch with the modifications was called something else, like 'travis

Re: Github?

2014-05-08 Thread Felipe Contreras
vis.yml file :) I actually think we should have GitHub repo, and a .travis.yml file. However, the travis stuff can live in a 'travis-ci' branch. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Github?

2014-05-08 Thread Felipe Contreras
d it easier for Notmuch to distribute them. As for the vim plugin, it can already be used as a bundle: https://github.com/felipec/notmuch-vim-ruby -- Felipe Contreras

Re: Github?

2014-05-08 Thread Felipe Contreras
d it easier for Notmuch to distribute them. As for the vim plugin, it can already be used as a bundle: https://github.com/felipec/notmuch-vim-ruby -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Final call for news for 0.18

2014-05-04 Thread Felipe Contreras
e debian changelog and it looks correct, I don't think there is much point in mentioning the fix in the NEWS. -- Felipe Contreras

Re: Final call for news for 0.18

2014-05-04 Thread Felipe Contreras
e debian changelog and it looks correct, I don't think there is much point in mentioning the fix in the NEWS. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v2 3/3] vim: improve the way messages are sent

2014-05-01 Thread Felipe Contreras
encoded. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 0cb94f6..331e930 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -86,17 +86,22

[PATCH v2 2/3] vim: make the html handler configurable

2014-05-01 Thread Felipe Contreras
From: Paul Roberts Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 25a16e9..0cb94f6 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -919,7 +919,8 @@ ruby <&l

[PATCH v2 1/3] vim: fix count_threads variable check

2014-05-01 Thread Felipe Contreras
It never really worked; in Ruby only 'nil' and 'false' evaluate to false, therefore the statement '0 : true ? false' returns true, so it doesn't matter if notmuch_folders_count_threads = 0, count_threads would be true. We need to check specifically if the valu

[PATCH v2 0/3] vim plugin updates

2014-05-01 Thread Felipe Contreras
A few trivial updates, and an important fix. Changes since v1: improved commit messages. Felipe Contreras (2): vim: fix count_threads variable check vim: improve the way messages are sent Paul Roberts (1): vim: make the html handler configurable vim/notmuch.vim | 39

Final call for news for 0.18

2014-05-01 Thread Felipe Contreras
. > these patches should just have come earlier... Yes. > ... but if you had a good case, fix these things (quickly!) and had > strong backing from some other notmuch-vim users I could see a small > chance of these being part of the next release... All right. > PS: does vim frontend lack id:message-id feature -- What feature? -- Felipe Contreras

[PATCH v2 3/3] vim: improve the way messages are sent

2014-05-01 Thread Felipe Contreras
encoded. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 0cb94f6..331e930 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -86,17 +86,22

[PATCH v2 2/3] vim: make the html handler configurable

2014-05-01 Thread Felipe Contreras
From: Paul Roberts Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 25a16e9..0cb94f6 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -919,7 +919,8 @@ ruby <&l

[PATCH v2 0/3] vim plugin updates

2014-05-01 Thread Felipe Contreras
A few trivial updates, and an important fix. Changes since v1: improved commit messages. Felipe Contreras (2): vim: fix count_threads variable check vim: improve the way messages are sent Paul Roberts (1): vim: make the html handler configurable vim/notmuch.vim | 39

[PATCH v2 1/3] vim: fix count_threads variable check

2014-05-01 Thread Felipe Contreras
It never really worked; in Ruby only 'nil' and 'false' evaluate to false, therefore the statement '0 : true ? false' returns true, so it doesn't matter if notmuch_folders_count_threads = 0, count_threads would be true. We need to check specifically if the valu

RE: Final call for news for 0.18

2014-05-01 Thread Felipe Contreras
these patches should just have come earlier... Yes. > ... but if you had a good case, fix these things (quickly!) and had > strong backing from some other notmuch-vim users I could see a small > chance of these being part of the next release... All right. > PS: does vim frontend lac

Final call for news for 0.18

2014-04-30 Thread Felipe Contreras
me any NEWS comments ASAP. What about the vim changes? http://mid.gmane.org/1398289784-18203-1-git-send-email-felipe.contreras at gmail.com -- Felipe Contreras

RE: Final call for news for 0.18

2014-04-30 Thread Felipe Contreras
me any NEWS comments ASAP. What about the vim changes? http://mid.gmane.org/1398289784-18203-1-git-send-email-felipe.contre...@gmail.com -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 3/3] Improve the way messages are sent

2014-04-23 Thread Felipe Contreras
We want the proper encoding and content-type to be set when sending the mail, but human-readable plain-text for composing. So split the code in two parts: the presentation and the transport conversion. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 34

[PATCH 2/3] Make the html handler configurable

2014-04-23 Thread Felipe Contreras
From: Paul Roberts Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 25a16e9..0cb94f6 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -919,7 +919,8 @@ ruby <&l

[PATCH 1/3] Fix count_threads variable check

2014-04-23 Thread Felipe Contreras
Seems it never really worked. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index d7b310c..25a16e9 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -633,7 +633,7 @@ ruby <&l

[PATCH 0/3] vim plugin updates

2014-04-23 Thread Felipe Contreras
A few trivial updates, and an important fix. Felipe Contreras (2): Fix count_threads variable check Improve the way messages are sent Paul Roberts (1): Make the html handler configurable vim/notmuch.vim | 39 --- 1 file changed, 24 insertions(+), 15

[PATCH 1/3] Fix count_threads variable check

2014-04-23 Thread Felipe Contreras
Seems it never really worked. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index d7b310c..25a16e9 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -633,7 +633,7 @@ ruby <&l

[PATCH 2/3] Make the html handler configurable

2014-04-23 Thread Felipe Contreras
From: Paul Roberts Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 25a16e9..0cb94f6 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -919,7 +919,8 @@ ruby <&l

[PATCH 3/3] Improve the way messages are sent

2014-04-23 Thread Felipe Contreras
We want the proper encoding and content-type to be set when sending the mail, but human-readable plain-text for composing. So split the code in two parts: the presentation and the transport conversion. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 34

[PATCH 0/3] vim plugin updates

2014-04-23 Thread Felipe Contreras
A few trivial updates, and an important fix. Felipe Contreras (2): Fix count_threads variable check Improve the way messages are sent Paul Roberts (1): Make the html handler configurable vim/notmuch.vim | 39 --- 1 file changed, 24 insertions(+), 15

[PATCH 00/21] vim: general updates

2013-11-27 Thread Felipe Contreras
On Wed, Nov 20, 2013 at 4:13 PM, David Bremner wrote: > Felipe Contreras writes: >>> Please do. It's one of the things I'm waiting for before a feature >>> freeze for 0.17 >> >> Sorry I forgot, it's pushed now. > > OK, thanks. Anything you

Re: [PATCH 00/21] vim: general updates

2013-11-26 Thread Felipe Contreras
On Wed, Nov 20, 2013 at 4:13 PM, David Bremner wrote: > Felipe Contreras writes: >>> Please do. It's one of the things I'm waiting for before a feature >>> freeze for 0.17 >> >> Sorry I forgot, it's pushed now. > > OK, thanks. Anything you

[PATCH 00/21] vim: general updates

2013-11-20 Thread Felipe Contreras
On Wed, Nov 20, 2013 at 6:21 AM, David Bremner wrote: > Felipe Contreras writes: > >> >> All right, if there's no further feedback I'll push these tomorrow. >> > > Please do. It's one of the things I'm waiting for before a feature > free

Re: [PATCH 00/21] vim: general updates

2013-11-20 Thread Felipe Contreras
On Wed, Nov 20, 2013 at 6:21 AM, David Bremner wrote: > Felipe Contreras writes: > >> >> All right, if there's no further feedback I'll push these tomorrow. >> > > Please do. It's one of the things I'm waiting for before a feature > free

[PATCH 00/21] vim: general updates

2013-11-11 Thread Felipe Contreras
On Sat, Nov 2, 2013 at 7:55 AM, Felipe Contreras wrote: > I've been cooking this in my personal notmuch-vim-ruby repository, and I think > they are ready for notmuch. > > A few highlights: > > * There's now support to compose new messages, previously there wa

Re: [PATCH 00/21] vim: general updates

2013-11-11 Thread Felipe Contreras
On Sat, Nov 2, 2013 at 7:55 AM, Felipe Contreras wrote: > I've been cooking this in my personal notmuch-vim-ruby repository, and I think > they are ready for notmuch. > > A few highlights: > > * There's now support to compose new messages, previously there wa

[PATCH 21/21] vim: add help file

2013-11-08 Thread Felipe Contreras
On Fri, Nov 8, 2013 at 12:03 PM, David Bremner wrote: > Felipe Contreras writes: >> >> You can probably check that it's working with this: >> % vim -c ":h notmuch" > > It turns I needed to re-run > >"vim-addon-manager install notmuch"

Re: [PATCH 21/21] vim: add help file

2013-11-08 Thread Felipe Contreras
On Fri, Nov 8, 2013 at 12:03 PM, David Bremner wrote: > Felipe Contreras writes: >> >> You can probably check that it's working with this: >> % vim -c ":h notmuch" > > It turns I needed to re-run > >"vim-addon-manager install notmuch"

[PATCH 21/21] vim: add help file

2013-11-08 Thread Felipe Contreras
On Fri, Nov 8, 2013 at 6:43 AM, David Bremner wrote: > Felipe Contreras writes: > >> Signed-off-by: Felipe Contreras >> --- >> debian/notmuch-vim.dirs| 1 + >> debian/notmuch-vim.install | 1 + >> vim/Makefile | 1 +

Re: [PATCH 21/21] vim: add help file

2013-11-08 Thread Felipe Contreras
On Fri, Nov 8, 2013 at 6:43 AM, David Bremner wrote: > Felipe Contreras writes: > >> Signed-off-by: Felipe Contreras >> --- >> debian/notmuch-vim.dirs| 1 + >> debian/notmuch-vim.install | 1 + >> vim/Makefile | 1 +

Getting the right root mail of the thread

2013-11-03 Thread Felipe Contreras
uire another call to the library and > regenerating the search results. Yes. I say it should be a property of the query. I don't see why anybody would want it any other way, but it wouldn't hurt to make it an option. -- Felipe Contreras

Getting the right root mail of the thread

2013-11-03 Thread Felipe Contreras
On Sun, Nov 3, 2013 at 1:22 PM, Daniel Kahn Gillmor wrote: > On 11/02/2013 09:08 AM, Felipe Contreras wrote: >> >> Either way this doesn't make any sense to me. Each thread has a single >> origin >> mail, why would anybody would like to show a message other t

Getting the right root mail of the thread

2013-11-03 Thread Felipe Contreras
On Sat, Nov 2, 2013 at 8:58 AM, Jani Nikula wrote: > On Sat, 02 Nov 2013, Felipe Contreras wrote: >> On Sat, Nov 2, 2013 at 7:50 AM, Jani Nikula wrote: >>> On Sat, 02 Nov 2013, Felipe Contreras wrote: >> >>>> I think there should be a way to get the root ma

Re: Getting the right root mail of the thread

2013-11-03 Thread Felipe Contreras
uire another call to the library and > regenerating the search results. Yes. I say it should be a property of the query. I don't see why anybody would want it any other way, but it wouldn't hurt to make it an option. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: Getting the right root mail of the thread

2013-11-03 Thread Felipe Contreras
On Sun, Nov 3, 2013 at 1:22 PM, Daniel Kahn Gillmor wrote: > On 11/02/2013 09:08 AM, Felipe Contreras wrote: >> >> Either way this doesn't make any sense to me. Each thread has a single >> origin >> mail, why would anybody would like to show a message other t

Re: Getting the right root mail of the thread

2013-11-03 Thread Felipe Contreras
On Sat, Nov 2, 2013 at 8:58 AM, Jani Nikula wrote: > On Sat, 02 Nov 2013, Felipe Contreras wrote: >> On Sat, Nov 2, 2013 at 7:50 AM, Jani Nikula wrote: >>> On Sat, 02 Nov 2013, Felipe Contreras wrote: >> >>>> I think there should be a way to get the root ma

Getting the right root mail of the thread

2013-11-02 Thread Felipe Contreras
On Sat, Nov 2, 2013 at 7:50 AM, Jani Nikula wrote: > On Sat, 02 Nov 2013, Felipe Contreras wrote: >> I think there should be a way to get the root mail of a thread, >> irrespective of the search order. > > Largely agreed. It's just that nobody's gotten around

[PATCH 21/21] vim: add help file

2013-11-02 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- debian/notmuch-vim.dirs| 1 + debian/notmuch-vim.install | 1 + vim/Makefile | 1 + vim/notmuch.txt| 153 + vim/notmuch.yaml | 1 + 5 files changed, 157 insertions

[PATCH 20/21] vim: check compose is done on delete

2013-11-02 Thread Felipe Contreras
Not on unload, which happens when we switch buffers. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 9109470..d7b310c 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -67,7

[PATCH 19/21] vim: remove unnecessary buffer queue

2013-11-02 Thread Felipe Contreras
Vim handles the buffers just fine: when one is deleted, we go to the previous one. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index fc9eaa2..9109470 100644 --- a/vim

[PATCH 18/21] vim: add wrapper for old variable names

2013-11-02 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 44 ++-- 1 file changed, 38 insertions(+), 6 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 71d4b32..fc9eaa2 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -391,23 +391,51

[PATCH 17/21] vim: move default sets to set_defaults()

2013-11-02 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 2fe9346..71d4b32 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -60,26 +60,6 @@ let

[PATCH 16/21] vim: rename public notmuch_rb variables

2013-11-02 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 4e4dfb0..2fe9346 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -60,24 +60,24 @@ let

[PATCH 15/21] vim: rename internal notmuch_rb variables

2013-11-02 Thread Felipe Contreras
Now we are the official one. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 59 ++--- 1 file changed, 27 insertions(+), 32 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 42c5f18..4e4dfb0 100644 --- a/vim/notmuch.vim

[PATCH 14/21] vim: add option to compose new messages

2013-11-02 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 33 + 1 file changed, 33 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 8383fd6..42c5f18 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -12,6 +12,7 @@ let g:notmuch_rb_folders_maps

[PATCH 13/21] vim: refactor open_reply()

2013-11-02 Thread Felipe Contreras
In preparation for composing new messages. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 92 ++--- 1 file changed, 49 insertions(+), 43 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 9a45300..8383fd6 100644 --- a

[PATCH 12/21] vim: trivial cleanup

2013-11-02 Thread Felipe Contreras
Using $email_address is more straight forward. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index cf829a6..9a45300 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -566,7 +566,7

[PATCH 11/21] vim: don't execute search if it's cancelled

2013-11-02 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 3 +++ 1 file changed, 3 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 64038eb..cf829a6 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -208,6 +208,9 @@ endfunction function! s:search_search_prompt() let

[PATCH 10/21] vim: generate custom message-id

2013-11-02 Thread Felipe Contreras
Using Mail as a reference. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 10 ++ 1 file changed, 10 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 4bd5f13..64038eb 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -421,6 +421,7 @@ ruby <&l

[PATCH 09/21] vim: split $email_address

2013-11-02 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index aa1b7ef..4bd5f13 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -427,7 +427,7 @@ ruby << EOF

[PATCH 08/21] vim: allow calling with arguments

2013-11-02 Thread Felipe Contreras
For example: :NotMuch date:today Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 9cfa795..aa1b7ef 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim

[PATCH 07/21] vim: add option to save the patches of a patch series

2013-11-02 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 15 +++ 1 file changed, 15 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index a1c5e28..9cfa795 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -34,6 +34,7 @@ let g:notmuch_rb_show_maps = { \ &#

[PATCH 06/21] vim: use much clearer sort constant

2013-11-02 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 11ea4fd..a1c5e28 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -302,7 +302,7 @@ ruby << EOF $messages

[PATCH 05/21] vim: show first message of the thread

2013-11-02 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 72bf73b..11ea4fd 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -557,6 +557,7 @@ ruby << EOF def search_

<    1   2   3   4   5   6   7   >