[PATCH v2] notmuch-emacs-mua: do not create a frame by default with --client

2015-04-06 Thread Tomi Ollila
On Sat, Apr 04 2015, Jani Nikula wrote: > Make the default behaviour for --client the same as emacsclient > default: do not create a new frame. Add a new option --create-frame, > passing the same option to emacsclient to create a frame. > > --- > > v2: fix killing frame with --create-frame > ---

[PATCH] nmbug-status: add support for specifying sort order for each view

2015-04-06 Thread Tomi Ollila
On Fri, Apr 03 2015, Jani Nikula wrote: > Let each view have "sort" key with possible values "oldest-first", > "newest-first", and "unsorted", and sort the results > accordingly. Oldest first remains the default. > --- lgtm. Tomi > devel/nmbug/nmbug-status | 10 +- > 1 file changed,

Re: [PATCH] nmbug-status: add support for specifying sort order for each view

2015-04-06 Thread Tomi Ollila
On Fri, Apr 03 2015, Jani Nikula j...@nikula.org wrote: Let each view have sort key with possible values oldest-first, newest-first, and unsorted, and sort the results accordingly. Oldest first remains the default. --- lgtm. Tomi devel/nmbug/nmbug-status | 10 +- 1 file changed,

Re: [PATCH v2] notmuch-emacs-mua: do not create a frame by default with --client

2015-04-06 Thread Tomi Ollila
On Sat, Apr 04 2015, Jani Nikula j...@nikula.org wrote: Make the default behaviour for --client the same as emacsclient default: do not create a new frame. Add a new option --create-frame, passing the same option to emacsclient to create a frame. --- v2: fix killing frame with

Re: [PATCH] nmbug-status: add support for specifying sort order for each view

2015-04-06 Thread Tomi Ollila
On Mon, Apr 06 2015, W. Trevor King wk...@tremily.us wrote: On Fri, Apr 03 2015, Jani Nikula j...@nikula.org wrote: Let each view have sort key with possible values oldest-first, newest-first, and unsorted, and sort the results accordingly. Oldest first remains the default. I like it, but

Re: notmuch doesn't work anymore

2015-03-31 Thread Tomi Ollila
On Mon, Mar 30 2015, Sepp Tannhuber sepp.tannhu...@yahoo.de wrote: I'm running notmuch from git://notmuchmail.org/git/notmuch. The current version fails with:     notmuch: symbol lookup error: notmuch: undefined symbol: notmuch_database_open_verbose Latest working is 83298fa. I always

[PATCH] notmuch-emacs-mua: non-forking escape () usage with backslash '\' escape

2015-03-29 Thread Tomi Ollila
Use the printf -v convention to give output variable as argument to escape () function so no subshell needs to be executed for escaping input. The '-v' option to escape () is just syntactic sugar for better understanding. Also, backslash is now escaped with another backslash for emacs. This ie

[PATCH] test/thread-order: more robust loop exit in case of broken input

2015-03-29 Thread Tomi Ollila
When creating $THREADS data it may end of not having 'None' at all or the numbers in line output yields a loop. To avoid loop the value in current array index is set to 'None' so that if the same item is reached again the loop will end. Also empty string as next array index will end the loop.

[PATCH] test/thread-order: more robust loop exit in case of broken input

2015-03-29 Thread Tomi Ollila
When creating $THREADS data it may end of not having 'None' at all or the numbers in line output yields a loop. To avoid loop the value in current array index is set to 'None' so that if the same item is reached again the loop will end. Also empty string as next array index will end the loop.

[Patch v6 4/8] lib: add "verbose" versions of notmuch_database_{open, create}

2015-03-28 Thread Tomi Ollila
On Sat, Mar 28 2015, David Bremner wrote: > The compatibility wrapper ensures that clients calling > notmuch_database_open will receive consistent output for now. > > The changes to notmuch-{new,search} and test/symbol-test are just to > make the test suite pass. > > The use of IGNORE_RESULT is

Re: [Patch v6 4/8] lib: add verbose versions of notmuch_database_{open, create}

2015-03-28 Thread Tomi Ollila
On Sat, Mar 28 2015, David Bremner da...@tethera.net wrote: The compatibility wrapper ensures that clients calling notmuch_database_open will receive consistent output for now. The changes to notmuch-{new,search} and test/symbol-test are just to make the test suite pass. The use of

"bouncing" messages

2015-03-25 Thread Tomi Ollila
On Tue, Apr 27 2010, Carl Worth wrote: > On Wed, 21 Apr 2010 19:54:20 -0300, Fernando Carrijo yahoo.com.br> wrote: >> micah anderson wrote: >> > It would be great if this became a key to make this easier. In mutt, >> > that key is 'b', which prompts you who you should send the message >> > to.

[PATCH] test/thread-order: continue loop while $parent is number

2015-03-25 Thread Tomi Ollila
Due to possible failure when creating $THREADS data there may be no 'None' text in the data. If having 'None' in the data is requirement for the loop to terminate the loop may continue forever. Inverting the test to check positive matches for numbers inhibits this particular problem. ---

[Patch v5 5/8] lib: add a log function with output to a string in notmuch_database_t

2015-03-25 Thread Tomi Ollila
On Tue, Mar 24 2015, David Bremner wrote: > In principle in the future this could do something fancier than sprintf. It would be better talking of sNprintf -- it is more accurate and potentially more educational. Rest of the patches in this series OK > --- > lib/database-private.h | 4

[Patch v5 4/8] lib: add "verbose" versions of notmuch_database_{open, create}

2015-03-25 Thread Tomi Ollila
On Tue, Mar 24 2015, David Bremner wrote: > The compatibility wrapper ensures that clients calling > notmuch_database_open will receive consistent output for now. > > The changes to notmuch-{new,search} and test/symbol-test are just to > make the test suite pass. > > The use of IGNORE_RESULT is

[Patch v5 3/8] test: add error reporting tests

2015-03-25 Thread Tomi Ollila
On Tue, Mar 24 2015, David Bremner wrote: > This includes tests for all of the error fprintfs in the library I > could figure out how to test without using gdb scripts. It boils down > to errors opening files and exceptions caused by corrupted Xapian > databases. > --- > test/T560-lib-error.sh

[Patch v5 2/8] test: add support for compiling and running C snippets

2015-03-25 Thread Tomi Ollila
On Tue, Mar 24 2015, David Bremner wrote: > This is to limit the copy-pasta involved in running C tests. I decided > to keep things simple and not try to provide an actual C skeleton. > > The setting of LD_LIBRARY_PATH is to force using the built libnotmuch > rather than any potential system

Can't compose message in Emacs - Notmuch

2015-03-25 Thread Tomi Ollila
On Wed, Mar 25 2015, Glyn Millington wrote: > David Bremner writes: > >> Glyn Millington writes: >> >>> Greetings! >>> >>> Emacs 24.4.1 (Arch Linux if that helps) >>> Notmuch 0.19 >>> >>> The problem is that I can neither compose a new email nor reply to an old >>> email unless I have already

emacs / vim - time taken to open threads

2015-03-25 Thread Tomi Ollila
On Wed, Mar 25 2015, David Bremner wrote: > Matthew Lear writes: > >> >> Despite being a vi guy for years, I prefer the emacs interface to >> notmuch and really like what it provides. I'm sticking with it but there >> is clearly a problem and I'd like to solve it. It's annoying when you >> know

Re: emacs / vim - time taken to open threads

2015-03-25 Thread Tomi Ollila
On Wed, Mar 25 2015, David Bremner da...@tethera.net wrote: Matthew Lear m...@bubblegen.co.uk writes: Despite being a vi guy for years, I prefer the emacs interface to notmuch and really like what it provides. I'm sticking with it but there is clearly a problem and I'd like to solve it.

Re: Can't compose message in Emacs - Notmuch

2015-03-25 Thread Tomi Ollila
On Wed, Mar 25 2015, Glyn Millington glyn.milling...@gmail.com wrote: David Bremner da...@tethera.net writes: Glyn Millington glyn.milling...@gmail.com writes: Greetings! Emacs 24.4.1 (Arch Linux if that helps) Notmuch 0.19 The problem is that I can neither compose a new email nor reply

Re: [Patch v5 2/8] test: add support for compiling and running C snippets

2015-03-25 Thread Tomi Ollila
On Tue, Mar 24 2015, David Bremner da...@tethera.net wrote: This is to limit the copy-pasta involved in running C tests. I decided to keep things simple and not try to provide an actual C skeleton. The setting of LD_LIBRARY_PATH is to force using the built libnotmuch rather than any

Re: [Patch v5 4/8] lib: add verbose versions of notmuch_database_{open, create}

2015-03-25 Thread Tomi Ollila
On Tue, Mar 24 2015, David Bremner da...@tethera.net wrote: The compatibility wrapper ensures that clients calling notmuch_database_open will receive consistent output for now. The changes to notmuch-{new,search} and test/symbol-test are just to make the test suite pass. The use of

Re: [Patch v5 5/8] lib: add a log function with output to a string in notmuch_database_t

2015-03-25 Thread Tomi Ollila
On Tue, Mar 24 2015, David Bremner da...@tethera.net wrote: In principle in the future this could do something fancier than sprintf. It would be better talking of sNprintf -- it is more accurate and potentially more educational. Rest of the patches in this series OK ---

Re: [Patch v5 3/8] test: add error reporting tests

2015-03-25 Thread Tomi Ollila
On Tue, Mar 24 2015, David Bremner da...@tethera.net wrote: This includes tests for all of the error fprintfs in the library I could figure out how to test without using gdb scripts. It boils down to errors opening files and exceptions caused by corrupted Xapian databases. ---

[PATCH] test/thread-order: continue loop while $parent is number

2015-03-25 Thread Tomi Ollila
Due to possible failure when creating $THREADS data there may be no 'None' text in the data. If having 'None' in the data is requirement for the loop to terminate the loop may continue forever. Inverting the test to check positive matches for numbers inhibits this particular problem. ---

Re: bouncing messages

2015-03-25 Thread Tomi Ollila
On Tue, Apr 27 2010, Carl Worth cwo...@cworth.org wrote: On Wed, 21 Apr 2010 19:54:20 -0300, Fernando Carrijo fcarr...@yahoo.com.br wrote: micah anderson mi...@riseup.net wrote: It would be great if this became a key to make this easier. In mutt, that key is 'b', which prompts you who you

[BUG] notmuch crashes on FreeBSD when synchronize_flags=true

2015-03-24 Thread Tomi Ollila
FYI (VirtualBox FreeBSD_10.1-64bit.7z from http://www.osboxes.org/freebsd/) root at osboxes:~/mail # rm -rf .notmuch/ root at osboxes:~/mail # notmuch new Found 1 total files (that's not much mail). Warning: /root/mail/new/new.mail is an mbox containing a single message, likely caused

[BUG] notmuch crashes on FreeBSD when synchronize_flags=true

2015-03-23 Thread Tomi Ollila
On Sat, Mar 21 2015, Simon Campese wrote: > Hello, > > I'm trying to setup notmuch on my FreeBSD machine (version 10.1). As > soon as I run 'notmuch new' (without an existing .notmuch directory), > notmuch crashes with the error message 'abort (core dumped) notmuch > new'. An example output

[DRAFT PATCH] emacs: show local date next to Date: in case value differs

2015-03-23 Thread Tomi Ollila
From: Tomi Ollila <t...@iki.fi> When adding Date: header of a message to notmuch-show buffer, compare the date string with local representation of it and if these differ, output Date: {original-date-string} ({local-date-representation}) This is useful e.g. when mail system provide

[PATCH v4] nmbug-status: Use 'show-ref --heads' for loading configs

2015-03-23 Thread Tomi Ollila
On Mon, Mar 23 2015, "W. Trevor King" wrote: > When loading configs from Git, the bare branch name (without a > refs/heads/ prefix or similar) matches all branches of that name > (including remote-tracking branches): > > .nmbug $ git show-ref config > 48f3bbf1d1492e5f3d2f01de6ea79a30d3840f20

Re: [BUG] notmuch crashes on FreeBSD when synchronize_flags=true

2015-03-23 Thread Tomi Ollila
On Sat, Mar 21 2015, Simon Campese notmuchmail_...@campese.de wrote: Hello, I'm trying to setup notmuch on my FreeBSD machine (version 10.1). As soon as I run 'notmuch new' (without an existing .notmuch directory), notmuch crashes with the error message 'abort (core dumped) notmuch new'.

Re: [PATCH v4] nmbug-status: Use 'show-ref --heads' for loading configs

2015-03-23 Thread Tomi Ollila
On Mon, Mar 23 2015, W. Trevor King wk...@tremily.us wrote: When loading configs from Git, the bare branch name (without a refs/heads/ prefix or similar) matches all branches of that name (including remote-tracking branches): .nmbug $ git show-ref config

[DRAFT PATCH] emacs: show local date next to Date: in case value differs

2015-03-23 Thread Tomi Ollila
From: Tomi Ollila t...@iki.fi When adding Date: header of a message to notmuch-show buffer, compare the date string with local representation of it and if these differ, output Date: {original-date-string} ({local-date-representation}) This is useful e.g. when mail system provides Date: strings

[PATCH] notmuch-emacs-mua: do not create a frame by default with --client

2015-03-22 Thread Tomi Ollila
On Sun, Mar 22 2015, Jani Nikula wrote: > Make the default behaviour for --client the same as emacsclient > default: do not create a new frame. Add a new option --create-frame, > passing the same option to emacsclient to create a frame. > > --- Changes LGTM. Tomi > > With this,

Re: [PATCH] notmuch-emacs-mua: do not create a frame by default with --client

2015-03-22 Thread Tomi Ollila
On Sun, Mar 22 2015, Jani Nikula j...@nikula.org wrote: Make the default behaviour for --client the same as emacsclient default: do not create a new frame. Add a new option --create-frame, passing the same option to emacsclient to create a frame. --- Changes LGTM. Tomi With this,

[PATCH v2] emacs: prefer notmuch-emacs-version in User-Agent: header

2015-03-21 Thread Tomi Ollila
Now that we have `notmuch-emacs-version' defined in notmuch emacs MUA use that as a part of User-Agent: header to provide more accurate version information when sending emails. In case some incomplete installation of notmuch emacs MUA is used and `notmuch-emacs-version' is defined as "unknown"

[Patch v4 4/9] lib: add "verbose" versions of notmuch_database_{open, create}

2015-03-21 Thread Tomi Ollila
On Sat, Mar 14 2015, David Bremner wrote: > The compatibility wrapper ensures that clients calling > notmuch_database_open will receive consistent output for now. > > The stdargs based infrastucture will be used in following commits for infrastructure :D > a more general logging mechanism. > >

[Patch v4 2/9] test: add support for compiling and running C snippets

2015-03-21 Thread Tomi Ollila
On Sat, Mar 14 2015, David Bremner wrote: > This is to limit the copy-pasta involved in running C tests. I decided Wat kind of spaghetti have you been eating... ;D > to keep things simple and not try to provide an actual C skeleton. > > The setting of LD_LIBRARY_PATH is to force using the

[PATCH v2] nmbug-status: Use 'show-ref --heads' for loading configs

2015-03-21 Thread Tomi Ollila
On Sun, Mar 15 2015, "W. Trevor King" wrote: > When loading configs from Git, the bare branch name (without a > refs/heads/ prefix or similar) matches all branches of that name > (including remote-tracking branches): > > .nmbug $ git show-ref config > 48f3bbf1d1492e5f3d2f01de6ea79a30d3840f20

Re: [Patch v4 2/9] test: add support for compiling and running C snippets

2015-03-21 Thread Tomi Ollila
On Sat, Mar 14 2015, David Bremner da...@tethera.net wrote: This is to limit the copy-pasta involved in running C tests. I decided Wat kind of spaghetti have you been eating... ;D to keep things simple and not try to provide an actual C skeleton. The setting of LD_LIBRARY_PATH is to force

Re: [PATCH v2] nmbug-status: Use 'show-ref --heads' for loading configs

2015-03-21 Thread Tomi Ollila
On Sun, Mar 15 2015, W. Trevor King wk...@tremily.us wrote: When loading configs from Git, the bare branch name (without a refs/heads/ prefix or similar) matches all branches of that name (including remote-tracking branches): .nmbug $ git show-ref config

Re: [Patch v4 4/9] lib: add verbose versions of notmuch_database_{open, create}

2015-03-21 Thread Tomi Ollila
On Sat, Mar 14 2015, David Bremner da...@tethera.net wrote: The compatibility wrapper ensures that clients calling notmuch_database_open will receive consistent output for now. The stdargs based infrastucture will be used in following commits for infrastructure :D a more general logging

[PATCH 2/2] cli: add support for notmuch command --help

2015-03-10 Thread Tomi Ollila
On Mon, Mar 09 2015, David Bremner wrote: > Jani Nikula writes: > >> -if (print_help) { >> +/* Handle notmuch --help [command] and notmuch command --help. */ >> +if (print_help || >> +(opt_index + 1 < argc && strcmp (argv[opt_index + 1], "--help") == 0)) { > > I like the

[PATCH 1/2] cli: fix top level --help combined with other options

2015-03-10 Thread Tomi Ollila
On Mon, Mar 09 2015, David Bremner wrote: > Jani Nikula writes: > >> -ret = notmuch_help_command (NULL, argc - 1, [1]); >> +/* >> + * Pass the first positional argument as argv[1] so the help >> + * command can give help for it. The help command ignores the >> + * argv[0]

Re: [PATCH 1/2] cli: fix top level --help combined with other options

2015-03-10 Thread Tomi Ollila
On Mon, Mar 09 2015, David Bremner da...@tethera.net wrote: Jani Nikula j...@nikula.org writes: -ret = notmuch_help_command (NULL, argc - 1, argv[1]); +/* + * Pass the first positional argument as argv[1] so the help + * command can give help for it. The help command ignores

Re: [PATCH 2/2] cli: add support for notmuch command --help

2015-03-10 Thread Tomi Ollila
On Mon, Mar 09 2015, David Bremner da...@tethera.net wrote: Jani Nikula j...@nikula.org writes: -if (print_help) { +/* Handle notmuch --help [command] and notmuch command --help. */ +if (print_help || +(opt_index + 1 argc strcmp (argv[opt_index + 1], --help) == 0)) { I

[PATCH 1/2] notmuch-emacs-mua: remove -C to keep short options compatible with mutt

2015-03-07 Thread Tomi Ollila
On Sat, Mar 07 2015, Jani Nikula wrote: > Notmuch uses long options exclusively all around. The short options in > notmuch-emacs-mua are intentionally just a compatible subset of > mutt(1). Keep it this way, if only to make documenting the fact easy! > > The Notmuch style --client long option

[PATCH] python: replace hardcoding of SONAME version

2015-03-07 Thread Tomi Ollila
On Sat, Mar 07 2015, David Bremner wrote: > Failing to update this string in globals.py causes failures when the > SONAME changes. In order to hopefully reduce the number of such > errors, automate the process of setting the SONAME in the python > bindings. Looks sensible me -- anyone knowing

[PATCH] notmuch-emacs-mua: more options, some fixes

2015-03-07 Thread Tomi Ollila
and line # @@ -18,25 +19,47 @@ # along with this program. If not, see http://www.gnu.org/licenses/ . # # Authors: Jani Nikula +# Tomi Ollila # set -eu +# escape: "expand" '\' to '\\' & '"' to '\"' +# Calling convention: escape -v var "$arg" (like in

Re: [PATCH 1/2] notmuch-emacs-mua: remove -C to keep short options compatible with mutt

2015-03-07 Thread Tomi Ollila
On Sat, Mar 07 2015, Jani Nikula j...@nikula.org wrote: Notmuch uses long options exclusively all around. The short options in notmuch-emacs-mua are intentionally just a compatible subset of mutt(1). Keep it this way, if only to make documenting the fact easy! The Notmuch style --client long

Re: [PATCH] python: replace hardcoding of SONAME version

2015-03-07 Thread Tomi Ollila
On Sat, Mar 07 2015, David Bremner da...@tethera.net wrote: Failing to update this string in globals.py causes failures when the SONAME changes. In order to hopefully reduce the number of such errors, automate the process of setting the SONAME in the python bindings. Looks sensible me --

[PATCH v2] lib: make notmuch shared library install_name be full path on Mac OS X

2015-03-05 Thread Tomi Ollila
On Thu, Mar 05 2015, "J. Lewis Muir" wrote: > The install_name of libnotmuch.dylib on Mac OS X is what is written > into a program that links against it. If it is just the name of the > shared library file, as opposed to the full path, the program won't be > able to find it when it runs and

Re: [PATCH v2] lib: make notmuch shared library install_name be full path on Mac OS X

2015-03-04 Thread Tomi Ollila
On Thu, Mar 05 2015, J. Lewis Muir jlm...@imca-cat.org wrote: The install_name of libnotmuch.dylib on Mac OS X is what is written into a program that links against it. If it is just the name of the shared library file, as opposed to the full path, the program won't be able to find it when it

[PATCH] go: add binding for notmuch_message_get_date

2015-03-03 Thread Tomi Ollila
On Mon, Mar 02 2015, Trevor Jim wrote: > --- > bindings/go/src/notmuch/notmuch.go | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/bindings/go/src/notmuch/notmuch.go > b/bindings/go/src/notmuch/notmuch.go > index b9230ad..f5fd54c 100644 > ---

Re: [PATCH] go: add binding for notmuch_message_get_date

2015-03-03 Thread Tomi Ollila
On Mon, Mar 02 2015, Trevor Jim t...@mac.com wrote: --- bindings/go/src/notmuch/notmuch.go | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/bindings/go/src/notmuch/notmuch.go b/bindings/go/src/notmuch/notmuch.go index b9230ad..f5fd54c 100644 ---

[PATCH 4/4] parse-time-string: fix setting and rounding of seconds

2015-03-02 Thread Tomi Ollila
On Mon, Mar 02 2015, Jani Nikula wrote: > If seconds are not specified in the string to be parsed, they're not > set according to the reference time (in the no rounding case) nor > rounded properly (in the rounding up cases). Fix this. > > The bug caused searches such as date:10:30..10:30 to

Re: [PATCH 4/4] parse-time-string: fix setting and rounding of seconds

2015-03-02 Thread Tomi Ollila
On Mon, Mar 02 2015, Jani Nikula j...@nikula.org wrote: If seconds are not specified in the string to be parsed, they're not set according to the reference time (in the no rounding case) nor rounded properly (in the rounding up cases). Fix this. The bug caused searches such as

[PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2015-02-26 Thread Tomi Ollila
On Thu, Feb 26 2015, "J. Lewis Muir" wrote: > On 2/25/15 1:34 AM, David Bremner wrote: >> Unfortunately we did not receive any feedback from Mac users in the >> meantime. It would be nice to know that your patch won't break the >> existing macports and brew packages. I suppose that those work

Re: [PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2015-02-26 Thread Tomi Ollila
On Thu, Feb 26 2015, J. Lewis Muir jlm...@imca-cat.org wrote: On 2/25/15 1:34 AM, David Bremner wrote: Unfortunately we did not receive any feedback from Mac users in the meantime. It would be nice to know that your patch won't break the existing macports and brew packages. I suppose that

[PATCH 5/5] completion: complete addresses in from:/to: search terms

2015-02-24 Thread Tomi Ollila
On Tue, Feb 24 2015, Jani Nikula wrote: > On Tue, 24 Feb 2015, Tomi Ollila wrote: >> On Tue, Jan 27 2015, Jani Nikula wrote: >> >>> Use the new notmuch address command to do completion for addresses in >>> from: and to:. >>> >>> --- >&

[PATCH 5/5] completion: complete addresses in from:/to: search terms

2015-02-24 Thread Tomi Ollila
On Tue, Jan 27 2015, Jani Nikula wrote: > Use the new notmuch address command to do completion for addresses in > from: and to:. > > --- > > This patch is more of an RFC. The to: completion is slw because > typically there are more matches to begin with, and then producing the > results

[PATCH 3/3] cli: fix clang build warnings

2015-02-23 Thread Tomi Ollila
On Mon, Feb 23 2015, Jani Nikula wrote: > Fix the following warning produced by clang 3.5.0: > > notmuch-search.c:730:25: warning: initializing 'void *' with an > expression of type 'const notmuch_opt_desc_t (*)[4]' discards > qualifiers [-Wincompatible-pointer-types-discards-qualifiers] >

Re: [PATCH 5/5] completion: complete addresses in from:/to: search terms

2015-02-23 Thread Tomi Ollila
On Tue, Jan 27 2015, Jani Nikula j...@nikula.org wrote: Use the new notmuch address command to do completion for addresses in from: and to:. --- This patch is more of an RFC. The to: completion is slw because typically there are more matches to begin with, and then producing the

bug report: Emacs notmuch-mode fails attachments with spaces

2015-02-20 Thread Tomi Ollila
On Wed, Feb 11 2015, Tomi Ollila wrote: > On Tue, Feb 10 2015, Nils Dagsson Moskopp > wrote: > >> Tomi Ollila writes: >> It seems to me that all of the following are true in this case: >> >> 1. Emacs executes the user's default shell to start zathura. > &g

Re: bug report: Emacs notmuch-mode fails attachments with spaces

2015-02-20 Thread Tomi Ollila
On Wed, Feb 11 2015, Tomi Ollila tomi.oll...@iki.fi wrote: On Tue, Feb 10 2015, Nils Dagsson Moskopp n...@dieweltistgarnichtso.net wrote: Tomi Ollila tomi.oll...@iki.fi writes: It seems to me that all of the following are true in this case: 1. Emacs executes the user's default shell

[PATCH] configure: consistent command -v usage

2015-02-18 Thread Tomi Ollila
When the shell builtin `command -v` operates normally, it either prints the path of the arg given to it and returns zero -- or it returns nonzero and prints nothing. In abnormal situations something might be printed to stderr and in that case we want to know about it; therefore the used command -v

[PATCH] configure: consistent command -v usage

2015-02-18 Thread Tomi Ollila
When the shell builtin `command -v` operates normally, it either prints the path of the arg given to it and returns zero -- or it returns nonzero and prints nothing. In abnormal situations something might be printed to stderr and in that case we want to know about it; therefore the used command -v

notmuch-mutt: support for messages that lack Message-ID headers (v3)

2015-02-15 Thread Tomi Ollila
d.html#20079 > > I've rewritten the patch taking into account the suggestions by Tomi > Ollila, who suggested a much cleaner approach for processing headers > and possibly fallback to synthetic Message-IDs (thanks Tomi!). > > I'll be happy to hear further comments on this patch series. >

Re: notmuch-mutt: support for messages that lack Message-ID headers (v3)

2015-02-15 Thread Tomi Ollila
#20079 I've rewritten the patch taking into account the suggestions by Tomi Ollila, who suggested a much cleaner approach for processing headers and possibly fallback to synthetic Message-IDs (thanks Tomi!). I'll be happy to hear further comments on this patch series. If there are none, please

bug report: Emacs notmuch-mode fails attachments with spaces

2015-02-11 Thread Tomi Ollila
On Tue, Feb 10 2015, Nils Dagsson Moskopp wrote: > Tomi Ollila writes: > >> On Mon, Feb 09 2015, Nils Dagsson Moskopp >> wrote: >> >>> Dear notmuch developers, >>> >>> >>> I use notmuch-mode for GNU Emacs for managing my email. >

Re: bug report: Emacs notmuch-mode fails attachments with spaces

2015-02-11 Thread Tomi Ollila
On Tue, Feb 10 2015, Nils Dagsson Moskopp n...@dieweltistgarnichtso.net wrote: Tomi Ollila tomi.oll...@iki.fi writes: On Mon, Feb 09 2015, Nils Dagsson Moskopp n...@dieweltistgarnichtso.net wrote: Dear notmuch developers, I use notmuch-mode for GNU Emacs for managing my email. I think

bug report: Emacs notmuch-mode fails attachments with spaces

2015-02-10 Thread Tomi Ollila
On Mon, Feb 09 2015, Nils Dagsson Moskopp wrote: > Dear notmuch developers, > > > I use notmuch-mode for GNU Emacs for managing my email. > > I think I have found a bug in notmuch-mode: If I do ?.-v? on the line ?[ > 2015 _ Richtlinien.pdf: application/pdf ]?, then notmuch will open three >

[PATCH 2/2] notmuch-mutt: support for messages that lack Message-ID headers

2015-02-09 Thread Tomi Ollila
On Mon, Feb 09 2015, Stefano Zacchiroli wrote: > From: "Jan N. Klug" > > For those messages, compute a synthetic Message-ID based on the SHA1 > of the whole message, in the same way that notmuch would do. See: > http://git.notmuchmail.org/git/notmuch/blob/HEAD:/lib/sha1.c > > To do the above,

Re: bug report: Emacs notmuch-mode fails attachments with spaces

2015-02-09 Thread Tomi Ollila
On Mon, Feb 09 2015, Nils Dagsson Moskopp n...@dieweltistgarnichtso.net wrote: Dear notmuch developers, I use notmuch-mode for GNU Emacs for managing my email. I think I have found a bug in notmuch-mode: If I do “.-v” on the line “[ 2015 _ Richtlinien.pdf: application/pdf ]”, then notmuch

Re: [PATCH 2/2] notmuch-mutt: support for messages that lack Message-ID headers

2015-02-09 Thread Tomi Ollila
On Mon, Feb 09 2015, Stefano Zacchiroli z...@upsilon.cc wrote: From: Jan N. Klug jan.n.k...@rub.de For those messages, compute a synthetic Message-ID based on the SHA1 of the whole message, in the same way that notmuch would do. See:

[RFC PATCH] emacs: add notmuch-show-resend-message

2015-02-06 Thread Tomi Ollila
From: Tomi Ollila <tomi.oll...@iki.fi> Resend message to new recipients using #'message-resend. Recipients are read from minibuffer as a comma-separated string (with some keyboard support including tab completion) Final confirmation before sending is asked. The function is bound

[RFC PATCH] emacs: add notmuch-show-resend-message

2015-02-06 Thread Tomi Ollila
From: Tomi Ollila tomi.oll...@iki.fi Resend message to new recipients using #'message-resend. Recipients are read from minibuffer as a comma-separated string (with some keyboard support including tab completion) Final confirmation before sending is asked. The function is bound to 'b

[PATCH] emacs: Add a defcustom that specifies regexp for blocked remote images.

2015-02-02 Thread Tomi Ollila
On Mon, Feb 02 2015, Jinwoo Lee wrote: > It's default value is ".", meaning all remote images will be blocked > by default. > > --- > Addressed review comments. Ok, looks good to me. David can perhaps amend away the (accidental) whitespace change in the last hunk ? Tomi > --- >

Re: [PATCH] emacs: Add a defcustom that specifies regexp for blocked remote images.

2015-02-02 Thread Tomi Ollila
On Mon, Feb 02 2015, Jinwoo Lee jinwo...@gmail.com wrote: It's default value is ., meaning all remote images will be blocked by default. --- Addressed review comments. Ok, looks good to me. David can perhaps amend away the (accidental) whitespace change in the last hunk ? Tomi ---

[PATCH] emacs: Add a defcustom that specifies regexp for blocked remote images.

2015-02-01 Thread Tomi Ollila
On Sun, Feb 01 2015, Tomi Ollila wrote: > On Sun, Feb 01 2015, David Edmondson wrote: > >> On Thu, Jan 29 2015, Jinwoo Lee wrote: >>> It's default value is ".", meaning all remote images will be blocked >>> by default. >>> >>> --- >&g

[PATCH] emacs: Add a defcustom that specifies regexp for blocked remote images.

2015-02-01 Thread Tomi Ollila
On Sun, Feb 01 2015, David Edmondson wrote: > On Thu, Jan 29 2015, Jinwoo Lee wrote: >> It's default value is ".", meaning all remote images will be blocked >> by default. >> >> --- >> This time setting gnus-blocked-images from the correct place. > > Looks good - it is better than the code

[PATCH] emacs: Add a defcustom that specifies regexp for blocked remote images.

2015-02-01 Thread Tomi Ollila
On Thu, Jan 29 2015, Jinwoo Lee wrote: > It's default value is ".", meaning all remote images will be blocked > by default. > > --- > This time setting gnus-blocked-images from the correct place. > --- > emacs/notmuch-show.el | 23 ++- > 1 file changed, 18 insertions(+), 5

Re: [PATCH] emacs: Add a defcustom that specifies regexp for blocked remote images.

2015-02-01 Thread Tomi Ollila
On Thu, Jan 29 2015, Jinwoo Lee jinwo...@gmail.com wrote: It's default value is ., meaning all remote images will be blocked by default. --- This time setting gnus-blocked-images from the correct place. --- emacs/notmuch-show.el | 23 ++- 1 file changed, 18

Re: [PATCH] emacs: Add a defcustom that specifies regexp for blocked remote images.

2015-02-01 Thread Tomi Ollila
On Sun, Feb 01 2015, Tomi Ollila tomi.oll...@iki.fi wrote: On Sun, Feb 01 2015, David Edmondson d...@dme.org wrote: On Thu, Jan 29 2015, Jinwoo Lee wrote: It's default value is ., meaning all remote images will be blocked by default. --- This time setting gnus-blocked-images from

Re: [PATCH] emacs: Add a defcustom that specifies regexp for blocked remote images.

2015-02-01 Thread Tomi Ollila
On Sun, Feb 01 2015, David Edmondson d...@dme.org wrote: On Thu, Jan 29 2015, Jinwoo Lee wrote: It's default value is ., meaning all remote images will be blocked by default. --- This time setting gnus-blocked-images from the correct place. Looks good - it is better than the code

[PATCH] Add a defcustom for whether to block remote images by default.

2015-01-29 Thread Tomi Ollila
On Thu, Jan 29 2015, Jinwoo Lee wrote: > On Thu, Jan 29, 2015 at 12:58 AM, Tomi Ollila wrote: >> On Thu, Jan 29 2015, David Bremner wrote: >> >>> Jinwoo Lee writes: >>> >>>> + (shr-blocke

[PATCH] Add a defcustom for whether to block remote images by default.

2015-01-29 Thread Tomi Ollila
On Thu, Jan 29 2015, David Bremner wrote: > Jinwoo Lee writes: > >> +(shr-blocked-images (if notmuch-show-block-remote-images >> +"." >> + shr-blocked-images))) >> (shr-insert-document dom) >> t)) > > Ideally such a

Re: [PATCH] Add a defcustom for whether to block remote images by default.

2015-01-29 Thread Tomi Ollila
On Thu, Jan 29 2015, David Bremner da...@tethera.net wrote: Jinwoo Lee jinwo...@gmail.com writes: +(shr-blocked-images (if notmuch-show-block-remote-images +. + shr-blocked-images))) (shr-insert-document dom) t)) Ideally

Re: [PATCH] Add a defcustom for whether to block remote images by default.

2015-01-29 Thread Tomi Ollila
On Thu, Jan 29 2015, Jinwoo Lee jinwo...@gmail.com wrote: On Thu, Jan 29, 2015 at 12:58 AM, Tomi Ollila tomi.oll...@iki.fi wrote: On Thu, Jan 29 2015, David Bremner da...@tethera.net wrote: Jinwoo Lee jinwo...@gmail.com writes: + (shr-blocked-images (if notmuch-show-block-remote-images

[PATCH] doc: gzipped notmuch.3 before trying to install notmuch.3.gz

2015-01-25 Thread Tomi Ollila
On Sun, Jan 25 2015, David Bremner wrote: > If HAVE_SPHINX=0 but HAVE_DOXYGEN=1, then the previous version was > trying to install notmuch.3.gz but only got as far as creating > notmuch.3 > --- > > doc/Makefile.local is messy enough that I found Tomi's fix hard to > follow. Probably the real

Re: [PATCH] doc: gzipped notmuch.3 before trying to install notmuch.3.gz

2015-01-25 Thread Tomi Ollila
On Sun, Jan 25 2015, David Bremner da...@tethera.net wrote: If HAVE_SPHINX=0 but HAVE_DOXYGEN=1, then the previous version was trying to install notmuch.3.gz but only got as far as creating notmuch.3 --- doc/Makefile.local is messy enough that I found Tomi's fix hard to follow. Probably

[LATE NIGHT PATCH] build gzipped apidoc in case have doxygen but not sphinx

2015-01-22 Thread Tomi Ollila
In case we had doxygen but not sphinx notmuch.3 was created but notmuch.3.gz not -- which means install fails! This patch (with late night unpolished commit message will fix that) --- I'll do better one... hmm, next week (unless someone gets there first \o/) doc/Makefile.local | 11 ++-

privacy problem: text/html parts pull in network resources

2015-01-22 Thread Tomi Ollila
On Wed, Jan 21 2015, Daniel Kahn Gillmor wrote: > If i send a message with a text/html part (either it's only text/html, > or all parts are rendered, or it's multipart/alternative with only a > text/html subpart) and that HTML has src="http://example.org/test.png"/> in it, then notmuch will

[LATE NIGHT PATCH] build gzipped apidoc in case have doxygen but not sphinx

2015-01-22 Thread Tomi Ollila
In case we had doxygen but not sphinx notmuch.3 was created but notmuch.3.gz not -- which means install fails! This patch (with late night unpolished commit message will fix that) --- I'll do better one... hmm, next week (unless someone gets there first \o/) doc/Makefile.local | 11 ++-

Re: privacy problem: text/html parts pull in network resources

2015-01-21 Thread Tomi Ollila
On Wed, Jan 21 2015, Daniel Kahn Gillmor d...@fifthhorseman.net wrote: If i send a message with a text/html part (either it's only text/html, or all parts are rendered, or it's multipart/alternative with only a text/html subpart) and that HTML has img src=http://example.org/test.png/ in it,

Re: [DRAFT PATCH v2] modified notmuch-emacs-mua v2

2015-01-21 Thread Tomi Ollila
On Tue, Jan 20 2015, David Bremner da...@tethera.net wrote: Tomi Ollila tomi.oll...@iki.fi writes: This is second draft patch of (first being) id:1405026779-29966-1-git-send-email-tomi.oll...@iki.fi I saw potential problem with only supporting emacsclient(1) in the version David sent: id

[DRAFT PATCH v2] modified notmuch-emacs-mua v2

2015-01-20 Thread Tomi Ollila
://www.gnu.org/licenses/ . +# +# Authors: Jani Nikula +# Tomi Ollila +# + +set -eu + +# Cannot use [[ ]] until we know we have bash. +case ${BASH_VERSION-} in '') +echo "Not BASH!" >&2 +exit 1 +esac + +# escape: "expand" '\' to '\\' & '"' to '\&

[PATCH] lib: add new status reporting API for notmuch_query_search_{m, t}

2015-01-20 Thread Tomi Ollila
On Tue, Jan 20 2015, David Bremner wrote: > This at least allows distinguishing between out of memory and Xapian > exceptions. Adding finer grained status codes would allow different > Xapian exceptions to be preserved. > > Adding wrappers allows people to transition gradually to the new API, >

Re: [PATCH] lib: add new status reporting API for notmuch_query_search_{m, t}

2015-01-20 Thread Tomi Ollila
On Tue, Jan 20 2015, David Bremner da...@tethera.net wrote: This at least allows distinguishing between out of memory and Xapian exceptions. Adding finer grained status codes would allow different Xapian exceptions to be preserved. Adding wrappers allows people to transition gradually to the

<    7   8   9   10   11   12   13   14   15   16   >