Re: [PATCH v2 00/10] ruby: object cleanups

2021-05-11 Thread Tomi Ollila
On Tue, May 11 2021, Felipe Contreras wrote: > On Tue, May 4, 2021 at 3:25 AM Felipe Contreras > wrote: >> >> On Tue, May 4, 2021 at 3:17 AM Felipe Contreras >> wrote: >> > >> > This superseeds my previous series [1] with much more cleanups. >> > >> > An important new change is the move towards

Re: [PATCH 5/9] test: test relative paths for database.hook_dir

2021-05-07 Thread Tomi Ollila
On Fri, May 07 2021, David Bremner wrote: > --- > test/T400-hooks.sh | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/test/T400-hooks.sh b/test/T400-hooks.sh > index 3a2df2f4..00c99337 100755 > --- a/test/T400-hooks.sh > +++ b/test/T400-hooks.sh > @@ -43,7 +43,7 @@

[PATCH] test: say_color() in one write(2)

2021-05-06 Thread Tomi Ollila
say_color() used to call (builtin) printf (and tput(1) to stdout) several times, which caused attempts to write messages with color to have partial content (e.g. escape sequences) often intermixed with other tests when parallel tests were run. Now, with all output collected, then written out

Re: [PATCH 1/9] test: move test_ruby() inside the only client

2021-05-02 Thread Tomi Ollila
On Sun, May 02 2021, David Bremner wrote: > Felipe Contreras writes: > >> Not much point in polluting the main library, and also will be useful to >> modify it in tandem with the tests. >> > > I can live with this change. I'd say strong LGTM :D Tomi > > d >

[PATCH] test: replace notmuch_passwd_sanitize() with _libconfig_sanitize()

2021-05-02 Thread Tomi Ollila
notmuch_passwd_sanitize() in test-lib.sh is too generic, it cannot work in many cases... The more specific version _libconfig_sanitize() replaces it in T590-libconfig.sh and the code that uses it is modified to output the keys (ascending numbers printed in hex) so the sanitizer knows what to

Re: [PATCH 00/13] test: several fixes and improvements

2021-05-01 Thread Tomi Ollila
On Sat, May 01 2021, David Bremner wrote: > Felipe Contreras writes: > >> The current tests fail on my machine due to my configuration, mainly because >> I didn't have dtach >> installed, but also other stuff. >> >> The following patches fix all the issues I found, and also do plenty of >>

Re: [PATCH 04/13] test: use correct fqdn in passwd_sanitize()

2021-05-01 Thread Tomi Ollila
On Sat, May 01 2021, Felipe Contreras wrote: > My fqdn is 'natae.localdomain', however, socket.getfqdn() returns > 'localhost'. > > To fetch the true fqdn we need socket.getaddrinfo(). > > For more information see: https://stackoverflow.com/a/11580042/10474 > > Signed-off-by: Felipe Contreras >

Re: [PATCH 03/13] test: remove USER_FULL_NAME when not present

2021-05-01 Thread Tomi Ollila
On Sat, May 01 2021, Felipe Contreras wrote: > If a full name is not configured, the output is empty. > This is possibly not portable, but it's a start. > > Signed-off-by: Felipe Contreras > --- > test/T590-libconfig.sh | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: [PATCH 02/13] test: unset NAME environment variable

2021-05-01 Thread Tomi Ollila
On Sat, May 01 2021, Felipe Contreras wrote: > Otherwise the output from the tests would be different. > > Signed-off-by: Felipe Contreras > --- > test/test-lib.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/test/test-lib.sh b/test/test-lib.sh > index e13797a7..ae653363 100644 >

Re: [PATCH 01/13] test: fix passwd_sanitize()

2021-05-01 Thread Tomi Ollila
On Sat, May 01 2021, Felipe Contreras wrote: > If any of the variables is empty the output is completely messed up, > because replace("", "FOO") puts "FOO" before every single character. > > I don't have my full name configured, and this is what I get: > >

Re: [PATCH] perf-test: add option to run perf

2021-04-25 Thread Tomi Ollila
On Sun, Apr 25 2021, David Bremner wrote: > Although the generation of perf data is not as slow as valgrind, it > seems simplest to re-use the machinery already there to save the logs > in a timestamped subdirectory. > --- > > I'm not sure about the use of --call-graph=lbr here. On the one hand,

Re: [PATCH] ruby: fix ruby 3.1 warnings

2021-04-19 Thread Tomi Ollila
On Mon, Apr 19 2021, David Bremner wrote: > Felipe Contreras writes: > >> Hello. >> >> On Sat, Apr 17, 2021 at 7:20 AM David Bremner wrote: >> >>> Thanks for the patch. I have a couple of questions / comments >>> >>> - It doesn't apply against current master (5248f55d5f1). Can you rebase >>>

Re: [PATCH] compat: expose canonicalize_file_name to C++

2021-04-18 Thread Tomi Ollila
On Sun, Apr 18 2021, Tomi Ollila wrote: > > not perl, but python3 -c 'import socket; print(socket.getfqdn())' notmuch_passwd_sanitize() { python3 -c ' import os, sys, pwd, socket pw = pwd.getpwuid(os.getuid()) user = pw.pw_name name = pw.pw_gecos.partition(",")[0] fqdn

Re: [PATCH] compat: expose canonicalize_file_name to C++

2021-04-18 Thread Tomi Ollila
On Sun, Apr 18 2021, David Bremner wrote: > Đoàn Trần Công Danh writes: > >> >> Anyway, I see some failure in the testsuite due to: >> - *My* hostname(1) (from coreutils) doesn't understand "-f" Interesting (neither of these use coreutils hostname) $ rpm -q -f =hostname

Re: v1 deletion patches

2021-04-18 Thread Tomi Ollila
On Fri, Apr 16 2021, David Bremner wrote: > This version has a better commit message for 2/2 and portability fixes > (thanks to Tomi) for 1/2. Looks safe enough to be pushed in. Tomi > > It obsoletes the WIP version [1] > > [1]: id:20210414021627.1236560-1-da...@tethera.net

Re: [PATCH] compat: expose canonicalize_file_name to C++

2021-04-18 Thread Tomi Ollila
On Sun, Apr 18 2021, Đoàn Trần Công Danh wrote: > On 2021-04-17 11:39:59-0300, David Bremner wrote: >> Đoàn Trần Công Danh writes: >> >> > >> > However, I see that lib/open.cc uses g_key_file_get_value from GLib >> > already, we may switch to g_canonicalize_file_name then? >> > >> >> Yes that

Re: [PATCH 1/2] WIP: add performance test for removing files.

2021-04-15 Thread Tomi Ollila
On Tue, Apr 13 2021, David Bremner wrote: > No doubt this is non-portable use of tar. portable alternative(s) (?) (we probably can trust no file names start with '-') > --- > performance-test/T00-new.sh | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: Query emails sent to undisclosed-recipients

2021-03-23 Thread Tomi Ollila
On Tue, Mar 23 2021, David Bremner wrote: > Tomi Ollila writes: > >> On Tue, Mar 23 2021, Firmin Martin wrote: >> >>> Hi, >>> >>> I have emails whose the "To" field is undisclosed recipients. In JSON: >>> >>> ```

Re: Query emails sent to undisclosed-recipients

2021-03-23 Thread Tomi Ollila
On Tue, Mar 23 2021, Firmin Martin wrote: > Hi, > > I have emails whose the "To" field is undisclosed recipients. In JSON: > > ``` > "To": "undisclosed-recipients: ;" > ``` > > I would want to tag such email as spam, but I can't query them > using > > ``` > notmuch show --format=json

Re: [PATCH] test: add known broken test for long directory bug

2021-03-18 Thread Tomi Ollila
On Wed, Mar 17 2021, David Bremner wrote: > In [1] Gregor Zattler explained the results of his hard working > tracking down a bug in notmuch with long directories. This test > duplicates the bug. > > [1]: id:20210317194728.GB5561@no.workgroup > --- > test/T050-new.sh | 14 ++ > 1

Re: [PATCH] devel/uncrustify: add line length limits.

2021-03-08 Thread Tomi Ollila
On Sun, Mar 07 2021, David Bremner wrote: > A generous limit of 102 is chosen to moderate the amount of resulting > reformatting. LGTM Tomi > --- > devel/uncrustify.cfg | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/devel/uncrustify.cfg b/devel/uncrustify.cfg > index

Re: List archive

2021-03-01 Thread Tomi Ollila
On Sun, Feb 28 2021, David Bremner wrote: > I have restarted the generation of a list archive at > > https://nmbug.notmuchmail.org/archive/notmuch-list.tar.xz > > As you can tell from the name, it's not an mbox anymore, but an archive > of a Maildir. > > I have updated the links I found in the

Re: parallel test failures

2021-02-27 Thread Tomi Ollila
On Fri, Feb 26 2021, David Bremner wrote: > David Bremner writes: > >> >> Thanks to both of you for your feedback / suggestions. I did read today >> that timeout exits with 124 when the time limit is reached. I haven't >> investigated further (nor do I know how the timelimit should be reached,

Re: [PATCH] emacs: notmuch-tree: mark the initial message at point as read

2021-02-25 Thread Tomi Ollila
On Tue, Feb 16 2021, Jonas Bernoulli wrote: > When moving between message in a tree or show buffer, the message at > point is marked as read. Likewise when creating such a buffer, then > the message that is initially at point is supposed to be marked as > read as well. > > The latter worked for

Re: parallel test failures

2021-02-25 Thread Tomi Ollila
On Fri, Feb 19 2021, David Bremner wrote: > I have intermittent failures when running the test suite on sufficiently > parallel machines. I have attached a log of such a failing build, > although it does not seem especially illuminating. > > It takes anywhere from 5 to 300 runs to get a failure

[RFC PATCH] python-cffi out-of-tree build

2021-02-17 Thread Tomi Ollila
setup.py and _build.py to refer some other files based on directory where setup.py is located (os.path.dirname(sys.argv[0]). Dropped bindings/python-cffi/version.txt and refer ../../version.txt instead -- _build.py already refers ../../lib so why have version.txt twice (with identical content).

Re: [PATCH] test: Fix race condition in T568-lib-thread.sh

2021-02-15 Thread Tomi Ollila
On Sun, Feb 14 2021, David Bremner wrote: > The assignment of thread-ids is (apparently) non-deterministic in a > way that mostly seems to show up on multicore machines. In my tests > the number is different from that previously assumed by this test > about 15% of the time on a 50 thread (25

Re: [PATCH 2/2] lib: use a stricter unused macro

2021-02-15 Thread Tomi Ollila
On Sun, Feb 14 2021, David Bremner wrote: > This would have caught bugs like the one corrected in the previous > commit. Series LGTM. Tomi > --- > lib/notmuch-private.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h >

Re: [PATCH] python: convert shebangs to python3

2021-02-13 Thread Tomi Ollila
On Fri, Feb 12 2021, Daniel Kahn Gillmor wrote: > This is the last bit of "python" left in the notmuch codebase. > > https://www.python.org/dev/peps/pep-0394/#recommendation encourages > "third-party distributors" to use more-specific shebang lines. I'm > not certain that the notmuch project

Re: [PATCH] fix FTBFS with glib

2021-02-12 Thread Tomi Ollila
On Thu, Feb 11 2021, Michael J. Gruber wrote: > With newer glib, notmuch FTBFS because of C linkage error. This is due If/when the alternative change is send (if it works), then it would be nice if this FTBFS were opened (i searched it but deliberately leave it still a mystery for some of us ;)

Re: [PATCH] emacs: When completing tags, offer each tag once

2021-02-02 Thread Tomi Ollila
On Tue, Feb 02 2021, David Bremner wrote: > > Maybe delete-dups (subr.el) would be useful here? It is destructive, but > even with a copy (if needed), it should still be faster. I looked the implementation of delete-dups. In case of >100 elements, it uses hash table for checking duplicates. less

Re: [PATCH] emacs: When completing tags, offer each tag once

2021-02-02 Thread Tomi Ollila
On Mon, Feb 01 2021, David Edmondson wrote: > On Monday, 2021-02-01 at 11:49:36 -04, David Bremner wrote: > >> David Edmondson writes: >>> >>> +(defun notmuch-search-uniq-tags (tags) >>> + (let (result) >>> +(mapc (lambda (tag) >>> + (unless (member tag result) >>> + (push

Re: [PATCH] notmuch-show: use correct format specifier for ssize_t

2021-02-02 Thread Tomi Ollila
On Mon, Feb 01 2021, David Bremner wrote: > Đoàn Trần Công Danh writes: > >> Signed-off-by: Đoàn Trần Công Danh >> --- >> >> I found this after inspecting one of my build today. >> I'm not sure what is acceptable action. >> I think using %zd is the right move. >> But I'm not sure if you

Re: [PATCH 37/38] CLI: use configured hook directory

2021-01-24 Thread Tomi Ollila
On Sat, Jan 16 2021, David Bremner wrote: > This enables support for hooks outside the database directory. > It relies strongly on configuration information being usable between > closing the database and destroying it. > --- > hooks.c| 7 +- > notmuch-client.h | 2 +- >

Re: [PATCH 04/38] lib/open: add support for config profiles and default locations

2021-01-24 Thread Tomi Ollila
On Sat, Jan 16 2021, David Bremner wrote: In id:20210116170406.842014-4-da...@tethera.net there is missing space after , gchar **groups,**keys, *val; Here, perhaps s/This commits fills in/Fill in/ (?) > This commit fills in the remainder of the documented functionality for >

Re: [PATCH 01/38] lib: add _notmuch_string_map_set

2021-01-24 Thread Tomi Ollila
On Sat, Jan 16 2021, David Bremner wrote: First, is this patch series safe to be applied and put into use ? :D I've looked this through once. So much stuff hard to figure out if there is something broken. Most of the comments here and other patches are about style (line break), but some

Re: [RFC PATCH] show: Add support for -format=raw -body=false

2021-01-18 Thread Tomi Ollila
On Mon, Jan 18 2021, David Edmondson wrote: > On Monday, 2021-01-18 at 14:28:02 -04, David Bremner wrote: > >> David Edmondson writes: >>> Now, it would be nice to be able to say something like... >>> >>> notmuch show --format=sexp --body=false \ >>> --headers=received-by,face,x-face \ >>>

Re: [PATCH] test: add (back) upgrade tests

2021-01-17 Thread Tomi Ollila
On Sun, Jan 17 2021, David Bremner wrote: > In ee897cab8b721 the upgrade tests from pre v3 databases were > removed. The reasons for that are still valid, but we should still > test the code paths that do the upgrade, and it is relatively > straightforward to do that for v3 to v3 upgrades. > ---

[PATCH 1/3] emacs: fix declare-function definitions with related line breaks

2021-01-16 Thread Tomi Ollila
- declare-function notmuch-unthreaded lacked file name - declare-function notmuch-search had differently named last arg - note: check-declare-directory did not complain about that - declare-function notmuch-search-show-thread without nil - some functions declared to be in different file than

Re: [PATCH 02/36] test/T391-python-cffi

2021-01-15 Thread Tomi Ollila
On Fri, Jan 15 2021, David Bremner wrote: > David Bremner writes: > >> David Bremner writes: >> >>> Make bindings test verbose. This helps in debugging. >>> --- >> >> Applied first two patches (#1 amended per Tomi's suggestion) to master >> > > Except I missed the extra space. Sigh. Noticed ;)

Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope

2021-01-13 Thread Tomi Ollila
On Wed, Jan 13 2021, David Bremner wrote: > Jonas Bernoulli writes: > >> This fixes a minor whitespace bug that Tomi notices in (1). >> >> This also adds for commits, two of them in response to a concern >> raised by Tomi, who didn't "see enough point for requiring subr-x >> just [for

Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope

2021-01-13 Thread Tomi Ollila
On Sun, Jan 10 2021, Jonas Bernoulli wrote: > This fixes a minor whitespace bug that Tomi notices in (1). > > This also adds for commits, two of them in response to a concern > raised by Tomi, who didn't "see enough point for requiring subr-x > just [for string-empty-p]", which I agree with: > >

Re: How to control quoting of original message when replying?

2021-01-12 Thread Tomi Ollila
On Tue, Jan 12 2021, di...@santanas.co.za wrote: > Greetings all :) > > I'm wondering, how to reply to a thread without quoting the older email? In case of using emacs MUA, press Ctrl-W immediately when entered to reply buffer :D > Ideally I would like to not include a quoted reply by default,

Re: [PATCH 0/4] emacs: avoid type errors due to nil as content-type

2021-01-12 Thread Tomi Ollila
On Tue, Jan 12 2021, Jonas Bernoulli wrote: > Tomi Ollila writes: >> Note that messages >> >> 20210110140112.25930-11-jo...@bernoul.li and >> 20210110140112.25930-12-jo...@bernoul.li >> >> have base64 -encoded content, with CRLF line endings >&

Re: [PATCH 0/4] emacs: avoid type errors due to nil as content-type

2021-01-11 Thread Tomi Ollila
On Sun, Jan 10 2021, Jonas Bernoulli wrote: > The fourth commit tries to address the issue raised in > id:87k0sxa6c3@fifthhorseman.net. > > The output of "notmuch show --format=sexp --format-version=4" > may contain `:content-type' entries with `nil' as the value, > when it fails to

Re: [PATCH 01/36] test/T750-gzip: don't compress the xapian database

2021-01-11 Thread Tomi Ollila
On Sun, Jan 10 2021, David Bremner wrote: > Tomi Ollila writes: > >> On Sun, Jan 03 2021, David Bremner wrote: >> >>> +find ${MAIL_DIR} -name .notmuch -prune -false -o -type f -exec gzip >>> --recursive {} \; >> >> (some extra spaces above) &

Re: [PATCH 02/36] test/T391-python-cffi

2021-01-10 Thread Tomi Ollila
On Sun, Jan 03 2021, David Bremner wrote: > Make bindings test verbose. This helps in debugging. > --- > test/T391-python-cffi.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/T391-python-cffi.sh b/test/T391-python-cffi.sh > index f961069b..d54bad27 100755 > ---

Re: [PATCH 01/36] test/T750-gzip: don't compress the xapian database

2021-01-10 Thread Tomi Ollila
On Sun, Jan 03 2021, David Bremner wrote: > This causes mysterious failures in trying to detect if a database > exists. > --- > test/T750-gzip.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/T750-gzip.sh b/test/T750-gzip.sh > index fac41d39..807086fd 100755 > ---

Re: [PATCH] emacs/notmuch-show: Work around errors where a part lacks a content-type

2021-01-03 Thread Tomi Ollila
On Sun, Jan 03 2021, Daniel Kahn Gillmor wrote: > This is an inadequate workaround to the concerns raised in > id:87wnwu8tzf@fifthhorseman.net -- when it is installed, a > particular kind of malformed message (in particular, one containing a > message/rfc822 part that is improperly

Re: Folder+tags

2021-01-03 Thread Tomi Ollila
On Sun, Jan 03 2021, in...@sindominio.net wrote: > On Sun Dec 27, 2020 at 10:09 PM CET, Tomi Ollila wrote: >> On Sun, Dec 27 2020, in...@sindominio.net wrote: >> > On Sun Dec 27, 2020 at 2:12 PM CET, Tomi Ollila wrote: >> >> On Sun, Dec 27 2020, in...@sindominio.net

Re: [PATCH 00/32] [emacs] Add outline headings and switch to lexical scope

2020-12-28 Thread Tomi Ollila
On Sun, Dec 27 2020, Tomi Ollila wrote: > On Mon, Dec 14 2020, Jonas Bernoulli wrote: > >> Hello, >> >> This patch serious changes a number of things, including boring >> cleanup, but the big changes are the following. The respective >> commits are

Re: Folder+tags

2020-12-27 Thread Tomi Ollila
On Sun, Dec 27 2020, in...@sindominio.net wrote: > On Sun Dec 27, 2020 at 2:12 PM CET, Tomi Ollila wrote: >> On Sun, Dec 27 2020, in...@sindominio.net wrote: >> >> There sure is notmuch-after-tag-hook (in emacs MUA), but -hooks don't >> take argument(s) so how does it k

Re: Folder+tags

2020-12-27 Thread Tomi Ollila
On Sun, Dec 27 2020, in...@sindominio.net wrote: > Ok, I've been thinking more about tag-folder synchronisation and reading > everything I could. However, I need some guidance. > > I think that maybe the cleanest way to go is to have an after-tag-hook > which, if the recently added tag

Re: [PATCH 00/32] [emacs] Add outline headings and switch to lexical scope

2020-12-27 Thread Tomi Ollila
On Mon, Dec 14 2020, Jonas Bernoulli wrote: > Hello, > > This patch serious changes a number of things, including boring > cleanup, but the big changes are the following. The respective > commits are also marked in the list below. See these commits > for longer descriptions. > > 1. Split all

[PATCH] nmbug: notmuch-report: set both background and foreground colors

2020-12-20 Thread Tomi Ollila
Whenever setting background color, set also corresponding foreground color. Don't expect default foreground color to be #000 (or something close); user may have changed it. --- I have set default background color #000 and default foreground color #ddd. Just used firefox style editor to add those

Re: [PATCH 3/6] lib: factor out prefix related code to its own file

2020-12-20 Thread Tomi Ollila
On Sun, Dec 20 2020, David Bremner wrote: > Reduce the size of database.cc, and limit the scope of prefix_table, > make sure it's accessed via a well-defined internal API. > --- > lib/Makefile.local | 4 +- > lib/database-private.h | 7 ++ > lib/database.cc| 203

Re: [PATCH] test/T360-symbol-hiding: use readelf in place of nm

2020-12-12 Thread Tomi Ollila
On Fri, Dec 11 2020, David Bremner wrote: > It turns out that using nm -P isn't as portable as hoped. In particular on > architectures using ELF v1 (e.g. ppc64), the desired symbols end up in > the data section instead of text. > > The test is currently only functional on ELF based architectures,

Re: [PATCH] build/docs: move docstring prereq to file targets

2020-12-10 Thread Tomi Ollila
On Wed, Dec 09 2020, David Bremner wrote: > Under a sufficiently high level of parallelism [1] there seems to be a > a race condition that allows sphinx-build to start running before the > docstrings are extracted. This change moves the docstring stamp from > the phony targets sphinx-html and

Re: question: how to change file extension generated by (notmuch-show-view-part)

2020-11-23 Thread Tomi Ollila
On Mon, Nov 23 2020, Wenlong Dai wrote: > I've been trying to use links2 to view html part of messages. > The problem I'm encountering is that, the part would be saved as > /tmp/xxx/xxx.shtml and > passed on to links2, and it seems links2 doesn't recognise the .shtml > extension. > > netsurf

Re: Problems with unicode characters under emacs and Xorg

2020-11-03 Thread Tomi Ollila
Emacs versions involved ? Tomi ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: Clashes between "version" files and C++ keyword

2020-10-28 Thread Tomi Ollila
On Wed, Oct 28 2020, Ralph Seichter wrote: > Building Notmuch on macOS is known to cause problems because the Notmuch > distribution archive contains two files named "version". These clash > with the keyword as defined in C++20 [1] and will likely > become obvious on other platforms as well once

Re: Dependencies should include "realpath"

2020-10-20 Thread Tomi Ollila
On Tue, Oct 20 2020, Ralph Seichter wrote: > * Tomi Ollila: > >>> rsti_dir = os.path.abspath('emacs') >> >> Good suggestion, anyway, the simplest change would be just: >> >> - printf "rsti_dir = '%s'\n" $(realpath emacs) >> + printf "

[PATCH] configure: replace $(realpath emacs) with $(cd emacs && pwd -P)

2020-10-20 Thread Tomi Ollila
For portability; the realpath command (e.g. from GNU coreutils) is not so common outside Linux systems. The "$(cd emacs && pwd -P)" replaces that realpath(1) execution suitably in this context (using just bash(1) builtins). --- Quotes ("") added for it to be better example for someone(tm) who

Re: Dependencies should include "realpath"

2020-10-19 Thread Tomi Ollila
On Sat, Oct 17 2020, Ralph Seichter wrote: > * David Bremner: > >> Do you have a suggested replacement? I guess some inline perl with "use >> Cwd 'realpath'" would probably work, although I haven't tested it. > > At a quick glance, that particular section of "configure" is run by > doc/conf.py to

Re: [PATCH] emacs docs: rstdoc.el: consistent single quote conversions

2020-10-13 Thread Tomi Ollila
On Fri, Oct 09 2020, David Bremner wrote: > Tomi Ollila writes: > >> With text-quoting-style 'grave keeps "'" and "`" quotes unaltered >> for further processing done by this code (regardless of locale...). >> The tools that read the reStructuredT

[PATCH] emacs docs: rstdoc.el: consistent single quote conversions

2020-10-09 Thread Tomi Ollila
With text-quoting-style 'grave keeps "'" and "`" quotes unaltered for further processing done by this code (regardless of locale...). The tools that read the reStructuredText markup generated can do their styling instead. Added temporary conversions of ' and ` to \001 and \002 so that 's and `s

ANNOUNCE: nottoomuch-addresses.sh 2.5

2020-10-03 Thread Tomi Ollila
ANNOUNCE: nottoomuch-addresses.sh 2.5 What is New in Version 2.5 (Sat 2020-10-03): Added reading of user-controlled file 'addresses.top' -- addresses to be matched first when searches done. Get it from https://github.com/domo141/nottoomuch/blob/master/nottoomuch-addresses.rst

Re: [PATCH] emacs: Remove notmuch-mua-message-send-hook

2020-09-13 Thread Tomi Ollila
On Sat, Sep 12 2020, Tim Quelch wrote: > Currently `message-send-hook` functions are being called twice: In > notmuch send common when `notmuch-mua-send-hook` functions are > run (which by default includes `notmuch-mua-message-send-hook`) and in > `message-send` itself. > > Because

Re: [PATCH] test: fix syntax errors in erroring calls to notmuch insert

2020-09-03 Thread Tomi Ollila
On Thu, Sep 03 2020, David Bremner wrote: > notmuch insert does not currently support passing a filename for the > input, so all of these tests have an extra error in addition to the > one being tested for. > > Currently this does not make a difference because the error being > tested for is

Re: [PATCH v2] emacs: Use pop-to-buffer-same-window rather than switch-to-buffer

2020-08-22 Thread Tomi Ollila
On Tue, Aug 11 2020, Sean Whitton wrote: > This means that notmuch commands obey display-buffer-alist so the user > can customize how buffers show up. > > It also permits the use of C-x 4 4, C-x 5 5 and C-x t t, available in > Emacs 28. For example, one can use C-x 4 4 M-x notmuch-jump-search

[PATCH] NEWS: notmuch-mutt: system(shell pipeline) replaced internally

2020-08-17 Thread Tomi Ollila
--- NEWS | 8 1 file changed, 8 insertions(+) diff --git a/NEWS b/NEWS index 4160e39c9c30..b25bfaa38254 100644 --- a/NEWS +++ b/NEWS @@ -6,6 +6,14 @@ Emacs The minimum supported major version of GNU Emacs is now 25.1. +Notmuch-Mutt + + +The shell pipeline executed by

Re: [PATCH 1/2] Emacs: Add a new function for balancing bidi control chars

2020-08-16 Thread Tomi Ollila
On Sat, Aug 15 2020, Teemu Likonen wrote: > The following Unicode's bidirectional control chars are modal so that > they push a new bidirectional rendering mode to a stack: > > U+202A LEFT-TO-RIGHT EMBEDDING > U+202B RIGHT-TO-LEFT EMBEDDING > U+202D LEFT-TO-RIGHT OVERRIDE > U+202E

Re: [PATCH] devel/release-checks.sh: use grep to find copyright year.

2020-08-16 Thread Tomi Ollila
On Sun, Aug 16 2020, David Bremner wrote: > This is quite fragile, but it works for now, unlike the python > version. > > In general it seems conf.py is not intended to be evaluated outside of > sphinx, as it assumes certain global names (in particular "tags") are > defined. > --- > > I am going

Re: New release for Emacs 27.1?

2020-08-11 Thread Tomi Ollila
On Wed, Aug 12 2020, Damien Cassou wrote: > Hi, > > Emacs 27.1 being officially out, is it the right moment to release > Notmuch? People will face problems otherwise because Notmuch got some > fixes for Emacs 27.1 recently. Release cycle for 0.31 could be shorter, just for that reason. There

[PATCH] configure: Check if emacs >= 25 (instead of >= 24) is available

2020-08-11 Thread Tomi Ollila
"The minimum supported major version of GNU Emacs is now 25.1." 25.1 is the first "released" version of Emacs 25. --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index a357eb91..40e8b255 100755 --- a/configure +++ b/configure @@ -829,8

Re: [PATCH v3 00/34] A great number of cosmetic changes

2020-08-09 Thread Tomi Ollila
On Sun, Aug 09 2020, David Bremner wrote: > Jonas Bernoulli writes: >> >> Jonas Bernoulli (34): >> emacs: Shorten long lines >> emacs: Remove excess empty lines > > > These patches (and Đoàn Trần Công Danh's that I just applied by hand) > both seem to have problem with base64 encoded patches

Re: [PATCH v3 00/34] A great number of cosmetic changes

2020-08-09 Thread Tomi Ollila
On Sat, Aug 08 2020, Jonas Bernoulli wrote: > David Bremner writes: > >> Tomi Ollila writes: > >>> So we have 3 options: >>> >>> 1) apply this patch and now drop support for emacs 24 >>> >>> 2) apply this patch and somehow infor e

Re: [PATCH v2] configure: check for pytest with python -m pytest

2020-08-07 Thread Tomi Ollila
On Mon, Aug 03 2020, Đoàn Trần Công Danh wrote: > On different distro, pytest is suffixed with different patterns. > > On the other hand, `python3-pytest' could be invoked correctly, > via `python3 -m pytest', the latter is used by our tests, now. > > Switch to `$python -m pytest` to fix address

Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate

2020-08-07 Thread Tomi Ollila
On Thu, Aug 06 2020, Jonas Bernoulli wrote: > David Bremner writes: >> "cl-incf is a Lisp macro in ‘aquamacs-tools.el’." >> >> What the actual heck? > > Indeed. Did you follow the link to the definition to figure out what's > going on? > > Ah... I found this:

Re: [PATCH 1/2] test: drop NOTMUCH_DEFAULT_XAPIAN_BACKEND from T360-symbol-test

2020-07-31 Thread Tomi Ollila
On Wed, Jul 29 2020, David Bremner wrote: > Inspired by the suggestion of > > id:20200727154108.16269-3-congdan...@gmail.com > > to drop the configuration test for the default backend. This version > is hopefully robust against backend changes. > --- > test/T360-symbol-hiding.sh | 4

Re: [PATCH 00/23] A create number of cosmetic changes

2020-07-30 Thread Tomi Ollila
On Sun, Jul 26 2020, Jonas Bernoulli wrote: > Hello, > > Please forgive me for this wall of unsolicited cleanup; I blame it > on a mild form of ocd. I made most of these changes a few months > ago when I was splitting the libraries into `outline-minor-mode' > compatible sections. To do so I had

Re: [PATCH 03/23] emacs: Fix indentation

2020-07-30 Thread Tomi Ollila
On Sun, Jul 26 2020, Jonas Bernoulli wrote: > --- > emacs/coolj.el | 16 ++--- > emacs/notmuch-address.el | 18 +++--- > emacs/notmuch-compat.el| 86 - > emacs/notmuch-draft.el | 18 +++--- > emacs/notmuch-hello.el | 24

[PATCH] notmuch-mutt: replace shell pipeline with internal pipe processing

2020-07-27 Thread Tomi Ollila
The shell pipeline used to symlink files based in search results to "cache" directory for mutt(1) to use was prone to portability problems (due to /bin/sh differences). The replacement executes `notmuch search` without intermediate shell (so shell_quote was removed in this case), reads the

Re: [PATCH 1/3] gitignore: Ignore generated sphinx.config

2020-07-27 Thread Tomi Ollila
On Sun, Jul 26 2020, Jonas Bernoulli wrote: > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 1c8705ec..8f3ebec0 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -17,3 +17,4 @@ tags > /.stamps > *.stamp > /bindings/python-cffi/build/

Re: [PATCH 02/23] emacs: Remove excess empty lines

2020-07-27 Thread Tomi Ollila
On Sun, Jul 26 2020, Jonas Bernoulli wrote: > Most people who write lots of lisp tend to only sparsely use empty > "separator" lines within forms. In lisp they feel unnecessary and > since most files stick to this convention we get a bit confused > when there are extra empty lines. It feels

Re: [PATCH 01/23] emacs: Shorten long lines

2020-07-27 Thread Tomi Ollila
On Sun, Jul 26 2020, Jonas Bernoulli wrote: > --- > emacs/coolj.el | 2 +- > emacs/notmuch-address.el | 38 +++-- > emacs/notmuch-company.el | 17 -- > emacs/notmuch-crypto.el | 16 +++--- > emacs/notmuch-draft.el | 12 ++-- >

Re: [PATCH] T355: specify hash algorithm explicitly

2020-07-27 Thread Tomi Ollila
On Mon, Jul 27 2020, Đoàn Trần Công Danh wrote: > On some systems (notably, the one shipped with LibreSSL), > default fingerprint digest algorithm is SHA256. > > On other systems, users can change default digest algorithm by changing > default_md in /etc/ssl/default_md. > > Let's ask openssl to

Re: [PATCH] configure: account for various name of pytest-3

2020-07-27 Thread Tomi Ollila
On Mon, Jul 27 2020, Đoàn Trần Công Danh wrote: > On different distro, pytest is suffixed with different patterns. > Try to account for them, now. > > Signed-off-by: Đoàn Trần Công Danh > --- > configure | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH] configure: detect version by compiler for build

2020-07-27 Thread Tomi Ollila
On Mon, Jul 27 2020, Đoàn Trần Công Danh wrote: > We'll need to run the compiled binary to report our current version. > > With the same code base, we should have the same version information > regardless of compiler and architecture. > > Let's use the compiler for building architecture to build

Re: simplify handling of writable database modes

2020-07-27 Thread Tomi Ollila
On Sun, Jul 26 2020, David Bremner wrote: > As the last commit message mentions, it is a bit hard to be sure one > is using static_cast correctly, so this series eliminates > the use of static_cast for Xapian database objects. > > As a bonus, it deletes more code than it adds. > > Based on a

Re: [Kevin McCarthy] Bug#966100: notmuch-mutt: symlinking now fails for indexed mailboxes with a space in the name

2020-07-23 Thread Tomi Ollila
On Thu, Jul 23 2020, David Bremner wrote: > From: Kevin McCarthy > Subject: Bug#966100: notmuch-mutt: symlinking now fails for indexed mailboxes > with a space in the name > To: Debian Bug Tracking System > Date: Wed, 22 Jul 2020 19:06:27 -0700 > > Package: notmuch-mutt > Version: 0.30-1 >

Re: [PATCH 1/2] doc: replace use of environment variables with a generated config

2020-07-17 Thread Tomi Ollila
On Tue, Jul 14 2020, Floris Bruynooghe wrote: > On Sat 11 Jul 2020 at 10:20 -0300, David Bremner wrote: > >> I don't love the use of exec, but it is getting unwieldy to pass > > It's already a config file written in Python which is a terrible sin. > So no need to apologise, I think it makes sense

Re: [PATCH] doc: make gzipped man pages reproducible

2020-07-11 Thread Tomi Ollila
On Sat, Jul 11 2020, Jonas Witschel wrote: > gzip includes the name of the uncompressed file and its modification > timestamp into the compressed archive. The latter makes it hard to > reproduce the generated files bit for bit at a later time, so omit this > information from the archive using the

Re: [PATCH 1/2] doc: replace use of environment variables with a generated config

2020-07-11 Thread Tomi Ollila
On Sat, Jul 11 2020, David Bremner wrote: > I don't love the use of exec, but it is getting unwieldy to pass > configuration options on the sphinx-build command line, and I > anticipate further use of conditionals. Perhaps less "opinions" in commit message. (and as I think I don't comment 2/2,

Re: [PATCH] emacs: Add notmuch-show-local-dates option

2020-07-04 Thread Tomi Ollila
On Fri, Jul 03 2020, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> But if the sender is in TZ=Europe/Berlin, i would see: >> >> Date: Fri, 03 Jul 2020 13:22:36 -0400 [Fri, 03 Jul 2020 19:22:36 +0200] >> >> (Note that RFC 5322 Date format shows the hour offset, but not the >> actual

Re: [PATCH] doc: update name of gmime package to install

2020-07-01 Thread Tomi Ollila
On Fri, Jun 26 2020, David Bremner wrote: > Fedora still has an old gmime-devel which is 2.6.x. This is no longer > supported by notmuch. > --- > INSTALL | 2 +- > configure | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/INSTALL b/INSTALL > index f1236e71..3f11c2b7

[PATCH] Makefile.global: drop -std=gnu99. C11 (or later) compiler required

2020-06-24 Thread Tomi Ollila
Since October 2018 building notmuch has actually required compiler that knows C11. Also this -std=gnu99 was not used in code compiled by configure, so in theory this could have caused problems... ...but no related reports have been sent, perhaps ever. Both gcc and clang has been shipping

Re: [PATCH 1/2] configure: detect 64 bit time_t

2020-06-24 Thread Tomi Ollila
On Wed, Jun 24 2020, David Bremner wrote: > Certain tests involving timestamps > 32bits cannot pass with the > current libnotmuch API. We will avoid this isssue for now by disabling s/isssue/issue/ > those tests on "old" architectures with 32bit time_t. > --- > configure | 33

Re: [PATCH] completion: remove "setup" from the list of possible completions

2020-06-23 Thread Tomi Ollila
On Sat, Jun 20 2020, Ralph Seichter wrote: > * Tomi Ollila: > >> imo.the completions should primarily provide convenience to the >> interactive user, to see all possible options (also those >> seldomly.used) one can use help and namual pages... > > "Can use&quo

Re: [PATCH] completion: remove "setup" from the list of possible completions

2020-06-20 Thread Tomi Ollila
On Sat, Jun 20 2020, reto@labrat.space wrote: > On Fri, Jun 19, 2020 at 12:40:49PM +0200, Łukasz Stelmach wrote: >> Having "setup" in the set requires entering three instad of two characters >> for "search". Since "setup" is rearly used it makes little sense to have >> it in the set and cripple

<    1   2   3   4   5   6   7   8   9   10   >