Re: [PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-22 Thread Carl Worth
On Wed, 14 Apr 2010 17:35:44 -0700, Carl Worth wrote: > On Tue, 13 Apr 2010 18:37:57 +0200, Gregor Hoffleit > wrote: > > The test suite doesn't yet cover --format=json output nor UTF-8 in > > subject or body. > > > > This patch starts with test cases for 'search --format=json' and > > 'show --f

[PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-22 Thread Carl Worth
On Wed, 14 Apr 2010 17:35:44 -0700, Carl Worth wrote: > On Tue, 13 Apr 2010 18:37:57 +0200, Gregor Hoffleit > wrote: > > The test suite doesn't yet cover --format=json output nor UTF-8 in > > subject or body. > > > > This patch starts with test cases for 'search --format=json' and > > 'show --f

[PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-16 Thread David Edmondson
On Wed, 14 Apr 2010 17:35:44 -0700, Carl Worth wrote: > [*] I say "should" because I don't believe we have any actual > specification of the data coming out of the JSON output yet. One other > thing that seems odd is the name of "date_unix" in the show output and > "timestamp" in the search output

[PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-16 Thread Michal Sojka
> But you might actually like that change since it's one you requested in > your first version of the modular test suite. I'm dropping the annoying > execute_expecting macro that both runs notmuch and tests the > output. There's now a much cleaner separation such as: > > output=$($NOTMUCH se

Re: [PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-16 Thread David Edmondson
On Wed, 14 Apr 2010 17:35:44 -0700, Carl Worth wrote: > [*] I say "should" because I don't believe we have any actual > specification of the data coming out of the JSON output yet. One other > thing that seems odd is the name of "date_unix" in the show output and > "timestamp" in the search output

Re: [PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-16 Thread Michal Sojka
> But you might actually like that change since it's one you requested in > your first version of the modular test suite. I'm dropping the annoying > execute_expecting macro that both runs notmuch and tests the > output. There's now a much cleaner separation such as: > > output=$($NOTMUCH se

Re: [PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-15 Thread Carl Worth
On Thu, 15 Apr 2010 10:33:46 +0200, Michal Sojka wrote: > are you still interrested in modular test suite from git? If so, could > you please look at id:87mxxg7bxo@steelpick.2x.cz and tell me your > opinion. I'm still updating the modularized tests to match the state in > master but every chan

[PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-15 Thread Carl Worth
On Thu, 15 Apr 2010 10:33:46 +0200, Michal Sojka wrote: > are you still interrested in modular test suite from git? If so, could > you please look at id:87mxxg7bxo.fsf at steelpick.2x.cz and tell me your > opinion. I'm still updating the modularized tests to match the state in > master but every c

[PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-15 Thread Michal Sojka
On Thu, 15 Apr 2010, Carl Worth wrote: > On Tue, 13 Apr 2010 18:37:57 +0200, Gregor Hoffleit > wrote: > > The test suite doesn't yet cover --format=json output nor UTF-8 in > > subject or body. > > > > This patch starts with test cases for 'search --format=json' and > > 'show --format=json'. >

Re: [PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-15 Thread Michal Sojka
On Thu, 15 Apr 2010, Carl Worth wrote: > On Tue, 13 Apr 2010 18:37:57 +0200, Gregor Hoffleit > wrote: > > The test suite doesn't yet cover --format=json output nor UTF-8 in > > subject or body. > > > > This patch starts with test cases for 'search --format=json' and > > 'show --format=json'. >

Re: [PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-14 Thread Carl Worth
On Tue, 13 Apr 2010 18:37:57 +0200, Gregor Hoffleit wrote: > The test suite doesn't yet cover --format=json output nor UTF-8 in > subject or body. > > This patch starts with test cases for 'search --format=json' and > 'show --format=json'. Thanks for the tests, Gregor! I was about to push this,

[PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-14 Thread Carl Worth
On Tue, 13 Apr 2010 18:37:57 +0200, Gregor Hoffleit wrote: > The test suite doesn't yet cover --format=json output nor UTF-8 in > subject or body. > > This patch starts with test cases for 'search --format=json' and > 'show --format=json'. Thanks for the tests, Gregor! I was about to push this

[PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-13 Thread Gregor Hoffleit
The test suite doesn't yet cover --format=json output nor UTF-8 in subject or body. This patch starts with test cases for 'search --format=json' and 'show --format=json'. Furthermore, it has test cases for a search for a UTF-8 string in a mail body for a UTF-8 string in a mail subject. Finally,

[PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-13 Thread Gregor Hoffleit
The test suite doesn't yet cover --format=json output nor UTF-8 in subject or body. This patch starts with test cases for 'search --format=json' and 'show --format=json'. Furthermore, it has test cases for a search for a UTF-8 string in a mail body for a UTF-8 string in a mail subject. Finally,