Re: [PATCH] emacs: notmuch-tree: mark the initial message at point as read

2021-07-25 Thread David Bremner
Jonas Bernoulli writes: > When moving between message in a tree or show buffer, the message at > point is marked as read. Likewise when creating such a buffer, then > the message that is initially at point is supposed to be marked as > read as well. Applied to master. Thanks for patiently

Re: [PATCH] emacs: notmuch-tree: mark the initial message at point as read

2021-07-23 Thread Jonas Bernoulli
David Bremner writes: > Jonas Bernoulli writes: > >> >> Please merge the proposed fix; IMO it is sound. My follow-up, the reply >> to Tomi, seems quite confused though. But just because we are uncertain >> whether there is further room for improvement, that shouldn't keep us >> from fixing

Re: [PATCH] emacs: notmuch-tree: mark the initial message at point as read

2021-07-19 Thread David Bremner
Jonas Bernoulli writes: > > Please merge the proposed fix; IMO it is sound. My follow-up, the reply > to Tomi, seems quite confused though. But just because we are uncertain > whether there is further room for improvement, that shouldn't keep us > from fixing the bug. Maybe in the future we

Re: [PATCH] emacs: notmuch-tree: mark the initial message at point as read

2021-07-19 Thread Jonas Bernoulli
David Bremner writes: > Jonas Bernoulli writes: > >> Hm, when no tree buffer is involved, then `notmuch-show-command-hook' >> probably is required. Anyway, there seems to be some undead code and >> rethinking all this would be a good idea. > > I'm not sure I followed the discussion, but I'm

Re: [PATCH] emacs: notmuch-tree: mark the initial message at point as read

2021-06-05 Thread David Bremner
Jonas Bernoulli writes: > Hm, when no tree buffer is involved, then `notmuch-show-command-hook' > probably is required. Anyway, there seems to be some undead code and > rethinking all this would be a good idea. I'm not sure I followed the discussion, but I'm marking

Re: [PATCH] emacs: notmuch-tree: mark the initial message at point as read

2021-02-26 Thread Jonas Bernoulli
Hm, when no tree buffer is involved, then `notmuch-show-command-hook' probably is required. Anyway, there seems to be some undead code and rethinking all this would be a good idea. ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send

Re: [PATCH] emacs: notmuch-tree: mark the initial message at point as read

2021-02-26 Thread Jonas Bernoulli
> I try to understand whether adding notmuch-tree-command-hook to > post-command-hook in notmuch-tree.el (not in this change) actually > have any effect. You're right, that's unnecessary, and it gets worse. `notmuch-tree-command-hook' is unnecessary too and if it weren't, then it would fail

Re: [PATCH] emacs: notmuch-tree: mark the initial message at point as read

2021-02-25 Thread Tomi Ollila
On Tue, Feb 16 2021, Jonas Bernoulli wrote: > When moving between message in a tree or show buffer, the message at > point is marked as read. Likewise when creating such a buffer, then > the message that is initially at point is supposed to be marked as > read as well. > > The latter worked for

[PATCH] emacs: notmuch-tree: mark the initial message at point as read

2021-02-15 Thread Jonas Bernoulli
When moving between message in a tree or show buffer, the message at point is marked as read. Likewise when creating such a buffer, then the message that is initially at point is supposed to be marked as read as well. The latter worked for `notmuch-show' but not for `notmuch-tree'. Press "RET"