[PATCH 00/11] Improve charset and cid: handling

2015-01-24 Thread Austin Clements
I added declare-functions for both of these, which should take care of the Emacs 23 warnings and be more robust on Emacs 24. We can't reach the function that calls these unless shr is actually available, but the byte compiler doesn't know that. On Sat, 26 Apr 2014, Mark Walters wrote: > Aside

Re: [PATCH 00/11] Improve charset and cid: handling

2015-01-24 Thread Austin Clements
I added declare-functions for both of these, which should take care of the Emacs 23 warnings and be more robust on Emacs 24. We can't reach the function that calls these unless shr is actually available, but the byte compiler doesn't know that. On Sat, 26 Apr 2014, Mark Walters

[PATCH 00/11] Improve charset and cid: handling

2014-04-26 Thread Mark Walters
Aside from the minor comments I mentioned in previous emails and one more comment below this looks good. The extra comment is that on emacs23 I get the following when compiling: In end of data: notmuch-show.el:2188:1:Warning: the following functions are not known to be defined:

Re: [PATCH 00/11] Improve charset and cid: handling

2014-04-26 Thread Mark Walters
Aside from the minor comments I mentioned in previous emails and one more comment below this looks good. The extra comment is that on emacs23 I get the following when compiling: In end of data: notmuch-show.el:2188:1:Warning: the following functions are not known to be defined:

[PATCH 00/11] Improve charset and cid: handling

2014-04-22 Thread Tomi Ollila
On Mon, Apr 21 2014, Austin Clements wrote: > I set out to quickly add support for cid: links in the shr renderer > and wound up making our charset handling more robust and rewriting our > content-ID handling. The test introduced in patch 2 passes in all but > one really obscure case, but only

[PATCH 00/11] Improve charset and cid: handling

2014-04-21 Thread Austin Clements
I set out to quickly add support for cid: links in the shr renderer and wound up making our charset handling more robust and rewriting our content-ID handling. The test introduced in patch 2 passes in all but one really obscure case, but only because of many unwritten and potentially fragile

[PATCH 00/11] Improve charset and cid: handling

2014-04-21 Thread Austin Clements
I set out to quickly add support for cid: links in the shr renderer and wound up making our charset handling more robust and rewriting our content-ID handling. The test introduced in patch 2 passes in all but one really obscure case, but only because of many unwritten and potentially fragile

Re: [PATCH 00/11] Improve charset and cid: handling

2014-04-21 Thread Tomi Ollila
On Mon, Apr 21 2014, Austin Clements amdra...@mit.edu wrote: I set out to quickly add support for cid: links in the shr renderer and wound up making our charset handling more robust and rewriting our content-ID handling. The test introduced in patch 2 passes in all but one really obscure