[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-08 Thread Tomi Ollila
On Sat, Feb 08 2014, "W. Trevor King" wrote: > On Sat, Feb 08, 2014 at 08:29:41PM +0200, Tomi Ollila wrote: >> On Sat, Feb 08 2014, W. Trevor King wrote: >> > On Sat, Feb 08, 2014 at 09:54:28AM -0400, David Bremner wrote: >> >> >> >> yeah, the colour scheme is not my favourite. For the sake of

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-08 Thread Tomi Ollila
On Sat, Feb 08 2014, "W. Trevor King" wrote: > On Sat, Feb 08, 2014 at 09:54:28AM -0400, David Bremner wrote: >> W. Trevor King writes: >> > I'll remove this once the series lands, but I've currently got a >> > preview up at http://tremily.us/status.html >> >> yeah, the colour scheme is not my

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-08 Thread W. Trevor King
On Sat, Feb 08, 2014 at 09:37:43PM +0200, Tomi Ollila wrote: > On Sat, Feb 08 2014, W. Trevor King wrote: > > On Sat, Feb 08, 2014 at 08:29:41PM +0200, Tomi Ollila wrote: > >> On Sat, Feb 08 2014, W. Trevor King wrote: > >> > On Sat, Feb 08, 2014 at 09:54:28AM -0400, David Bremner wrote: > >> >>

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-08 Thread David Bremner
"W. Trevor King" writes: > I'll remove this once the series lands, but I've currently got a > preview up at http://tremily.us/status.html yeah, the colour scheme is not my favourite. For the sake of being semi-constructive, I attach an alternative suggestion using colours #ffd96e and #bce.

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-08 Thread W. Trevor King
On Sat, Feb 08, 2014 at 08:29:41PM +0200, Tomi Ollila wrote: > On Sat, Feb 08 2014, W. Trevor King wrote: > > On Sat, Feb 08, 2014 at 09:54:28AM -0400, David Bremner wrote: > >> W. Trevor King writes: > >> > I'll remove this once the series lands, but I've currently got a > >> > preview up at

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-08 Thread W. Trevor King
On Sat, Feb 08, 2014 at 09:54:28AM -0400, David Bremner wrote: > W. Trevor King writes: > > I'll remove this once the series lands, but I've currently got a > > preview up at http://tremily.us/status.html > > yeah, the colour scheme is not my favourite. For the sake of being > semi-constructive,

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-08 Thread W. Trevor King
On Sat, Feb 08, 2014 at 09:54:28AM -0400, David Bremner wrote: W. Trevor King writes: I'll remove this once the series lands, but I've currently got a preview up at http://tremily.us/status.html yeah, the colour scheme is not my favourite. For the sake of being semi-constructive, I attach

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-08 Thread Tomi Ollila
On Sat, Feb 08 2014, W. Trevor King wk...@tremily.us wrote: On Sat, Feb 08, 2014 at 09:54:28AM -0400, David Bremner wrote: W. Trevor King writes: I'll remove this once the series lands, but I've currently got a preview up at http://tremily.us/status.html yeah, the colour scheme is not my

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-08 Thread W. Trevor King
On Sat, Feb 08, 2014 at 08:29:41PM +0200, Tomi Ollila wrote: On Sat, Feb 08 2014, W. Trevor King wrote: On Sat, Feb 08, 2014 at 09:54:28AM -0400, David Bremner wrote: W. Trevor King writes: I'll remove this once the series lands, but I've currently got a preview up at

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-08 Thread Tomi Ollila
On Sat, Feb 08 2014, W. Trevor King wk...@tremily.us wrote: On Sat, Feb 08, 2014 at 08:29:41PM +0200, Tomi Ollila wrote: On Sat, Feb 08 2014, W. Trevor King wrote: On Sat, Feb 08, 2014 at 09:54:28AM -0400, David Bremner wrote: yeah, the colour scheme is not my favourite. For the sake of

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-08 Thread W. Trevor King
On Sat, Feb 08, 2014 at 09:37:43PM +0200, Tomi Ollila wrote: On Sat, Feb 08 2014, W. Trevor King wrote: On Sat, Feb 08, 2014 at 08:29:41PM +0200, Tomi Ollila wrote: On Sat, Feb 08 2014, W. Trevor King wrote: On Sat, Feb 08, 2014 at 09:54:28AM -0400, David Bremner wrote: More importantly

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-07 Thread W. Trevor King
On Wed, Feb 05, 2014 at 07:31:27AM -0800, W. Trevor King wrote: > On Wed, Feb 05, 2014 at 05:24:56PM +0200, Tomi Ollila wrote: > > Forgot to mention that the <, >, & etc. characters could also be > > encoded in this patch series (to , , etc.) > > Good point. I'll xml.sax.saxutils.escape the

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-07 Thread W. Trevor King
On Wed, Feb 05, 2014 at 07:31:27AM -0800, W. Trevor King wrote: On Wed, Feb 05, 2014 at 05:24:56PM +0200, Tomi Ollila wrote: Forgot to mention that the , , etc. characters could also be encoded in this patch series (to lt;, gt;, amp; etc.) Good point. I'll xml.sax.saxutils.escape the

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-06 Thread W. Trevor King
On Thu, Feb 06, 2014 at 12:54:56AM +0200, Tomi Ollila wrote: > On Wed, Feb 05 2014, "W. Trevor King" wrote: > > On Wed, Feb 05, 2014 at 05:00:45PM +0200, Tomi Ollila wrote: > >> #DFF for the light-blue works better for me. > > > > I'm fine with that. As I said in my cover letter, I'm happy to

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-06 Thread Tomi Ollila
On Wed, Feb 05 2014, "W. Trevor King" wrote: > On Wed, Feb 05, 2014 at 05:00:45PM +0200, Tomi Ollila wrote: >> After I fixed the wrapper the program works fine on python 2.6.6. > > :) > >> now every other thread is background-colored (girly) pink (fef?) >> and every other light blue (eff). for

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-06 Thread W. Trevor King
On Thu, Feb 06, 2014 at 12:54:56AM +0200, Tomi Ollila wrote: On Wed, Feb 05 2014, W. Trevor King wrote: On Wed, Feb 05, 2014 at 05:00:45PM +0200, Tomi Ollila wrote: #DFF for the light-blue works better for me. I'm fine with that. As I said in my cover letter, I'm happy to have

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-05 Thread Tomi Ollila
On Wed, Feb 05 2014, Tomi Ollila wrote: > I have some comments on the new look -- which is pretty nice btw. > > now every other thread is background-colored (girly) pink (fef?) > and every other light blue (eff). for me the light blue is not > visible (there are no body background color set?) >

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-05 Thread Tomi Ollila
On Tue, Feb 04 2014, Tomi Ollila wrote: > On Tue, Feb 04 2014, "W. Trevor King" wrote: > > > $ PYTHONPATH=$PWD/bindings/python/ ./devel/nmbug/nmbug-status > ... > Traceback (most recent call last): > File "devel/nmbug/nmbug-status", line 318, in > page.write(database=db,

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-05 Thread W. Trevor King
On Wed, Feb 05, 2014 at 05:24:56PM +0200, Tomi Ollila wrote: > Forgot to mention that the <, >, & etc. characters could also be > encoded in this patch series (to , , etc.) Good point. I'll xml.sax.saxutils.escape the message-id, from, and subject at the end of HtmlPage._message_display_data,

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-05 Thread W. Trevor King
On Wed, Feb 05, 2014 at 05:00:45PM +0200, Tomi Ollila wrote: > After I fixed the wrapper the program works fine on python 2.6.6. :) > now every other thread is background-colored (girly) pink (fef?) > and every other light blue (eff). for me the light blue is not > visible (there are no body

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-05 Thread Tomi Ollila
On Tue, Feb 04 2014, Tomi Ollila tomi.oll...@iki.fi wrote: On Tue, Feb 04 2014, W. Trevor King wk...@tremily.us wrote: $ PYTHONPATH=$PWD/bindings/python/ ./devel/nmbug/nmbug-status ... Traceback (most recent call last): File devel/nmbug/nmbug-status, line 318, in module

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-05 Thread Tomi Ollila
On Wed, Feb 05 2014, Tomi Ollila tomi.oll...@iki.fi wrote: I have some comments on the new look -- which is pretty nice btw. now every other thread is background-colored (girly) pink (fef?) and every other light blue (eff). for me the light blue is not visible (there are no body background

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-05 Thread W. Trevor King
On Wed, Feb 05, 2014 at 05:00:45PM +0200, Tomi Ollila wrote: After I fixed the wrapper the program works fine on python 2.6.6. :) now every other thread is background-colored (girly) pink (fef?) and every other light blue (eff). for me the light blue is not visible (there are no body

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-05 Thread W. Trevor King
On Wed, Feb 05, 2014 at 05:24:56PM +0200, Tomi Ollila wrote: Forgot to mention that the , , etc. characters could also be encoded in this patch series (to lt;, gt;, amp; etc.) Good point. I'll xml.sax.saxutils.escape the message-id, from, and subject at the end of

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-05 Thread Tomi Ollila
On Wed, Feb 05 2014, W. Trevor King wk...@tremily.us wrote: On Wed, Feb 05, 2014 at 05:00:45PM +0200, Tomi Ollila wrote: After I fixed the wrapper the program works fine on python 2.6.6. :) now every other thread is background-colored (girly) pink (fef?) and every other light blue (eff).

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread Tomi Ollila
On Tue, Feb 04 2014, "W. Trevor King" wrote: >> >> I don't know what to paste, so i paste this: >> >> $ python >> Python 2.6.6 (r266:84292, Nov 21 2013, 12:39:37) >> [GCC 4.4.7 20120313 (Red Hat 4.4.7-3)] on linux2 >> Type "help", "copyright", "credits" or "license" for more information. > >

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread Tomi Ollila
On Tue, Feb 04 2014, "W. Trevor King" wrote: > > >>> from __future__ import unicode_literals > >>> import codecs > >>> import locale > >>> import sys > >>> print(locale.getpreferredencoding()) # same as yours > UTF-8 > >>> print(sys.getdefaultencoding()) # same as yours > ascii

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread Tomi Ollila
On Tue, Feb 04 2014, "W. Trevor King" wrote: > On Tue, Feb 04, 2014 at 12:30:30PM +0200, Tomi Ollila wrote: >> On Tue, Feb 04 2014, W. Trevor King wrote: >> > On Mon, Feb 03, 2014 at 11:10:23PM +0200, Tomi Ollila wrote: >> >> File "devel/nmbug/nmbug-status", line 197, in _write_threads >> >>

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread W. Trevor King
On Tue, Feb 04, 2014 at 08:40:18PM +0200, Tomi Ollila wrote: > On Tue, Feb 04 2014, W. Trevor King wrote: > > > > >>> from __future__ import unicode_literals > > >>> import codecs > > >>> import locale > > >>> import sys > > >>> print(locale.getpreferredencoding()) # same as yours > >

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread W. Trevor King
On Tue, Feb 04, 2014 at 12:30:30PM +0200, Tomi Ollila wrote: > On Tue, Feb 04 2014, W. Trevor King wrote: > > On Mon, Feb 03, 2014 at 11:10:23PM +0200, Tomi Ollila wrote: > >> File "devel/nmbug/nmbug-status", line 197, in _write_threads > >> ).format(**message_display_data)) > >> File

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread W. Trevor King
On Tue, Feb 04, 2014 at 07:50:32AM -0800, W. Trevor King wrote: > That's two votes for Python 2.6 and none for later versions, so I'll > just try a bit harder for 2.6 compatibility ;). As a v2 preview, and to help with further review, I've posted my current v1+ version of this branch at:

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread David Bremner
Tomi Ollila writes: > anyway, if this doesn't resolve out and there is no resistance to require > python 2.7 (that means from David) I can hack around this to get this > reviewed. Currently the production copy of nmbug-status is running with python2.6 on Debian squeeze. I _should_ upgrade that

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread W. Trevor King
On Tue, Feb 04, 2014 at 12:30:30PM +0200, Tomi Ollila wrote: > On Tue, Feb 04 2014, "W. Trevor King" wrote: > > On Mon, Feb 03, 2014 at 11:10:23PM +0200, Tomi Ollila wrote: > >> File "devel/nmbug/nmbug-status", line 197, in _write_threads > >> ).format(**message_display_data)) > >> File

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread W. Trevor King
On Tue, Feb 04, 2014 at 09:07:45AM -0400, David Bremner wrote: > Tomi Ollila writes: > > anyway, if this doesn't resolve out and there is no resistance to require > > python 2.7 (that means from David) I can hack around this to get this > > reviewed. > > Currently the production copy of

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread Tomi Ollila
On Tue, Feb 04 2014, W. Trevor King wk...@tremily.us wrote: On Mon, Feb 03, 2014 at 11:10:23PM +0200, Tomi Ollila wrote: data['message-id-term'] = 'id:{}'.format(value) ValueError: zero length field name in format Oops, Python 2.6 still needs explicit indexes ('{0}', not '{}'). It's an

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread David Bremner
Tomi Ollila tomi.oll...@iki.fi writes: anyway, if this doesn't resolve out and there is no resistance to require python 2.7 (that means from David) I can hack around this to get this reviewed. Currently the production copy of nmbug-status is running with python2.6 on Debian squeeze. I

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread W. Trevor King
On Tue, Feb 04, 2014 at 09:07:45AM -0400, David Bremner wrote: Tomi Ollila writes: anyway, if this doesn't resolve out and there is no resistance to require python 2.7 (that means from David) I can hack around this to get this reviewed. Currently the production copy of nmbug-status is

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread W. Trevor King
On Tue, Feb 04, 2014 at 12:30:30PM +0200, Tomi Ollila wrote: On Tue, Feb 04 2014, W. Trevor King wrote: On Mon, Feb 03, 2014 at 11:10:23PM +0200, Tomi Ollila wrote: File devel/nmbug/nmbug-status, line 197, in _write_threads ).format(**message_display_data)) File

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread W. Trevor King
On Tue, Feb 04, 2014 at 07:50:32AM -0800, W. Trevor King wrote: That's two votes for Python 2.6 and none for later versions, so I'll just try a bit harder for 2.6 compatibility ;). As a v2 preview, and to help with further review, I've posted my current v1+ version of this branch at:

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread W. Trevor King
On Tue, Feb 04, 2014 at 12:30:30PM +0200, Tomi Ollila wrote: On Tue, Feb 04 2014, W. Trevor King wrote: On Mon, Feb 03, 2014 at 11:10:23PM +0200, Tomi Ollila wrote: File devel/nmbug/nmbug-status, line 197, in _write_threads ).format(**message_display_data)) File

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread Tomi Ollila
On Tue, Feb 04 2014, W. Trevor King wk...@tremily.us wrote: On Tue, Feb 04, 2014 at 12:30:30PM +0200, Tomi Ollila wrote: On Tue, Feb 04 2014, W. Trevor King wrote: On Mon, Feb 03, 2014 at 11:10:23PM +0200, Tomi Ollila wrote: File devel/nmbug/nmbug-status, line 197, in _write_threads

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread Tomi Ollila
On Tue, Feb 04 2014, W. Trevor King wk...@tremily.us wrote: from __future__ import unicode_literals import codecs import locale import sys print(locale.getpreferredencoding()) # same as yours UTF-8 print(sys.getdefaultencoding()) # same as yours ascii

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread W. Trevor King
On Tue, Feb 04, 2014 at 08:40:18PM +0200, Tomi Ollila wrote: On Tue, Feb 04 2014, W. Trevor King wrote: from __future__ import unicode_literals import codecs import locale import sys print(locale.getpreferredencoding()) # same as yours UTF-8

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-04 Thread Tomi Ollila
On Tue, Feb 04 2014, W. Trevor King wk...@tremily.us wrote: I don't know what to paste, so i paste this: $ python Python 2.6.6 (r266:84292, Nov 21 2013, 12:39:37) [GCC 4.4.7 20120313 (Red Hat 4.4.7-3)] on linux2 Type help, copyright, credits or license for more information. It looks

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-03 Thread Tomi Ollila
On Mon, Feb 03 2014, "W. Trevor King" wrote: > I noticed that nmbug-status was written in Python :), but not > compatible with Python 3 :(. I started cleaning up a few print > statements, but this quickly turned into a more general refactoring. > Let me know if this is too much to bite off at

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-03 Thread W. Trevor King
On Mon, Feb 03, 2014 at 11:10:23PM +0200, Tomi Ollila wrote: > data['message-id-term'] = 'id:"{}"'.format(value) > ValueError: zero length field name in format Oops, Python 2.6 still needs explicit indexes ('{0}', not '{}'). It's an easy fix, so I'll queue it for v2. You're still going to

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-03 Thread W. Trevor King
I noticed that nmbug-status was written in Python :), but not compatible with Python 3 :(. I started cleaning up a few print statements, but this quickly turned into a more general refactoring. Let me know if this is too much to bite off at once. I tried to keep each patch fairly contained, but

[PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-03 Thread W. Trevor King
I noticed that nmbug-status was written in Python :), but not compatible with Python 3 :(. I started cleaning up a few print statements, but this quickly turned into a more general refactoring. Let me know if this is too much to bite off at once. I tried to keep each patch fairly contained, but

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-03 Thread Tomi Ollila
On Mon, Feb 03 2014, W. Trevor King wk...@tremily.us wrote: I noticed that nmbug-status was written in Python :), but not compatible with Python 3 :(. I started cleaning up a few print statements, but this quickly turned into a more general refactoring. Let me know if this is too much to

Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

2014-02-03 Thread W. Trevor King
On Mon, Feb 03, 2014 at 11:10:23PM +0200, Tomi Ollila wrote: data['message-id-term'] = 'id:{}'.format(value) ValueError: zero length field name in format Oops, Python 2.6 still needs explicit indexes ('{0}', not '{}'). It's an easy fix, so I'll queue it for v2. You're still going to need