Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query

2020-02-29 Thread Sean Whitton
Hello David, On Sun 01 Dec 2019 at 09:01PM +00, David Edmondson wrote: > On Friday, 2019-11-29 at 13:01:00 -07, Sean Whitton wrote: > >> On Wed 27 Nov 2019 at 08:52PM +00, David Edmondson wrote: >>> It's a lot to ask, I know, but if you could provide a specific set of >>> messages with a

Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query

2019-12-01 Thread David Edmondson
On Friday, 2019-11-29 at 13:01:00 -07, Sean Whitton wrote: > On Wed 27 Nov 2019 at 08:52PM +00, David Edmondson wrote: >> It's a lot to ask, I know, but if you could provide a specific set of >> messages with a corresponding initial query that fails for you after >> limiting using your function,

Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query

2019-11-29 Thread Sean Whitton
Dear David, Thank you again for your interest. On Wed 27 Nov 2019 at 08:52PM +00, David Edmondson wrote: > If this does what I think, which is to filter the current thread to show > only those messages that contain actual patches (with an optional > version number), then, with the previous

Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query

2019-11-27 Thread David Edmondson
On Wednesday, 2019-11-27 at 10:42:59 -07, Sean Whitton wrote: > On Wed 27 Nov 2019 at 01:08PM +00, David Edmondson wrote: > >> On Tuesday, 2019-11-26 at 16:25:29 -07, Sean Whitton wrote: >> >>> On Tue 26 Nov 2019 at 10:52PM +00, David Edmondson wrote: >>> The poor behaviour is just a side

Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query

2019-11-27 Thread Sean Whitton
[dropping Org-mode list per David's suggestion] Hello, On Wed 27 Nov 2019 at 01:08PM +00, David Edmondson wrote: > On Tuesday, 2019-11-26 at 16:25:29 -07, Sean Whitton wrote: > >> On Tue 26 Nov 2019 at 10:52PM +00, David Edmondson wrote: >> >>> The poor behaviour is just a side effect of the

Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query

2019-11-27 Thread David Edmondson
On Tuesday, 2019-11-26 at 16:25:29 -07, Sean Whitton wrote: > On Tue 26 Nov 2019 at 10:52PM +00, David Edmondson wrote: > >> The poor behaviour is just a side effect of the way that queries are >> composed to implement the filter functionality. Does the attached patch >> help? > > Unfortunately,

Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query

2019-11-26 Thread Sean Whitton
Hello David, Thank you for the investigation. On Tue 26 Nov 2019 at 10:52PM +00, David Edmondson wrote: > The poor behaviour is just a side effect of the way that queries are > composed to implement the filter functionality. Does the attached patch > help? Unfortunately, it is still broken in

Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query

2019-11-26 Thread David Edmondson
On Tuesday, 2019-11-26 at 14:57:28 -07, Sean Whitton wrote: > On Tue 26 Nov 2019 at 08:05PM +00, David Edmondson wrote: > >> Could you explain how you were using `notmuch-show-thread-id' in a way >> that was broken by the presence of an arbitrary query? > > I've observed that the standard notmuch

Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query

2019-11-26 Thread Sean Whitton
Hello David, On Tue 26 Nov 2019 at 08:05PM +00, David Edmondson wrote: > Could you explain how you were using `notmuch-show-thread-id' in a way > that was broken by the presence of an arbitrary query? I've observed that the standard notmuch command `notmuch-show-filter-thread' doesn't work in a

Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query

2019-11-26 Thread Sean Whitton
Hello, On Tue 26 Nov 2019 at 08:17PM +01, ra...@free.fr wrote: > Your approach probably works most of the time, but I don't like the idea > of having to perform 2 queries when one should be enough. > > I think a better approach would be to change notmuch-show (or add a > new version) that would

Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query

2019-11-26 Thread David Edmondson
On Thursday, 2019-11-21 at 14:37:44 -07, Sean Whitton wrote: > The function `org-notmuch-follow-link' in {org,ol}-notmuch.el calls > `notmuch-show' with an arbitrary notmuch search query. However, the > docstring for `notmuch-show' specifies that a notmuch thread ID, rather > than an arbitrary

Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query

2019-11-26 Thread racin
Hi, > > Here is my workaround. If this approach seems sensible I can prepare a > patch to `org-notmuch-follow-link` in ol-notmuch.el. Your approach probably works most of the time, but I don't like the idea of having to perform 2 queries when one should be enough. I think a better approach

Re: Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query

2019-11-26 Thread Sean Whitton
Dear maintainers, On Thu 21 Nov 2019 at 02:37PM -07, Sean Whitton wrote: > The function `org-notmuch-follow-link' in {org,ol}-notmuch.el calls > `notmuch-show' with an arbitrary notmuch search query. However, the > docstring for `notmuch-show' specifies that a notmuch thread ID, rather > than

Bug: ol-notmuch.el: calls `notmuch-show' with arbitrary search query

2019-11-21 Thread Sean Whitton
Dear maintainers, The function `org-notmuch-follow-link' in {org,ol}-notmuch.el calls `notmuch-show' with an arbitrary notmuch search query. However, the docstring for `notmuch-show' specifies that a notmuch thread ID, rather than an arbitrary notmuch query, should be supplied to `notmuch-show'.