Re: [Patch v4 2/2] test: initial performance testing infrastructure

2012-11-26 Thread David Bremner
Austin Clements writes: > > The README definitely helps. Might still be worth a comment in the > code since it took me some thinking to realize it would do something > reasonable when given no argument. Perhaps above the initial > assignment of arg, I decided to fix the code, rather than commen

Re: [Patch v4 2/2] test: initial performance testing infrastructure

2012-11-25 Thread Austin Clements
Quoth David Bremner on Nov 25 at 8:05 pm: > Austin Clements writes: > >> +add_email_corpus takes arguments "--small" and "--medium" for when you > >> +want smaller corpuses to check. > > > > "corpora"? > > reworded to say > > , > | add_email_corpus takes arguments "--small" and "--medium"

Re: [Patch v4 2/2] test: initial performance testing infrastructure

2012-11-25 Thread David Bremner
Austin Clements writes: >> +subdirs := compat completion emacs lib man parse-time-string >> +subdirs := $(subdirs) performance-test util test > += ? > Sure. >> +CORPUS_NAME := notmuch-email-corpus-$(PERFTEST_VERSION).tar.xz > > Would it make sense to split out the different size corpora so a u

Re: [Patch v4 2/2] test: initial performance testing infrastructure

2012-11-25 Thread Austin Clements
Quoth da...@tethera.net on Nov 25 at 11:02 am: > From: David Bremner > > This is not near as fancy as as the unit tests, on the theory that > the code should typically be crashing when performance tuning. > Nonetheless, there is plenty of room for improvement. Several more of > the pieces of the