On Mon, 12 Dec 2011 14:26:21 -0400, David Bremner wrote:
> On Sun, 11 Dec 2011 20:41:53 +0400, Dmitry Kurochkin
> wrote:
> > Hi David.
> >
> > On Sun, 11 Dec 2011 12:07:51 -0400, David Bremner wrote:
> > > From: David Bremner
> > >
> > > Two new internal routines are created _config_get_list
On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner wrote:
> It turns out that our existing (trivial) python test is enough to
> catch this bug, but the corpus needs to be augmented. This
> augmentation is a bit intrusive so I'm thinking of cherry-picking only
> the actual fix to the release branch
* emacs/notmuch-show.el (notmuch-show-buttonized-link-present),
* emacs/notmuch-show.el (notmuch-show-buttonized-link-present-and-unread),
* emacs/notmuch-show.el (notmuch-show-buttonized-link-missing):
new faces for buttonized id: links.
* emacs/notmuch-show.el (notmuch-show-found-target-p): ad
* emacs/notmuch-show.el (notmuch-show-found-target-p): new predicate function
that uses notmuch(1) 'count' to see if a query turns up any results.
* emacs/notmuch-show.el (notmuch-show-if-found): new function that only shows
a message/thread if present in the database and otherwise returns an
"Worldwide, -ize endings prevail in scientific writing and are commonly
used by many international organizations, such as the ISO and the
WHO. The European Union switched from -ize to -ise some years ago in its
English language publications, and this resulted in the coexistence of
the -ize spelling
On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins
wrote:
> Since message-ids necessarily match just a single message, there's no
> reason to do a search for the id before viewing the actual message;
> the search just becomes an extra screen to click through. Clicking on
> an id: links no
On Wed, 21 Dec 2011 11:35:37 -0800, Jameson Graef Rollins
wrote:
> On Wed, 21 Dec 2011 07:44:16 -0400, David Bremner wrote:
> [SNIP]
>
> > On my machine all of the programs (except nottoomuch ;) ) that use
> > ~/.config are gui based, and a bunch of them store binary blobs (or not
> > plain tex
On Sun, 18 Dec 2011 20:18:03 +0400, Dmitry Kurochkin
wrote:
> On Sun, 18 Dec 2011 18:12:51 +0200, Tomi Ollila wrote:
> > On Sun, 18 Dec 2011 19:50:52 +0400, Dmitry Kurochkin
> > wrote:
> > > +1 for the former.
> >
> > +1
> >
> > > How about indenting with spaces+tabs vs indenting with spaces
When running the Emacs tests in verbose mode, only the first missing
prereq is reported because the `run_emacs' function is short-circuited
early:
#+begin_example
emacs: Testing emacs interface
missing prerequisites: [0] emacs(1)
skipping test: [0] Basic notmuch-hello view in ema
On Sun, 27 Nov 2011 22:36:12 +0400, Dmitry Kurochkin
wrote:
> Changes:
>
> v3 since v2:
>
> * rebased the remaining patches on current master
>
> v2 since v1:
>
> * Add test_require_external_prereq function to explicitly check for
> external dependencies, use it in test_emacs.
>
> * Indent
On Tue, 22 Nov 2011 22:40:21 -0500, Austin Clements wrote:
> Quoth Jameson Graef Rollins on Nov 20 at 12:10 pm:
> > The open question seems to be how we handle the content encoding
> > parameters. My argument is that those should either be used by notmuch
> > to properly encode the content for th
To allow for expansion whilst keeping everything tidy and organized,
move all defcustom/defface variables to the following subgroups,
defined in notmuch-lib.el:
- Hello
- Search
- Show
- Send
- Crypto
- Hooks
- Appearance
- External Commands
As an added benefit, defcustom keyword args are now con
On Sun, 20 Nov 2011 22:35:42 +0400, Dmitry Kurochkin
wrote:
> On Sat, 19 Nov 2011 08:59:29 -0400, David Bremner wrote:
> > On Sat, 19 Nov 2011 08:18:41 +0400, Dmitry Kurochkin
> > wrote:
> > > Before the change, notmuch used g_mime_content_type_to_string(3)
> > > function to output Content-Typ
On Thu, 17 Nov 2011 11:14:11 +0100, Thomas Jost wrote:
> On Wed, 16 Nov 2011 21:50:17 +0100, Pieter Praet wrote:
> > On Wed, 16 Nov 2011 15:33:49 +0100, Thomas Jost
> > wrote:
> > > Hello list,
> > >
> > > This is another rebased version of Pieter's series to add GPG and Emacs
> > > as test
>
On Wed, 11 Jan 2012 22:57:39 -0500, Austin Clements wrote:
> > From: David Bremner
> >
> > This patch shows the raw result of running uncrustify on notmuch-reply.c.
> > The re-indenting of "format_reply" would probably not be desirable.
>
> The good news is that that structure is on its way out
On Thu, 17 Nov 2011 08:21:59 +0200, Jani Nikula wrote:
> On Nov 16, 2011 11:39 PM, "Pieter Praet" wrote:
> >
> > On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila
> wrote:
> > > On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet
> wrote:
> > > > No further explanation needed.
> > > > ---
> > > > N
On Wed, 16 Nov 2011 23:47:53 +0100, Pieter Praet wrote:
> On Sun, 13 Nov 2011 13:16:48 -0800, Jameson Graef Rollins
> wrote:
> > This patch breaks out much of the functionality of
> > notmuch-show-advance-and-archive into a new function:
> > notmuch-show-advance. This new function does all the
On Sun, 25 Dec 2011 15:55:43 -0400, David Bremner wrote:
>
> Well, it's -19C outside, so guess that is appropriate.
>
> I have merged master to release in preparation for release. There should
> only be additions to NEWS or fixes for serious bugs for branch release
> until 0.11 is out the door.
Quoth Tomi Ollila on Jan 12 at 10:51 am:
> On Wed, 11 Jan 2012 23:13:44 -0500, Austin Clements wrote:
> > This is important to fix, but this solution seems needlessly
> > roundabout. What about using an after-advice and simply delq'ing
> > whatever the offending hook is? That wouldn't even need
Quoth David Bremner on Jan 12 at 9:08 am:
> @@ -425,7 +420,7 @@ notmuch_search_command (void *ctx, int argc, char *argv[])
> int limit = -1; /* unlimited */
>
> enum { NOTMUCH_FORMAT_JSON, NOTMUCH_FORMAT_TEXT }
> - format_sel = NOTMUCH_FORMAT_TEXT;
> +format_sel = NOTMUCH_FORMA
On Thu, 12 Jan 2012 14:42:49 +, David Edmondson wrote:
> On Thu, 12 Jan 2012 18:17:44 +0400, Dmitry Kurochkin
> wrote:
> > I think there is a record of useful features and fixes that were not
> > accepted to notmuch because of some implementation issues. And
> > interested people were using
On Thu, 12 Jan 2012 18:17:44 +0400, Dmitry Kurochkin
wrote:
> I think there is a record of useful features and fixes that were not
> accepted to notmuch because of some implementation issues. And
> interested people were using them in private repos for years. (I do not
> say that it is always t
Hi David.
On Thu, 12 Jan 2012 12:00:14 +, David Edmondson wrote:
> On Wed, 11 Jan 2012 22:34:45 +0400, Dmitry Kurochkin
> wrote:
> > -1
>
> Which puts me back to 0 :-(
>
> > One particular issue with your patch is that it adds (incorrect) charset
> > parameter to plain/text parts which ar
On Thu, 12 Jan 2012 09:08:18 -0400, David Bremner wrote:
>
> > All of the other format fixes look very reasonable to me. I think you
> > managed to find one of the least canonical source files in the tree.
> > Was that intentional?
>
> Yes, I expect there would be less changes elsewhere. Althou
On Thu, 12 Jan 2012 15:36:07 +0200, Tomi Ollila wrote:
> On Thu, 12 Jan 2012 12:07:40 +, David Edmondson wrote:
> > On Thu, 12 Jan 2012 12:33:58 +0400, Dmitry Kurochkin
> > wrote:
> > > I did not follow the rest of the discussion, so sorry if I missed
> > > something obvious. But why can't
On Thu, 12 Jan 2012 12:07:40 +, David Edmondson wrote:
> On Thu, 12 Jan 2012 12:33:58 +0400, Dmitry Kurochkin
> wrote:
> > I did not follow the rest of the discussion, so sorry if I missed
> > something obvious. But why can't we render HTML parts in replies the
> > same way we do in notmuch
Add the charset of text/html parts to the JSON output of 'notmuch
-show' when it is known. Observe the encoding when rendering such
parts in emacs.
---
Add the charset only for text/html parts to avoid incorrectly
declaring the charset for JSON inline text/plain parts (as they have
already been co
On Thu, 12 Jan 2012 09:08:18 -0400, David Bremner wrote:
> The corresponding diff for notmuch-search.c follows
> -
> - notmuch_filenames_destroy( filenames );
> +
> + notmuch_filenames_destroy ( filenames );
Can you make it remove the extra spaces after ( and before ) to
On Wed, 11 Jan 2012 22:57:39 -0500, Austin Clements wrote:
> > From: David Bremner
> >
> > This patch shows the raw result of running uncrustify on notmuch-reply.c.
> > The re-indenting of "format_reply" would probably not be desirable.
>
> The good news is that that structure is on its way out
On Wed, 11 Jan 2012 22:50:32 -0500, Austin Clements wrote:
> I'm not sure what the point of the last test is, but this patch
> covered everything I could think of, so LGTM.
Maybe checking that long subject line (possibly split/join sometimes in the
process) keeps it's original form (?)
LGTM (and
On Tue, 03 Jan 2012 22:36:59 +, Darren McGuicken
wrote:
> On Tue, 03 Jan 2012 17:09:39 -0500, Peter Portante
> wrote:
> > I am interested in using notmuch from within emacs, but have not been
> > able to get the latest version of notmuch (0.10.2) to compile under
> > Fedora 16.
>
> Looks
On Thu, 12 Jan 2012 12:33:58 +0400, Dmitry Kurochkin
wrote:
> I did not follow the rest of the discussion, so sorry if I missed
> something obvious. But why can't we render HTML parts in replies the
> same way we do in notmuch-show (using `mm-display-part')? That should
> not introduce a w3m.el
On Wed, 11 Jan 2012 22:34:45 +0400, Dmitry Kurochkin
wrote:
> -1
Which puts me back to 0 :-(
> One particular issue with your patch is that it adds (incorrect) charset
> parameter to plain/text parts which are converted to UTF-8 in JSON
> output.
Patches that break things should obviously not
On Wed, 11 Jan 2012 23:13:44 -0500, Austin Clements wrote:
> This is important to fix, but this solution seems needlessly
> roundabout. What about using an after-advice and simply delq'ing
> whatever the offending hook is? That wouldn't even need a version
> check.
delq could work -- thanks for
Hi Adam.
On Mon, 9 Jan 2012 19:10:48 -0700, Adam Wolfe Gordon wrote:
> Hi David,
>
> Thanks for the review. Most of the things you've suggested are easy
> changes, and I think obvious improvements, so I'll change them for the
> next version. A bit of discussion on the more involved things belo
On Wed, 11 Jan 2012 16:15:30 -0500, Aaron Ecay wrote:
> On Wed, 11 Jan 2012 08:20:56 +, David Edmondson wrote:
> > On Tue, 10 Jan 2012 21:54:02 +0200, Jani Nikula wrote:
> > > -(defun notmuch-mua-reply (query-string &optional sender)
> > > +(defun notmuch-mua-reply (query-string &optional se
101 - 136 of 136 matches
Mail list logo
