Re: [PATCH v4 2/9] parse-time-string: add a date/time parser to notmuch

On Mon, 15 Oct 2012, Ethan Glasser-Camp ethan.glasser.c...@gmail.com wrote: +/* Parse a previously postponed number if one exists. */ +static int parse_postponed_number (struct state *state, int v, int n, char d); +static int +handle_postponed_number (struct state *state, enum field

[PATCH] notmuch compact support

Here is a new spin of my patchset introduced in late August (id:1345476704-17091-1-git-send-email-bgamari.f...@gmail.com) adding a compact command to libnotmuch and the command line frontend. I believe the concerns raised in August have been addressed, but correct me if I'm wrong. Cheers, - Ben

[PATCH 3/3] Add notmuch compact command

--- Makefile.local|1 + notmuch-client.h |3 +++ notmuch-compact.c | 43 +++ notmuch.c |3 +++ 4 files changed, 50 insertions(+) create mode 100644 notmuch-compact.c diff --git a/Makefile.local b/Makefile.local index

[PATCH 2/3] Produce status messages during compacting

--- lib/database.cc | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 6e83a61..49aa36d 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -780,11 +780,24 @@ notmuch_database_close (notmuch_database_t *notmuch)

Re: [PATCH 1/2] Add notmuch_database_flush method

Adrien Bustany adr...@bustany.org writes: This method explicitly flushes the pending modifications to disk. It is useful if your program has various threads, each with a read only DB and one writer thread with a read/write DB. In that case, you most likely want the writer to sync the changes

Re: [PATCH 1/3] Add notmuch_database_close_compact

Hi Ben - I'd like some meaningful commit messages here. Please find other comments inline. BR, Jani. On Wed, 17 Oct 2012, Ben Gamari bgamari.f...@gmail.com wrote: --- configure | 21 - lib/database.cc | 54 ++

Re: [PATCH 2/3] Produce status messages during compacting

Again, a commit message saying *why* having a flood of status messages is a good idea would be appreciated. I'm not sure it is a good idea. On Wed, 17 Oct 2012, Ben Gamari bgamari.f...@gmail.com wrote: --- lib/database.cc | 15 ++- 1 file changed, 14 insertions(+), 1

Re: [PATCH 3/3] Add notmuch compact command

Nag nag nag: Commit message. ;) The custom is to have a man page for each notmuch cli command. Small nitpicks below. BR, Jani. On Wed, 17 Oct 2012, Ben Gamari bgamari.f...@gmail.com wrote: --- Makefile.local|1 + notmuch-client.h |3 +++ notmuch-compact.c | 43

Re: [PATCH 1/2] Add notmuch_database_flush method

Le 17/10/2012 18:53, Ethan Glasser-Camp a écrit : Adrien Bustany adr...@bustany.org writes: This method explicitly flushes the pending modifications to disk. It is useful if your program has various threads, each with a read only DB and one writer thread with a read/write DB. In that case, you

[PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t

The code of the patches in unchanged, but the formatting issues are now hopefully fixed. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/2] Add notmuch_database_flush method

This method explicitly flushes the pending modifications to disk. It is useful if your program has various threads, each with a read only DB and one writer thread with a read/write DB. In that case, you most likely want the writer to sync the changes to disk so that the readers can see them,

[PATCH 2/2] Add notmuch_database_reopen method

Calling notmuch_database_reopen is needed to refresh the database contents when the database on disk was modified by another notmuch_database_t instance, for example in a different thread. --- lib/database.cc | 17 + lib/notmuch.h | 8 2 files changed, 25 insertions(+)

[PATCH 1/3] test: emacs: toggle eliding of non-matching messages in `notmuch-show'

From: Pieter Praet pie...@praet.org See commits 44a544ed, 866ce8b1, 668b66ec. Signed-off-by: Ethan Glasser-Camp et...@betacantrips.com --- I am embarrassed to admit I didn't try to apply these patches before I removed the needs-review tag. This one didn't apply. Here's the trivial fix. The tests

Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers'

Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes: This patch, and its predecessors, all look great to me. But a note: many of the first lines in your commit messages ({show, hide} message headers) contain tabs. I hate tabs. Is this intentional? I have noticed it on other patches you've

[PATCH] test: Move tests from emacs to emacs-show

This requires changing the contents of the crypto tests, as one thread that was marked read by the earlier tests in test/emacs is no longer marked read. This moves tests for: - 09d19ac test: emacs: toggle eliding of non-matching messages in `notmuch-show', which should have actually read:

Re: [PATCH] test: handle filenames that have directories in them

On Fri, Oct 12 2012, Ethan Glasser-Camp ethan.glasser.c...@gmail.com wrote: Since $TEST_DIRECTORY is an absolute path, any filenames generated with it will be complete paths. Only use the basename to generate suffixes for filenames. Signed-off-by: Ethan Glasser-Camp et...@betacantrips.com

[PATCH v4 2/9] parse-time-string: add a date/time parser to notmuch

On Mon, 15 Oct 2012, Ethan Glasser-Camp wrote: >> +/* Parse a previously postponed number if one exists. */ >> +static int parse_postponed_number (struct state *state, int v, int n, char >> d); >> +static int >> +handle_postponed_number (struct state *state, enum field next_field) >> +{ >> +

[PATCH] notmuch compact support

Here is a new spin of my patchset introduced in late August (id:"1345476704-17091-1-git-send-email-bgamari.foss at gmail.com") adding a compact command to libnotmuch and the command line frontend. I believe the concerns raised in August have been addressed, but correct me if I'm wrong. Cheers,

[PATCH 2/3] Produce status messages during compacting

--- lib/database.cc | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 6e83a61..49aa36d 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -780,11 +780,24 @@ notmuch_database_close (notmuch_database_t *notmuch)

[PATCH 1/3] Add notmuch_database_close_compact

--- configure | 21 - lib/database.cc | 54 ++ lib/notmuch.h | 14 ++ 3 files changed, 88 insertions(+), 1 deletion(-) diff --git a/configure b/configure index acb90a8..6551b13 100755 ---

[PATCH 3/3] Add notmuch compact command

--- Makefile.local|1 + notmuch-client.h |3 +++ notmuch-compact.c | 43 +++ notmuch.c |3 +++ 4 files changed, 50 insertions(+) create mode 100644 notmuch-compact.c diff --git a/Makefile.local b/Makefile.local index

[PATCH 1/2] Add notmuch_database_flush method

Adrien Bustany writes: > This method explicitly flushes the pending modifications to disk. It is > useful if your program has various threads, each with a read only DB and > one writer thread with a read/write DB. In that case, you most likely > want the writer to sync the changes to disk so

[PATCH 1/3] Add notmuch_database_close_compact

Hi Ben - I'd like some meaningful commit messages here. Please find other comments inline. BR, Jani. On Wed, 17 Oct 2012, Ben Gamari wrote: > --- > configure | 21 - > lib/database.cc | 54 ++ > lib/notmuch.h

[PATCH 2/3] Produce status messages during compacting

Again, a commit message saying *why* having a flood of status messages is a good idea would be appreciated. I'm not sure it is a good idea. On Wed, 17 Oct 2012, Ben Gamari wrote: > --- > lib/database.cc | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git

[PATCH 3/3] Add notmuch compact command

Nag nag nag: Commit message. ;) The custom is to have a man page for each notmuch cli command. Small nitpicks below. BR, Jani. On Wed, 17 Oct 2012, Ben Gamari wrote: > --- > Makefile.local|1 + > notmuch-client.h |3 +++ > notmuch-compact.c | 43

[PATCH 1/3] test: emacs: toggle eliding of non-matching messages in `notmuch-show'

From: Pieter Praet See commits 44a544ed, 866ce8b1, 668b66ec. Signed-off-by: Ethan Glasser-Camp --- I am embarrassed to admit I didn't try to apply these patches before I removed the needs-review tag. This one didn't apply. Here's the trivial fix. The tests are still placed at

[PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers'

Ethan Glasser-Camp writes: > This patch, and its predecessors, all look great to me. But a note: many of the first lines in your commit messages ("{show, hide} message headers") contain tabs. I hate tabs. Is this intentional? I have noticed it on other patches you've sent (such as

[PATCH v8 0/8] reworked crypto toggle, plus a few other toggles

Ethan Glasser-Camp writes: > Pieter Praet writes: > >> Great work! >> >> Here's some tests. > > Hi! These look fine to me. With Mark's review > (id:"87k41e45hi.fsf at qmul.ac.uk"), I'm removing the needs-review tag. Tests pushed (with Ethan's rebased version of the first patch) d

[PATCH] test: Move tests from emacs to emacs-show

This requires changing the contents of the crypto tests, as one thread that was marked read by the earlier tests in test/emacs is no longer marked read. This moves tests for: - 09d19ac "test: emacs: toggle eliding of non-matching messages in `notmuch-show'", which should have actually read: