Adrien Bustany writes:
> This makes notmuch appropriately free the underlying notmuch C objects
> when garbage collecting their Go wrappers. To make sure we don't break
> the underlying links between objects (for example, a notmuch_messages_t
> being GC'ed before a notmuch_message_t belonging to
ccx at webprojekty.cz writes:
> Hello, for quite some time my set of scripts just lied in my repo and
> waited for polish before release. So tonight I finally managed to update
> the docs, remove old stuff, rewrite some unfortunate things etc.
>
> One notable addition is slrn2maildir script which
Adrien Bustany writes:
> The code of the patches in unchanged, but the formatting issues are now
> hopefully fixed.
These look fine to me, and they're pretty trivial.
Ethan
Peter Wang writes:
> Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can
> cover all four values of search --exclude in the cli.
This series looks good to me. It's a nice clean up and a nice new
feature. Patches all apply.
However, I'm getting test failures like:
FAIL Search, exclu
Adrien Bustany writes:
> This makes notmuch appropriately free the underlying notmuch C objects
> when garbage collecting their Go wrappers. To make sure we don't break
> the underlying links between objects (for example, a notmuch_messages_t
> being GC'ed before a notmuch_message_t belonging to
c...@webprojekty.cz writes:
> Hello, for quite some time my set of scripts just lied in my repo and
> waited for polish before release. So tonight I finally managed to update
> the docs, remove old stuff, rewrite some unfortunate things etc.
>
> One notable addition is slrn2maildir script which ca
Adrien Bustany writes:
> The code of the patches in unchanged, but the formatting issues are now
> hopefully fixed.
These look fine to me, and they're pretty trivial.
Ethan
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailma
On Thu, Oct 18 2012, Ethan wrote:
> On Thu, Oct 18, 2012 at 5:50 AM, Tomi Ollila wrote:
>
>> On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
>>
>> > Ethan Glasser-Camp writes:
>> >
>> >> This patch, and its predecessors, all look great to me.
>> >
>> > But a note: many of the first lines in your
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
> This requires changing the contents of the crypto tests, as one thread
> that was marked read by the earlier tests in test/emacs is no longer
> marked read.
>
> This moves tests for:
>
> - 09d19ac "test: emacs: toggle eliding of non-matching message
On Fri, Oct 12 2012, Ethan Glasser-Camp wrote:
> Dmitry Kurochkin writes:
>
>> Actually, we can do both: check file name for consistent diff order
>> (from expected to actual) and use file names that the caller provides.
>
> Hi! Reviewing the patch queue a little bit here. It seems like this
> pa
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
> Ethan Glasser-Camp writes:
>
>> This patch, and its predecessors, all look great to me.
>
> But a note: many of the first lines in your commit messages ("{show,
Hmm, first lines -- IIRC mailman adds those tabs to the subject line -- and
those are
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
> Ethan Glasser-Camp writes:
>
>> This patch, and its predecessors, all look great to me.
>
> But a note: many of the first lines in your commit messages ("{show,
> hide} message headers") contain tabs. I hate tabs. Is this intentional?
> I have noti
On Wed, Oct 17 2012, Ben Gamari wrote:
> ---
> configure | 21 -
> lib/database.cc | 54 ++
> lib/notmuch.h | 14 ++
> 3 files changed, 88 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/c
.launchpad.net/mailman/+bug/265915
I guess I can stop complaining about it ;) Patches 1-3 are probably ready
then. Thanks, Tomi.
Ethan
-- next part --
An HTML attachment was scrubbed...
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20121018/291cc76a/attachment.html>
On Wed, Oct 17 2012, Jani Nikula wrote:
> Nag nag nag: Commit message. ;)
>
> The custom is to have a man page for each notmuch cli command.
>
> Small nitpicks below.
>
>
> BR,
> Jani.
>
>
> On Wed, 17 Oct 2012, Ben Gamari wrote:
>> ---
>> Makefile.local|1 +
>> notmuch-client.h |3
Ethan Glasser-Camp writes:
> Since $TEST_DIRECTORY is an absolute path, any filenames generated
> with it will be complete paths. Only use the basename to generate
> suffixes for filenames.
pushed.
d
Ethan Glasser-Camp writes:
> This requires changing the contents of the crypto tests, as one thread
> that was marked read by the earlier tests in test/emacs is no longer
> marked read.
pushed.
d
On Fri, Oct 12 2012, Ethan Glasser-Camp wrote:
> Since $TEST_DIRECTORY is an absolute path, any filenames generated
> with it will be complete paths. Only use the basename to generate
> suffixes for filenames.
>
> Signed-off-by: Ethan Glasser-Camp
> ---
> Discovered this while reviewing the patc
On Thu, Oct 18 2012, Ethan wrote:
> On Thu, Oct 18, 2012 at 5:50 AM, Tomi Ollila wrote:
>
>> On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
>>
>> > Ethan Glasser-Camp writes:
>> >
>> >> This patch, and its predecessors, all look great to me.
>> >
>> > But a note: many of the first lines in your
On Thu, Oct 18, 2012 at 5:50 AM, Tomi Ollila wrote:
> On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
>
> > Ethan Glasser-Camp writes:
> >
> >> This patch, and its predecessors, all look great to me.
> >
> > But a note: many of the first lines in your commit messages ("{show,
>
> Hmm, first lines
Ethan Glasser-Camp writes:
> Since $TEST_DIRECTORY is an absolute path, any filenames generated
> with it will be complete paths. Only use the basename to generate
> suffixes for filenames.
pushed.
d
___
notmuch mailing list
notmuch@notmuchmail.org
ht
Ethan Glasser-Camp writes:
> This requires changing the contents of the crypto tests, as one thread
> that was marked read by the earlier tests in test/emacs is no longer
> marked read.
pushed.
d
___
notmuch mailing list
notmuch@notmuchmail.org
http:/
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
> This requires changing the contents of the crypto tests, as one thread
> that was marked read by the earlier tests in test/emacs is no longer
> marked read.
>
> This moves tests for:
>
> - 09d19ac "test: emacs: toggle eliding of non-matching message
On Fri, Oct 12 2012, Ethan Glasser-Camp wrote:
> Dmitry Kurochkin writes:
>
>> Actually, we can do both: check file name for consistent diff order
>> (from expected to actual) and use file names that the caller provides.
>
> Hi! Reviewing the patch queue a little bit here. It seems like this
> pa
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
> Ethan Glasser-Camp writes:
>
>> This patch, and its predecessors, all look great to me.
>
> But a note: many of the first lines in your commit messages ("{show,
Hmm, first lines -- IIRC mailman adds those tabs to the subject line -- and
those are
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
> Ethan Glasser-Camp writes:
>
>> This patch, and its predecessors, all look great to me.
>
> But a note: many of the first lines in your commit messages ("{show,
> hide} message headers") contain tabs. I hate tabs. Is this intentional?
> I have noti
Calling notmuch_database_reopen is needed to refresh the database
contents when the database on disk was modified by another
notmuch_database_t instance, for example in a different thread.
---
lib/database.cc | 17 +
lib/notmuch.h | 8
2 files changed, 25 insertions(+)
This method explicitly flushes the pending modifications to disk. It is
useful if your program has various threads, each with a read only DB and
one writer thread with a read/write DB. In that case, you most likely
want the writer to sync the changes to disk so that the readers can see
them, withou
The code of the patches in unchanged, but the formatting issues are now
hopefully fixed.
Le 17/10/2012 18:53, Ethan Glasser-Camp a ?crit :
> Adrien Bustany writes:
>
>> This method explicitly flushes the pending modifications to disk. It is
>> useful if your program has various threads, each with a read only DB and
>> one writer thread with a read/write DB. In that case, you most like
30 matches
Mail list logo
