Re: [PATCH 1/2] fix compilation without emacs

2013-11-19 Thread Tomi Ollila
On Tue, Nov 19 2013, Tomi Valkeinen tomi.valkei...@iki.fi wrote: If emacs is not installed, the following error is printed while compiling: /bin/sh: 1: emacs: not found This patch fixes the build. Tervetuloa notmuch-muutosten ihmeelliseen maailmaan ! It might be better to exclude the

Re: [PATCH 1/2] fix compilation without emacs

2013-11-19 Thread Tomi Valkeinen
On 2013-11-19 12:43, Tomi Ollila wrote: On Tue, Nov 19 2013, Tomi Valkeinen tomi.valkei...@iki.fi wrote: It might be better to exclude the whole emacs directory from build when compiling without emacs, but that's a bigger change. Well, that change would probably break my build: I configure

Re: notmuch-lib questions and observations

2013-11-19 Thread Jani Nikula
On Mon, 18 Nov 2013, Tomi Valkeinen tomi.valkei...@iki.fi wrote: Hi, I found out about notmuch quite recently, and now I've been tinkering with it, prototyping a GUI client. I have some questions and observations: Hello Tomi, glad you've found notmuch too! ;) Your mail would deserve a more

Re: notmuch-lib questions and observations

2013-11-19 Thread Tomi Valkeinen
On 2013-11-19 14:12, Jani Nikula wrote: On Mon, 18 Nov 2013, Tomi Valkeinen tomi.valkei...@iki.fi wrote: Hi, I found out about notmuch quite recently, and now I've been tinkering with it, prototyping a GUI client. I have some questions and observations: Hello Tomi, glad you've found

Re: notmuch-lib questions and observations

2013-11-19 Thread Jesse Rosenthal
Tomi Valkeinen tomi.valkei...@iki.fi writes: I think I wasn't very clear on what I meant. I was thinking about the behavior that graphical mail clients have: they periodically refresh the emails, showing new ones if there are any, and they'll show some icon or such which tells the user this

Re: [PATCH] emacs: do not put quoted reply in primary selection

2013-11-19 Thread David Bremner
Mark Walters markwalters1...@gmail.com writes: Anyway, this is the best I can manage! pushed, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v3 3/5] compact: preserve backup database until compacted database is in place

2013-11-19 Thread David Bremner
Tomi Ollila tomi.oll...@iki.fi writes: It is less error prone and window of failure opportunity is smaller if the old (backup) database is always renamed (instead of sometimes rmtree'd) before new (compacted) database is put into its place. Finally rmtree() old database in case old database

Re: [PATCH] NEWS: insert quotable parts in reply as they are displayed in show view

2013-11-19 Thread David Bremner
Jani Nikula j...@nikula.org writes: News for commit 5c19eb46a906819744a022463ee3fd7cdfaabbb9 Author: Jani Nikula j...@nikula.org Date: Sun Sep 1 20:59:53 2013 +0300 emacs: insert quotable parts in reply as they are displayed in show view --- pushed. d

[PATCH 1/2] fix compilation without emacs

2013-11-19 Thread Tomi Valkeinen
If emacs is not installed, the following error is printed while compiling: /bin/sh: 1: emacs: not found This patch fixes the build. It might be better to exclude the whole emacs directory from build when compiling without emacs, but that's a bigger change. Signed-off-by: Tomi Valkeinen ---

[PATCH 2/2] lib: fix error handling

2013-11-19 Thread Tomi Valkeinen
Currently if a Xapian exception happens in notmuch_message_get_header, the exception is not caught leading to crash. In notmuch_message_get_date the exception is caught, but an internal error is raised, again leading to crash. This patch fixes the error handling by making both functions catch the

[PATCH 1/2] fix compilation without emacs

2013-11-19 Thread Tomi Ollila
On Tue, Nov 19 2013, Tomi Valkeinen wrote: > If emacs is not installed, the following error is printed while > compiling: > > /bin/sh: 1: emacs: not found > > This patch fixes the build. Tervetuloa notmuch-muutosten ihmeelliseen maailmaan ! > It might be better to exclude the whole emacs

[PATCH 1/2] fix compilation without emacs

2013-11-19 Thread Tomi Valkeinen
d. Yep, that one also works for me. Tomi -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 901 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20131119/46711e8f/attachment.pgp>

notmuch-lib questions and observations

2013-11-19 Thread Jani Nikula
On Mon, 18 Nov 2013, Tomi Valkeinen wrote: > Hi, > > I found out about notmuch quite recently, and now I've been tinkering > with it, prototyping a GUI client. I have some questions and observations: Hello Tomi, glad you've found notmuch too! ;) Your mail would deserve a more thorough answer

notmuch-lib questions and observations

2013-11-19 Thread Tomi Valkeinen
ose, so > we could, at least in theory, switch from xapian to something else. I > don't know how feasible that would be though. I think Austin has > experimented with that. Ah, a valid point, I didn't think of that. Tomi -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 901 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20131119/69a841be/attachment.pgp>

notmuch-lib questions and observations

2013-11-19 Thread Jesse Rosenthal
Tomi Valkeinen writes: > I think I wasn't very clear on what I meant. I was thinking about the > behavior that graphical mail clients have: they periodically refresh the > emails, showing new ones if there are any, and they'll show some icon or > such which tells the user this email is "new"

[PATCH] NEWS: insert quotable parts in reply as they are displayed in show view

2013-11-19 Thread David Bremner
Jani Nikula writes: > News for > commit 5c19eb46a906819744a022463ee3fd7cdfaabbb9 > Author: Jani Nikula > Date: Sun Sep 1 20:59:53 2013 +0300 > > emacs: insert quotable parts in reply as they are displayed in show view > --- pushed. d

[PATCH] emacs: do not put quoted reply in primary selection

2013-11-19 Thread David Bremner
Mark Walters writes: > > Anyway, this is the best I can manage! > pushed, d

[PATCH v3 3/5] compact: preserve backup database until compacted database is in place

2013-11-19 Thread David Bremner
Tomi Ollila writes: > It is less error prone and window of failure opportunity is smaller > if the old (backup) database is always renamed (instead of sometimes > rmtree'd) before new (compacted) database is put into its place. > Finally rmtree() old database in case old database backup is not