Re: [PATCH] emacs: show: let the user override the mime-type of an attachment

2015-08-01 Thread David Bremner
Mark Walters markwalters1...@gmail.com writes: +(defun notmuch-show-internal-mm-display-part (handle) It's very much a quibble, but I don't understand the naming scheme here. Is internal meant to denote an privateish function? If so the convention of using -- (notmuch-show--mm-display-part, I

[PATCH 2/2] emacs: make modifications to message Fcc vars buffer-local

2015-08-01 Thread David Bremner
Previously we globally modified these variables, which tended to cause problems for people using message-mode, but not notmuch-mua-mail, to send mail. User visible changes: - calling notmuch-fcc-header-setup is no longer optional. OTOH, it seems to do the right thing if notmuch-fcc-dirs is set

[PATCH 1/2] emacs: define a notmuch-compose-mode based on message mode.

2015-08-01 Thread David Bremner
This is to provide a clean way of overriding e.g. keybindings when sending mail from notmuch. --- emacs/notmuch-mua.el | 4 1 file changed, 4 insertions(+) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index 33f1399..a7d3eaa 100644 --- a/emacs/notmuch-mua.el +++

Stop stomping on global fcc related variables

2015-08-01 Thread David Bremner
After several attempts [1] this is the best replacement for notmuch-fcc-initialization I could come up with. [1]: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21174 ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH 3/4] emacs: tree: add sort argument to notmuch-tree

2015-08-01 Thread David Bremner
Mark Walters writes: > + OPEN-TARGET: If TRUE open the target message in the message pane. > + OLDEST-FIRST: If TRUE display threads sorted oldest first" > + (interactive > + (list > +;; Prompt for a query > +nil > +;; use default search order > +nil nil nil nil

Stop stomping on global fcc related variables

2015-08-01 Thread David Bremner
After several attempts [1] this is the best replacement for notmuch-fcc-initialization I could come up with. [1]: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21174

[PATCH 2/2] emacs: make modifications to message Fcc vars buffer-local

2015-08-01 Thread David Bremner
Previously we globally modified these variables, which tended to cause problems for people using message-mode, but not notmuch-mua-mail, to send mail. User visible changes: - calling notmuch-fcc-header-setup is no longer optional. OTOH, it seems to do the right thing if notmuch-fcc-dirs is set

[PATCH 1/2] emacs: define a notmuch-compose-mode based on message mode.

2015-08-01 Thread David Bremner
This is to provide a clean way of overriding e.g. keybindings when sending mail from notmuch. --- emacs/notmuch-mua.el | 4 1 file changed, 4 insertions(+) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index 33f1399..a7d3eaa 100644 --- a/emacs/notmuch-mua.el +++

[PATCH] emacs: show: let the user override the mime-type of an attachment

2015-08-01 Thread David Bremner
Mark Walters writes: > +(defun notmuch-show-internal-mm-display-part (handle) It's very much a quibble, but I don't understand the naming scheme here. Is internal meant to denote an privateish function? If so the convention of using -- (notmuch-show--mm-display-part, I guess) seems more common