[PATCH] notmuch-tag: Allow using both --remove-all and --batch

2015-08-11 Thread Daniel Schoepe
Hi, I noticed that it makes sense to combine the --batch and --remove-all options to notmuch. This can be used, for instance, when synchronizing tags by transferring the tags for all changed mails. This series removes this (undocumented) restriction and adds some tests. Best regards, Daniel

[PATCH 2/2] test: Tests for combining --batch and --remove-all

2015-08-11 Thread Daniel Schoepe
This patch adds some tests for combining --remove-all with --batch or --input when calling notmuch-tag. --- test/T150-tagging.sh | 24 1 file changed, 24 insertions(+) diff --git a/test/T150-tagging.sh b/test/T150-tagging.sh index 821d393..19539dd 100755 ---

[PATCH 1/2] cli: Allow combining --remove-all and --batch

2015-08-11 Thread Daniel Schoepe
This patch removes the restriction on notmuch-tag that disallows using both --remove-all and --batch. Combining the two options removes tags on all messages affected by each query before applying the new tags. --- notmuch-tag.c | 4 1 file changed, 4 deletions(-) diff --git a/notmuch-tag.c

Change test to use empty tag modifications

2015-08-11 Thread Daniel Schoepe
As Jani pointed out, having a test checking the functionality with an empty line of tag modification makes more sense than having two tests with non-empty tags, so here's a fixed version of the preceding patch. Best regards, Daniel ___ notmuch mailing

[PATCH] test: Tests for combining --batch and --remove-all

2015-08-11 Thread Daniel Schoepe
This patch adds some tests for combining --remove-all with --batch or --input when calling notmuch-tag. --- test/T150-tagging.sh | 25 + 1 file changed, 25 insertions(+) diff --git a/test/T150-tagging.sh b/test/T150-tagging.sh index 821d393..8adcabc 100755 ---

[PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro

2015-08-11 Thread Tomi Ollila
Some compilers (older than gcc 4.5 and clang 2.9) do support __attribute__ ((deprecated)) but not __attribute__ ((deprecated(message))). Check (clang) and know (gcc) which versions support which variants and make two definitions of define NOTMUCH_DEPRECATED macro; one with and and one without the

Re: [PATCH 3/5] cli/count: add --output=modifications

2015-08-11 Thread David Bremner
Tomi Ollila tomi.oll...@iki.fi writes: Currently, `notmuch count` outputs lines that contain just one integer; this changes this by introducing output with uuid ([0-9a-f-]) and integer delimited by tab character. To put it lightly, this looks inconsistent and don't please my aesthetic eye.

Re: [PATCH 3/5] cli/count: add --output=modifications

2015-08-11 Thread Tomi Ollila
On Tue, Aug 11 2015, David Bremner da...@tethera.net wrote: Tomi Ollila tomi.oll...@iki.fi writes: Currently, `notmuch count` outputs lines that contain just one integer; this changes this by introducing output with uuid ([0-9a-f-]) and integer delimited by tab character. To put it

[PATCH] notmuch-tag: Allow using both --remove-all and --batch

2015-08-11 Thread Daniel Schoepe
Hi, I noticed that it makes sense to combine the --batch and --remove-all options to notmuch. This can be used, for instance, when synchronizing tags by transferring the tags for all changed mails. This series removes this (undocumented) restriction and adds some tests. Best regards, Daniel

[PATCH 1/2] cli: Allow combining --remove-all and --batch

2015-08-11 Thread Daniel Schoepe
This patch removes the restriction on notmuch-tag that disallows using both --remove-all and --batch. Combining the two options removes tags on all messages affected by each query before applying the new tags. --- notmuch-tag.c | 4 1 file changed, 4 deletions(-) diff --git a/notmuch-tag.c

[PATCH 2/2] test: Tests for combining --batch and --remove-all

2015-08-11 Thread Daniel Schoepe
This patch adds some tests for combining --remove-all with --batch or --input when calling notmuch-tag. --- test/T150-tagging.sh | 24 1 file changed, 24 insertions(+) diff --git a/test/T150-tagging.sh b/test/T150-tagging.sh index 821d393..19539dd 100755 ---

Change test to use empty tag modifications

2015-08-11 Thread Daniel Schoepe
As Jani pointed out, having a test checking the functionality with an empty line of tag modification makes more sense than having two tests with non-empty tags, so here's a fixed version of the preceding patch. Best regards, Daniel

[PATCH] test: Tests for combining --batch and --remove-all

2015-08-11 Thread Daniel Schoepe
This patch adds some tests for combining --remove-all with --batch or --input when calling notmuch-tag. --- test/T150-tagging.sh | 25 + 1 file changed, 25 insertions(+) diff --git a/test/T150-tagging.sh b/test/T150-tagging.sh index 821d393..8adcabc 100755 ---

[PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro

2015-08-11 Thread Tomi Ollila
Some compilers (older than gcc 4.5 and clang 2.9) do support __attribute__ ((deprecated)) but not __attribute__ ((deprecated("message"))). Check (clang) and know (gcc) which versions support which variants and make two definitions of define NOTMUCH_DEPRECATED macro; one with and and one without

[PATCH 3/5] cli/count: add --output=modifications

2015-08-11 Thread David Bremner
Tomi Ollila writes: > Currently, `notmuch count` outputs lines that contain just one integer; > this changes this by introducing output with uuid ([0-9a-f-]) and integer > delimited by tab character. > > To put it lightly, this looks "inconsistent" and don't please my aesthetic > eye. > > One