Re: [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

2019-06-10 Thread Ralph Seichter
* Daniel Kahn Gillmor: > Perhaps Ralph Seichter (explicitly cc'ed above) could comment on how > it'll affect homebrew? MacPorts, actually. ;-) I have not yet been able to look into this patch series, but I hope to be able to do so soonish. -Ralph ___

[PATCH 1/2] doc: don't build notmuch-emacs.info for configure --without-emacs

2019-06-10 Thread David Bremner
Since the docstrings are not built in the case of --without-emacs, even if emacs is detected, don't let sphinx build the emacs docs. This avoids a large number of error messages due to missing includes. It's actually a bit surprising sphinx doesn't generate an error for the missing include files.

[PATCH 2/2] doc: Don't install emacs docs when they are not built

2019-06-10 Thread David Bremner
In 40b025 we stopped building the notmuch-emacs documentation if HAVE_EMACS=0 (i.e. no emacs was detected by configure). Unfortunately we continued to try to install the (non-existent) documentation, which causes build/install failures. As a bonus, we also avoid installing the documentation if

Re: [PATCH] doc: Don't install emacs docs when they are not built

2019-06-10 Thread David Bremner
Tomi Ollila writes: > > Interestingly, in your commit message you mention that changing := to = > makes a difference. I would have thought that assigning INFO_INFO_FILES > with := would have expanded INFO_TEXI_FILES just 2 lines below after > its introduction. Ah. Silly me. The non-working

Re: Ye olde Apple mktemp

2019-06-10 Thread Ralph Seichter
* Ralph Seichter: > The following local patch solves the issue for me [...] Well, it does solve the mktemp call failing due to a missing parameter. There is however additional fun [1] to be had once mktemp succeeds: -snip- Checking for GMime session key extraction support... gpg: can't

Re: [PATCH] doc: Don't install emacs docs when they are not built

2019-06-10 Thread Tomi Ollila
On Mon, Jun 10 2019, David Bremner wrote: > In 40b025 we stopped building the notmuch-emacs documentation if > HAVE_EMACS=0 (i.e. no emacs was detected by configure). Unfortunately > we continued to try to install the (non-existent) documentation, which > causes build/install failures. > > As a

[PATCH] doc: Don't install emacs docs when they are not built

2019-06-10 Thread David Bremner
In 40b025 we stopped building the notmuch-emacs documentation if HAVE_EMACS=0 (i.e. no emacs was detected by configure). Unfortunately we continued to try to install the (non-existent) documentation, which causes build/install failures. As a bonus, we also avoid installing the documentation if

[PATCH v2 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

2019-06-10 Thread Daniel Kahn Gillmor
From: David Bremner This removes the dependency of this test script on gdb, and considerably speeds up the running of the tests. --- dkg cleaned up the placement of gen_insert_msg, and used printf's %q to handle the perverse case where $gen_msg_filename happens to have a U+0022 QUOTATION MARK

Re: notmuch vim failing to show rfc822 attachments

2019-06-10 Thread Daniel Kahn Gillmor
Hi Kay-- On Tue 2019-05-07 01:51:50 +0200, Kay wrote: > I've recently switched to using notmuch for mail management and I like > it so far. The only thing stopping me from full joy is that neither alot > nor the notmuch vim frontend can display message/rfc822 attachments. that sounds

[PATCH] fix misspelling

2019-06-10 Thread Daniel Kahn Gillmor
Signed-off-by: Daniel Kahn Gillmor --- lib/messages.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/messages.c b/lib/messages.c index 04fa19f8..7ddfaf26 100644 --- a/lib/messages.c +++ b/lib/messages.c @@ -117,7 +117,7 @@ _notmuch_messages_has_next (notmuch_messages_t

Re: [PATCH] python: bind add_property/remove_property and related methods

2019-06-10 Thread Daniel Kahn Gillmor
Hi VA-- On Sat 2019-06-08 17:37:10 +0200, VA wrote: > These methods were simply missing from the Python bindings. > From 47dcf1659377f1ec8a237fbe474a5412123d0aa1 Mon Sep 17 00:00:00 2001 > From: hydrargyrum > Date: Sun, 27 Jan 2019 09:43:57 +0100 > Subject: [PATCH] python: bind

[PATCH 1/2] debian: bump Standards-Version to 4.3.0 (no changes needed)

2019-06-10 Thread Daniel Kahn Gillmor
/usr/share/doc/debian-policy/upgrading-checklist.txt.gz suggests that notmuch is already compliant with debian-policy 4.3.0. Signed-off-by: Daniel Kahn Gillmor --- debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/control b/debian/control index

Re: [PATCH] append _unused to the expression defined using unused() macro

2019-06-10 Thread Daniel Kahn Gillmor
On Thu 2019-05-30 22:56:14 +0300, Tomi Ollila wrote: > This way if variables defined using unused() macro are actually > used then code will not compile... > > - removed unused usage around one argc and one argv since those > were used > > - changed one unused (char *argv[]) to unused (char

Re: STYLE and uncrustify

2019-06-10 Thread Daniel Kahn Gillmor
Hi Bremner-- Thanks for doing this kind of cleanup work. Long-term consistency is worth the short-term pain. The main short-term pain comes from dealing with changes that are in-flight. As someone with a couple of series that are in flight, of course i'd prefer that you merge my changes first,

Re: Cycle-expand all org-style in show-mode and search all

2019-06-10 Thread Daniel Kahn Gillmor
Hi Pierre-- sorry for the delay in responding here, i'd missed this proposal when it came in! I *think* what you're trying to do here is, when reading a thread in emacs' notmuch-show mode, you want to use "C-s" (I-search?) to find whatever you're searching for in the folded messages as well as

Re: [PATCH] test: aggregate-results.sh: consistent style. zero forks.

2019-06-10 Thread Daniel Kahn Gillmor
On Tue 2019-06-04 22:46:24 +0300, Tomi Ollila wrote: > - all variables in $((...)) without leading $ > - all comparisons use -gt, -eq or -ne > - no -a nor -o inside [ ... ] expressions > - all indentation levels using one tab > > Dropped unnecessary empty string check when reading results files. >

Re: [WIP PATCH] test: make test-serially to run test serially

2019-06-10 Thread Daniel Kahn Gillmor
On Wed 2019-05-08 19:46:25 +0300, Tomi Ollila wrote: > This is easier and less error prone than mistyping NOTMUCH_TEST_SERIALIZE > manually from command line (mistype make test-serially and it just doesn't > work) > --- > > quick first version. this works, but someone(tm) w/ native english

Re: [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

2019-06-10 Thread Daniel Kahn Gillmor
On Sun 2019-05-26 10:08:54 -0300, David Bremner wrote: > This removes the dependency of this test script on gdb, and > considerably speeds up the running of the tests. This series looks good to me. I've tested it with moreutils parallel installed, and it reduces total CPU time for the parallel

Re: [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

2019-06-10 Thread Daniel Kahn Gillmor
One more nit-pick: On Sun 2019-05-26 10:08:54 -0300, David Bremner wrote: > +test_expect_code 0 "notmuch_with_shim shim-$code insert --keep < > \"$gen_msg_filename\"" This kind of business breaks obscurely if $gen_msg_filename happens to have U+0022 QUOTATION MARK in it. That's a pretty

[PATCH] debian: enable build hardening features

2019-06-10 Thread Daniel Kahn Gillmor
Debian's build hardening toolchain options produce binary artifacts that are more resistant to compromise. The most visible change for notmuch today is likely to be the addition of the "bindnow" linker flag, which contributes to making the "Global Offset Table" fully read-only. See

[PATCH 2/2] debian: Add appropriate substitution variables to debian/control

2019-06-10 Thread Daniel Kahn Gillmor
Without this change, dh_gencontrol emits: dpkg-gencontrol: warning: package python-notmuch: substitution variable ${python:Provides} unused, but is defined dpkg-gencontrol: warning: package python-notmuch: substitution variable ${python:Versions} unused, but is defined dpkg-gencontrol: warning:

[PATCH] emacs: add keywords to notmuch-emacs-mua.desktop

2019-06-10 Thread Daniel Kahn Gillmor
Debian's lintian has an informational alert desktop-entry-lacks-keywords-entry, which recommends including Keywords= in a .desktop file. I dug around a bit in /usr/share/applications/*.desktop to make sure that we covered the range of keywords other e-mail applications are using. If anyone has

Re: [BUG] emacs: notmuch-mua-attachment-check finds triggering string inside forwarded messages

2019-06-10 Thread Daniel Kahn Gillmor
On Wed 2019-05-08 19:19:18 +0200, Örjan Ekeberg wrote: > I have found what seems to be a bug, or at least a misbehaviour of the > "missing attachment warning" implemented by the otherwise so nice > notmuch-mua-attachment-check. > > It works fine to detect the regexp for attachments in simple

Re: [emacs] Auto-rotate pictures

2019-06-10 Thread Daniel Kahn Gillmor
Hi Pierre-- On Wed 2019-04-03 11:10:54 +0200, Pierre Neidhardt wrote: > Some pictures embed "exif" metadata with autorotate information. > I know that mu4e can autorotate inlined pictures. > I guess it wouldn't be too hard to implement this for Emacs Notmuch > either. If you have pointers to

Re: [PATCH] python: bind add_property/remove_property and related methods

2019-06-10 Thread VA
Le 09/06/2019 à 21:58, Daniel Kahn Gillmor a écrit : We do expose this functionality in the library, so it's not the end of the world to expose it in the python bindings, but i do worry a little bit about encouraging people to fiddle with markers set by the indexer. Conflicts could be easily

Re: [PATCH] fix misspelling

2019-06-10 Thread Tomi Ollila
On Mon, Jun 10 2019, Daniel Kahn Gillmor wrote: > Signed-off-by: Daniel Kahn Gillmor > --- > lib/messages.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/messages.c b/lib/messages.c > index 04fa19f8..7ddfaf26 100644 > --- a/lib/messages.c > +++ b/lib/messages.c >

Ye olde Apple mktemp

2019-06-10 Thread Ralph Seichter
Another quirk that occurs during the configuration phase on older macOS versions (when they were still called OS X, actually) in the MacPorts build farm: Checking for GMime session key extraction support... usage: mktemp [-d] [-q] [-t prefix] [-u] template ... mktemp [-d] [-q] [-u]

[PATCH V2] test: aggregate-results.sh: consistent style. zero forks.

2019-06-10 Thread Tomi Ollila
- all variables in $((...)) without leading $ - all comparisons use -gt, -eq or -ne - no -a nor -o inside [ ... ] expressions - all indentation levels using one tab Dropped unnecessary empty string check when reading results files. Replaced pluralize() which was executed in subshell with

Re: Ye olde Apple mktemp

2019-06-10 Thread Tomi Ollila
On Mon, Jun 10 2019, Ralph Seichter wrote: > Another quirk that occurs during the configuration phase on older macOS > versions (when they were still called OS X, actually) in the MacPorts > build farm: > > Checking for GMime session key extraction support... > usage: mktemp [-d] [-q] [-t