[PATCH v2] Free the results of scandir()

2012-02-06 Thread Ethan Glasser-Camp
From: Ethan Glasser-Camp scandir() returns "strings allocated via malloc(3)" which are then "collected in array namelist which is allocated via malloc(3)". Currently we just free the array namelist. Instead, free all the entries of namelist, and then free namelist. entry only points to elements

[PATCH v2] emacs: Leave blank subjects alone by default.

2012-02-06 Thread David Edmondson
Add `notmuch-blank-subject' to control how empty or whitespace only subjects are treated. The default behaviour is to leave them alone. The user can choose a string to use as a replacement. Modify code that cannot handle blank subjects to use a fixed string. --- Fix the non-string subject case (a

[PATCH v2 3/3] cli: reach previously unreachable cleanup code in "notmuch show"

2012-02-06 Thread Jani Nikula
The last lines of notmuch_show_command() function were unreachable. Fix it by using a variable for return value. Signed-off-by: Jani Nikula --- notmuch-show.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index b358278..c8fbd79 10

[PATCH v2 2/3] cli: convert "notmuch show" to use the new argument parser

2012-02-06 Thread Jani Nikula
Use the new notmuch argument parser to handle arguments in "notmuch show". There are three minor functional changes: 1) Also set params.raw = TRUE when defaulting to raw format when part is requested but format is not specified. This was a bug, and --part=0 without --format=raw did not work

[PATCH v2 1/3] cli: use notmuch_bool_t for boolean fields in notmuch_show_params_t

2012-02-06 Thread Jani Nikula
Use notmuch_bool_t instead of int for entire_thread, raw, and decrypt boolean fields in notmuch_show_params_t. No functional changes. Signed-off-by: Jani Nikula --- notmuch-client.h |6 +++--- notmuch-reply.c |7 +++ notmuch-show.c | 14 +++--- 3 files changed, 13 insert

[PATCH 0/3] notmuch show argument parsing

2012-02-06 Thread Jani Nikula
Hi all, v2 addressing Austin's comments in id:"20120206041205.GP10898 at mit.edu". Separate the bool cleanup into a new patch, cleaning up notmuch reply while at it. No functional changes since v1. For reviewing convenience, the diff between v1 and v2 is at the end of this cover letter. BR, Jan

[PATCH] emacs: Leave blank subjects alone by default.

2012-02-06 Thread David Edmondson
Add `notmuch-blank-subject' to control how empty or whitespace only subjects are treated. The default behaviour is to leave them alone. The user can choose a string to use as a replacement. Modify code that cannot handle blank subjects to use a fixed string. --- emacs/notmuch-lib.el | 20

[PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-02-06 Thread David Edmondson
/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120206/343aa34f/attachment-0001.pgp>

[PATCH] Free the results of scandir()

2012-02-06 Thread Ethan Glasser-Camp
From: Ethan Glasser-Camp scandir() returns "strings allocated via malloc(3)" which are then "collected in array namelist which is allocated via malloc(3)". Currently we just free the array namelist. Instead, free all the entries of namelist, and then free namelist. entry only points to elements

[PATCH v2 1/2] emacs: Use text properties rather than overlays in `notmuch-show-mode'.

2012-02-06 Thread David Edmondson
hmail.org/pipermail/notmuch/attachments/20120206/49a838ee/attachment.pgp>

[PATCH 0/3] notmuch show argument parsing

2012-02-06 Thread Austin Clements
Quoth Jani Nikula on Feb 06 at 9:57 pm: > Hi all, > > v2 addressing Austin's comments in id:"20120206041205.GP10898 at mit.edu". > Separate the bool cleanup into a new patch, cleaning up notmuch reply > while at it. No functional changes since v1. LGTM. (Heads up: I never received patch 1/3, t

[PATCH v2 2/2] test: Update test to match previous patch.

2012-02-06 Thread David Edmondson
Indentation now uses tabs where possible. --- ...hread-maildir-storage-with-fourfold-indentation |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation b/test/emacs.expected-output/

[PATCH v2 1/2] emacs: Use text properties rather than overlays in `notmuch-show-mode'.

2012-02-06 Thread David Edmondson
Except for where invisibility is involved, replace the use of overlays in `notmuch-show-mode' with text properties, which are more efficient and can be merged together more effectively. --- emacs/notmuch-show.el | 66 +++- emacs/notmuch-wash.el |8

[PATCH v2 0/2] emacs: Use text properties rather than overlays in `notmuch-show-mode'.

2012-02-06 Thread David Edmondson
v2: - simple rebase. David Edmondson (2): emacs: Use text properties rather than overlays in `notmuch-show-mode'. test: Update test to match previous patch. emacs/notmuch-show.el | 66 --- emacs/notmuch-wash.el |

[PATCH v3 3/3] emacs: Don't insert a part header if it's the first part and text/*.

2012-02-06 Thread David Edmondson
Previously this logic applied only to text/plain. Allow it for other text/* parts as well. --- emacs/notmuch-show.el |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index ce79762..c60e613 100644 --- a/emacs/notmuch-show

[PATCH v3 2/3] emacs: Optionally hide some part headers.

2012-02-06 Thread David Edmondson
Add a regexp, `notmuch-show-part-headers-hidden' and if the content-type of a part matches, don't show the part header. --- emacs/notmuch-show.el | 43 --- 1 files changed, 28 insertions(+), 15 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmu

[PATCH v3 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

2012-02-06 Thread David Edmondson
Instead, allow the caller to specify some parameters for the button. Rework `notmuch-show-insert-part-multipart/signed' and `notmuch-show-insert-part-multipart/encrypted' accordingly. --- emacs/notmuch-show.el | 86 +--- 1 files changed, 45 insertions(

[PATCH v2] emacs: Add more processing of displayed headers.

2012-02-06 Thread David Edmondson
Wrap headers to the width of the window and indent continuations. --- emacs/notmuch-show.el | 43 --- 1 files changed, 36 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 7469e2e..a589d37 100644 --- a/emacs/no

[PATCH v3 0/3] part header code tidying and options

2012-02-06 Thread David Edmondson
v3: - simple rebase. The previous version of this had 'LGTM' for each of the three parts. jrollins asked some questions, all of which were answered. David Edmondson (3): emacs: Don't return the button from `notmuch-show-insert-part-header'. emacs: Optionally hide some part headers. emac

[PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-02-06 Thread Antoine Beaupré
- Erich Fromm -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120206/9c13fe07/attachment.pgp>

Installation on Mac OS X Lion

2012-02-06 Thread Blake Sweeney
Quoting Saurabh Nanda (2012-02-05 03:27:38) >Hi, > >I'm trying to install notmuchmail on my Mac box, but have (obviously) >run into dependancy issues (Xapian, GMime, Glib, talloc). Has anyone >managed to install notmuchmail on Mac OS X? How painful is it? Is it >possible to have a binary packag

[PATCH v2] emacs: Leave blank subjects alone by default.

2012-02-06 Thread David Edmondson
Add `notmuch-blank-subject' to control how empty or whitespace only subjects are treated. The default behaviour is to leave them alone. The user can choose a string to use as a replacement. Modify code that cannot handle blank subjects to use a fixed string. --- Fix the non-string subject case (a

Re: [PATCH] Free the results of scandir()

2012-02-06 Thread Jani Nikula
On Mon, 6 Feb 2012 17:02:49 -0500, Ethan Glasser-Camp wrote: > From: Ethan Glasser-Camp > > scandir() returns "strings allocated via malloc(3)" which are then > "collected in array namelist which is allocated via > malloc(3)". Currently we just free the array namelist. Instead, free > all the

[PATCH] Free the results of scandir()

2012-02-06 Thread Ethan Glasser-Camp
From: Ethan Glasser-Camp scandir() returns "strings allocated via malloc(3)" which are then "collected in array namelist which is allocated via malloc(3)". Currently we just free the array namelist. Instead, free all the entries of namelist, and then free namelist. entry only points to elements

[PATCH v7 0/8] reworked crypto toggle, plus a few other toggles

2012-02-06 Thread Tomi Ollila
On Mon, 6 Feb 2012 09:21:14 +, David Edmondson wrote: > v7: > - Simple rebase. The whole patch series applied cleanly (git am) on top of current origin/master + Dmitry's patchset id:"1328426033-21480-2-git-send-email-dmitry.kurochkin at gmail.com" > David Edmondson (8): > emacs: Rework c

[PATCH] emacs: Leave blank subjects alone by default.

2012-02-06 Thread David Edmondson
Add `notmuch-blank-subject' to control how empty or whitespace only subjects are treated. The default behaviour is to leave them alone. The user can choose a string to use as a replacement. Modify code that cannot handle blank subjects to use a fixed string. --- emacs/notmuch-lib.el | 20

newbie questions

2012-02-06 Thread Jesse Rosenthal
On Mon, 06 Feb 2012 08:51:15 +0200, Tomi Ollila wrote: > On Fri, 3 Feb 2012 12:59:34 +0100, Tamas Papp wrote: > > > > 1. How can I restrict searches (eg of my inbox) to the last few > > messages (eg 50-100) or some date (eg last 2 weeks)? I am using the > > Emacs interface. > > Currently, if y

[PATCH v2] emacs: Add more processing of displayed headers.

2012-02-06 Thread David Edmondson
Wrap headers to the width of the window and indent continuations. --- emacs/notmuch-show.el | 43 --- 1 files changed, 36 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 7469e2e..a589d37 100644 --- a/emacs/no

[PATCH v2] Wrap and indent headers in show mode

2012-02-06 Thread David Edmondson
v2: - Simple rebase. David Edmondson (1): emacs: Add more processing of displayed headers. emacs/notmuch-show.el | 43 --- 1 files changed, 36 insertions(+), 7 deletions(-) -- 1.7.8.3

Re: [PATCH 0/3] notmuch show argument parsing

2012-02-06 Thread Austin Clements
Quoth Jani Nikula on Feb 06 at 9:57 pm: > Hi all, > > v2 addressing Austin's comments in id:"20120206041205.gp10...@mit.edu". > Separate the bool cleanup into a new patch, cleaning up notmuch reply > while at it. No functional changes since v1. LGTM. (Heads up: I never received patch 1/3, thou

[PATCH v2 3/3] cli: reach previously unreachable cleanup code in "notmuch show"

2012-02-06 Thread Jani Nikula
The last lines of notmuch_show_command() function were unreachable. Fix it by using a variable for return value. Signed-off-by: Jani Nikula --- notmuch-show.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index b358278..c8fbd79 10

[PATCH v2 2/3] cli: convert "notmuch show" to use the new argument parser

2012-02-06 Thread Jani Nikula
Use the new notmuch argument parser to handle arguments in "notmuch show". There are three minor functional changes: 1) Also set params.raw = TRUE when defaulting to raw format when part is requested but format is not specified. This was a bug, and --part=0 without --format=raw did not work

[PATCH v2 1/3] cli: use notmuch_bool_t for boolean fields in notmuch_show_params_t

2012-02-06 Thread Jani Nikula
Use notmuch_bool_t instead of int for entire_thread, raw, and decrypt boolean fields in notmuch_show_params_t. No functional changes. Signed-off-by: Jani Nikula --- notmuch-client.h |6 +++--- notmuch-reply.c |7 +++ notmuch-show.c | 14 +++--- 3 files changed, 13 insert

[PATCH 0/3] notmuch show argument parsing

2012-02-06 Thread Jani Nikula
Hi all, v2 addressing Austin's comments in id:"20120206041205.gp10...@mit.edu". Separate the bool cleanup into a new patch, cleaning up notmuch reply while at it. No functional changes since v1. For reviewing convenience, the diff between v1 and v2 is at the end of this cover letter. BR, Jani.

Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-02-06 Thread Antoine Beaupré
On Sun, 05 Feb 2012 23:07:02 -0800, Jameson Graef Rollins wrote: > Sorry to be so late on this, but I'm not a big fan of this new feature. > I would prefer to always see the subject (or any other field for that > matter) as is. I agree. as a native french speaker, for example, it's annoying havi

Re: Installation on Mac OS X Lion

2012-02-06 Thread Blake Sweeney
Quoting Saurabh Nanda (2012-02-05 03:27:38) >Hi, > >I'm trying to install notmuchmail on my Mac box, but have (obviously) >run into dependancy issues (Xapian, GMime, Glib, talloc). Has anyone >managed to install notmuchmail on Mac OS X? How painful is it? Is it >possible to have a binary packag

[PATCH v6 2/3] add support for user-specified files & directories to ignore

2012-02-06 Thread Tomi Ollila
On Mon, 6 Feb 2012 11:28:24 +0200, Tomi Ollila wrote: > A new configuration key 'new.ignore' is used to determine which > files and directories user wants not to be scanned as new mails. > > Mark the corresponding test as no longer broken. > > This work merges my previous attempts and Andreas A

Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-02-06 Thread David Edmondson
On Mon, 06 Feb 2012 11:19:46 -0800, Jameson Graef Rollins wrote: > On Mon, 06 Feb 2012 08:56:34 +, David Edmondson wrote: > > With blank subjects the printing code generated an error (because > > `rename-buffer' doesn't like an empty string as the first argument), so > > _some_ change is req

[PATCH v6 3/3] NEWS: add news section for new.ignore

2012-02-06 Thread Tomi Ollila
Added NEWS section 'Mail store folder/file ignore'. --- NEWS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 5c5b645..59da584 100644 --- a/NEWS +++ b/NEWS @@ -29,6 +29,12 @@ Tag exclusion notmuch config set search.exclude_tags deleted spam +Ma

[PATCH v6 2/3] add support for user-specified files & directories to ignore

2012-02-06 Thread Tomi Ollila
A new configuration key 'new.ignore' is used to determine which files and directories user wants not to be scanned as new mails. Mark the corresponding test as no longer broken. This work merges my previous attempts and Andreas Amann's work in id:"ylp7hi23mw8.fsf at tyndall.ie" --- notmuch-clien

[PATCH v6 1/3] test: add tests wrt ignoring user-specified files and directories

2012-02-06 Thread Tomi Ollila
Files and directories which are specified in 'new.ignore' in the config file shouldn't be indexed nor reported by `notmuch new'. This is basically Pieter's work with Austin's comments addressed. --- test/new | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --

Re: newbie questions

2012-02-06 Thread albin stjerna
On Fri, 3 Feb 2012 12:59:34 +0100, Tamas Papp wrote: > Hi, Hi Tamas, and (I suppose) welcome to the Notmuch mailing list! > I just started using notmuch. It is fascinating, but I still need to > figure out a few things: > > 1. How can I restrict searches (eg of my inbox) to the last few > messa

Installation on Mac OS X Lion

2012-02-06 Thread Saurabh Nanda
Hi, I'm trying to install notmuchmail on my Mac box, but have (obviously) run into dependancy issues (Xapian, GMime, Glib, talloc). Has anyone managed to install notmuchmail on Mac OS X? How painful is it? Is it possible to have a binary package for this? Thanks, Saurabh. -- http://www.saura

Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-02-06 Thread Jameson Graef Rollins
On Mon, 06 Feb 2012 08:56:34 +, David Edmondson wrote: > With blank subjects the printing code generated an error (because > `rename-buffer' doesn't like an empty string as the first argument), so > _some_ change is required. This sounds like something that could easily be fixed in the printi

[PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-02-06 Thread Jameson Graef Rollins
ily be fixed in the printing code, without changing the show and search behavior. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuc

Re: newbie questions

2012-02-06 Thread Jesse Rosenthal
On Mon, 06 Feb 2012 08:51:15 +0200, Tomi Ollila wrote: > On Fri, 3 Feb 2012 12:59:34 +0100, Tamas Papp wrote: > > > > 1. How can I restrict searches (eg of my inbox) to the last few > > messages (eg 50-100) or some date (eg last 2 weeks)? I am using the > > Emacs interface. > > Currently, if y

[PATCH v7 8/8] emacs: A prefix argument to `notmuch-show' should invert the matching message behaviour.

2012-02-06 Thread David Edmondson
Allow the user to open a thread with inverted `notmuch-show-only-matching-messages' behaviour using a prefix argument. --- emacs/notmuch-show.el |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 8c24f38..9c1d8fc 100644

[PATCH v7 7/8] emacs: Add `notmuch-show-only-matching-messages'.

2012-02-06 Thread David Edmondson
Allow the user to choose that only matching messages are shown by default. --- emacs/notmuch-show.el |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index ec36767..8c24f38 100644 --- a/emacs/notmuch-show.el +++ b/emacs/n

[PATCH v7 6/8] emacs: Check that the parent buffer is alive before using it.

2012-02-06 Thread David Edmondson
--- emacs/notmuch-show.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index f23aa8d..ec36767 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1683,7 +1683,7 @@ added." (interactive "P") (let ((paren

[PATCH v7 5/8] emacs: Optionally retain the state of the buffer during `notmuch-show-refresh-view'.

2012-02-06 Thread David Edmondson
With an argument, record and reply the state of the buffer during `notmuch-show-refresh-view'. In this context, "state" is defined as: - the open/closed state of each message, - the current message. Traditional use of refresh with the = key does not retain the state. The recently introduced tog

[PATCH v7 4/8] emacs: Add a binding (t) to toggle the truncation of long lines.

2012-02-06 Thread David Edmondson
--- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 89663ee..db9292c 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1131,6 +1131,7 @@ Refreshes the current view, observing changes

[PATCH v7 3/8] emacs: Allow the indentation of content to be toggled.

2012-02-06 Thread David Edmondson
Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el |

[PATCH v7 2/8] emacs: Allow `notmuch-show-mode' to display only matching messages.

2012-02-06 Thread David Edmondson
The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1 file

[PATCH v7 1/8] emacs: Rework crypto switch toggle.

2012-02-06 Thread David Edmondson
Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour i

[PATCH v7 0/8] reworked crypto toggle, plus a few other toggles

2012-02-06 Thread David Edmondson
v7: - Simple rebase. David Edmondson (8): emacs: Rework crypto switch toggle. emacs: Allow `notmuch-show-mode' to display only matching messages. emacs: Allow the indentation of content to be toggled. emacs: Add a binding (t) to toggle the truncation of long lines. emacs: Optionally reta

[PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

2012-02-06 Thread Austin Clements
Quoth Jani Nikula on Feb 06 at 7:54 am: > On Sun, 5 Feb 2012 23:12:05 -0500, Austin Clements > wrote: > > Yikes. I don't envy you this patch. Two minor nits, otherwise this > > and the next patch LGTM. > > Thanks for the review. I'll roll another version, I think it will be > better with your

[PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-02-06 Thread David Edmondson
rious other bits of code that require something other > > than a blank subject still work properly. > > I am actually perfectly happy to see this patch reverted. Whatever bremner decides. -- next part -- A non-text attachment was scrubbed... Name: not availa

newbie questions

2012-02-06 Thread Tomi Ollila
On Fri, 3 Feb 2012 12:59:34 +0100, Tamas Papp wrote: > Hi, > > I just started using notmuch. It is fascinating, but I still need to > figure out a few things: > > 1. How can I restrict searches (eg of my inbox) to the last few > messages (eg 50-100) or some date (eg last 2 weeks)? I am using t

NEWS: add entries for the changes in the python bindings

2012-02-06 Thread Tomi Ollila
On Mon, 06 Feb 2012 00:21:58 -, Justus Winter <4winter at informatik.uni-hamburg.de> wrote: > Quoting Tomi Ollila (2012-02-05 22:19:16) > >On Sun, 29 Jan 2012 18:08:50 +0100, Justus Winter <4winter at > >informatik.uni-hamburg.de> wrote: > >> This patch series adds a section for the python bi

Re: [PATCH v2 1/2] emacs: Use text properties rather than overlays in `notmuch-show-mode'.

2012-02-06 Thread David Edmondson
On Mon, 6 Feb 2012 16:08:21 +, David Edmondson wrote: > Except for where invisibility is involved, replace the use of overlays > in `notmuch-show-mode' with text properties, which are more efficient > and can be merged together more effectively. Austin reviewed this (id:"20120124161511.gc16.

[PATCH v2 2/2] test: Update test to match previous patch.

2012-02-06 Thread David Edmondson
Indentation now uses tabs where possible. --- ...hread-maildir-storage-with-fourfold-indentation |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation b/test/emacs.expected-output/

[PATCH v2 0/2] emacs: Use text properties rather than overlays in `notmuch-show-mode'.

2012-02-06 Thread David Edmondson
v2: - simple rebase. David Edmondson (2): emacs: Use text properties rather than overlays in `notmuch-show-mode'. test: Update test to match previous patch. emacs/notmuch-show.el | 66 --- emacs/notmuch-wash.el |

[PATCH v2 1/2] emacs: Use text properties rather than overlays in `notmuch-show-mode'.

2012-02-06 Thread David Edmondson
Except for where invisibility is involved, replace the use of overlays in `notmuch-show-mode' with text properties, which are more efficient and can be merged together more effectively. --- emacs/notmuch-show.el | 66 +++- emacs/notmuch-wash.el |8

[PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

2012-02-06 Thread Jani Nikula
On Sun, 5 Feb 2012 23:12:05 -0500, Austin Clements wrote: > Yikes. I don't envy you this patch. Two minor nits, otherwise this > and the next patch LGTM. Thanks for the review. I'll roll another version, I think it will be better with your suggestions incorporated. > Quoth Jani Nikula on Feb 0

[PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-02-06 Thread David Edmondson
ng other than a blank subject still work properly. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120206/9cf7dd14/attachment.pgp>

[PATCH v3 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

2012-02-06 Thread David Edmondson
Instead, allow the caller to specify some parameters for the button. Rework `notmuch-show-insert-part-multipart/signed' and `notmuch-show-insert-part-multipart/encrypted' accordingly. --- emacs/notmuch-show.el | 86 +--- 1 files changed, 45 insertions(

[PATCH v3 2/3] emacs: Optionally hide some part headers.

2012-02-06 Thread David Edmondson
Add a regexp, `notmuch-show-part-headers-hidden' and if the content-type of a part matches, don't show the part header. --- emacs/notmuch-show.el | 43 --- 1 files changed, 28 insertions(+), 15 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmu

[PATCH v2] emacs: Add more processing of displayed headers.

2012-02-06 Thread David Edmondson
Wrap headers to the width of the window and indent continuations. --- emacs/notmuch-show.el | 43 --- 1 files changed, 36 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 7469e2e..a589d37 100644 --- a/emacs/no

[PATCH v3 0/3] part header code tidying and options

2012-02-06 Thread David Edmondson
v3: - simple rebase. The previous version of this had 'LGTM' for each of the three parts. jrollins asked some questions, all of which were answered. David Edmondson (3): emacs: Don't return the button from `notmuch-show-insert-part-header'. emacs: Optionally hide some part headers. emac

[PATCH v3 3/3] emacs: Don't insert a part header if it's the first part and text/*.

2012-02-06 Thread David Edmondson
Previously this logic applied only to text/plain. Allow it for other text/* parts as well. --- emacs/notmuch-show.el |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index ce79762..c60e613 100644 --- a/emacs/notmuch-show

Re: [PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

2012-02-06 Thread Austin Clements
Quoth Jani Nikula on Feb 06 at 7:54 am: > On Sun, 5 Feb 2012 23:12:05 -0500, Austin Clements wrote: > > Yikes. I don't envy you this patch. Two minor nits, otherwise this > > and the next patch LGTM. > > Thanks for the review. I'll roll another version, I think it will be > better with your su

[PATCH v2] emacs: Add more processing of displayed headers.

2012-02-06 Thread David Edmondson
Wrap headers to the width of the window and indent continuations. --- emacs/notmuch-show.el | 43 --- 1 files changed, 36 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 7469e2e..a589d37 100644 --- a/emacs/no

[PATCH v2] Wrap and indent headers in show mode

2012-02-06 Thread David Edmondson
v2: - Simple rebase. David Edmondson (1): emacs: Add more processing of displayed headers. emacs/notmuch-show.el | 43 --- 1 files changed, 36 insertions(+), 7 deletions(-) -- 1.7.8.3 ___ notmuch mailing l

Re: [PATCH v7 0/8] reworked crypto toggle, plus a few other toggles

2012-02-06 Thread Tomi Ollila
On Mon, 6 Feb 2012 09:21:14 +, David Edmondson wrote: > v7: > - Simple rebase. The whole patch series applied cleanly (git am) on top of current origin/master + Dmitry's patchset id:"1328426033-21480-2-git-send-email-dmitry.kuroch...@gmail.com" > David Edmondson (8): > emacs: Rework cryp

Re: [PATCH v6 2/3] add support for user-specified files & directories to ignore

2012-02-06 Thread Tomi Ollila
On Mon, 6 Feb 2012 11:28:24 +0200, Tomi Ollila wrote: > A new configuration key 'new.ignore' is used to determine which > files and directories user wants not to be scanned as new mails. > > Mark the corresponding test as no longer broken. > > This work merges my previous attempts and Andreas A

[PATCH v6 1/3] test: add tests wrt ignoring user-specified files and directories

2012-02-06 Thread Tomi Ollila
Files and directories which are specified in 'new.ignore' in the config file shouldn't be indexed nor reported by `notmuch new'. This is basically Pieter's work with Austin's comments addressed. --- test/new | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --

[PATCH v6 2/3] add support for user-specified files & directories to ignore

2012-02-06 Thread Tomi Ollila
A new configuration key 'new.ignore' is used to determine which files and directories user wants not to be scanned as new mails. Mark the corresponding test as no longer broken. This work merges my previous attempts and Andreas Amann's work in id:"ylp7hi23mw8@tyndall.ie" --- notmuch-client.h

[PATCH v6 3/3] NEWS: add news section for new.ignore

2012-02-06 Thread Tomi Ollila
Added NEWS section 'Mail store folder/file ignore'. --- NEWS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 5c5b645..59da584 100644 --- a/NEWS +++ b/NEWS @@ -29,6 +29,12 @@ Tag exclusion notmuch config set search.exclude_tags deleted spam +

[PATCH v7 8/8] emacs: A prefix argument to `notmuch-show' should invert the matching message behaviour.

2012-02-06 Thread David Edmondson
Allow the user to open a thread with inverted `notmuch-show-only-matching-messages' behaviour using a prefix argument. --- emacs/notmuch-show.el |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 8c24f38..9c1d8fc 100644

[PATCH v7 7/8] emacs: Add `notmuch-show-only-matching-messages'.

2012-02-06 Thread David Edmondson
Allow the user to choose that only matching messages are shown by default. --- emacs/notmuch-show.el |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index ec36767..8c24f38 100644 --- a/emacs/notmuch-show.el +++ b/emacs/n

[PATCH v7 5/8] emacs: Optionally retain the state of the buffer during `notmuch-show-refresh-view'.

2012-02-06 Thread David Edmondson
With an argument, record and reply the state of the buffer during `notmuch-show-refresh-view'. In this context, "state" is defined as: - the open/closed state of each message, - the current message. Traditional use of refresh with the = key does not retain the state. The recently introduced tog

[PATCH v7 6/8] emacs: Check that the parent buffer is alive before using it.

2012-02-06 Thread David Edmondson
--- emacs/notmuch-show.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index f23aa8d..ec36767 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1683,7 +1683,7 @@ added." (interactive "P") (let ((paren

[PATCH v7 3/8] emacs: Allow the indentation of content to be toggled.

2012-02-06 Thread David Edmondson
Very deeply indented content is sometimes difficult to read (particular for something like patches). Allow the indentation of the content to be toggled with '<'. Indentation of the header lines is not affected, so it remains possible to see the structure of the thread. --- emacs/notmuch-show.el |

[PATCH v7 1/8] emacs: Rework crypto switch toggle.

2012-02-06 Thread David Edmondson
Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour i

[PATCH v7 0/8] reworked crypto toggle, plus a few other toggles

2012-02-06 Thread David Edmondson
v7: - Simple rebase. David Edmondson (8): emacs: Rework crypto switch toggle. emacs: Allow `notmuch-show-mode' to display only matching messages. emacs: Allow the indentation of content to be toggled. emacs: Add a binding (t) to toggle the truncation of long lines. emacs: Optionally reta

[PATCH v7 4/8] emacs: Add a binding (t) to toggle the truncation of long lines.

2012-02-06 Thread David Edmondson
--- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 89663ee..db9292c 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1131,6 +1131,7 @@ Refreshes the current view, observing changes

[PATCH v7 2/8] emacs: Allow `notmuch-show-mode' to display only matching messages.

2012-02-06 Thread David Edmondson
The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1 file

Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-02-06 Thread David Edmondson
On Mon, 06 Feb 2012 00:06:54 -0800, Jameson Graef Rollins wrote: > On Mon, 06 Feb 2012 07:47:38 +, David Edmondson wrote: > > On Sun, 05 Feb 2012 23:07:02 -0800, Jameson Graef Rollins > > wrote: > > > Sorry to be so late on this, but I'm not a big fan of this new feature. > > > I would pre

NEWS: add entries for the changes in the python bindings

2012-02-06 Thread Justus Winter
Quoting Tomi Ollila (2012-02-05 22:19:16) >On Sun, 29 Jan 2012 18:08:50 +0100, Justus Winter <4winter at >informatik.uni-hamburg.de> wrote: >> This patch series adds a section for the python binding changes to the >> NEWS file. > >I marked patches 2/3 and 3/3 stale as git-am doesn't accept those a

Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-02-06 Thread Jameson Graef Rollins
On Mon, 06 Feb 2012 07:47:38 +, David Edmondson wrote: > On Sun, 05 Feb 2012 23:07:02 -0800, Jameson Graef Rollins > wrote: > > Sorry to be so late on this, but I'm not a big fan of this new feature. > > I would prefer to always see the subject (or any other field for that > > matter) as is.

[PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

2012-02-06 Thread Jameson Graef Rollins
k subject still work properly. I am actually perfectly happy to see this patch reverted. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120206/909a1bf2/attachment-0001.pgp>