[PATCH v3 7/9] test: Update the test output to accord with the reply changes

On Mon, 12 May 2014, David Edmondson wrote: > Replying to a message with multiple parts will now typically include > content from several parts (whereas previously only the first part was > used). Update the expected output from the emacs reply tests > accordingly. I will reply here rather than t

[PATCH v3 0/9] emacs: Improve the cited message included in replies

On Tue, 13 May 2014, David Edmondson wrote: > Firstly, I don't think that the code resulting from this patch series is > beyond improvement - the intention was really only that it be better > than the current implementation. > > On Mon, May 12 2014, Mark Walters wrote: >> On Mon, 12 May 2014, Dav

[PATCH v3 4/9] emacs/mua: Generate improved cited text for replies

ing a bunch of complication to this specific patch. -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 310 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140513/be09e86b/attachment-0001.pgp>

[PATCH v3 0/9] emacs: Improve the cited message included in replies

t; -- >> 2.0.0.rc0 >> >> ___ >> notmuch mailing list >> notmuch at notmuchmail.org >> http://notmuchmail.org/mailman/listinfo/notmuch -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 310 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140513/df50f8ec/attachment.pgp>

[PATCH v3 2/9] emacs/show: Allow the user to decide when part headers should be inserted

(funcall notmuch-show-insert-header-p-function >> part)) >> (notmuch-show-insert-part-header nth mime-type content-type >> (plist-get part :filename >> (content-beg (point))) >> >> -- >> 2.0.0.rc0 >> >> ___ >> notmuch mailing list >> notmuch at notmuchmail.org >> http://notmuchmail.org/mailman/listinfo/notmuch -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 310 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140513/afc21d48/attachment.pgp>

[PATCH v3 1/9] emacs/show: Re-arrange determination if a part header is necessary

(notmuch-show-insert-part-header nth mime-type content-type >> (plist-get part :filename >> (content-beg (point))) >> >> -- >> 2.0.0.rc0 >> >> ___ >> notmuch mailing list >> notmuch at notmuchmail.org >> http://notmuchmail.org/mailman/listinfo/notmuch -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 310 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140513/9f5b1a7b/attachment.pgp>

[PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

ttp://notmuchmail.org/pipermail/notmuch/attachments/20140513/a8a4122d/attachment.pgp>

[PATCH v2] lib: Start all function names in notmuch-private.h with

As noted in devel/STYLE, every private library function should start with _notmuch. This patch corrects function naming that did not adhere to this style in lib/notmuch-private.h. In particular, the old function names that now begin with _notmuch are notmuch_sha1_of_file notmuch_sha1_of_st

[PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

cite that as the reason for the patch instead. chuck -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 494 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140513/7df6602e/attachment.pgp>

Re: [PATCH v3 7/9] test: Update the test output to accord with the reply changes

On Mon, 12 May 2014, David Edmondson wrote: > Replying to a message with multiple parts will now typically include > content from several parts (whereas previously only the first part was > used). Update the expected output from the emacs reply tests > accordingly. I will reply here rather than t

Re: [PATCH v3 0/9] emacs: Improve the cited message included in replies

On Tue, 13 May 2014, David Edmondson wrote: > Firstly, I don't think that the code resulting from this patch series is > beyond improvement - the intention was really only that it be better > than the current implementation. > > On Mon, May 12 2014, Mark Walters wrote: >> On Mon, 12 May 2014, Dav

Re: [PATCH v3 4/9] emacs/mua: Generate improved cited text for replies

On Mon, May 12 2014, Mark Walters wrote: > On Mon, 12 May 2014, David Edmondson wrote: >> Use the message display code to generate message text to cite in >> replies. > > So this is the key change. I am trying to work out what the actual > changes are here: in your commit message for the test upda

Re: [PATCH v3 0/9] emacs: Improve the cited message included in replies

Firstly, I don't think that the code resulting from this patch series is beyond improvement - the intention was really only that it be better than the current implementation. On Mon, May 12 2014, Mark Walters wrote: > On Mon, 12 May 2014, David Edmondson wrote: >> emacs: Improve the cited message

Re: [PATCH v3 2/9] emacs/show: Allow the user to decide when part headers should be inserted

On Mon, May 12 2014, Mark Walters wrote: > On Mon, 12 May 2014, David Edmondson wrote: >> Make the function that determines whether a part header should be >> inserted a user controlled, with some example functions. >> --- >> emacs/notmuch-show.el | 21 +++-- >> 1 file changed, 19

Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

As noted in the In-Reply-To header, this patch replaces id:1399402716-13714-1-git-send-email-ccel...@cs.stanford.edu. pgpOnVsuIV3Xa.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/n

Re: [PATCH v3 1/9] emacs/show: Re-arrange determination if a part header is necessary

On Mon, May 12 2014, Mark Walters wrote: > On Mon, 12 May 2014, David Edmondson wrote: >> Move the determination of whether a part header is required to a >> distinct function. >> --- >> emacs/notmuch-show.el | 25 ++--- >> 1 file changed, 18 insertions(+), 7 deletions(-) >> >

[PATCH v2] lib: Start all function names in notmuch-private.h with

As noted in devel/STYLE, every private library function should start with _notmuch. This patch corrects function naming that did not adhere to this style in lib/notmuch-private.h. In particular, the old function names that now begin with _notmuch are notmuch_sha1_of_file notmuch_sha1_of_st

Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

David Bremner writes: > David Bremner writes: > >> Originally I thought this was uneccesarily intrusive, but on a second >> look I see that there is only one symbol changed that doesn't start with >> _notmuch, so I guess for consistency it's fine. Actually, they all start with _notmuch. The sym