Re: [PATCH 2/6] cli: make notmuch_config_open() "is new" parameter input only

2013-03-03 Thread David Bremner
Jani Nikula writes: > Use the notmuch_config_is_new() function instead. I think it would be worth describing the API change here. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 3/6] cli: abstract subcommand finding into a new function

2013-03-03 Thread David Bremner
Jani Nikula writes: > Clean up code. > --- > notmuch.c | 68 > +++-- > 1 file changed, 35 insertions(+), 33 deletions(-) This looks OK, and independent from the other patches in the series, but it will need to be rebased for changes in

Re: [PATCH 4/6] cli: plug main notmuch command into subcommand machinery

2013-03-03 Thread David Bremner
Jani Nikula writes: > This also allows the main notmuch command to have arguments (though > they are not used). If the motivation here is to actually add arguments (i.e. --config), I would say so here. d ___ notmuch mailing list notmuch@notmuchmail.or

Re: [PATCH 6/6] cli: add top level --config=FILE option

2013-03-03 Thread David Bremner
Jani Nikula writes: > Let the user specify the config file on the command line. > > -config = notmuch_config_open (local, NULL, command->create_config); > +config = notmuch_config_open (local, config_file_name, > command->create_config); > if (!config) > return 1; LGTM

Re: [PATCH 0/6] notmuch cli config changes

2013-03-03 Thread David Bremner
Jani Nikula writes: > > Heh, I just wanted to see what the response was first before putting in > the effort to document it. The code comes easy. :) > It turns out this series is actually needed (or would be useful) to fix a bug in the emacs interface; see id:874nguxbvq@tu-dortmund.de So I'm

Re: [RFC] [PATCH] lib/database.cc: change how the parent of a message is calculated

2013-03-03 Thread David Bremner
Aaron Ecay writes: > git send-email is mad about lines >998 characters in the test patch, so > I’m sending the patches as attachments to this email. (Is there a > better way to include the expected output of a notmuch command which > outputs long lines in a test script?) What about pretty print

Re: [PATCH v4 03/12] cli: add insert command

2013-03-05 Thread David Bremner
Peter Wang writes: > The notmuch insert command reads a message from standard input, > writes it to a Maildir folder, and then incorporates the message into > the notmuch database. Essentially it moves the functionality of > notmuch-deliver into notmuch. The first three patches in this series l

Re: [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new" parameter input only

2013-03-07 Thread David Bremner
Jani Nikula writes: > We now have a notmuch_config_is_new() function to query whether a > config was created or not. Change the notmuch_config_open() is_new > parameter into boolean create_new to determine whether the function > should create a new config if one doesn't exist. This reduces the >

Re: [PATCH] test/README: mention the test_expect_equal_json and *sanitize* functions

2013-03-07 Thread David Bremner
Aaron Ecay writes: > also fix one typo > --- pushed, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] build: fix out-of-tree builds

2013-03-07 Thread David Bremner
Jani Nikula writes: > --- > > David, does the perf test still work for you with these changes? make perf-test OPTIONS=--medium runs the time tests, but then fails with ./performance-test/notmuch-memory-test --medium make[1]: ./performance-test/notmuch-memory-test: Command not found make[1]: **

Re: [PATCH v2 5/6] cli: move config open/close to main() from subcommands

2013-03-08 Thread David Bremner
Jani Nikula writes: > This allows specifying config file as a top level argument to notmuch, > and generally makes it possible to override config file options in > main(), without having to touch the subcommands. > I pushed patchs 5 through 7 of this 6 patch series. - I'll see if I can figure o

Re: [PATCH v3 0/2] Customize how each tag is displayed

2013-03-25 Thread David Bremner
Austin Clements writes: > > BTW, it looks like my notmuch-combine-face-text-property patch hasn't > been pushed yet. It is now, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v3 0/2] Customize how each tag is displayed

2013-03-25 Thread David Bremner
Damien Cassou writes: > [PATCH 1/2] emacs: Add notmuch-combine-face-text-property-string > [PATCH 2/2] emacs: possibility to customize the rendering of tags > Pushed to master, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/

Re: [PATCH v2] completion: complete bash completion rewrite

2013-03-29 Thread David Bremner
Jani Nikula writes: > Rewrite the bash completion script to actually do something > useful. Supported completions: > > * All the notmuch commands, command line arguments, and values for > keyword arguments. It seems to do what it says on the box. The bash code look OK, although I'm probably not

Re: [PATCH v2] lib: Fix name reordering to handle commas without spaces

2013-03-29 Thread David Bremner
Adam Wolfe Gordon writes: > Notmuch automatically re-orders names of the format "Last, First" to > "First Last" when the associated email address is > first.l...@example.com. But, if a name is of the format "Last,First" > then notmuch will format the name as "irst Last". Handle any number of > sp

Re: [PATCH 1/1] devel/STYLE: information how to enable standard pre-commit hook

2013-03-29 Thread David Bremner
Tomi Ollila writes: > It is easier to enable git standard pre-commit hook, when the > operation to do so is presented. Pushed. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/1] devel: add post-release tools news2wiki.pl and man-to-mdwn.pl

2013-03-29 Thread David Bremner
Tomi Ollila writes: > After new notmuch release has been published the NEWS and manual > pages have been updated using these 2 programs. > > Adding the tools to notmuch repository eases their use, adds more > transparency to the "process" and gives more people chance to > do the updates is one is

Re: [RFC PATCH 1/3] cli: cosmetic style cleanup

2013-03-29 Thread David Bremner
This doesn't apply anymore. Also, the commit message could be a bit more specific. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: introduce notmuch-command-to-string, replace use of shell-command-to-string

2013-03-29 Thread David Bremner
da...@tethera.net writes: > From: David Bremner > > This has two benefits: unified error handling, and avoiding tramp's > hooking into shell-command-string. > > This seems to be a fix for id:874nguxbvq@tu-dortmund.de > --- > > Simon: can you check if this fi

Re: [PATCH v4 06/12] test: add tests for insert

2013-03-29 Thread David Bremner
It took longer than I thought (of course) but I finally finished looking at the first 6 patches. I already mentioned a minor man page issue in a seperate message. I took a second pass through 03/12, and I think I would prefer thethe control flow of insert_message be closer to the standard style

Re: [PATCH 2/2] cli: mime node: abstract decryption and signature verification

2013-03-29 Thread David Bremner
Jani Nikula writes: > The code filled with #ifdef GMIME_ATLEAST_26 is difficult to > read. Abstract the decryption and signature verification into > functions, with separate implementations for GMime 2.4 and 2.6, to > clarify the code. This series mostly looks OK, although it's a challenge to tr

Re: [PATCH v4 04/12] man: document 'insert' command

2013-03-29 Thread David Bremner
Peter Wang writes: > + > +.B notmuch insert > +reads a message from standard input > +and delivers it to the specified maildir folder, > +then incorporates the message into the notmuch database. > +It is an alternative to using a separate tool to deliver > +the message then running > +.B notmuch n

Re: [PATCH v2 1/3] cli: config: remove unnecessary braces from if blocks

2013-03-30 Thread David Bremner
Jani Nikula writes: > Cosmetic change to drop unnecessary braces that don't even conform to > the prevailing coding style. pushed this one patch. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] NEWS: bash completion

2013-03-30 Thread David Bremner
Jani Nikula writes: > --- > NEWS | 12 > 1 file changed, 12 insertions(+) Pushed both. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2 0/4] cli: notmuch tag --remove-all option

2013-03-30 Thread David Bremner
Jani Nikula writes: > Rebased version of > id:1a2c09adc1c963f1aa209c09143f85dca7634e11.1358876448.git.j...@nikula.org pushed. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/1] emacs/notmuch.el: remove instruction to (require 'notmuch) in ~/.emacs

2013-03-31 Thread David Bremner
Tomi Ollila writes: > The (require 'notmuch) is unnecessary to be added to ~/.emacs for > M-x notmuch or emacs -f notmuch to start it. > > If (require 'notmuch) is added to ~/.emacs it is loaded to every > instance of emacs although it may not be used in majority of > those instances (but if need

Re: [PATCH 1/3] nmbug-status: simplify config file read from nmbug git

2013-04-01 Thread David Bremner
Jani Nikula writes: > This should be functionally the same as before. > --- Except that if a local config branch does not exist (but the remote one does) the old complicated version works, while the new one does ont. Do you want to try again, or just go with the other two patches? d ___

Re: [PATCH] emacs: introduce notmuch-command-to-string, replace use of shell-command-to-string

2013-04-01 Thread David Bremner
da...@tethera.net writes: > From: David Bremner > > This has two benefits: unified error handling, and avoiding tramp's > hooking into shell-command-string. > > This seems to be a fix for id:874nguxbvq@tu-dortmund.de > --- > > Simon: can you check if this fix

Re: [PATCH v3 0/6] batch count for notmuch-hello speedup

2013-04-01 Thread David Bremner
Jani Nikula writes: > This is v3 of id:cover.1362841844.git.j...@nikula.org, with the commit > messages of patches 1/6 and 3/6 fixed. No other changes. Thanks to > Jameson and Tomi for review, and of course Mark for the elisp part. Pushed, d ___ notmu

Re: [PATCH v2 0/3] cli: clean up gmime 2.4 vs. 2.6 conditional build

2013-04-01 Thread David Bremner
Jani Nikula writes: > This is v2 of [1]. Added comments per David's request, and while at it, > added a third patch to conform the existing conditional build in notmuch > show to the same style. The whole series should have no functional > changes, and thus v2 should have no functional changes si

[Joerg Jaspert] Bug#688609: notmuch: Can't deal with compressed maildir files

2013-04-02 Thread David Bremner
I misread this the first time, thinking it was about mboxes. Dealing with compressed individual messages seems at least potentially simpler. --- Begin Message --- Package: notmuch Version: 0.13.2-1 Severity: wishlist Dear Maintainer, another wishlist going upstream. Would be nice if notmuch ca

RE: the future of notmuch-vim?

2013-04-02 Thread David Bremner
Felipe Contreras writes: > > I did try the emacs frontend, and it was not working properly for me at the > time, and I believe I documented my issues. It was not just my dislike of > emacs > that motivated me to write notmuch-vim-ruby. I could only find a comment about the (admittedly imperfect)

Re: [PATCH] emacs: functions to import sender or recipient into BBDB

2013-04-06 Thread David Bremner
Daniel Bergey writes: > > From a show buffer, notmuch-bbdb/snarf-from imports the sender into > bbdb. notmuch-bbdb/snarf-to imports all recipients. Newly imported > contacts are reported in the minibuffer / Messages buffer. > > Both functions use the BBDB parser to recognize email address format

Re: [PATCH 3/3] nmbug-status: only import notmuch when needed

2013-04-06 Thread David Bremner
Jani Nikula writes: > Make it possible to use the script to query search views without > notmuch python bindings installed. Pushed 2 and 3 d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] lib: Add a new prefix "list" to the search-terms syntax

2013-04-06 Thread David Bremner
"Alexey I. Froloff" writes: > + > +/* Description may be RFC2047 encoded */ > +char *decoded_desc = g_mime_utils_header_decode_phrase(description); Surprisingly, the docs claim g_mime_utils_header_decode_phrase has no error conditions, so I guess this is OK. > + > +_notmuch_message_g

Re: [PATCH] emacs: functions to import sender or recipient into BBDB

2013-04-06 Thread David Bremner
David Bremner writes: > Daniel Bergey writes: >> >> From a show buffer, notmuch-bbdb/snarf-from imports the sender into >> bbdb. notmuch-bbdb/snarf-to imports all recipients. Newly imported >> contacts are reported in the minibuffer / Messages buffer. >> >

Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

2013-04-07 Thread David Bremner
Karl Fogel writes: > This patch fixes a trivial missing-paren problem in notmuch-address.el > (and reindents the following defun accordingly). I'm not subscribed > to this list, so please keep me CC'd on any followups. > > Best, > -Karl Dear Karl; Thanks very much for the patch. Since the off

Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

2013-04-08 Thread David Bremner
Jani Nikula writes: > On Mon, 08 Apr 2013, Tomi Ollila wrote: >> The most tolerable way is to send new patch series w/ these 2 patches >> that apply cleanly on top of current master (661dcf87aeb70) so that the >> things that David needs to do are just to run `git am` and `make test`. > > I'd say

Re: [PATCH] lib: Add a new prefix "list" to the search-terms syntax

2013-04-08 Thread David Bremner
"Alexey I. Froloff" writes: > On Sat, Apr 06, 2013 at 08:54:59AM -0300, David Bremner wrote: >> On the other hand, _notmuch_message_gen_terms does return a status. I >> agree that currently this status is not useful, but that could change in >> the future. I al

Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

2013-04-09 Thread David Bremner
Tomi Ollila writes: > On Tue, Apr 09 2013, Jed Brown wrote: > >> David Bremner writes: >> >>> Squashed sounds good to me too. Sorry I'm too lazy/busy at the moment to >>> do it myself. >> >> I tested the attached and it's working

Re: Integrating notmuch with gnus?

2013-04-10 Thread David Bremner
"Rainer M. Krug" writes: >> > <#secure method=pgpmime mode=sign> > I found a solution to using notmuch with gnus at [1] which explains how > to set it up. In a nutshell: G G is replaced with a call of > notmuch-search and an additional function makes it possible to locate > the mail in the group i

Re: [PATCH] debian: package ruby bindings

2013-04-13 Thread David Bremner
Felipe Contreras writes: > On Wed, Apr 3, 2013 at 5:27 PM, Felipe Contreras > wrote: >> Signed-off-by: Felipe Contreras >> --- >> debian/control | 14 ++ >> debian/notmuch-ruby.install | 1 + >> debian/rules| 9 + >> 3 files changed, 24 insert

Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions

2013-04-13 Thread David Bremner
Mark Walters writes: > On Wed, 10 Apr 2013, Tomi Ollila wrote: >> Some (declare-function ...) definitions were drifted away from the >> actual (defun ...)'s. To find the drifts and to verify changes >> the following command line was used: >> >> $ emacs --batch -L emacs --eval '(check-declare-dir

Re: [PATCH] debian: package ruby bindings

2013-04-13 Thread David Bremner
Felipe Contreras writes: > On Sat, Apr 13, 2013 at 6:35 AM, David Bremner wrote: >> Felipe Contreras writes: >> Mainly I've been busy. I need to double check the ruby packaging with >> somebody else. So, please continue to be patient, and not modify the >> stu

Re: [PATCH] debian: package ruby bindings

2013-04-13 Thread David Bremner
Felipe Contreras writes: > > Not according to debian: > http://packages.debian.org/sid/amd64/libnotmuch-dev/filelist > The latest is in experimental (because of the freeze) http://packages.debian.org/experimental/amd64/libnotmuch-dev/filelist d __

Re: [PATCH] debian: package ruby bindings

2013-04-14 Thread David Bremner
Felipe Contreras writes: > > diff --git a/debian/control b/debian/control > index 854a32a..620c5ce 100644 > --- a/debian/control > +++ b/debian/control > @@ -15,6 +15,7 @@ Build-Depends: > libz-dev, > python-all (>= 2.6.6-3~), > python3-all (>= 3.1.2-7~), > + ruby-dev, > emacs23-nox | ema

Re: [PATCH] cli: mime node: fix compiler warning when building against gmime 2.4

2013-04-14 Thread David Bremner
Jani Nikula writes: [...] > mime-node.c:224:9: warning: assignment discards ‘const’ qualifier from > pointer target type [enabled by default] > > Pass the non-const signature validity to the destructor to fix this. pushed, d ___ notmuch mailing list

Re: [PATCH 1/3] test: add some config file tests

2013-04-14 Thread David Bremner
Jani Nikula writes: > Test the --config=FILE option, and add a broken test for writing > config file through a symbolic link. > --- > test/config | 24 > 1 file changed, 24 insertions(+) Series pushed, d ___ notmuch mailing

Re: [PATCH] debian: package ruby bindings

2013-04-15 Thread David Bremner
Felipe Contreras writes: >> The package is still installing files into /usr/local, which is a >> violation of debian policy 9.1.2 >> >> It's a good idea to run "lintian" on the resulting debian packages; >> that's how I caught the problem with /usr/local. > > Tell that to debian maintainers who co

Re: [PATCH] debian: package ruby bindings

2013-04-15 Thread David Bremner
Felipe Contreras writes: >> On a related note, is the ruby build >> procedure documented somewhere? > > Not really, it's just standard. > OK, but that doesn't really help us deal with support requests e.g. on IRC. Some "feature requests" for the bindings: 1. Add a short README describing how t

Re: Python analogous for the CLI command

2013-04-18 Thread David Bremner
Flavius Aspra writes: > Hi > > Can you give me some pointers on how to use the python module to get the JSON > data with notmuch effort, equivalent to the command: > > notmuch show --entire-thread=true --format=json id: > > ? > > Some key classes and methods would be helpful. From the documen

Re: Compiling fails

2013-04-18 Thread David Bremner
Simonas Kazlauskas writes: > Of course `#pragma GCC` has to mean something and might be a reason why > compiling with `CXX=clang++` fails. Yep. clang is not currently supported. I'm not sure how difficult it would be to get working. d ___ notmuch ma

Re: [PATCH] go: use a different goconfig package

2013-04-23 Thread David Bremner
Justus Winter <4win...@informatik.uni-hamburg.de> writes: > The notmuch-addrlookup utility uses a third party library to read the > notmuch configuration file. The previously used implementation at > "github.com/kless/goconfig" vanished, so this patch switches to the > implementation at "github.co

Re: [PATCH] debian: package ruby bindings

2013-04-23 Thread David Bremner
Felipe Contreras writes: > On Mon, Apr 15, 2013 at 5:34 AM, David Bremner wrote: >> >> OK, but that doesn't really help us deal with support requests e.g. on IRC. >> Some "feature requests" for the bindings: > > Can you point to some of these request

feature request for notmuch python bindings

2013-04-23 Thread David Bremner
In talking with Patrick on IRC, it came up that the python bindings apparently lack support for the tag exclusion API, which has been in libnotmuch for almost a year. Did I miss something? If not, would you minding adding that to your TODO list for the binding? It would be nice if all frontends h

Re: [PATCH] don't store temporary value returned from c_str()

2013-04-27 Thread David Bremner
Vladimir Marek writes: > > const char* > string::c_str(void) { > char buf[100]; > > strcpy (buf, this->internal_representation); > return buf; > } Isn't that undefined behavior, returning a pointer to a (non-static) local variable? d ___

Re: [PATCH] debian: package ruby bindings

2013-04-28 Thread David Bremner
Felipe Contreras writes: > > I understand that you are not going to work on the Debian packages for > some time, but what prevents this patch from being merged to notmuch > 'master'? Is there any problems with the patch? Shall I just push it? The Debian packaging in master is the `live' packaging

Re: [PATCH] debian: package ruby bindings

2013-04-29 Thread David Bremner
Felipe Contreras writes: > > I don't take it personally, I just don't see why a part of the project > has to be treated differently because you (the debian packager), don't > want to setup a separate git repo where to have this 'live' packaging > (or even a separate branch). > My hypothetical laz

Re: [PATCH] don't store temporary value returned from c_str()

2013-04-29 Thread David Bremner
Vladimir Marek writes: >> It's okay to use the result of .c_str() as long as the string object >> stays in scope, and none of the non-const member functions are >> called. Here, I think the problem is that TermIterator's overloaded >> operator*() returns a string object within the if block's scop

Re: [PATCH] lib: Add a new prefix "list" to the search-terms syntax

2013-04-29 Thread David Bremner
Hi Alexey, Thanks for working on this. I think the boolean prefix version makes more sense, and it seems to work OK. I have a few comments below "Alexey I. Froloff" writes: > +begin_list_id = strrchr (list_id_header, '<'); > +if (!begin_list_id) { > + fprintf (stderr, "Warning: No

Re: [PATCH] man: document NOTMUCH_DEBUG_QUERY

2013-04-30 Thread David Bremner
da...@tethera.net writes: > From: David Bremner > > This is is really functionality of the library, but CLI users might > not look at library docs even if they existed beyond notmuch.h Pushed, d ___ notmuch mailing list notmuch@notmuchm

Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions

2013-04-30 Thread David Bremner
Tomi Ollila writes: > Some (declare-function ...) definitions were drifted away from the > actual (defun ...)'s. To find the drifts and to verify changes > the following command line was used: > > $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")' pushed, d

Re: Notmuch Emacs UI aborts on SourceForge.net newsletter

2013-04-30 Thread David Bremner
Amadeusz Żołnowski writes: > Attached message, when opened, causes Emacs crash: > > *** glibc detected *** emacs: free(): invalid next size (fast): > 0x0324f5e0 *** I can confirm that, although only with the shr renderer. With the w3m, renderer, it does not crash for me. I'm marking it

Re: [PATCH] go: use a different goconfig package

2013-05-03 Thread David Bremner
Justus Winter <4win...@informatik.uni-hamburg.de> writes: > The notmuch-addrlookup utility uses a third party library to read the > notmuch configuration file. The previously used implementation at > "github.com/kless/goconfig" vanished, so this patch switches to the > implementation at "github.co

Re: [PATCH] lib/message.cc: stale pointer bug (v3)

2013-05-03 Thread David Bremner
vladimir.ma...@oracle.com writes: > From: Vladimir Marek > > Xapian::TermIterator::operator* returns std::string which is destroyed > as soon as (*i).c_str() finishes. The remembered pointer 'term' then > references invalid memory. Pushed, d ___ notmu

Re: [PATCH] lib: Add a new prefix "list" to the search-terms syntax

2013-05-03 Thread David Bremner
"Alexey I. Froloff" writes: > >> > +void *local = talloc_new (message); >> we should handle ENOMEM here, I think. > There are 16 talloc_new() calls and ENOMEM is not handled > anywhere. This makes me a bit sad but I agree it's not your fault ;). > >> > +/* _notmuch_message_add_term

Re: Notmuch Emacs UI aborts on SourceForge.net newsletter

2013-05-03 Thread David Bremner
Amadeusz Żołnowski writes: > Attached message, when opened, causes Emacs crash: > > *** glibc detected *** emacs: free(): invalid next size (fast): > 0x0324f5e0 *** As promised, I duplicated this without notmuch, so I reported upstream as http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14

Re: [PATCH 1/2] test: add tests for the handling of References and In-Reply-To headers

2013-05-04 Thread David Bremner
Aaron Ecay writes: > These tests are known_broken, the following commit fixes them. > --- On current master, I get FIXED Use In-Reply-To when no References d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/n

Re: [PATCH 1/2] test: add tests for the handling of References and In-Reply-To headers

2013-05-04 Thread David Bremner
Aaron Ecay writes: > These tests are known_broken, the following commit fixes them. > --- Sorry for the extra mails, but this patch also makes test/basic fail because thread-replies is not added to test/notmuch-test d ___ notmuch mailing list notmuch@

Re: [PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-05-04 Thread David Bremner
Aaron Ecay writes: > +if (ref && strcmp(ref, message_id)) { > + return ref; > +} else { > + return NULL; > +} As a nit, there should be a space after strcmp. But if nobody has any other comments, I could amend that. d ___ notmuch ma

Re: [PATCH 5/6] python: Add bindings for notmuch_thread_get_messages

2013-05-04 Thread David Bremner
Austin Clements writes: > --- > bindings/python/notmuch/thread.py | 27 ++- Justus OKed this privately. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: add kernel.org mail archive redirector

2013-05-05 Thread David Bremner
Jani Nikula writes: > See http://lkml.kernel.org/ > --- > emacs/notmuch-show.el |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Pushed. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 5/6] python: Add bindings for notmuch_thread_get_messages

2013-05-05 Thread David Bremner
Austin Clements writes: > --- > bindings/python/notmuch/thread.py | 27 ++- > 1 file changed, 22 insertions(+), 5 deletions(-) Pushed, finally. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailma

Re: attachment with missing Content-Disposition

2013-05-08 Thread David Bremner
Johannes Schauer writes: > > Alternatively, how about making attachment detection configurable so that > everybody is free to decide himself what he wants to be treated as attachment? That was my first thought when I saw the discussion on IRC. It seems to be a special case of allowing saved searc

Re: [PATCH 1/8] lib: add --exclude=all option

2013-05-11 Thread David Bremner
Peter Wang writes: > From: Mark Walters > > Adds a exclude all option to the lib which means that excluded > messages are completely ignored (as if they had actually been > deleted). Hi Peter, Mark; This patch doesn't apply anymore, which makes it hard to test the series. At least by eye the

Re: [PATCH v2 4/8] man: clarify search --exclude documentation

2013-05-12 Thread David Bremner
Mark Walters writes: > From: Peter Wang > > Highlight "excluded messages" as a term with a meaning that > may not be obvious. > Pushed the two man page updates that don't relate to new features. d ___ notmuch mailing list notmuch@notmuchmail.org http

Re: [PATCH 1/2] test: add basic test for notmuch setup

2013-05-12 Thread David Bremner
Jani Nikula writes: > And annotate with test_subtest_known_broken. Hooray. Pushed these two. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2013-05-12 Thread David Bremner
Mark Walters writes: > - notmuch_query_set_omit_excluded (query, NOTMUCH_EXCLUDE_FALSE); > + notmuch_query_set_omit_excluded (query, NOTMUCH_EXCLUDE_FLAG); Shouldn't the documentation be updated to cover NOTMUCH_EXCLUDE_FLAG? I realize it is not _wrong_ as written, but it is a b

Re: [PATCH 1/1] emacs: removed code attempting to support emaces prior to version 23

2013-05-12 Thread David Bremner
Tomi Ollila writes: > > I suggested in IRC that we (first) deprecate this support, but as it has > not worked like 18 months It is just simpler to drop it now. I'll do > NEWS patch if this approach is accepted. > please do. d ___ notmuch mailing list

Re: [PATCH 1/2] contrib: pick: add thread based utility functions

2013-05-12 Thread David Bremner
Mark Walters writes: > Previously notmuch-pick had no thread based functionality. This adds a > macro to iterate through all messages in a thread. To simplify this it > adds a text-property marker to the first message of each thread. > +(defun notmuch-pick-get-messages-ids-thread () > + "Retur

Re: [PATCH 1/1] emacs/notmuch-address.el: add notmuch-address-selection-function

2013-05-12 Thread David Bremner
Tomi Ollila writes: > Added a customizable variable notmuch-address-selection-function > and the function with the same name to provide a way for user to > change the function called to do address selection. The patch looks OK. I did notice that discussion on "selection-menu.el" kindoff dropped

Re: [PATCH 1/1] emacs/notmuch-address.el: add notmuch-address-selection-function

2013-05-13 Thread David Bremner
Tomi Ollila writes: > Added a customizable variable notmuch-address-selection-function and > the function with the same name to provide a way for user to change > the function called to do address selection. Pushed. d ___ notmuch mailing list notmuch@

Re: [PATCH 1/1] emacs: removed code attempting to support emaces prior to version 23

2013-05-13 Thread David Bremner
Tomi Ollila writes: > I suggested in IRC that we (first) deprecate this support, but as it > has not worked like 18 months It is just simpler to drop it now. I'll > do NEWS patch if this approach is accepted. pushed. so now you owe NEWS ;). d ___ notm

Re: [PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-05-13 Thread David Bremner
Aaron Ecay writes: > Presently, the code which finds the parent of a message as it is being > added to the database assumes that the first Message-ID-like substring > of the In-Reply-To header is the parent Message ID. Some mail > clients, however, put stuff other than the Message-ID of the pare

Re: [PATCH v2 0/8] search --exclude=all

2013-05-13 Thread David Bremner
Mark Walters writes: > This is a rebased version of > id:1340198947-29370-1-git-send-email-noval...@gmail.com I have not > tested it significantly in this form but the rebasing looks ok and all > the tests pass. Pushed all but 7/8. I leave it to Peter and Mark to discuss which of their patches t

Re: [PATCH] build: fix out-of-tree builds

2013-05-15 Thread David Bremner
Jani Nikula writes: > # List all subdirectories here. Each contains its own Makefile.local > -subdirs := compat completion emacs lib man parse-time-string > -subdirs += performance-test util test > +subdirs = compat completion emacs lib man parse-time-string performance-test > util test Is this

Re: simplify and fix performance tests

2013-05-15 Thread David Bremner
da...@tethera.net writes: > Jani noticed the alleged file notmuch-memory-test was missing. > Austin grumbled about explicitly adding tests to a list. > This series should give them both something else to grumble about. Pushed, d ___ notmuch mailing lis

Re: [PATCH] emacs: tag: fix compile warning

2013-05-15 Thread David Bremner
Mark Walters writes: > When compiling notmuch-tag.el there is a compile warning: > notmuch-tag.el:27:1:Warning: cl package required at runtime > pushed the patch. Someone (TM) should investigate the new cl- prefixed functions, e.g. cl-loop which maybe me less hassle in the long run. d _

Re: [PATCH] build: fix out-of-tree builds

2013-05-16 Thread David Bremner
Jani Nikula writes: > On Wed, 15 May 2013, David Bremner wrote: >> Jani Nikula writes: >>> # List all subdirectories here. Each contains its own Makefile.local >>> -subdirs := compat completion emacs lib man parse-time-string >>> -subdirs += performance-

Re: [PATCH v2] debian: package ruby bindings

2013-05-16 Thread David Bremner
Felipe Contreras writes: > Signed-off-by: Felipe Contreras > --- > debian/control | 14 ++ > debian/notmuch-ruby.install | 1 + > debian/rules| 3 +++ > 3 files changed, 18 insertions(+) > create mode 100644 debian/notmuch-ruby.install > I get a buil

Re: [PATCH v2] debian: package ruby bindings

2013-05-16 Thread David Bremner
Felipe Contreras writes: > > Yes. Do you have an old version of notmuch installed? > Yes I do. Hmm. It still seems like a bug to me; shouldn't the include paths be ordered to find the right include files first? d ___ notmuch mailing list notmuch@notmuc

Re: Joining messages into threads

2013-05-17 Thread David Bremner
Vladimir Marek writes: > > I am getting mails from some automated tools (let's imagine bugzilla for > example), which concern several specific topics (like bugs). > Unfortunately those mails are not 'threaded' (don't have In-Reply-To > header). Once the mails are indexed, is there a way make them

Re: [PATCH 3/5] emacs: Use async process helper for search

2013-05-18 Thread David Bremner
Mark Walters writes: >> - (error >> - (message "%s" (error-message-string err)) > > This line is > (message "%s" (second err)) > in master. > This is a seperate patch sent to the list recently. d __

Re: [PATCH] emacs: Proper error string handling in search sentinel

2013-05-18 Thread David Bremner
Austin Clements writes: > Apparently Emacs provides a function to stringify errors properly. > Use this in the search sentinel where we have to do our own error > messaging, rather than assuming the first error argument will be the > descriptive string. Pushed. Mark, this should fix the problem

Re: Solaris support - missing or incompatible functions

2013-05-18 Thread David Bremner
Vladimir Marek writes: >> >> There may be some prerequisites to running tests that you're missing, >> and the test setup fails to tell you about. A pastebin of the 'make >> test' output might be helpful. > > Ok, in that case please let me take a look at the tests first. > For what it's worth, I

Re: [PATCH 1/1] NEWS: removal of backported support for Emacs version 22

2013-05-18 Thread David Bremner
Tomi Ollila writes: > --- > NEWS | 13 + > > +Emacs Interface > +--- > + > +Removal of backported Emacs version 23 functionality for Emacs 22 > + > + Two years ago some Emacs 23 functionality that notmuch used were > + backported to notmuch to be conditionally used wit

Re: [PATCH] emacs: Compute build dependencies to fix byte compile issues

2013-05-19 Thread David Bremner
Austin Clements writes: > > This patch addresses these problems by computing make dependency rules > from the (require 'x) forms in the Elisp source files, which we inject > into make's dependency database. this seems to work as advertised. > +;; > +;; Copyright © Austin Clements I guess you ne

use of flet in notmuch-emacs

2013-05-19 Thread David Bremner
Today I noticed , | emacs --quick --directory emacs -batch -f batch-byte-compile emacs/notmuch-show.el | | In notmuch-show-view-part: | emacs/notmuch-show.el:541:22:Warning: `flet' is an obsolete macro (as of | 24.3); use either `cl-flet' or `cl-letf'. ` Chatter on #emacs suggests

Re: how the date query works?

2013-05-20 Thread David Bremner
David Belohrad writes: > > Is there any kind of manual how to use it? I'm of course particularly > interested in 'today', 'yesterday', 'last week', 'last month' :) > See man notmuch-search-terms http://notmuchmail.org/manpages/notmuch-search-terms-7/ ___

Re: Python Bindings missing on PyPI

2013-05-20 Thread David Bremner
Patrick Gerken writes: > > Is there any rationale that prevents registering the python bindings > on pypi? > If this is only because of missing maintainer, would anybody > object if I put the bindings on pypi? I imagine the python bindings are pretty dependent on the version of notmuch they ship

<    3   4   5   6   7   8   9   10   11   12   >