On Wed, 18 Jan 2012 23:00:15 +0400, Dmitry Kurochkin
wrote:
> > That would allow a sane default (("image/*" "text/*") perhaps), but also
> > allow more to be added to that list (or some to be removed), either by
> > code that detected the (in)ability to render it or the user.
>
> Perhaps there i
On Thu, 19 Jan 2012 00:22:53 +0400, Dmitry Kurochkin
wrote:
> Changes in v2 since v1:
>
> * expected results changes for tests moved from patch 2 to 1 where it belong
The patch set looks good to me.
pgpNMumAPxq0s.pgp
Description: PGP signature
___
n
On Wed, 18 Jan 2012 17:18:48 -0500, Aaron Ecay wrote:
> Runtime dependencies are not allowed in code distributed with emacs
> because of RMS’s conservativism[1].
Yow! Conservatism is such a pejorative term.
But, I generally agree. We should allow cl at runtime and document the
same.
pgpAUmSfE9
The `mm-inlinable-p' function works better if it has access to the
data of the relevant part, so load that content before calling it.
Don't load the content for parts that the user has indicated no desire
to inline.
This fixes the display of attached image/jpeg parts, for example.
---
Updated as
On Wed, 18 Jan 2012 16:55:59 +0200, Tomi Ollila wrote:
> > + # Report success/failure.
> > + if ! test_skip "$test_subtest_name"
> > + then
> > + if [ "$result" == t ]
>
> if [ "$result" = t ]
>
> to be compatible with POSIX and consistent with rest code.
I'm happy
On Thu, 19 Jan 2012 12:32:21 +0200, Tomi Ollila wrote:
> Consider the following:
>
> $ emacsclient --eval '(print "$(echo rm -rf /); echo `date +%Y`")'
> "$(echo rm -rf /); echo `date +%Y`"
Or:
$ emacsclient --eval '(shell-command "rm -rf /")'
What's your point?
pgpcfhf7mbWOZ.pgp
Description
---
test/test-lib.sh |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index d1fbc05..7c9ce24 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -926,7 +926,7 @@ test_emacs () {
--eval '(orphan-watchdo
Including some more test framework in test-lib.el.
---
test/emacs-address-cleaning.el | 29 +
test/emacs-address-cleaning.sh | 12
test/notmuch-test |1 +
test/test-lib.el | 30 ++
4 files cha
Add a new test function to allow simpler testing of emacs
functionality.
`test_emacs_expect_t' takes one argument - a list expression to
evaluate. The test passes if the expression returns `t', otherwise it
fails and the output is reported to the tester.
---
In the interest of moving forward, don
On Fri, 20 Jan 2012 00:53:39 -0500, Aaron Ecay wrote:
> I’m personally of the opinion that notmuch should just say “the mail
> composition facility is provided by message mode (here is the
> documentation on customizing it)”.
In general, +1.
> One possible step that might ease the transition pai
Add a regexp, `notmuch-show-part-headers-hidden' and if the
content-type of a part matches, don't show the part header.
---
emacs/notmuch-show.el | 41 +++--
1 files changed, 27 insertions(+), 14 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch
On Thu, 19 Jan 2012 13:43:09 -0500, Aaron Ecay wrote:
> - (message-goto-body))
> + (message-goto-body)
> + (mml-quote-region (point) (mark)))
Obviously good. It would be nice to have a comment about why it's `mark'
and not `point-max'. In fact, it would be good to have a comment
explaining why
---
emacs/notmuch-show.el | 26 --
1 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 03c1f6b..f62f8ac 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -286,20 +286,18 @@ message at DEPTH i
Instead, allow the caller to specify some parameters for the
button. Rework `notmuch-show-insert-part-multipart/signed' and
`notmuch-show-insert-part-multipart/encrypted' accordingly, moving
most of the code into a common
`notmuch-show-insert-part-multipart/signed-or-encrypted' to reduce
duplicatio
On Fri, 20 Jan 2012 12:13:49 -0800, Jameson Graef Rollins
wrote:
> On Wed, 18 Jan 2012 14:35:01 -0500, Austin Clements wrote:
> > Shouldn't we only be doing this for parts with inline (or not
> > attachment) content-disposition? That's cheap to check. Or do we
> > actually want things like ima
On Fri, 20 Jan 2012 12:04:27 -0800, Jameson Graef Rollins
wrote:
> On Thu, 19 Jan 2012 09:34:07 +0000, David Edmondson wrote:
> > The `mm-inlinable-p' function works better if it has access to the
> > data of the relevant part, so load that content before calling it.
>
On Sun, 22 Jan 2012 13:38:09 -0800, Jameson Graef Rollins
wrote:
> This patch seems to include multiple distinct changes. There is a
> change to notmuch-show-insert-part-header, but a seemingly unrelated
> change to the insertion of signed/encrypted part buttons. They should
> be in separate pa
On Mon, 23 Jan 2012 00:52:26 -0800, Jameson Graef Rollins
wrote:
> On Mon, 23 Jan 2012 08:16:03 +0000, David Edmondson wrote:
> > There was no problem with the logic. The code in the two functions was
> > almost identical, so I'd like to make any future changes i
Instead, allow the caller to specify some parameters for the
button. Rework `notmuch-show-insert-part-multipart/signed' and
`notmuch-show-insert-part-multipart/encrypted' accordingly.
---
Removed the merge of multipart/signed and multipart/encrypted.
emacs/notmuch-show.el | 84
Add a regexp, `notmuch-show-part-headers-hidden' and if the
content-type of a part matches, don't show the part header.
---
emacs/notmuch-show.el | 41 +++--
1 files changed, 27 insertions(+), 14 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch
Previously this logic applied only to text/plain. Allow it for other
text/* parts as well.
---
This was not included in version 1 of the patch set.
emacs/notmuch-show.el |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
On Mon, 23 Jan 2012 00:34:20 -0800, Jameson Graef Rollins
wrote:
> Brake up notmuch-show-archive-thread-internal into two new functions:
"Break", otherwise +1.
pgpyDxMQ6giYZ.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.
+1.
pgpNuY5fVgFxs.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
+1.
pgpViJzHc5v89.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins
wrote:
> -(defun notmuch-show-next-open-message ()
> +(defun notmuch-show-next-open-message (&optional pop-at-end)
>"Show the next message."
> - (interactive)
> - (let (r)
> + (interactive "P")
> + (let ((parent-buffer notmuch-show
+1.
pgprc98UhV8FC.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
v2 of these patches need to be merged with Mark's part saving
stuff. I've done this, but I'll hold off posting the merged version
until this one is reviewed, unless anyone objects.
pgpVYndJoTvv0.pgp
Description: PGP signature
___
notmuch mailing list
no
On Thu, 19 Jan 2012 12:54:02 +, David Edmondson wrote:
> Add a new test function to allow simpler testing of emacs
> functionality.
>
> `test_emacs_expect_t' takes one argument - a list expression to
> evaluate. The test passes if the expression returns `t', oth
---
Split out from the tests and re-factored.
test/test-lib.el | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/test/test-lib.el b/test/test-lib.el
index 96752f0..c4a5db4 100644
--- a/test/test-lib.el
+++ b/test/test-lib.el
@@ -20,6 +20,8 @@
;;
;;
On Mon, 23 Jan 2012 09:39:30 -0800, Jameson Graef Rollins
wrote:
> On Mon, 23 Jan 2012 11:02:04 +0000, David Edmondson wrote:
> > On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins
> > wrote:
> > > -(defun notmuch-show-next-open-message ()
> > > +(def
When checking for a running emacs, test_emacs evaluates the empty list
'()'. This returns 'nil' when emacs is running, which is then
prepended to the actual test result. Given that it is not part of the
actual test output the test harness can incorrectly report test
failure (or success).
---
Comme
Add a new test function to allow simpler testing of emacs
functionality.
`test_emacs_expect_t' takes one argument - a lisp expression to
evaluate. The test passes if the expression returns `t', otherwise it
fails and the output is reported to the tester.
---
As per Dmitry:
- don't call `test_ski
---
Anticipate the failure of test 3.
test/emacs-address-cleaning.el | 29 +
test/emacs-address-cleaning.sh | 19 +++
test/notmuch-test |1 +
3 files changed, 49 insertions(+), 0 deletions(-)
create mode 100644 test/emacs-address-
`notmuch-show-stash-gmane' stashes a URI for the current message at
Gmane, presuming that Gmane has a copy of the message with the same
Message-Id.
`notmuch-show-stash-gmane-and-go' both stashes the message and opens
the relevant page in the configured browser.
Add the relevant test for `notmuch-
In preparation for changes to support showing and hiding MIME parts on
the fly (general parts, choosing amongst multipart/alternative and
show updated signing/encryption status without redisplay) I'm trying
to clean up some of the `notmuch-show-mode' code. This patch is part
of that, though it stan
Indentation now uses tabs where possible.
---
...hread-maildir-storage-with-fourfold-indentation |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git
a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation
b/test/emacs.expected-output/
Except for where invisibility is involved, replace the use of overlays
in `notmuch-show-mode' with text properties, which are more efficient
and can be merged together more effectively.
---
emacs/notmuch-show.el | 66 +++-
emacs/notmuch-wash.el |8
Add a regexp, `notmuch-show-part-headers-hidden' and if the
content-type of a part matches, don't show the part header.
---
emacs/notmuch-show.el | 43 ---
1 files changed, 28 insertions(+), 15 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmu
Rebased on top of the recent button related changes from Mark.
[PATCH 1/3] emacs: Don't return the button from
[PATCH 2/3] emacs: Optionally hide some part headers.
[PATCH 3/3] emacs: Don't insert a part header if it's the first part
___
notmuch mailing
Previously this logic applied only to text/plain. Allow it for other
text/* parts as well.
---
emacs/notmuch-show.el |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index a0a2873..23bf1f4 100644
--- a/emacs/notmuch-show
Instead, allow the caller to specify some parameters for the
button. Rework `notmuch-show-insert-part-multipart/signed' and
`notmuch-show-insert-part-multipart/encrypted' accordingly.
---
emacs/notmuch-show.el | 86 +---
1 files changed, 45 insertions(
On Tue, 24 Jan 2012 03:48:54 +0400, Dmitry Kurochkin
wrote:
> Changes:
>
> v3:
>
> * rebased on current master
>
> v2:
>
> * expected results changes for tests moved from patch 2 to 1 where it belong
This set look fine to me. Poor Daniel has to re-merge...
pgp8SA0MdAnzU.pgp
Description: P
On Tue, 24 Jan 2012 19:45:18 +0400, Dmitry Kurochkin
wrote:
> 1. rename notmuch-test-compare to notmuch-test-expect-equal
I'll change this.
> 2. move the top level equal check to the non-list branch
I'd rather not change this, though I'll write some commentary to explain
how things are.
> But
Small changes as per Dmitry's last comments.
David Edmondson (4):
test: Don't return the result of checking for running emacs to the
tester.
test: Add `test_emacs_expect_t'.
test: Add more helpers for emacs tests.
test: Add address cleaning tests
When checking for a running emacs, test_emacs evaluates the empty list
'()'. This returns 'nil' when emacs is running, which is then
prepended to the actual test result. Given that it is not part of the
actual test output the test harness can incorrectly report test
failure (or success).
---
test/
---
test/test-lib.el | 26 ++
1 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/test/test-lib.el b/test/test-lib.el
index 96752f0..bc75f06 100644
--- a/test/test-lib.el
+++ b/test/test-lib.el
@@ -20,6 +20,8 @@
;;
;; Authors: Dmitry Kurochkin
+(require '
Add a new test function to allow simpler testing of emacs
functionality.
`test_emacs_expect_t' takes one argument - a lisp expression to
evaluate. The test passes if the expression returns `t', otherwise it
fails and the output is reported to the tester.
---
test/README |8 ++
---
test/emacs-address-cleaning.el | 29 +
test/emacs-address-cleaning.sh | 19 +++
test/notmuch-test |1 +
3 files changed, 49 insertions(+), 0 deletions(-)
create mode 100644 test/emacs-address-cleaning.el
create mode 100755 test
On Tue, 24 Jan 2012 11:15:11 -0500, Austin Clements wrote:
> LGTM other than one very minor nit, though I pretty reliably make
> fence post errors when dealing with text properties, so perhaps
> somebody else should check that.
>
> Quoth David Edmondson on Jan 24 at 11:36 am:
On Tue, 24 Jan 2012 10:46:57 -0800, Jameson Graef Rollins
wrote:
> On Tue, 24 Jan 2012 12:53:38 +0000, David Edmondson wrote:
> > Instead, allow the caller to specify some parameters for the
> > button. Rework `notmuch-show-insert-part-multipart/signed' and
> >
On Tue, 24 Jan 2012 11:52:09 -0800, Jameson Graef Rollins
wrote:
> On Tue, 24 Jan 2012 19:25:19 +0000, David Edmondson wrote:
> > On Tue, 24 Jan 2012 10:46:57 -0800, Jameson Graef Rollins
> > wrote:
> > > Is there a reason it's really necessary to make this chan
On Tue, 24 Jan 2012 16:10:47 -0800, Jameson Graef Rollins
wrote:
> On Tue, 24 Jan 2012 16:34:32 -0500, micah anderson wrote:
> > David replied to it because it was sent to him, but the list email
> > hasn't come through yet (I want this functionality, so I'm dying to see
> > the patch!)
>
> Hey
On Thu, 08 Dec 2011 11:05:50 +0200, Tomi Ollila wrote:
> On Wed, 07 Dec 2011 19:51:32 -0400, David Bremner wrote:
> > On Wed, 14 Sep 2011 00:32:01 +0300, tomi.oll...@iki.fi wrote:
> > > This patch set adds a configuration option 'database.exclude'; a list of
> > > files/directories to be excluded
On Wed, 25 Jan 2012 01:50:08 +0100, Pieter Praet wrote:
> In a perfect world, everyone would be using Notmuch and have a local
> copy of every message ever sent to any ML. While we're waiting for
> Atlantis to resurface, we'll need an interim solution.
>
> +1 for the idea, but Gmane doesn't arch
On Wed, 25 Jan 2012 06:25:39 +0100, Pieter Praet wrote:
> * emacs/notmuch-show.el (notmuch-show-open-or-close-all):
> Rename to `notmuch-show-toggle-all-messages', and make it toggle
> visibility of all messages based on the visibility of the current
> message, instead of setting visibility
+19,8 @@
;;
;; Authors: David Edmondson
+(declare-function notmuch-show-get-prop "notmuch-show" (prop &optional props))
+
(defcustom notmuch-print-mechanism 'notmuch-print-lpr
"How should printing be done?"
:group 'notmuch
--
1.7.8.3
On Wed, 25 Jan 2012 11:19:30 +0200, Tomi Ollila wrote:
> On Wed, 25 Jan 2012 08:52:15 +0000, David Edmondson wrote:
> > `notmuch-show-get-prop' should be declared.
> > ---
>
> How 'bout
>
> (require 'notmuch-lib)
>
> and put that declare-fun
The current behaviour (all messages shown, non-matching collapsed)
is retained as the default. Type '!' to switch to showing only
the matching messages - non-matching messages are not available.
'!' will switch back to showing everything.
---
emacs/notmuch-show.el | 18 +-
1 file
Very deeply indented content is sometimes difficult to
read (particular for something like patches). Allow the indentation of
the content to be toggled with '<'.
Indentation of the header lines is not affected, so it remains
possible to see the structure of the thread.
---
emacs/notmuch-show.el |
me' is used only in notmuch-show.el, so the
setting really belongs there with an appropriate name.
David Edmondson (3):
emacs: Rework crypto switch toggle.
emacs: Allow `notmuch-show-mode' to display only matching messages.
emacs: Allow the indentation of content
Re-work the existing crypto switch toggle to be based on a persistant
buffer-local variable.
To allow this, modify `notmuch-show-refresh-view' to erase and re-draw
in the current buffer rather than killing the current buffer and
creating a new one. (This will also allow more per-buffer behaviour i
On Wed, 25 Jan 2012 01:26:19 -0800, Jameson Graef Rollins
wrote:
> On Wed, 25 Jan 2012 06:23:01 +0000, David Edmondson wrote:
> > Can you explain the logic that will apply to determine whether or not a
> > reply is encrypted?
>
> My plan was to modify notmuch-reply.c to
On Wed, 25 Jan 2012 12:18:22 +0200, Tomi Ollila wrote:
> On Wed, 25 Jan 2012 06:31:43 +0000, David Edmondson wrote:
> >
> > Your point about Gmane not having everything applies equally to any
> > service, suggesting that perhaps the user should also have an option to
> &
On Tue, 24 Jan 2012 16:06:17 -0800, Jameson Graef Rollins
wrote:
> notmuch-show-tag-thread-internal: applies a tag to all messages in
> thread. If option remove flag is t, tags will be removed instead of
> added.
If it's non-nil, but yes.
> notmuch-show-next-thread: moves to the next thread in
On Tue, 24 Jan 2012 16:06:18 -0800, Jameson Graef Rollins
wrote:
> This function is now just for archiving the current thread. A new
> function is created to archive-then-next. The 'a' key binding is
> updated accordingly.
>
> This will allow people to bind to the simple thread archiving funct
On Tue, 24 Jan 2012 16:06:19 -0800, Jameson Graef Rollins
wrote:
> This adds two new message archiving functions that parallel the thread
> archiving functions: notmuch-show-archive-message{,-then-next}. The
> former also takes a prefix argument to unarchive the message (ie. put
> back in inbox)
Fine.
pgpbZ9FwaIxol.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Fine.
pgpqE7gXQcFlO.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Fine.
pgpnqUEwPXg2v.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Fine.
pgpKbaKgOLkD5.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Fine.
pgpQD2IcvndvB.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Avoids warnings due to unicode characters and improves display.
David Edmondson (2):
emacs: Avoid `mail-header-parse-address' in
`notmuch-show-clean-address'.
emacs: Another special case for `notmuch-show-clean-address'.
emacs/notmuch-show.el
`mail-header-parse-address' expects un-decoded mailbox parts, which is
not what we have at this point. Replace it with simple string
deconstruction.
Mark the corresponding test as no longer broken.
Minor whitespace cleanup.
---
emacs/notmuch-show.el | 50 --
Remove backslashes.
---
emacs/notmuch-show.el | 14 +-
test/emacs-address-cleaning.el |6 --
2 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 1fd2524..c849e84 100644
--- a/emacs/notmuch-show.el
+++ b/
Three minor cleanup or small improvement patches.
David Edmondson (3):
emacs: Stop the `truncate-string-to-width' madness.
emacs: Don't mark messages as "unsaved" when printing.
emacs: Prefer '[No Subject]' to blank subjects.
emacs/notmuch-lib.el |5
`ps-print-buffer' notes that a buffer is unsaved unless
`buffer-modified-p' returns `nil', so ensure that it does.
---
emacs/notmuch-print.el |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el
index f96ccbe..83eb525 100644
--- a
There's no need to call `truncate-string-to-width' twice in this code
path.
---
emacs/notmuch.el | 14 ++
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 3ec0816..3f6b977 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@
(setq subject "[No Subject]"))
+ subject)
+
;;
(defun notmuch-common-do-stash (text)
diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el
index 83eb525..51bb740 100644
--- a/emacs/notmuch-print.el
+++ b/emacs/notmuch-print.el
@@ -19,6 +19,8 @@
;;
;; Authors: David Edmon
On Wed, 25 Jan 2012 13:51:46 +0100, Thomas Jost wrote:
> Works fine for me, but this also breaks en Emacs test:
>
> FAIL notmuch-show for message with invalid From
> --- emacs.10.expected 2012-01-25 12:50:00.310786410 +
> +++ emacs.10.output 2012-01-25 12:50:00.310786410
On Wed, 25 Jan 2012 13:08:33 +, David Edmondson wrote:
> ---
> emacs/notmuch-lib.el |5 +
> emacs/notmuch-print.el |8 ++--
> emacs/notmuch-show.el |5 -
> emacs/notmuch.el |5 +
> 4 files changed, 16 insertions(+), 7 deletions(-)
`ps-print-buffer' notes that a buffer is unsaved unless
`buffer-modified-p' returns `nil', so ensure that it does.
---
emacs/notmuch-print.el |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el
index f96ccbe..83eb525 100644
--- a
There's no need to call `truncate-string-to-width' twice in this code
path.
---
emacs/notmuch.el | 14 ++
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 3ec0816..3f6b977 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@
\t]*$" subject))
+ (setq subject "[No Subject]"))
+ subject)
+
;;
(defun notmuch-common-do-stash (text)
diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el
index 83eb525..51bb740 100644
--- a/emacs/notmuch-print.el
+++ b/emacs/notmuch-print.el
@@ -19,6 +19,8 @@
;
Three minor cleanup or small improvement patches.
v2: Fix the case where subject can be `nil' in patch 3.
David Edmondson (3):
emacs: Stop the `truncate-string-to-width' madness.
emacs: Don't mark messages as "unsaved" when printing.
emacs: Prefer '[No Subjec
Avoids warnings due to unicode characters and improves display.
v2: Update the existing test output accordingly.
David Edmondson (3):
emacs: Avoid `mail-header-parse-address' in
`notmuch-show-clean-address'.
test: Updated expected output for new `notmuch-show-clean-address
`mail-header-parse-address' expects un-decoded mailbox parts, which is
not what we have at this point. Replace it with simple string
deconstruction.
Mark the corresponding test as no longer broken.
Minor whitespace cleanup.
---
emacs/notmuch-show.el | 50 --
Remove backslashes.
---
emacs/notmuch-show.el | 14 +-
test/emacs-address-cleaning.el |6 --
2 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 1fd2524..c849e84 100644
--- a/emacs/notmuch-show.el
+++ b/
---
test/emacs |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/test/emacs b/test/emacs
index f150d95..8ca4c8a 100755
--- a/test/emacs
+++ b/test/emacs
@@ -78,7 +78,7 @@ thread=$(notmuch search --output=threads
subject:message-with-invalid-from)
test_emacs "(notmuch-show
If the region to be hidden with a button by
`notmuch-wash-region-to-button' starts at the beginning of the buffer,
the invisible region will include the inserted button. This is
unfortunate, as it means that it is not possible to see the button to
be pressed.
Make a little space at the start of th
On Wed, 25 Jan 2012 19:10:35 +0400, Dmitry Kurochkin
wrote:
> On Wed, 25 Jan 2012 15:05:08 +0000, David Edmondson wrote:
> > If the region to be hidden with a button by
> > `notmuch-wash-region-to-button' starts at the beginning of the buffer,
> > the invisible region
The body of the test may cause the current buffer to change. Ensure
that the output goes to the correct buffer by switching back before
inserting it.
---
test/test-lib.el |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/test/test-lib.el b/test/test-lib.el
index 36e793a..
Added a test, which required some improvements to the test harness.
The fix still seems awkward.
David Edmondson (4):
test: `visible-buffer-substring' should not return text properties.
test: `notmuch-test-run' should protect against buffer switching.
test: Add test for Origin
When using `visible-buffer-substring' to examine a buffer, the text
properties are not useful, so don't include them.
---
test/test-lib.el |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/test/test-lib.el b/test/test-lib.el
index bc75f06..36e793a 100644
--- a/test/test-lib
If the region to be hidden with a button by
`notmuch-wash-region-to-button' starts at the beginning of the buffer,
the invisible region will include the inserted button. This is
unfortunate, as it means that it is not possible to see the button to
be pressed.
Make a little space at the start of th
---
test/emacs-original-message-hiding.el | 15 +++
test/emacs-original-message-hiding.sh | 20
test/notmuch-test |1 +
3 files changed, 36 insertions(+), 0 deletions(-)
create mode 100644 test/emacs-original-message-hiding.el
create m
Obviously good, +1.
pgp9PO8Q9MCDD.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Address Dmitry's comments.
David Edmondson (4):
test: `visible-buffer-substring' should not return text properties.
test: `notmuch-test-run' should protect against buffer switching.
test: Add test for Original Message hiding at point-min.
emacs: Take more care when hidi
If the region to be hidden with a button by
`notmuch-wash-region-to-button' starts at the beginning of the buffer,
the invisible region will include the inserted button. This is
unfortunate, as it means that it is not possible to see the button to
be pressed.
Make a little space at the start of th
When using `visible-buffer-substring' to examine a buffer, the text
properties are not useful, so don't include them.
---
test/test-lib.el |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/test/test-lib.el b/test/test-lib.el
index bc75f06..5b32e0a 100644
--- a/test/t
The body of the test may cause the current buffer to change. Ensure
that the output goes to the correct buffer by switching back before
inserting it.
---
test/test-lib.el |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/test/test-lib.el b/test/test-lib.el
index 5b32e0a..
101 - 200 of 2079 matches
Mail list logo
