Re: bug#50460: 27.1; defcustom for mail-user-agent is too strict?

2021-09-08 Thread Lars Ingebrigtsen
David Bremner  writes:

> The defcustom for mail-user-agent looks like
>
> :type '(radio (function-item :tag "Message package"
>  :format "%t\n"
>  message-user-agent)
> ;; [...] snip   
>   (function-item :tag "Message with full Gnus features"
>  :format "%t\n"
>  gnus-user-agent)
>   (function :tag "Other"))
>
> This means that a symbol without a function definition cannot be set
> (using customize) as mail-user-agent. This seem inconsistent with the
> docstring of define-mail-user-agent, 

Yup.  Now fixed in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: bug#49380: 27.1; is mm-inline-message supported outside Gnus?

2021-07-06 Thread Lars Ingebrigtsen
David Bremner  writes:

> That makes sense to me, with the (perhaps obvious) caveat that calling
> without binding the setup function should cleanly do the display
> (perhaps with less fontification) and return.

Yup.  I've now done the refactoring, so there should be no user-visible
changes for Gnus usage, and it should basically work outside of Gnus, too.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: bug#49380: 27.1; is mm-inline-message supported outside Gnus?

2021-07-05 Thread Lars Ingebrigtsen
David Bremner  writes:

> I should have been more precise. I'm calling it indirectly via
> mm-display-part, which is useful in the case where someone attaches a
> message/rfc822 part to their message. In principle notmuch can (and in
> the general case does) render the part directly, but in certain odd
> fall-back cases it is handy to give a visual representation of the part
> in the buffer without parsing etc.. ourselves.  So the user does have a
> mail reader, namely notmuch. In fact I can almost make it work by
> forcing the buffer back into notmuch-show-mode after calling
> mm-display-part, but that has some side-effects I'd prefer to avoid.

Yes, that was what I was thinking about -- the rendered embedded message
can't be easily interacted with without the mail reader being able to
hook into the rendering.  I mean, it's a kinda semi-recursive thing: You
want to be able to use (some of) the mail reader's commands to respond
to the embedded message.  Which is why `mm-inline-message' calls the
Gnus functions here.

But perhaps the function should be rewritten to call a (say)
`mm-inline-message-setup-function', bound by the caller?  Then both Gnus
and notmuch could use the function.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: bug#49380: 27.1; is mm-inline-message supported outside Gnus?

2021-07-04 Thread Lars Ingebrigtsen
David Bremner  writes:

> notmuch-show-mode relies on various mm-* functions to display message
> parts. This is problematic for "message/rfc822" parts, since
> mm-inline-message ends up calling (gnus-article-prepare-display) which
> resets the buffer major-mode to gnus-article-mode since
> notmuch-show-mode is not a derived mode of gnus-article-mode. This
> breaks a few things from a notmuch internals / user point of view.  I
> can forcibly reset the major-mode, but that has it's own problems. I
> would welcome suggestions for workarounds, or clarification of the
> extent to which the functions in mm-view.el are expected to be usable
> outside gnus.

Yeah, it's confusing.  `mm-inline-message' is really an "internal" Gnus
function, while most of the other mm functions are more general.

Disentangling that mess is daunting, but for that function in
particular, I guess it wouldn't be that difficult to rewrite it to avoid
doing anything Gnus-ish unless we're in Gnus...  On the other hand, it's
a function to display a complete message, which leaves you with a buffer
that's pretty pointless unless you have a mail reader to interact with
it afterwards.

So perhaps it should just be renamed and moved to Gnus?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: bug#23747: bug present without emacs25 or notmuch

2019-09-23 Thread Lars Ingebrigtsen
David Bremner  writes:

> David Bremner  writes:
>
>> I have managed to duplicate (I think) this bug without notmuch or emacs
>> 25.
>>
>> In emacs 24.5.1 (on debian)
>>
>> (require 'mml2015)
>> (setq mml2015-sign-with-sender t)
>>
>> M-x toggle-debug-on-error
>>
>> M-x message-mail
>> (fill in some headers, From: me)
>> C-c C-m C-s
>> C-c C-c
>
> I just tried this script in emacs 25.1 (debian) and could not reproduce
> the bug. So maybe it's fixed?

OK; thanks for checking.  I'm closing the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-05-10 Thread Lars Ingebrigtsen
Eli Zaretskii  writes:

> I think so, but I'd be happier if someone from the Gnus folks could
> eyeball this patch.
>
> Lars, any comments/objections?

I think the patch looks OK -- it'll change the behaviour if you have
set enable-multibyte-characters to nil, but...  does anybody do that?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch