perate-all' currently works, i.e. operate on
matched *messages* instead of matched *threads*, is not only counter-
intuitive (same as it would be for `notmuch-search-add-tag' and
`notmuch-search-remove-tag' [2]), but semantically incorrect
On Mon, 11 Jul 2011 17:05:32 -0400, Austin Clements wrote:
> Quoth Pieter Praet on Jul 11 at 10:43 pm:
> > TL;DR: I can haz regex pl0x?
>
> Oof, what a pain. I'm happy to change the output format of search; I
> hadn't realized how difficult it would be to parse.
On Sat, 16 Jul 2011 08:37:52 -0400, Jason Woofenden
wrote:
> I added tag:me to all messages from me.
>
> Then I added this to my index page:
>
> tag:notmuch and tag:unread and tag:me
>
> So my attention could be drawn to threads I'd participated in,
> which had new messages. (This list has eno
On Sat, 16 Jul 2011 16:26:04 +0200, Pieter Praet wrote:
> [SNIP]
> The Notmuch project is in the unique position of being the product of
> Carl's (legimitate) dislike of email (see his talk @ LCA2011 [1]), so
> it's safe to say patches may take some time to pass the gat
On Wed, 13 Jul 2011 14:57:21 -0400, Austin Clements wrote:
> Quoth Pieter Praet on Jul 13 at 4:16 pm:
> > On Mon, 11 Jul 2011 17:05:32 -0400, Austin Clements
> > wrote:
> > > Quoth Pieter Praet on Jul 11 at 10:43 pm:
> > > > TL;DR: I can haz regex pl0x?
Rebased to current master.
Previous version:
id:"1307016220-17509-1-git-send-email-pieter at praet.org"
Discussion:
id:"1317660447-27520-1-git-send-email-schnouki at schnouki.net"
Adds a new test that checks for the presence of 'gpg',
and adds that test as a prereq to all subsequent tests
that rely on GnuPG.
This causes tests with unmet dependencies to be skipped.
---
test/crypto | 33 +++--
1 files changed, 19 insertions(+), 14 deletions(-)
Adds a new test that checks for the presence of 'emacs',
and adds that test as a prereq to all subsequent tests
that rely on Emacs.
This causes tests with unmet dependencies to be skipped.
---
test/crypto | 17 ++---
1 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/t
Adds a new test that checks for the presence of 'emacs',
and adds that test as a prereq to all subsequent tests
that rely on Emacs.
This causes tests with unmet dependencies to be skipped.
---
test/emacs | 65 ---
1 files changed, 35 inse
Adds a new test that checks for the presence of 'emacs',
and adds that test as a prereq to all subsequent tests
that rely on Emacs.
This causes tests with unmet dependencies to be skipped.
---
test/emacs-large-search-buffer |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff
- without GNU Screen:
> All 247 tests behaved as expected (1 expected failure).
> 46 tests skipped.
> - with GNU Screen:
> 242/247 tests passed.
> 2 broken tests failed as expected.
> 3 tests failed.
>
> (The 3 failed tests come from some trouble w
On Mon, 3 Oct 2011 18:47:17 +0200, Thomas Jost
wrote:
> [...]
The SCREEN prereq would preferrably be added in a separate commit.
Also, you appear to have given *every* test the EMACS+GPG prereq,
while only the ones using `emacs_deliver_message' require EMACS.
Peace
--
Pieter
On Mon, 3 Oct 2011 18:47:18 +0200, Thomas Jost
wrote:
> [...]
Nice catches @
- "Sending a message via (fake) SMTP"
- "Hiding message following HTML part"
(though I think the latter test wasn't there yet when I submitted my
patch series)
New "issues":
- The SCREEN prereq would preferr
On Tue, 18 Oct 2011 08:18:18 -0700, Jameson Graef Rollins wrote:
> On Mon, 10 Oct 2011 15:49:03 +0200, Daniel Schoepe
> wrote:
> > On Tue, 5 Jul 2011 20:33:00 +0200, Pieter Praet
> > wrote:
> > > To allow for expansion whilst keeping everything tidy and organize
On Tue, 01 Nov 2011 20:57:59 +0100, Pieter Praet wrote:
> On Mon, 3 Oct 2011 18:47:18 +0200, Thomas Jost
> wrote:
> [...]
> - @ "Verify that sent messages are saved/searchable (via FCC)":
>
> This doesn't need an EMACS prereq.
> [...]
My mistake, s
On Tue, 01 Nov 2011 20:56:17 +0100, Pieter Praet wrote:
> On Mon, 3 Oct 2011 18:47:17 +0200, Thomas Jost
> wrote:
> [...]
>
> Also, you appear to have given *every* test the EMACS+GPG prereq,
> while only the ones using `emacs_deliver_message' require EMACS.
>
>
On Tue, 01 Nov 2011 14:17:51 -0700, Jameson Graef Rollins wrote:
> On Tue, 1 Nov 2011 20:49:11 +0100, Pieter Praet wrote:
> > -test_expect_success 'emacs delivery of signed message' \
> > +test_expect_success GPG 'emacs delivery of signed message' \
>
&g
On Tue, 1 Nov 2011 22:20:25 +0200, Ali Polatel wrote:
> On Tue, Nov 01, 2011 at 08:49:10PM +0100, Pieter Praet wrote:
> >Rebased to current master.
> >
> >Previous version:
> > id:"1307016220-17509-1-git-send-email-pieter at praet.org"
> >
> >
On Mon, 31 Oct 2011 23:59:49 -0300, David Bremner wrote:
> On Fri, 30 Sep 2011 01:26:46 +0200, Thomas Schwinge
> wrote:
> > This new test currently fails -- but it shouldn't.
> > ---
> >
> > Hi!
> >
> > I found this while manually copying directories and running notmuch new.
> >
> > Am I just
On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins wrote:
> From: Tomi Ollila
>
> dtach is lighter than screen and is not setuid/setgid program so
> TMPDIR does not get reset by dynamic loader when executed.
>
`dtach' may be lighter than `screen', but contrary to my expectations,
it app
On Fri, 1 Jul 2011 06:03:50 +0400, Dmitry Kurochkin wrote:
> The patch adds a test to check that json show format includes
> filenames for attachments with inline disposition.
> ---
>
> Carl, I owe you this test case for my patch that added filenames
> for inline attachments :)
>
> Regards,
>
On Sat, 08 Oct 2011 20:46:44 -0700, Jameson Graef Rollins wrote:
> On Sat, 27 Aug 2011 14:38:26 +0200, Michal Sojka
> wrote:
> > Emacs 23.2 queries by default about killing existing processes. This
> > is annoying when one wants to interrupt long search with 'q' key.
> > Disable this behavior fo
On Sun, 6 Nov 2011 12:17:36 -0500, Austin Clements wrote:
> This is a rebase and cleanup of Istvan Marko's patch from
> id:m3pqnj2j7a.fsf at zsu.kismala.com
>
Fantastic performance improvement Austin! This should be merged in ASAP.
BTW, compacting the db from time to time also has a significa
On Fri, 11 Nov 2011 02:33:38 +0100, Pieter Praet wrote:
> On Sun, 6 Nov 2011 12:17:36 -0500, Austin Clements
> wrote:
> > This is a rebase and cleanup of Istvan Marko's patch from
> > id:m3pqnj2j7a.fsf at zsu.kismala.com
> >
>
> Fantastic performance
On Sun, 30 Oct 2011 11:54:07 -0400, Ivy Foster
wrote:
> On Sun, 30 Oct 2011 11:06:38 +0100, Thomas Jost
> wrote:
> > On Sat, 29 Oct 2011 12:35:04 -0400, Ivy Foster
> > wrote:
> > > The following patch adds a mode-hook to
> > > notmuch-hello-mode. Not much else to say, really.
>
> > I agree i
On Thu, 10 Nov 2011 14:22:30 -0500, servilio wrote:
> On 10 November 2011 08:33, Sebastian Spaeth wrote:
> > On Tue, ?8 Nov 2011 21:55:28 -0500, Austin Clements
> > wrote:
> >> ?emacs/notmuch.el | ? 11 +++
> >> ?1 files changed, 3 insertions(+), 8 deletions(-)
> >
> >
> > Tested and wor
On Thu, 10 Nov 2011 23:53:41 -0500, Austin Clements wrote:
> Quoth Pieter Praet on Nov 11 at 4:04 am:
> > On Thu, 10 Nov 2011 14:22:30 -0500, servilio wrote:
> > > On 10 November 2011 08:33, Sebastian Spaeth
> > > wrote:
> > > > On Tue, ?8 N
On Fri, 11 Nov 2011 00:27:16 -0500, Austin Clements wrote:
> Quoth myself on Nov 10 at 11:53 pm:
> > Quoth Pieter Praet on Nov 11 at 4:04 am:
> > > I've tried getting some hard numbers using
> > >
> > > #+begin_src sh
> > >
On Fri, 11 Nov 2011 10:09:17 +0200, Tomi Ollila wrote:
> On Fri, 11 Nov 2011 01:17:37 +0100, Pieter Praet wrote:
> > On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins > finestructure.net> wrote:
> > > From: Tomi Ollila
> > >
> > > dtach is li
On Fri, 11 Nov 2011 12:29:34 -0500, David Bremner wrote:
> On Sat, 16 Apr 2011 15:12:43 +0200, Pieter Praet wrote:
> > Calling notmuch-help in notmuch-hello-mode results in error
> > "apply: Wrong type argument: listp, keymap"
>
> Hi Pieter;
>
> I'm a
On Sat, 12 Nov 2011 04:08:45 +0400, Dmitry Kurochkin wrote:
> Hi all.
>
> Any objections to this trivial patch? Can we get it pushed?
>
Appears to have been deprecated in favor of the original patch:
id:"1309762025-1172-1-git-send-email-dmitry.kurochkin at gmail.com"
See commit e972d752.
> R
On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin wrote:
> It is very convenient when C-e (bound to `widget-end-of-line') ignores
> trailing spaces inside the search widget. But it only does so if a
> widget is not followed by a newline (that is why it works in the saved
> search widgets). Th
On Sun, 13 Nov 2011 16:14:35 +0200, Jani Nikula wrote:
> On Sat, 12 Nov 2011 10:17:30 -0500, David Bremner
> wrote:
> > On Thu, 30 Jun 2011 10:20:29 +0200, Pieter Praet
> > wrote:
> > > Alter `do_search_tags()' to prepend each result with `tag:&
On Sun, 13 Nov 2011 15:00:56 -0800, Jameson Graef Rollins wrote:
> On Sat, 12 Nov 2011 10:17:30 -0500, David Bremner
> wrote:
> > What do people think about this change? Personally I will have change
> > some scripts to not add "tag:", but it isn't that big of a deal.
>
> I would actually prefe
Merge expected output into the actual test, so we can verify the stashed
filename using ${gen_msg_filename} instead of doing sed tricks.
---
Thanks David!
Here's a small update that was hanging out on one of my local branches.
Peace
test/emacs| 14 +++
On Sat, 12 Nov 2011 13:24:40 -0800, Jameson Graef Rollins wrote:
> On Sat, 12 Nov 2011 23:07:38 +0200, Tomi Ollila wrote:
> > 1) add line
> > { echo QUIT > /dev/tcp/127.0.0.1/25025; } 2>/dev/null
>
> I have no directory called "/dev/tcp" on my system.
>
You shouldn't. See (info "(bash)Re
On Sun, 13 Nov 2011 13:46:30 -0400, David Bremner wrote:
> On Tue, 01 Nov 2011 20:54:49 +0100, Pieter Praet wrote:
> >
> > I'll be commenting on these modified commits where needed, and have
> > re-submitted my original series (rebased to current master) in a new
>
On Sat, 12 Nov 2011 11:35:02 -0500, Austin Clements wrote:
> Quoth David Bremner on Nov 12 at 11:13 am:
> > On Sun, 10 Jul 2011 17:55:35 +0200, Pieter Praet
> > wrote:
> > > In order to be consistent with `notmuch-search-{add,remove}-tag'
> > > ("
Thanks David, awesome job!
Peace
--
Pieter
Add news entries for commits:
f9764bfacc97457d1154c2d2a6001a6564f13ec3
64febdf71c4184ca369f5d11d7f196704a3ec1a6
---
NEWS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/NEWS b/NEWS
index 044a51e..6c064da 100644
--- a/NEWS
+++ b/NEWS
@@ -8,6 +8,8 @@ Emacs tests are
No further explanation needed.
---
NEWS | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/NEWS b/NEWS
index 6c064da..daec4ad 100644
--- a/NEWS
+++ b/NEWS
@@ -130,7 +130,7 @@ Ruby bindings changes
-
- Wrap new library functions notmuch_da
done using the "hash" built-in instead of
> "which",
> as suggested in [3].
>
> Tested with and without dtach. A previous version of this series was also
> without emacs/gpg in a chroot, but not this one :)
>
> [1] id:"874ny4fcdz.fsf at prae
On Tue, 15 Nov 2011 12:17:59 -0500, servilio wrote:
> Hi,
>
> Given that this change is about display of search results, I have the
> suspicion that the following two factors might be more relevant:
>
> - size of the Emacs frame: bigger would mean more threads to show
>
> - composition of the s
On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila wrote:
> On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet wrote:
> > No further explanation needed.
> > ---
> > NEWS | 14 +++---
> > 1 files changed, 7 insertions(+), 7 deletions(-)
>
> The 'No
e buffer, and displays the next
> +thread from the search from which this thread was originally
> +shown."
> + (interactive)
> + (if (notmuch-show-advance)
> + (notmuch-show-archive-thread)))
>
> (defun notmuch-show-rewind ()
>"Backup through the thread, (rev
On Wed, 16 Nov 2011 18:17:46 -0400, David Bremner wrote:
> On Wed, 16 Nov 2011 21:37:48 +0100, Pieter Praet wrote:
> > Thanks David, awesome job!
> >
> >
>
> You're very welcome. I hope you still feel that way when you see how I
> amended your commits
On Sun, 25 Dec 2011 15:55:43 -0400, David Bremner wrote:
>
> Well, it's -19C outside, so guess that is appropriate.
>
> I have merged master to release in preparation for release. There should
> only be additions to NEWS or fixes for serious bugs for branch release
> until 0.11 is out the door.
On Wed, 16 Nov 2011 23:47:53 +0100, Pieter Praet wrote:
> On Sun, 13 Nov 2011 13:16:48 -0800, Jameson Graef Rollins finestructure.net> wrote:
> > This patch breaks out much of the functionality of
> > notmuch-show-advance-and-archive into a new function:
> > notmuch
On Thu, 17 Nov 2011 08:21:59 +0200, Jani Nikula wrote:
> On Nov 16, 2011 11:39 PM, "Pieter Praet" wrote:
> >
> > On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila
> wrote:
> > > On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet
> wrot
On Thu, 17 Nov 2011 11:14:11 +0100, Thomas Jost
wrote:
> On Wed, 16 Nov 2011 21:50:17 +0100, Pieter Praet wrote:
> > On Wed, 16 Nov 2011 15:33:49 +0100, Thomas Jost
> > wrote:
> > > Hello list,
> > >
> > > This is another rebased version of Pieter&#x
On Tue, 22 Nov 2011 22:40:21 -0500, Austin Clements wrote:
> Quoth Jameson Graef Rollins on Nov 20 at 12:10 pm:
> > The open question seems to be how we handle the content encoding
> > parameters. My argument is that those should either be used by notmuch
> > to properly encode the content for th
On Sun, 20 Nov 2011 22:35:42 +0400, Dmitry Kurochkin wrote:
> On Sat, 19 Nov 2011 08:59:29 -0400, David Bremner
> wrote:
> > On Sat, 19 Nov 2011 08:18:41 +0400, Dmitry Kurochkin > gmail.com> wrote:
> > > Before the change, notmuch used g_mime_content_type_to_string(3)
> > > function to output C
To allow for expansion whilst keeping everything tidy and organized,
move all defcustom/defface variables to the following subgroups,
defined in notmuch-lib.el:
- Hello
- Search
- Show
- Send
- Crypto
- Hooks
- Appearance
- External Commands
As an added benefit, defcustom keyword args are now con
On Sun, 27 Nov 2011 22:36:12 +0400, Dmitry Kurochkin wrote:
> Changes:
>
> v3 since v2:
>
> * rebased the remaining patches on current master
>
> v2 since v1:
>
> * Add test_require_external_prereq function to explicitly check for
> external dependencies, use it in test_emacs.
>
> * Indenti
When running the Emacs tests in verbose mode, only the first missing
prereq is reported because the `run_emacs' function is short-circuited
early:
#+begin_example
emacs: Testing emacs interface
missing prerequisites: [0] emacs(1)
skipping test: [0] Basic notmuch-hello view in ema
On Sun, 18 Dec 2011 20:18:03 +0400, Dmitry Kurochkin wrote:
> On Sun, 18 Dec 2011 18:12:51 +0200, Tomi Ollila wrote:
> > On Sun, 18 Dec 2011 19:50:52 +0400, Dmitry Kurochkin > gmail.com> wrote:
> > > +1 for the former.
> >
> > +1
> >
> > > How about indenting with spaces+tabs vs indenting with
On Wed, 21 Dec 2011 11:35:37 -0800, Jameson Graef Rollins wrote:
> On Wed, 21 Dec 2011 07:44:16 -0400, David Bremner
> wrote:
> [SNIP]
>
> > On my machine all of the programs (except nottoomuch ;) ) that use
> > ~/.config are gui based, and a bunch of them store binary blobs (or not
> > plain t
On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins wrote:
> Since message-ids necessarily match just a single message, there's no
> reason to do a search for the id before viewing the actual message;
> the search just becomes an extra screen to click through. Clicking on
> an id: links now
"Worldwide, -ize endings prevail in scientific writing and are commonly
used by many international organizations, such as the ISO and the
WHO. The European Union switched from -ize to -ise some years ago in its
English language publications, and this resulted in the coexistence of
the -ize spelling
* emacs/notmuch-show.el (notmuch-show-found-target-p): new predicate function
that uses notmuch(1) 'count' to see if a query turns up any results.
* emacs/notmuch-show.el (notmuch-show-if-found): new function that only shows
a message/thread if present in the database and otherwise returns an
* emacs/notmuch-show.el (notmuch-show-buttonized-link-present),
* emacs/notmuch-show.el (notmuch-show-buttonized-link-present-and-unread),
* emacs/notmuch-show.el (notmuch-show-buttonized-link-missing):
new faces for buttonized id: links.
* emacs/notmuch-show.el (notmuch-show-found-target-p): ad
On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner wrote:
> It turns out that our existing (trivial) python test is enough to
> catch this bug, but the corpus needs to be augmented. This
> augmentation is a bit intrusive so I'm thinking of cherry-picking only
> the actual fix to the release branch
On Mon, 12 Dec 2011 14:26:21 -0400, David Bremner wrote:
> On Sun, 11 Dec 2011 20:41:53 +0400, Dmitry Kurochkin gmail.com> wrote:
> > Hi David.
> >
> > On Sun, 11 Dec 2011 12:07:51 -0400, David Bremner
> > wrote:
> > > From: David Bremner
> > >
> > > Two new internal routines are created _co
Should have come before commit 1df71b55
---
test/config | 88 +
test/notmuch-test |1 +
2 files changed, 89 insertions(+), 0 deletions(-)
create mode 100755 test/config
diff --git a/test/config b/test/config
new file mode 100755
in
On Mon, 12 Dec 2011 22:50:04 +0200, Jani Nikula wrote:
> Support nil value for notmuch-poll-script to run "notmuch new" instead of
> an external script, and make this the new default. "notmuch new" is run
> using the configured notmuch-command.
>
> This allows taking better advantage of the "notm
Less code, same results, without sacrificing readability.
---
emacs/notmuch-address.el |6 +++---
emacs/notmuch-hello.el | 20 ++--
emacs/notmuch-show.el| 12 ++--
emacs/notmuch.el |8
4 files changed, 23 insertions(+), 23 deletions(-)
d
On Thu, 12 Jan 2012 23:46:46 -0400, David Bremner wrote:
> On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet wrote:
> > On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner
> > wrote:
>
> > with differing hashes), this has the potential of causing confusion
> > and
On Fri, 13 Jan 2012 05:05:35 -0400, David Bremner wrote:
> On Thu, 12 Jan 2012 23:46:46 -0400, David Bremner
> wrote:
> > On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet
> > wrote:
> > > On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner
> > > wrote:
>
On Thu, 12 Jan 2012 23:42:04 -0400, David Bremner wrote:
> On Thu, 12 Jan 2012 18:30:01 +0100, Pieter Praet wrote:
> > Should have come before commit 1df71b55
>
> This doesn't seem like an especially helpful commit
> message. Editorializing is ok, I guess, but
Full test coverage for getting, setting and removing options in
notmuch(1)'s config file ($NOTMUCH_CONFIG or $HOME/.notmuch-config).
---
Please *do* take note of the FIXME in the last test!
test/config | 88 +
test/notmuch-test |1 +
On Thu, 12 Jan 2012 23:16:29 -0400, David Bremner wrote:
> On Thu, 12 Jan 2012 18:08:08 +0100, Pieter Praet wrote:
> > > > - The previous point is a bit of a counterargument to this, but in
>
> > > I couls separate it. I made is a single patch to avoid having a
>
On Thu, 12 Jan 2012 23:11:35 -0400, David Bremner wrote:
> On Thu, 12 Jan 2012 18:06:14 +0100, Pieter Praet wrote:
> > That would indeed have been the most sensible thing to do.
> >
> > Could someone (who -unlike me- has already submitted his/her public SSH
> >
On Thu, 12 Jan 2012 23:31:34 -0400, David Bremner wrote:
> On Thu, 12 Jan 2012 18:12:16 +0100, Pieter Praet wrote:
> > To allow for expansion whilst keeping everything tidy and organized,
> > move all defcustom/defface variables to the following subgroups,
> > defi
To allow for expansion whilst keeping everything tidy and organized,
move all defcustom/defface variables to the following subgroups,
defined in notmuch-lib.el:
- Hello
- Search
- Show
- Send
- Crypto
- Hooks
- External Commands
- Appearance
As an added benefit, defcustom keyword args are now con
On Fri, 13 Jan 2012 16:15:59 +, David Edmondson wrote:
> On Thu, 12 Jan 2012 23:31:34 -0400, David Bremner
> wrote:
> > On Thu, 12 Jan 2012 18:12:16 +0100, Pieter Praet
> > wrote:
> > > To allow for expansion whilst keeping everything tidy and organized,
>
On Thu, 12 Jan 2012 21:34:29 +0400, Dmitry Kurochkin wrote:
> On Thu, 12 Jan 2012 18:16:59 +0100, Pieter Praet wrote:
> > When running the Emacs tests in verbose mode, only the first missing
> > prereq is reported because the `run_emacs' function is short
When running the Emacs tests in verbose mode, only the first missing
prereq is reported because the `run_emacs' function is short-circuited
early:
#+begin_example
emacs: Testing emacs interface
missing prerequisites: [0] emacs(1)
skipping test: [0] Basic notmuch-hello view in ema
On Fri, 13 Jan 2012 08:23:55 +, David Edmondson wrote:
> On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet wrote:
> > Less code, same results, without sacrificing readability.
>
> +1, but why not replace non-branching `if' with `when' as well?
I was planning to
Less code, same results, without sacrificing readability.
---
emacs/notmuch-show.el | 20 +---
emacs/notmuch-wash.el | 47 +++
emacs/notmuch.el | 28 +---
3 files changed, 45 insertions(+), 50 deletions
On Fri, 13 Jan 2012 16:06:17 +, David Edmondson wrote:
> On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet wrote:
> > Less code, same results, without sacrificing readability.
>
> Does this change correctly re-indent the line following the if/unless?
It does...
Or so I thou
On Thu, 12 Jan 2012 12:28:40 -0500, Austin Clements wrote:
> Quoth Pieter Praet on Jan 12 at 6:07 pm:
> > On Tue, 22 Nov 2011 22:40:21 -0500, Austin Clements
> > wrote:
> > > Quoth Jameson Graef Rollins on Nov 20 at 12:10 pm:
> > > > The open question s
ffer buffer)
> + return buffer))
> +
> +(if first
> + ;; If the first one we found is any other than the starting
> + ;; buffer, switch to it.
> + (unless (eq first start)
> + (switch-to-buffer first))
>(notmuch
>
> (setq mail
On Tue, 10 Jan 2012 22:15:02 +0200, Jani Nikula wrote:
> I don't feel qualified to review,
Allow me to disagree: your feeling and reality appear to be disjoint ATM :)
Peace
--
Pieter
On Sat, 14 Jan 2012 10:14:57 +0100, Pieter Praet wrote:
> On Fri, 13 Jan 2012 08:23:55 +, David Edmondson wrote:
> > On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet
> > wrote:
> > > Less code, same results, without sacrificing readability.
> >
> > +
On Thu, 12 Jan 2012 18:04:10 +0100, Pieter Praet wrote:
> On Wed, 16 Nov 2011 23:47:53 +0100, Pieter Praet wrote:
> > On Sun, 13 Nov 2011 13:16:48 -0800, Jameson Graef Rollins > finestructure.net> wrote:
> > > This patch breaks out much of the functionality of
> &
On Sat, 14 Jan 2012 08:16:30 -0400, David Bremner wrote:
> On Sat, 14 Jan 2012 09:57:56 +0100, Pieter Praet wrote:
> > Full test coverage for getting, setting and removing options in
> > notmuch(1)'s config file ($NOTMUCH_CONFIG or $HOME/.notmuch-config).
> >
> >
On Sat, 14 Jan 2012 13:08:28 -0500, Austin Clements wrote:
> Quoth Pieter Praet on Jan 14 at 10:04 am:
> > To allow for expansion whilst keeping everything tidy and organized,
> > move all defcustom/defface variables to the following subgroups,
> > defined in notmuch-lib
To allow for expansion whilst keeping everything tidy and organized,
move all defcustom/defface variables to the following subgroups,
defined in notmuch-lib.el:
- Hello
- Search
- Show
- Send
- Crypto
- Hooks
- External Commands
- Appearance
As an added benefit, defcustom keyword args are now con
On Sun, 15 Jan 2012 17:56:37 +0400, Dmitry Kurochkin wrote:
> On Sat, 14 Jan 2012 10:07:41 +0100, Pieter Praet wrote:
> > On Thu, 12 Jan 2012 21:34:29 +0400, Dmitry Kurochkin > gmail.com> wrote:
> > > On Thu, 12 Jan 2012 18:16:59 +0100, Pieter Praet
> > > wrot
CLisp'ier version of `notmuch-cycle-notmuch-buffers', merged into `notmuch',
eliminating the need to hog yet another keybind.
FYI: causes 2 compile warnings due to requiring the cl package at runtime.
---
emacs/notmuch.el | 34 --
1 files changed, 8 insertions(+)
Less code, same results, without sacrificing readability.
---
v2: Fixed indentation oversight @ `notmuch-hello-insert-tags'.
emacs/notmuch-address.el |6 +++---
emacs/notmuch-hello.el | 22 +++---
emacs/notmuch-show.el| 12 ++--
emacs/notmuch.el |
On Mon, 16 Jan 2012 10:56:03 +, David Edmondson wrote:
> Given the discussion that followed this patch I'd like to mark it as
> 'obsolete'.
>
> Any objections?
None whatsoever :)
Peace
--
Pieter
On Tue, 27 Dec 2011 16:47:14 +, David Edmondson wrote:
> The tags were coloured using text properties. Unfortunately that text
> (the header line) also has an overlay, which overrides the text
> properties. There's not point in applying text properties that will
> never be seen.
> ---
> emacs
On Mon, 16 Jan 2012 11:06:25 +, David Edmondson wrote:
> On Mon, 16 Jan 2012 11:42:31 +0100, Pieter Praet wrote:
> > CLisp'ier version of `notmuch-cycle-notmuch-buffers', merged into `notmuch',
> > eliminating the need to hog yet another keybind.
>
>
On Mon, 16 Jan 2012 12:28:06 +0100, Pieter Praet wrote:
> On Mon, 16 Jan 2012 11:06:25 +, David Edmondson wrote:
> > On Mon, 16 Jan 2012 11:42:31 +0100, Pieter Praet
> > wrote:
> > > CLisp'ier version of `notmuch-cycle-notmuch-buffers', merged into
>
On Mon, 16 Jan 2012 11:22:27 +, David Edmondson wrote:
> On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet wrote:
> > Alas, those text properties actually *were* effective (and I liked them :)
>
> Well, not in emacs 24. My reading of the source was that overlays were
> in
On Mon, 16 Jan 2012 11:47:03 +, David Edmondson wrote:
> On Mon, 16 Jan 2012 12:28:06 +0100, Pieter Praet wrote:
> > Perhaps we could use `ido-completion-help', like Org-mode does with
> > `org-iswitchb' ? OTOH, that would require an extra [RET]. Bah...
Make `notmuch-cycle-notmuch-buffers' more Lispy and merge into `notmuch',
eliminating the need to hog yet another keybind.
---
emacs/notmuch.el | 40 ++--
1 files changed, 14 insertions(+), 26 deletions(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
ind
On Mon, 16 Jan 2012 07:37:13 -0400, David Bremner wrote:
> On Mon, 16 Jan 2012 11:31:11 +0100, Pieter Praet wrote:
> >
> > Hmmm, `dnsdomainname' returns "(none)" here; Does it work for you?
> >
> > Running `domainname' instead seems to do the r
On Mon, 16 Jan 2012 11:43:25 +, David Edmondson wrote:
> On Thu, 12 Jan 2012 18:23:44 +0100, Pieter Praet wrote:
> > + (make-text-button string-start string-end
> > 'action `(lambda (arg)
> > - (notmuch-show ,(
501 - 600 of 786 matches
Mail list logo
