Re: [PATCH v5 2/4] util/repair: identify and repair "Mixed Up" mangled messages

On Sun, Sep 15 2019, Daniel Kahn Gillmor wrote: > This patch implements a functional identification and repair process If there is going to be more versions, then the above could be changed to either 1) This commit implements... or just 2) Implement a functional ... > for "Mixed Up" MIME mes

Re: version 4: Retrieve GPG keys asynchronously.

On Wed, Sep 11 2019, Daniel Kahn Gillmor wrote: > In id:87blw1rldy@tethera.net, bremner identified two of my edits > breaking dme's series that permits asynchronous retrieval of OpenPGP > keys. > > This is a revision of that series that should apply to the current > master, taking into account

Re: [PATCH] Drop devel/printmimestructure (it is in mailscripts 0.11)

On Sun, Sep 15 2019, Daniel Kahn Gillmor wrote: > mailscripts 0.11 now ships a derivative of devel/printmimestructure > called email-print-mime-structure. Maintenance for that utility will > happen in mailscripts from now on, so we should not track an > independent copy of it in notmuch's source

[PATCH] configure: disallow whitespace in paths, extend checks to $PWD

Whitespace in $NOTMUCH_SRCDIR (and $PWD) may work in builds, but definitely will not work in tests. It would be difficult to make tests support whitespace in test filename paths -- and fragile to maintain if done. So it is just easier and safer to disallow whitespace there. In case of out of tree

Re: [PATCH v1 2/2] emacs: Bind "u" to jump to the parent message in a thread

On Thu, Aug 29 2019, David Edmondson wrote: > --- > emacs/notmuch-show.el | 55 +++ > 1 file changed, 55 insertions(+) > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 1e3834f2..7c50d2cd 100644 > --- a/emacs/notmuch-show.el > +++ b/ema

Re: [PATCH v2] configure: fix out of tree build; check unsafe characters in srcdir

On Thu, Aug 29 2019, Daniel Kahn Gillmor wrote: > On Mon 2019-08-26 20:03:46 +0300, Tomi Ollila wrote: >> While check for GMime session key extraction support... was made >> out of tree build compatible, related (and some unrelated) unsafe >> characters are now checked in not

[PATCH v2] configure: fix out of tree build; check unsafe characters in srcdir

While check for GMime session key extraction support... was made out of tree build compatible, related (and some unrelated) unsafe characters are now checked in notmuch source directory path. The known unsafe characters in NOTMUCH_SRCDIR are: - Single quote (') -- NOTMUCH_SRCDIR='${NOTMUCH_SRCDIR

[PATCH] configure: fix out of tree build; check unsafe characters in srcdir

While check for GMime session key extraction support... was made out of tree build compatible, related (and some unrelated) unsafe characters are now checked in notmuch source directory path. The known unsafe characters in NOTMUCH_SRCDIR are: - Single quote (') -- NOTMUCH_SRCDIR='${NOTMUCH_SRCDIR

Re: [PATCH 1/3] test: add known broken tests for from: and subject:

On Wed, Aug 21 2019, David Bremner wrote: > Given we want 'a b' to parse as 'a AND b', then for any > probabilistic (free text) prefix foo:, we should also get 'foo:a > foo:b' expanding to 'foo:a AND foo:b'. Currently this is not true due > to the implimentation of regex fields. implementation =D

Re: regex [X-Z] with non-ascii char returns different results from (X|Y|Z)

On Thu, Aug 22 2019, David Bremner wrote: > "yury.t" writes: > >> Thank you for your reply. >> I confirmed that the issue is reproduced in C program.  >> https://pastebin.com/5NaCM45G >> >> Sorry for bothering you... > > I'm not sure, but it might be a glibc bug. S

Re: Indentation style

On Tue, Jul 30 2019, Ralph Seichter wrote: > * Tomi Ollila: > >> I like mixed tabs and spaces. for example cursor moves faster... > > If that's the case, you're just not using the right keys to move around > the source code. :-) In Vim, keys like W/B, +/- etc. i

Re: Indentation style

On Sun, Jul 28 2019, Daniel Kahn Gillmor wrote: > > (fwiw, i would also be happy if we moved away from literal tabs and just > used spaces-only. But i am not interested in setting off a flamewar, > so if anyone prefers the mixed-tabs-and-spaces situation we are in > today, i will never mention th

Re: notmuch ignoring alot of emails

On Fri, Jun 28 2019, Alvaro Herrera wrote: > On 2019-Jun-28, Alvaro Herrera wrote: > >> I think a real solution is to parse the message header, look for the >> Content-Length, and determine mbox-ness by looking for "From" only past >> that many bytes; that seems to match what other mail parsing to

Re: v3 of test speedup by replacing gdb with LD_PRELOAD

On Wed, Jun 26 2019, Daniel Kahn Gillmor wrote: > Here are the two patches from this series, revised according to the > on-list discussion. > > In particular, the revision from Bremner's original series are: > > * LD_PRELOAD is now prepended to, not clobbered (thanks, Tomi!) > * gen_insert_msg i

Re: [PATCH 1/2] test: provide machinery to make and use test_shims

On Sun, May 26 2019, David Bremner wrote: > These can be used e.g. to override return values for functions, in > place of the existing scripting of gdb. > --- > test/test-lib.sh | 16 > 1 file changed, 16 insertions(+) > > diff --git a/test/test-lib.sh b/test/test-lib.sh > index

Re: [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

On Mon, Jun 24 2019, Daniel Kahn Gillmor wrote: > On Fri 2019-06-14 08:16:14 -0300, David Bremner wrote: >> Ralph Seichter writes: >> >>> * Daniel Kahn Gillmor: >>> Perhaps Ralph Seichter (explicitly cc'ed above) could comment on how it'll affect homebrew? >>> >>> MacPorts, actually. ;-

Re: [PATCH v2 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

On Mon, Jun 10 2019, Daniel Kahn Gillmor wrote: > diff --git a/test/T070-insert.sh b/test/T070-insert.sh > index 48165caa..017124fc 100755 > --- a/test/T070-insert.sh > +++ b/test/T070-insert.sh > @@ -266,30 +264,18 @@ gen_insert_msg > > for code in FILE_NOT_EMAIL READ_ONLY_DATABASE UPGRADE_RE

Re: [PATCH] configure: fix mktemp call for macOS

On Sat, Jun 15 2019, Ralph Seichter wrote: > * Tomi Ollila: > >> First, it would be better if >> >> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XX") >> >> worked, then the behaviour on Linux would not change. > > I'm trying to

[PATCH] test: aggregate-results.sh: count test files where all tests skipped

Previously, when all tests were skipped on a test file, there were no indication of this in the final results aggregate-results.sh printed. Now count of the files where all tests were skipped is printed. --- test/aggregate-results.sh | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-)

Fwd: Delivery Status Notification (Failure)

ovat virheelliset tai vanhentuneet. Tarkista kyseisen tilin asetukset ja yritä lähettää viesti uudelleen. LISÄTIETOJA <https://support.google.com/mail/?p=CustomFromDenied> -- Forwarded message -- From: Tomi Ollila To: notmuch@notmuchmail.org Cc: Bcc: Date: Fri, 14 Jun 2019

Re: [PATCH] configure: fix mktemp call for macOS

On Fri, Jun 14 2019, Tomi Ollila wrote: > On Fri, Jun 14 2019, Ralph Seichter wrote: > >> * David Bremner: >> >>> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XX") >>> >>> (borrowed from test/test-lib.sh). This avoids hardcoding the t

Re: [PATCH] configure: fix mktemp call for macOS

On Fri, Jun 14 2019, Ralph Seichter wrote: > * David Bremner: > >> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XX") >> >> (borrowed from test/test-lib.sh). This avoids hardcoding the temporary >> directory. > > I had the same thought at first, but I want to ensure that the path > length does

Re: [PATCH 4/8] cli: run uncrustify

On Thu, Jun 13 2019, David Bremner wrote: > From: uncrustify > > This is the result of running > > $ uncrustify --replace --config devel/uncrustify.cfg *.c *.h > > in the top level source directory > --- Everything else than this one thing below and what I noticed looked like what I've reme

Re: [PATCH 1/7] cli: replace use of !! with macro

On Wed, Jun 12 2019, David Bremner wrote: > The slightly annoying reason to do this is because uncrustify can't > handle '!! foo' sensibly. The less annoying reason is that it helps > understand what the code does. > --- > command-line-arguments.c | 16 +--- > 1 file changed, 9 insert

Re: [PATCH] build: drop variable HAVE_EMACS. use WITH_EMACS instead

On Tue, Jun 11 2019, David Bremner wrote: > The extra flexibility of having both HAVE_EMACS (for yes, there is an > emacs we can use) and WITH_EMACS (the user wants emacs support) lead > to confusion and bugs. We now just force WITH_EMACS to 0 if no > suitable emacs is detected. LGTM. Tomi > --

Re: STYLE and uncrustify

On Fri, Jun 07 2019, David Bremner wrote: > I'm pondering running uncrustify on all/most of the notmuch codebase, > but I noticed a few things that uncrustify does are either not > documented in STYLE, or maybe contradicted. > > 1) Should block comments start with '*' ? Uncrustify thinks yes, STYL

Re: [PATCH 2/2] doc: Don't install emacs docs when they are not built

On Mon, Jun 10 2019, David Bremner wrote: > In 40b025 we stopped building the notmuch-emacs documentation if > HAVE_EMACS=0 (i.e. no emacs was detected by configure). Unfortunately > we continued to try to install the (non-existent) documentation, which > causes build/install failures. > > As a bo

Re: [PATCH] doc: Don't install emacs docs when they are not built

On Mon, Jun 10 2019, David Bremner wrote: > In 40b025 we stopped building the notmuch-emacs documentation if > HAVE_EMACS=0 (i.e. no emacs was detected by configure). Unfortunately > we continued to try to install the (non-existent) documentation, which > causes build/install failures. > > As a bo

Re: Ye olde Apple mktemp

On Mon, Jun 10 2019, Ralph Seichter wrote: > Another quirk that occurs during the configuration phase on older macOS > versions (when they were still called OS X, actually) in the MacPorts > build farm: > > Checking for GMime session key extraction support... > usage: mktemp [-d] [-q] [-t pref

[PATCH V2] test: aggregate-results.sh: consistent style. zero forks.

- all variables in $((...)) without leading $ - all comparisons use -gt, -eq or -ne - no -a nor -o inside [ ... ] expressions - all indentation levels using one tab Dropped unnecessary empty string check when reading results files. Replaced pluralize() which was executed in subshell with pluraliz

Re: [PATCH] fix misspelling

On Mon, Jun 10 2019, Daniel Kahn Gillmor wrote: > Signed-off-by: Daniel Kahn Gillmor > --- > lib/messages.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/messages.c b/lib/messages.c > index 04fa19f8..7ddfaf26 100644 > --- a/lib/messages.c > +++ b/lib/messages.c > @

[PATCH] test: aggregate-results.sh: consistent style. zero forks.

- all variables in $((...)) without leading $ - all comparisons use -gt, -eq or -ne - no -a nor -o inside [ ... ] expressions - all indentation levels using one tab Dropped unnecessary empty string check when reading results files. Replaced pluralize() which was executed in subshell with pluraliz

Re: [PATCH] perf-tests: #!/bin/bash -> #!/usr/bin/env bash

On Fri, May 31 2019, William Casarin wrote: > I couldn't run the performance tests on my machines due to a hardcoded > bash path. Use env for finding bash in weird systems like NixOS. Not so weird -- probably most non-Linux OS's that have bash, have bash somewhere else than in /bin/. LGTM. Tomi

Re: [PATCH] doc: use separate doctrees for distinct builders

On Fri, May 31 2019, David Bremner wrote: > It seems our previous attempt with order-only targets was not > sufficient to avoid problems with sphinx-builds doctree cache [0]. > Looking around at other people's approaches [1], using seperate probably good, but you may want to s/seperate/separate/

[PATCH] append _unused to the expression defined using unused() macro

This way if variables defined using unused() macro are actually used then code will not compile... - removed unused usage around one argc and one argv since those were used - changed one unused (char *argv[]) to unused (char **argv) to work with modified unused() macro definition --- Noticed

Re: revision 3: easing access to the cryptographic envelope

On Sun, May 26 2019, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> On Sun 2019-05-26 09:01:46 -0300, David Bremner wrote: >>> Daniel Kahn Gillmor writes: >>> This is the third revision of the series originally posted at id:20190424183113.29242-1-...@fifthhorseman.net (revisio

Re: [PATCH v2] test: report summary even when aborting

On Sun, May 26 2019, Daniel Kahn Gillmor wrote: > In certain cases of test suite failure, the summary report was not > being printed. In particular, any failure on the parallel test suite, > and any aborted test in the serialized test suite would end up hiding > the summary. > > It's better to al

[PATCH] NEWS: The minimum supported major version of Emacs is now 24.

--- NEWS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS b/NEWS index 26b8160c8ee2..d8aa272f0093 100644 --- a/NEWS +++ b/NEWS @@ -10,6 +10,8 @@ Command Line Interface Emacs - +The minimum supported major version of Emacs is now 24. + Support for GNU Emacs older than 25.1 is dep

Re: [PATCH] test: report summary even when aborting

On Sat, May 25 2019, Daniel Kahn Gillmor wrote: > In certain cases of test suite failure, the summary report was not > being printed. In particular, any failure on the parallel test suite, > and any aborted test in the serialized test suite would end up hiding > the summary. > > It's better to al

Re: [PATCH] test: redirect STDIN from /dev/tty

On Tue, May 21 2019, David Bremner wrote: > Tomi Ollila writes: > >> Without this stdin may be anything that parent process provided for it. >> >> Test processes might have tried to read something from it, which would >> have caused undeterministic behavior. >

Re: [PATCH] test: avoid hanging older gdb under GNU timeout and moreutils parallel

On Tue, May 21 2019, Daniel Kahn Gillmor wrote: > Hi Tomi-- > > On Tue 2019-05-21 09:12:12 +0300, Tomi Ollila wrote: >> This looks like a good read: >> https://ftp.gnu.org/old-gnu/Manuals/gdb/html_node/gdb_21.html >> and is used to speculate below. > > Tha

[PATCH] test: redirect STDIN from /dev/tty

Without this stdin may be anything that parent process provided for it. Test processes might have tried to read something from it, which would have caused undeterministic behavior. E.g. gdb(1) tries to do tty related ioctls on fd 0 (and fd 1 and fd 2, but those are redirected to 'test.output' bef

Re: [PATCH 3/3] configure: make _check_session_keys work with an as-needed linker

On Mon, May 20 2019, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> When using a promiscuous linker, _check_session_keys was working fine. >> > > cleanup series pushed, with one minor change. For reasons that Tomi can > explain, we use "command -v" instead of "which" in scripts. command

Re: [emacs] Auto-rotate pictures

On Sat, May 18 2019, Pierre Neidhardt wrote: > Friendly ping! :) patches tolerated >:D (if there is anyone who is interested enough to prioritize such a thing instead of doing something else) Tomi > > -- > Pierre Neidhardt > https://ambrevar.xyz/ __

Re: [PATCH] test: avoid hanging older gdb under GNU timeout and moreutils parallel

On Mon, May 20 2019, Daniel Kahn Gillmor wrote: > > A marginally cleaner patch be to consistently use gdb with either one > of: > > * -tty /dev/null > * < /dev/null This looks like a good read: https://ftp.gnu.org/old-gnu/Manuals/gdb/html_node/gdb_21.html and is used to speculate below. I also

Re: parallel tests broken on Debian stable

On Mon, May 20 2019, Daniel Kahn Gillmor wrote: > Thanks for catching this, Bremner. > > On Fri 2019-05-10 07:45:18 -0300, David Bremner wrote: >> In a debian stretch neither gnu parallel nor moreutils parallel >> successfully completes the tests. > > I have confirmed this misbehavior on debian st

Re: [PATCH 1/2] tests: make timeout configurable with NOTMUCH_TEST_TIMEOUT (default: 2m)

On Mon, May 20 2019, Daniel Kahn Gillmor wrote: > The current 2 minute timeout is reasonable, but to exercise the test > suite or induce timeout failures, we might want to make it shorter. > This makes it configurable so you can run (for example): > > make check NOTMUCH_TEST_TIMEOUT=10s > > We

Re: [PATCH 1/2] emacs: Move notmuch-search-interactive-region to notmuch-lib as notmuch-interactive-region

On Mon, May 20 2019, Leo Vivier wrote: > Hello, > > With the patch now in master, the documentation for Emacs (‘Tips and > Tricks for using Notmuch with Emacs’) needs to be updated: > https://notmuchmail.org/emacstips/#index5h2 > > ‘notmuch-search-interactive-region’ is mentioned in the second blo

[PATCH] test-lib.sh: "tidied" emacs_deliver_message ()

Added initialization and checking of smtp_dummy_port like it was done with smtp_dummy_pid. Made those function-local variables. One 8 spaces to tab consistency conversion. And last, but definitely not least; while doing above noticed that there were quite a few double-quoted strings where $@ was

Re: [PATCH] test/emacs: revert invalid-from test to pre-86f89385 behaviour

On Sat, May 11 2019, David Bremner wrote: > To the best of my understanding, this original behaviour was what > Carl's homebrew parser produced. With commit 86f89385 Austin switched > to using GMime (2.6). This produced arguably worse results, but since > the input was bad, we could live with it.

[PATCH] test-lib.sh: colors to test output when parallel(1) is run on tty

Done via $COLORS_WITHOUT_TTY environment variable as passing options to commands through parallel(1) does not look trivial. Reorganized color checking in test-lib.sh a bit for this (perhaps were not fully necessary but rest still an improvement): - color checking commands in subshell are not ru

[WIP PATCH] test: make test-serially to run test serially

This is easier and less error prone than mistyping NOTMUCH_TEST_SERIALIZE manually from command line (mistype make test-serially and it just doesn't work) --- quick first version. this works, but someone(tm) w/ native english experience could say how the naming sounds like... test/Makefile.local

Re: [PATCH] test: let the OS choose a port for smtp-dummy

On Tue, May 07 2019, Daniel Kahn Gillmor wrote: > On Tue 2019-05-07 07:20:49 -0300, David Bremner wrote: >> This should avoid potential collisions if we start running multiple >> smtp-dummy processes in parallel. > > This is excellent, simple, and clearly the right thing to do. I've > reviewed it

Re: [PATCH] test: avoid unnecessary extraction of the test fingerprint

On Tue, May 07 2019, Daniel Kahn Gillmor wrote: > FINGERPRINT is already exported by add_gnupg_home, so this is > unnecessary. This change also happens to get rid of the superfluous > check-trustdb spew from the test suite that looked like this: > > gpg: checking the trustdb > gpg: marginals need

Re: [PATCH] test: add configurable port to smtp-dummy

On Mon, May 06 2019, David Bremner wrote: > This is to allow smtp-dummy to potentially be used from multiple T*.sh > without collisions during parallel test running. > --- > test/T310-emacs.sh | 3 +++ > test/smtp-dummy.c | 7 ++- > test/test-lib.sh | 4 +++- > 3 files changed, 12 insertio

Re: [PATCH] tests: environment variable to specify that tests should be serialized

On Mon, May 06 2019, Jameson Rollins wrote: > From: Jameson Graef Rollins > > If NOTMUCH_TEST_SERIALIZE is non-null all tests will be run in series, > rather than in parallel. While I like this parallelization option, and hope a version (could be even David's smtp_dummy change) of it could be a

Re: parallelize test suite

On Sun, May 05 2019, Daniel Kahn Gillmor wrote: > On Sat 2019-05-04 19:53:23 -0300, David Bremner wrote: >> Last time we discussed parallel test running, there we concerns about >> multiple versions of certain servers colliding with each other. This >> still seems to be at least a theoretical issu

Re: [PATCH 1/3] tests: remove some redundant pre-cleanup of the corpus MAIL_DIR

On Sat, May 04 2019, Jameson Rollins wrote: This change LGTM, marked trivial, removed needs-review > From: Jameson Graef Rollins > > add_email_corpus itself does an rm -rf $MAIL_DIR, so these are not necessary. > --- > test/T100-search-by-folder.sh | 1 - > test/T650-regexp-query.sh | 1 - >

Re: Cleaning up GnuPG User ID validity in the test suite

On Sat, May 04 2019, Daniel Kahn Gillmor wrote: > In looking at the cryptographic features of the test suite, i noticed > that we're confusing user ID validity and key ownertrust (not an > uncommon confusion). We're also not testing with a "normal" GnuPG > installation, which has the secret key w

Re: [PATCH 1/2] test/raw: add some messages likely to be multiples of buffer size

On Sun, May 05 2019, Tomi Ollila wrote: > On Sat, May 04 2019, David Bremner wrote: > >> >> +test_python <> +from email.message import EmailMessage >> +for pow in range(12,21): > > ...^ space. i.e. (12, 21) > > from 4KiB to 1MiB.

Re: [PATCH 1/2] test/raw: add some messages likely to be multiples of buffer size

On Sat, May 04 2019, David Bremner wrote: > This highlights a bug where zero bytes are read at the end of the > file, and we attempt to write those to stdout, causing spurious write > failures. > --- > test/T210-raw.sh | 35 +++ > 1 file changed, 35 insertions(+) >

Re: [PATCH] build: drop support for gmime-2.6

On Wed, May 01 2019, David Bremner wrote: > GMime 3.0 is over 2 years old now, and 2.6 has been deprecated in > notmuch for about 1.5 years. > --- > > Thanks to Rob Browning, I realized that the gzipped-mail-file series I > have recently posted does not compile with GMime 2.6. This made me > think

Re: [PATCH 1/2] test: notmuch show --format=raw for 4096 byte messages.

On Sun, Apr 28 2019, David Bremner wrote: > Rob Browning isolated a bug where files of exactly 4096 bytes generate > errors because of a zero byte read. This happens to be effective test in case where FILE buffering uses 4096 byte buffers. If it used any other size then this is null test. So th

Re: [PATCH] emacs: drop use of message-default-charset

On Mon, Apr 22 2019, Daniel Kahn Gillmor wrote: > Apparently, message-default-charset is deprecated, which causes the > following warning messages during the build: > > In notmuch-maildir-setup-message-for-saving: > emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an >

Re: [PATCH] emacs: hint that notmuch-mua-attachment-regexp is a regular expression

On Sat, Apr 20 2019, Daniel Kahn Gillmor wrote: > Without this change, we see the following warnings during the build: > > ``` > In toplevel form: > emacs/notmuch-mua.el:119:1:Warning: defcustom for > ‘notmuch-mua-attachment-regexp’ fails to specify type > emacs/notmuch-mua.el:119:1:Warning: d

Re: [PATCH] cli/show: pass the siglist directly to the sigstatus sprinter

On Sat, Apr 20 2019, Daniel Kahn Gillmor wrote: > This makes it easier to reuse format_part_sigstatus_sprinter() when we > have other places that we want to display a signature status. Change looks trivial enough (and reduces the "scope" function sees which is always good if it is enough -- I tru

Re: [PATCH] tests: move FINGERPRINT definition to add_gnupg_home

On Sat, Apr 20 2019, Daniel Kahn Gillmor wrote: > If a test has added a GnuPG homedir, it may well want to know the > fingerprint. This saves us from having to redefine this magic string > in multiple places when more tests evenutally use the GnuPG homedir. This change looks good (s/evenutally/e

Re: [PATCH 1/2] CLI/reindex: fix memory leak

On Mon, Apr 15 2019, David Bremner wrote: > Since message is owned by messages, it was held for the entire run of > the program. This in turn means that the Xapian::Document objects are > not freed, and thus one ends up with (effectively) a copy of one's > entire mailstore in memory when running >

Re: Updated version of the patch-set for tagging forwarded messages

On Fri, Apr 12 2019, Örjan Ekeberg wrote: > This is a new (final?) version of the patch set for adding reference > links to forwarded messages, and tags to forwarded and replied messages. > > Thanks for all the comments and suggesions for improvements. Apart > from cleaning up the test code, the

Re: [PATCH 2/2] release: use xz compression

On Sat, Mar 23 2019, Daniel Kahn Gillmor wrote: > On Tue 2019-03-19 07:08:19 -0300, David Bremner wrote: >> This produces tarballs that are roughly 30% smaller. > > LGTM. I can confirm that i'm seeing tarball sizes go from 924543 bytes > (or 917179 bytes with gzip -9) to 644892 bytes with this xz

Re: [PATCH v2 4/4] test: add test for checking forwarded messages

On Fri, Apr 05 2019, Örjan Ekeberg wrote: > Add test of forwarding messages from within emacs. > The first test checks that a references header is properly > added to the new message. The second test checks that the > send-hook of the forwarding message adds a forwarded-tag > to the original mess

Re: [PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable

On Tue, Apr 02 2019, Örjan Ekeberg wrote: > Tomi Ollila writes: >> two things >> >> - I wonder whether we could drop (defun notmuch-message-mark-replied ()...) >> - why is it needed for backward compatibility ? > > Yes, it would be cleaner to simply remove it.

Re: [PATCH] performance-tests: tests for renamed/copied files in notmuch new

On Tue, Apr 02 2019, David Bremner wrote: > Several people have observed that this is surprisingly slow, and we > have a proposal to add tagging into this code path, so we want to make > sure it doesn't imply too much of a performance hit. > --- > performance-test/T00-new.sh | 30

Re: [PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable

On Sat, Mar 30 2019, Örjan Ekeberg wrote: > These patches implement a message-send-hook which uses a buffer-local variable > to tag replied and forwarded messages. > > The first patch replaces the current heuristic hook for detecting reply > messages with an explicit setting when the reply is comp

Re: notmuch ignoring alot of emails

On Sun, Mar 31 2019, Alexei Gilchrist wrote: >>> When I run notmuch I get a bunch (hundreds) of emails that are >>> ignored >>> with: >>> >>> Note: Ignoring non-mail file: ... >>> >>> The files are valid maildir files but have a paragraph somewhere in >>> the >>> body where someone has written "

Re: [PATCH] performance-test: fix copy-pasta in test description

On Fri, Mar 29 2019, David Bremner wrote: lgtm (do we want slang in commit messages ;D) I'd like to have some spaghetti now... > --- > performance-test/T03-reindex.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/performance-test/T03-reindex.sh b/performance-test/T03

Re: [PATCH] doc: document notmuch new --verbose

On Fri, Mar 29 2019, Michal Sojka wrote: LGTM. I run notmuch new always with --verbose (via wrapper). Good that the option is now mentioned. Tomi > --- > doc/man1/notmuch-new.rst | 4 > 1 file changed, 4 insertions(+) > > diff --git a/doc/man1/notmuch-new.rst b/doc/man1/notmuch-new.rst > i

Re: [PATCH] vim: Use non-deprecated method parse instead of new.

On Thu, Mar 21 2019, Nicolas Lesser wrote: 2 emails about this same change, this without typo :D But, in order to someone(tm) to review these changes (especially, since not everybody can test these changes), we'd need more content in commit message. https://notmuchmail.org/contributing/ is good

Re: python bindings: fix return value types with ctypes

On Sat, Mar 30 2019, VA wrote: LGTM (on paper -- checked ctypes doc that '.restype' looks like correctly spelled name) > There were some typos, where restype was misspelled "resttype" and an > "argtypes" was lost. > From f291f3d20b4683b468c48b35efc6b5ecc2719a1d Mon Sep 17 00:00:00 2001 > From: h

Re: inconsistent handling of stderr in notmuch-emacs

On Fri, Mar 15 2019, David Bremner wrote: > Rob noticed that generating extra output on stderr from the notmuch cli > breaks some things in notmuch-emacs (in his case this was from a wrapper > script). > > notmuch-search seems fairly robust at this point, but at least > notmuch-hello and notmuch-m

Re: [PATCH 1/2] test/T030-config: Separate stdout and stderr output

On Tue, Mar 12 2019, David Bremner wrote: > Luis Ressel writes: > >> POSIX doesn't specify the flushing behaviour of the STDOUT stream, so >> it's invalid to assume a particular order between the stdout and stderr >> output. The current test breaks on musl due to this. > > Series pushed. Thanks f

Re: [PATCH] test/T030-config: Separate stdout and stderr output

On Sun, Mar 10 2019, Luis Ressel wrote: > POSIX doesn't specify the flushing behaviour of the STDOUT stream, so > it's invalid to assume a particular order between the stdout and stderr > output. The current test breaks on musl due to this. > --- > test/T030-config.sh | 7 +-- > 1 file chang

Re: [PATCH] test: Ignore subtly different behaviour of the musl libc

On Tue, Feb 26 2019, Luis Ressel wrote: ... > --- a/test/T650-regexp-query.sh > +++ b/test/T650-regexp-query.sh > @@ -137,10 +137,10 @@ EOF > test_expect_equal_file EXPECTED OUTPUT > > test_begin_subtest "regexp error reporting" > -notmuch search 'from:/unbalanced[/' 1>OUTPUT 2>&1 > +notmuch

Re: [PATCH] Add a configure flag to disable rpaths

On Tue, Feb 26 2019, Luis Ressel wrote: although the commit message is a bit terse, this change looks simple and reasonable enough to be pushed (i.e. if i think hard I can see reason for this change even it is not described in commit message ;D) Tomi > --- > configure | 11 ++- > 1 file

Re: [Joerg Jaspert] Bug#922536: notmuch-emacs: notmuch breaks on directory removal

On Wed, Feb 20 2019, Matt Armstrong wrote: > Tomi Ollila writes: > >> On Sun, Feb 17 2019, David Bremner wrote: >> >>> Seems like reasonable complaint. It should be possible to change to >>> the maildir root, but probably requires shelling out to notmuch >&

Re: [Joerg Jaspert] Bug#922536: notmuch-emacs: notmuch breaks on directory removal

On Sun, Feb 17 2019, David Bremner wrote: > Seems like reasonable complaint. It should be possible to change to the > maildir root, but probably requires shelling out to notmuch config > get the value. Hmm. what does other emacs software do in that case ? Since OTOH I can think of a situation w

Re: [PATCH] python: fix get_property error when property doesn't exist

On Sun, Feb 17 2019, David Bremner wrote: > VA writes: > >> Le 01/02/2019 à 14:45, David Bremner a écrit : >>> Should we be throwing an appropriate exception rather than returning >>> None? That seems more pythonic to me. In either case we should document >>> the error handling. >> >> What would

Re: [PATCH] configure: resolve real path to bash

On Wed, Jan 30 2019, David Bremner wrote: > Đoàn Trần Công Danh writes: > >> The old code somehow resolves to `bin/sh' on Arch Linux/Void Linux >> auto build systems. >> > > I'm not sure if this is better or worse than > > > https://nmbug.notmuchmail.org/nmweb/show/20190117021132.28327-1-dav

Re: merge broken mail threads

On Wed, Jan 23 2019, Nicolas Bock wrote: > Hi, > > Sometimes during a lengthy discussion someone inadvertently breaks > the email thread because their mail client doesn't get it. Is > there a way to merge the two fragmented threads again with > notmuch? There is this secret trick where you sen

Re: Threading of forwarded messages

On Tue, Jan 22 2019, Örjan Ekeberg wrote: > Hi, > > Let me first say that I am a very happy user of notmuch+emacs. Once the > initial setup and configuration was done, usage has been a very pleasant > experience. It daily saves me from getting lost in the constant torrent > of incoming e-mail, w

Re: fix bash autoconfiguration

On Wed, Jan 16 2019, David Bremner wrote: > Testing by people running with /bin/sh = bash welcome. The bug shows > up as a shebang of /bin/sh in /usr/bin/notmuch-emacs-mua LGTM Tomi ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.

[PATCH] configure: check that the version of emacs we may have is at least 24

This also effectively drops support to Emacs version 23, which was deprecated in version 0.23.2 (2016-11-20) and did not entirely work any more. --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index b2200be08a03..3ae26241df2a 100755 --- a

Re: [PATCH 0/3] API: add notes on lifetimes

On Mon, Dec 17 2018, rhn wrote: > Hi, > > this patch series addresses API shortcomings that were found while working on > the Rust bindings [0]. > > The first two patches address the problem that the docs never clearly state > when messages obtained as replies are destroyed, while the last patch

Re: [PATCH 2/2] cli: notmuch show support for --include-html with --format=text

On Wed, Oct 31 2018, ma...@kakoune.org wrote: > From: Maxime Coste To me these changes looks simple and trivial enough to be merged (if these works, but code LGTM) Tomi > > --- > NEWS | 3 ++- > doc/man1/notmuch-show.rst | 11 ++- > notmuch-show.c|

Re: EMACS error "Package html2text is obsolete"

On Sat, Nov 03 2018, Ralph Seichter wrote: > Hello list, > > I tried to access https://notmuchmail.org/pipermail/notmuch/ several > times today, but it always resulted in a connection error, so I am > now trying the mailing list. > > When I open a HTML message in the EMACS UI, the error message "P

[PATCH] wip: support differently named sphinx-build binaries

Needed at least on Fedora 28 when only python3-sphinx is installed. This is just midway to quick hack (which I used when updating wiki manpages) and full support (and will time fix this before anyone really cares)... --- configure | 20 +++- doc/Makefile.local | 3 +--

Re: [PATCH v1 2/2] emacs: Update integration with third party packages.

On Thu, Oct 04 2018, David Edmondson wrote: > `mm-inline-text-html-with-images' was removed from mm-decode.el in > 2016 and replaced with `mm-html-inhibit-images'. > > `gnus-select-frame-set-input-focus' was removed from gnus-util.el in > 2016 and existed only for XEmacs compatibility. 2/2 looks

Re: [PATCH 4/6] contrib/notmuch-mutt: add install target

On Sun, Sep 16 2018, David Bremner wrote: > The main goal here is to be able to install the notmuch-mutt script > with an absolute shebang. I have tried to make the notmuch-mut Series looks pretty good to me... mut mut should probably be mutt ;D Also we probably don't care those who have footgun

Re: [PATCH 2/2] build: install notmuch-emacs-mua with absolute shebang

On Sun, Sep 09 2018, David Bremner wrote: > Follow distro-centric rules to reduce the chance of surprising > behaviour due to PATH changes > --- > emacs/Makefile.local | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/emacs/Makefile.local b/emacs/Makefile.local > index

Re: Test suite fixes for Xapian 1.2.x

On Sun, Sep 09 2018, David Bremner wrote: > Some bit rot crept in, and the test suite no longer passes on Xapian > without field processors. The fix is simple enough not to pull the > plug on support for old Xapian just yet. Fine by me. Also dropping xapian 1.2.x support is fine by me (so that I

<    1   2   3   4   5   6   7   8   9   10   >