Re: [PATCH] test: add broken tests for maildir syncing

On Fri, Aug 04 2017, David Bremner wrote: > Users should be able to specify synced tags in new.tags > --- > > Anarcat had an interesting idea about using "flagged" in new.tags, but > it doesn't work, because of (I think) the following code: > > for (tag = state->new_tags; *tag != NULL;

Re: Custom notmuch-show for html?

On Tue, Jul 25 2017, William Casarin wrote: > Tomi Ollila <tomi.oll...@iki.fi> writes: >> If you try to work something on this (or anything), please report your >> progress :D > > I didn't really get far after I discovered how awesome emacs-w3m was. > pandoc

Re: Custom notmuch-show for html?

On Sun, Jul 23 2017, William Casarin wrote: > Hey there, > > I would like to never use emacs' slow html renderer when viewing > html-only email. What I want to do is pipe the html through: > > pandoc -f html -t plain > > and then show the output of that. Right now I can do this with `. |` but >

[PATCH] NEWS for release 0.25: Emacs: support for stashing message timestamp

--- NEWS | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/NEWS b/NEWS index f844f1a77d93..4f3bdfa5752b 100644 --- a/NEWS +++ b/NEWS @@ -8,7 +8,7 @@ Add regexp searching for mid, paths, and tags. Skip HTML tags when indexing -In particular this

[PATCH] NEWS: a few formatting updates for 0.24 news items (wiki compatibility)

- removed 7 trailing dots -- to make those lines subsection headers - converted some (mime type) text to monospace - removed one extra space --- bi-annual cleanup (previous around 2015-10)... NEWS | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [PATCH] emacs: change default for notmuch-crypto-process-mime to t

On Sun, Jul 09 2017, David Bremner wrote: > There are some cases like remote usage where this might cause > problems, but those users can easily customize the variable. The > inconvenience seems to be outweighed by the security benefit for most > users. > --- Trivial enough to LGTM codewise --

Re: [PATCH 07/23] test/crypto: mark extra space in userid as a bug in gmime-2.6

On Sat, Jun 03 2017, David Bremner wrote: > I can't see the space in the output of gpg -K --with-colons > --- > test/T350-crypto.sh | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh > index 0753acf3..720a2225 100755 > ---

Re: Bug: fatal error with notmuch new, second run starts indexing all over again

You could also try notmuch new --verbose --- and then look into the last file it was indexing when crash occurred... Tomi ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: Modify kill and exit functions on emacs notmuch mode

On Sat, Jun 03 2017, katsuyuki wrote: > Hi, I modified kill and exit functions on emacs notmuch mode. > I want to hear your opinion about the change. Some years ago I had a problem notmuch choosing "strange" buffer when exiting e.g. mail buffer (and I sent a patch to "fix" that). Eventually the

Re: Compiling notmuch in cygwin

(note: User-Agent: a bit faked, copied from cygwin emacs after evaluating (setq notmuch-mua-user-agent-function #'notmuch-mua-user-agent-full) and then pressing 'm' in notmuch hello buffer in cygwin emacs) On Tue, May 30 2017, Tony Malykh wrote: > Hello everyone, > > Has anyone tried to

Re: [Patch v3 08/11] test: define GMime version dependant breakage

On Sat, May 27 2017, David Bremner wrote: > We have some tests where the gmime 3 behaviour seems like a bug fix, > others where it's less clear, so we allow both possibilities. > --- > configure| 5 + > test/test-lib.sh | 16 > 2 files changed, 21 insertions(+) > >

Re: [Patch v3 06/11] test/thread-naming: remove excess escaping from sender address.

On Sat, May 27 2017, David Bremner wrote: > This is another case where the behaviour of gmime-2.6 and gmime-3.0 > seems to differ. It may be that we prefer the more lax parsing of the > previous version, but that should be tested seperately. This series lgtm (afaiu) so far, but s/seper/separ/

[no subject]

for future reference if need for atexit functionality arises. From Tomi Ollila <tomi.oll...@iki.fi> # This line is ignored. From: Tomi Ollila <tomi.oll...@iki.fi> Subject: stop gpg-agent (among other) processes at test module exit In-Reply-To: ___

[PATCH 2/2] exit lingering gpg agents at the end of relevant tests

Since gnupg 2.1.20, gpg-agent no longer shut itself down when $GNUPGHOME directory is removed. Add exit hooks to the test modules which execute `gpgconf --kill all` Add exit hooks to execute `gpgconf --kill all` in the modules that create $GNUPGHOME for gpg to work with. --- test/T350-crypto.sh

[PATCH 1/2] test-lib.sh: add "atexit" functionality

New function at_exit_function registers given function to be called at script termination. Functions so registered are called in the reverse order of their registration; no arguments are passed. Function is called only once; re-adding with function name already registered will remove previous

Re: [PATCH v2 03/11] notmuch-search: add filesize based sort order

On Fri, May 19 2017, Ioan-Adrian Ratiu wrote: > With this it now becomes possible to order the search results by > filesize using the --sort=biggest-first/smallest-first args. Quick drive-by comment (for now): In many places elsewhere we're talking about 'large' files (e.g. LARGEFILE_SOURCE...)

Re: [Bug] lingering gpg-agents from test suite

On Mon, May 15 2017, Justus Winter wrote: > David Bremner writes: > >> Thanks to changes in gnupg 2.1.20, the agent started by the notmuch test >> suite is no longer killed by deleting the home directory. >> >> So yay, we get to adapt to changes in gnupg, again. >> >> See also

RE: Upcoming GMime 3.0 changes

On Tue, May 09 2017, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> >> out of curiosity, why do you think we won't be able to drop gmime-2.6 >> for a few years? if it's due to the debian release cycle and wanting to >> backport notmuch to stretch, i don't think

Re: [notmuch] Re: v3 of regexp search for mid/folder/path

On Sun, May 07 2017, David Bremner wrote: > David Bremner writes: > >> No sooner posted than I realized it had a bug: the previous version >> compared against the prefixed term so anchored searches failed. >> >> I've also included some tests for the new features in this

Re: Address Completion

On Mon, Apr 10 2017, Jörg Volbers wrote: > Hello, > > If I press looking for an address while writing mail, > vanilla notmuch offers me one preselected candidate. Since I use > ivy-mode, this canididate narrows down the list of all candidates, > forcing me to delete

[PATCH] configure: Be more verbose when compiler sanity checks fail

When configure could not get past initial compiler sanity check the user was left with no explanation why this happened (usually the reason is that compilers are not installed). By printing the executed command line and re-executing it without output redirection user gets better information how

[PATCH] Makefile.local: have all files in release tarball be owned by root

The tar content `git archive` creates (reproducibly) have owner and group set to 'root'. (GNU) tar writes user ids to the added file `version` by default. The contents of tar archive looks better and more consistent when owner and group in all files are the same. While at it, split this long

[PATCH] emacs: with prefix argument, notmuch-show-stash-date stashes timestamp

Using timestamp of a message is useful in many Xapian queries. --- This is my suggested alternative to id:20170110181525.18269-1-j...@nikula.org since my comments in id:m2fuimv4mj@guru.guru-group.fi This variant uses prefix argument to `c d` to do stashing of a timestamp and do not (at this

Re: [PATCH] test: swap order of arguments of test_expect_equal

On Thu, Apr 06 2017, David Bremner wrote: > For some reason (probably inherited from git), the order arguments for > test_expect_equal was "$output $expected"; this again matters when > generating diffs. > --- IMO these both of these should use expected - output argument

Re: [PATCH 1/2] test: standardize argument order to test_expect_equal_file

On Wed, Apr 05 2017, David Bremner wrote: > It is annoying to debug failing tests when the interpretation of the > diffs is reversed for some tests. > --- +1 > test/T080-search.sh| 2 +- > test/T090-search-output.sh | 36 +++ >

Re: fix for dump headers

On Tue, Mar 28 2017, David Bremner wrote: > When I added message properties to the dump output I messed up the > copy-paste to add properties to the header. The fix is trivial, but > I'm not sure if this means we should bump the format version > (i.e. write #notmuch-dump:3) to

Re: revised foo:"" handling

On Sat, Mar 25 2017, David Bremner wrote: > This obsoletes the first two patches of > > id:20170318030303.17344-1-da...@tethera.net > > I think this is a more meaningful interpretation than matching all messages. These changes look good (AFAIU). tests pass (debian

Re: memory leak cleanup for notmuch show

On Sat, Mar 18 2017, David Bremner wrote: > Inspired by Jeff's patch, I updated the memory test suite to test > notmuch-show, this series is the result. I also include Jeff's > original patch in this series. series LGTM. tests pass (fedora 25, gmime 2.6.20, xapian 1.2.24)

Re: [PATCH 1/6] perf-test: use 'eval' in memory_run

On Sat, Mar 18 2017, David Bremner wrote: > This allows the use of redirection in the tests > --- > performance-test/perf-test-lib.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/performance-test/perf-test-lib.sh >

[PATCH] lib/message.cc: fix Coverity finding (use after free)

The object where pointer to `data` was received was deleted before it was used in _notmuch_string_list_append(). Relevant Coverity messages follow: 3: extract Assigning: data = std::__cxx11::string(message->doc.()).c_str(), which extracts wrapped state from temporary of type

Re: [PATCH] fix memory leaks in notmuch-show.c:format_headers_sprinter()

On Thu, Mar 16 2017, Jeffrey Stedfast wrote: > Hey guys, > > Was just grepping through notmuch sources and discovered what I think are > memory leaks in notmuch-show.c’s format_headers_sprinter() code. > > Internet_address_list_to_string() and

Re: [PATCH] rename libutil.a to libnotmuch_util.a

On Tue, Mar 14 2017, David Bremner wrote: > Apparently some systems (MacOS?) have a system library called libutil > and the name conflict causes problems. Since this library is quite > notmuch specific, rename it to something less generic. > --- LGTM > Makefile.global |

Re: [PATCH 2/2] lib: clamp return value of g_mime_utils_header_decode_date to >=0

On Sun, Mar 12 2017, David Bremner wrote: > For reasons not completely understood at this time, gmime (as of > 2.6.22) is returning a date before 1900 on bad date input. Since this > confuses some other software, we clamp such dates to 0, > i.e. 1970-01-01. > --- >

Re: emacs: use epg-gpg-program

On Mon, Mar 13 2017, David Bremner <da...@tethera.net> wrote: > Tomi Ollila <tomi.oll...@iki.fi> writes: > >> From: John Byrnes <j...@johnbyrnes.info> >> >> From: John Byrnes <j...@johnbyrnes.info> >> >> Adjusted notmuch-crypto

Re: [PATCH] test: verify test database v1 checksum in more portable way

On Mon, Mar 13 2017, David Bremner <da...@tethera.net> wrote: > Tomi Ollila <tomi.oll...@iki.fi> writes: > >> Replaced use of sha256 (gnu coreutils binary) with more portable >> openssl sha256 execution. >> --- >> >> Works on Linux and also on my

emacs: use epg-gpg-program

From: John Byrnes From: John Byrnes Adjusted notmuch-crypto gpg call-process function to respect the GPG program set by the EasyPG epg-gpg-program variable. This is to correct a problem observed on NixOS where only gpg2 is installed by default. The

[PATCH] test: verify test database v1 checksum in more portable way

Replaced use of sha256 (gnu coreutils binary) with more portable openssl sha256 execution. --- Works on Linux and also on my FreeBSD KVM environment. test/T530-upgrade.sh | 6 -- test/test-databases/database-v1.tar.xz.sha256 | 1 - 2 files changed, 4 insertions(+),

Re: [PATCH] configure: change default bash completion location to /usr/share

On Sun, Mar 12 2017, David Bremner wrote: > At least Fedora and Debian now use > /usr/share/bash-completion/completions now. Apparently > /etc/bash_completion.d will be phased out at some point in the future. > --- LGTM (from keyboard of 20+ year zsh user) Tomi > configure

Re: notmuch-0.18 issues [was Re: notmuch-0.16: realpath() compatibility issue; clang visibility problem]

On Sun, Mar 12 2017, David Bremner wrote: > Thomas Klausner writes: > >> >> 1. pkgsrc's copy of rst2man is called "rst2man.py". The configure test >> > > Since I see notmuch in pkgsrc for netbsd, I guess things have improved. > I had a quick look at the

[PATCH] test-databases: use wget or curl to download test databases

Often Linux systems are shipped with wget(1) by default (and no curl). Many BSDs, macOS, and e.g. some Linux minimal/container images comes with curl(1) (and no wget). Attempting to download with curl if wget is not available increases the likelihood for this to succeed. --- This is an update

[PATCH 3/3] fix out of tree tests

Use $NOTMUCH_SRCDIR/ instead of $TEST_DIRECTORY/../ (in those 2 places) where reference to source directory instead of build directory is required. --- test/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index

[PATCH 1/3] configure: add ${NOTMUCH_SRCDIR} -- absolute path to notmuch source

The ${srcdir} -- usually relative path to notmuch source -- works fine in current ./configure and all makefiles. To have simple access to notmuch source in tests and out of tree builds holding absolute path to the source directory is useful. --- Fixed version of series starting with

[PATCH 2/3] fix out of tree build

In addition to use ${srcdir} and deliver ${NOTMUCH_SRCDIR} where needed, source from ruby bindings had to be copied to the out-of-tree target directory -- if the source files in source directory were referenced in build and there were also built object files there, those could have been considered

Re: [RFC PATCH 6] support make goals after initial {'', dist, data}clean goal(s)

On Thu, Mar 09 2017, David Bremner <da...@tethera.net> wrote: > Tomi Ollila <tomi.oll...@iki.fi> writes: > >> Now make goal combinations starting with *clean goals, >> ending with *clean coals, and having non-*clean goals in between >> should work. What does no

Re: [PATCH] emacs: add support for stashing formatted timestamp

On Thu, Mar 09 2017, David Bremner wrote: > Jani Nikula writes: > >> notmuch-show-stash-date stashes the Date: header of the message >> verbatim. While that is useful, sometimes more control of the output >> is desirable. >> >> Add support for stashing the

Re: [PATCH] tests: add compatibility layer

On Thu, Mar 09 2017, David Bremner wrote: > From: Mikhail > > Make test-lib-common.sh load test-lib-<$PLATFORM>.sh to create > additional shim for platform specifics. > > Use test-lib-FREEBSD.sh to call GNU utilities instead of native ones. > > - amended by

Re: [David Bremner] Re: [PATCH] cli/new: Avoid printing "\033[K" to non-terminal output

On Thu, Mar 09 2017, David Bremner wrote: > From: David Bremner > Subject: Re: [PATCH] cli/new: Avoid printing "\033[K" to non-terminal output > To: Łukasz Stelmach > Date: Thu, 09 Mar 2017 08:35:11 -0400 > > Łukasz Stelmach

[PATCH] configure: removed $zlib_(cflags|ldflags) from compat code build

When pkg-config does not find configure, a compat version of the zlib.pc is created. In creation of that configure attempted to read values of $zlib_cflags and $zlib_ldflags. In the usual case those were undefined, and with `set -a` now in the beginning of configure, configure broke. Even if

Re: [PATCH] build: use sha256sum instead of sha1sum to sign releases

On Thu, Mar 02 2017, David Bremner wrote: > SHA1 is weak/broken. > --- I'd just have 'build: use sha256sum instead of sha1sum to sign releases' as a commit message. Anyway, LGTM. Tomi PS: this is sha-2 256 -- that makes me wonder what will be the file suffix for sha-3 256

Re: [PATCH 3/3] test: move GNUPGHOME to TEST_TMPDIR

On Tue, Feb 28 2017, David Bremner wrote: > We already use this directory for dtach sockets, so it makes sense to > put gnupg sockets there as well. There doesn't seem to be a clean way > to put a fully functional socket in a different location than > GNUPGHOME. > --- LGTM.

Re: [PATCH 1/2] cli/config: don't try to open config file for 'notmuch help'

On Sun, Feb 26 2017, Jani Nikula wrote: > The help command does not really need to try to open the config > file. So don't. > > --- This series looks good, tests pass, repost of my patch seems to be unmodified (the power of running 2 emacses w/ notmuch rules!) In addition to

Re: [PATCH v2] emacs: show: stop display of application/* parts

On Mon, Feb 27 2017, Mark Walters wrote: > Hi > >>> But what will we do if the user has not customized it because she >>> /wants/ to display all possible things inline. I have not seen that this >>> patch is merged into master, and probably, when I have learned about

Re: [PATCH 1/2] cli/config: don't try to open config file for 'notmuch help'

On Sun, Feb 26 2017, Jani Nikula wrote: > The help command does not really need to try to open the config > file. So don't. > > --- I've forgotten this ... added notmuch::0.24 to this series and will check carefully and test tomorrow... Tomi > > This will allow better error

Re: [PATCH] emacs: use (system-name) instead of system-name

On Sun, Feb 26 2017, Jani Nikula wrote: > Fix the deprecation warning: > > In notmuch-maildir-fcc-make-uniq-maildir-id: > emacs/notmuch-maildir-fcc.el:279:53:Warning: ‘system-name’ is an obsolete > variable (as of 25.1); use (system-name) instead > > I've used (system-name)

Re: [PATCH] lib: remove notmuch_query_{count, search}_{threads, messages}

On Sat, Feb 25 2017, David Bremner wrote: > Jani Nikula writes: > >> On Wed, 22 Feb 2017, David Bremner wrote: >>> These 4 functions were originally deprecated in notmuch 0.21, more >>> than a year ago. >> >> This leaves the

Re: [PATCH 1/2] cli/show: list all filenames of a message in the formatted output

On Sat, Feb 25 2017, Jani Nikula wrote: > Instead of just having the first filename for the message, list all > duplicate filenames of the message as a list in the formatted > outputs. This bumps the format version to 3. > > --- Looks good to me. Tests pass. Tomi > > v2: fix

Re: [PATCH] lib: fix g_hash_table related read-after-free bug

On Wed, Feb 22 2017, David Bremner wrote: > The two g_hash_table functions (insert, add) have different behaviour > with respect to existing keys. g_hash_table_insert frees the new key, > while g_hash_table_add (which is really g_hash_table_replace in > disguise) frees the

Re: read after free in notmuch new

On Tue, Feb 21 2017, David Bremner wrote: > David Bremner writes: > >> David Bremner writes: >> >>> I haven't had a chance to really track this down, but it seems there is >>> a memory error in notmuch new (or a maybe false positive from

Re: [PATCH 2/2] test: use gpgconf --create-socketdir if available

On Tue, Feb 14 2017, David Bremner wrote: > This enables the shortened socket pathes in /run or equivalent. The > explicit call to gpgconf is needed for nonstandard GNUPGHOME settings. 2½ comments inline: __> --- > test/test-lib.sh | 14 ++ > 1 file changed, 14

Re: [Patch v4] lib: regexp matching in 'subject' and 'from'

On Thu, Feb 09 2017, David Bremner wrote: > Jani Nikula writes: > >> >> Theoretically "/" is an acceptable character in message-ids [1]. Rare, >> unlikely, but acceptable. Searching for message-id's beginning with "/" >> would have to use regexps, which would

Re: [Patch v4] lib: regexp matching in 'subject' and 'from'

TOn Sun, Jan 29 2017, Jani Nikula <j...@nikula.org> wrote: > On Wed, 25 Jan 2017, David Bremner <da...@tethera.net> wrote: >> Tomi Ollila <tomi.oll...@iki.fi> writes: >> >>> >>> Why would not mesasge_id not be useful to r

Re: [PATCH] test: allow user to choose which gdb to run tests with

On Wed, Jan 11 2017, Mikhail <mp39...@gmail.com> wrote: > On 17:56 08-Jan 2017 David Bremner wrote: >> Tomi Ollila <tomi.oll...@iki.fi> writes: >> >> > The variable used for selecting gdb is TEST_GDB, consistent with >> > TEST_CC and TEST_EMACS

Re: [PATCH 0/2] emacs: Fold long headers when sending

On Sun, Jan 29 2017, Mark Walters wrote: > This pair of patches add a test for folding long headers, and backport > the bugfix from emacs master. This fixes the bug reported in > id:87612qwh04@viking.dsc.soic.indiana.edu > > The fix in emacs master

Re: [PATCH] cli: don't call _entry_in_ignore_list twice in count files debug

On Sat, Dec 17 2016, Jani Nikula wrote: > Split file ignores in count_files to fixed and user configured in > order to not have to call _entry_in_ignore_list twice when debugging > is enabled. Minor detail. > --- LGTM. Tomi > notmuch-new.c | 18 ++ > 1 file

Re: [PATCH] [EMACS] Adjust notmuch-crypto gpg call-process function

On Wed, Jan 04 2017, John Byrnes wrote: > Hey Notmuchers, > > I'm running the latest NixOS and noticed that the system does not > install gpgv1 by default. This means that the only gpg binary available > is the gpg2 binary. > > I found that notmuch-crypto.el hardcodes the

Re: [PATCH] cli/show: list all filenames of a message in the formatted output

On Tue, Jan 10 2017, Jani Nikula wrote: > Instead of just having the first filename for the message, list all > duplicate filenames of the message as a list in the formatted > outputs. This bumps the format version to 3. Great stuff -- just now quite a few (~33) tests fail ;)

Re: [Patch v4] lib: regexp matching in 'subject' and 'from'

On Sat, Jan 21 2017, David Bremner wrote: > the idea is that you can run > > % notmuch search subject:// > % notmuch search from:// I like this interface. > > or > > % notmuch search subject:"your usual phrase search" > % notmuch search from:"usual phrase search" > > This

[RFC PATCH 6] support make goals after initial {'', dist, data}clean goal(s)

Now make goal combinations starting with *clean goals, ending with *clean coals, and having non-*clean goals in between should work. What does not expected to work are non-*clean - *clean - *non-clean goal combinations. Also, if first goals are *clean goals, re-creation of Makefile.config is

[RFC PATCH 5] support make goals after initial *clean goal(s)

Now make goal combinations starting with *clean goals, ending with *clean coals, and having non-*clean goals in between should work. What does not work is non-clean -- clean -- non-clean goal combination. Also, initial *clean goals do not request re-creation of Makefile.config if it exists and

[RFC PATCH 3] support goals after make *clean, *clean with current Makefile.config

Makes make clean, make distclean and make dataclean faster if Makefile.config exists but configure is newer. After 1st target being *clean, any non-*clean targets may follow it -- these are built in sub-make -- and when control returns to main make, it just recognizes targers already made. ---

[RFC PATCH 2] opportunistic support for make {, dist, data}clean {all, test, install}

Makes make clean, make distclean and make dataclean faster if Makefile.config exists but configure is newer. Makes any combination of make {,dist,data}clean {all,test,install} work (probably, some ad-hoc hand testing done). --- Well, could not resist the temptation to dig further... This may be

Re: [RFC PATCH] rfc: make 'make distclean' always use current Makefile.config

On Sun, Jan 08 2017, David Bremner <da...@tethera.net> wrote: > Tomi Ollila <tomi.oll...@iki.fi> writes: > > I like the idea here; it's an annoying wait. Could we do something > similar for make clean? yes exact `make clean`, see below. > >> ... and not r

Re: [PATCH] emacs: show: stop display of appliaction/* parts

On Sun, Jan 08 2017, Tomi Ollila <tomi.oll...@iki.fi> wrote: > On Sat, Jan 07 2017, Mark Walters <markwalters1...@gmail.com> wrote: > >> Gnus seems to display application/zip and application/tar by >> default. This doesn't seem desirable so we override it. >>

Re: [PATCH] emacs: show: stop display of appliaction/* parts

On Sat, Jan 07 2017, Mark Walters wrote: > Gnus seems to display application/zip and application/tar by > default. This doesn't seem desirable so we override it. > > We only override ifthe user has not customized > mm-inline-override-types themselves. > --- I suggest

[PATCH] test: allow user to choose which gdb to run tests with

The variable used for selecting gdb is TEST_GDB, consistent with TEST_CC and TEST_EMACS{,CLIENT}. --- I tested this on FreeBSD kvm virtual machine, changed env PATH=/usr/local/bin:$PATH CPATH=/usr/local/include LIBRARY_PATH=/usr/local/lib script typescript gmake test to env

Re: [PATCH 1/2] lib: use glib for sha1 digests instead of embedding libsha1

On Fri, Jan 06 2017, Jani Nikula wrote: > We already depend on glib both directly and indirectly (via gmime). We > might as well make use of its facilities. Drop the embedded libsha1 > and use glib for sha1 digests. Nice! tests pass. probably doesn't collide with anything in

[RFC PATCH] rfc: make 'make distclean' always use current Makefile.config

... and not recreate it (slowly) if 'configure' changed, just to be deleteted later during 'make distclean'. For cleaning the old Makefile.config might actually be more accurate if configure changes what will be cleaned later... --- Makefile | 8 +++- 1 file changed, 7 insertions(+), 1

Re: [BUG] notmuch-emacs highlights '>' quoted wrapped lines incorrectly

On Fri, Jan 06 2017, David Edmondson <d...@dme.org> wrote: > On Fri, Jan 06 2017, Tomi Ollila wrote: > >> On Thu, Jan 05 2017, David Edmondson <d...@dme.org> wrote: >> >>> On Thu, Jan 05 2017, Jani Nikula wrote: >>> >>>> When the

Re: [BUG] notmuch-emacs highlights '>' quoted wrapped lines incorrectly

On Thu, Jan 05 2017, David Edmondson wrote: > On Thu, Jan 05 2017, Jani Nikula wrote: > >> When the show view in notmuch-emacs highlights quoted text, any long, >> folded lines in quotes prefixed using '>' fail to be highlighted. Quotes >> prefixed using '> ' work fine. See below.

[PATCH] notmuch-config: ENOENT vs generic handling when file open fails.

When opening configuration file fails, ENOENT (file not found) is handled specially -- in setup missing file is ok (often expected), and otherwise user can be informed to run notmuch setup. In any other case the the reason is unknown, so there is no other option but to print generic error message

[PATCH] test: wrap 'wc -l' results in arithmetic evaluation to strip whitespace

Some new unwrapped 'wc -l's have been added since Jani's 60e79e3a9f1c8 --- test/T070-insert.sh| 2 +- test/T580-thread-search.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/T070-insert.sh b/test/T070-insert.sh index 57472b913964..7fb3b87e4584 100755 ---

Re: [PATCH] [EMACS] Adjust notmuch-crypto gpg call-process function

On Thu, Jan 05 2017, John Byrnes wrote: >> I think this is reasonable. We're already setting epg-gpg-program in >> test/test-lib.sh, and in debian, epg-gpg-program is provided by >> epg-config.el, which is part of emacs$VERSION-el, which is a dependency >> of

[PATCH] test: replaced use of python with $NOTMUCH_PYTHON (twice)

$NOTMUCH_PYTHON is sourced from sh.config, configured by ./configure and stated to be used as: "Name of python command to use in configure and the test suite." --- test/T260-thread-order.sh | 2 +- test/test-lib.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] [EMACS] Adjust notmuch-crypto gpg call-process function

On Wed, Jan 04 2017, Daniel Kahn Gillmor wrote: > On Tue 2017-01-03 21:55:48 -0500, John Byrnes wrote: >> I'm running the latest NixOS and noticed that the system does not >> install gpgv1 by default. This means that the only gpg binary available >> is the gpg2 binary. >>

[PATCH] test: atomicity.py: improve exit probability on failure

Some gdb python exceptions on some os environments (e.g. macOS Sierra, non-codesigned gdb) do not make gdb exit (but to drop down to nonexistent command line?). Mitigate this chance by explict SystemExit on all exceptions. The contents of output file 'gdb.out' is unchanged. --- test/atomicity.py

Re: [PATCH] tests: add compatibility layer

On Tue, Jan 03 2017, Tomi Ollila <tomi.oll...@iki.fi> wrote: > On Mon, Jan 02 2017, mp39...@gmail.com wrote: > >> From: Mikhail <mp39...@gmail.com> >> >> Make test-lib-common.sh load test-lib-<$PLATFORM>.sh to create >> additional shim for platform

Re: [PATCH] tests: add compatibility layer

On Tue, Jan 03 2017, Tomi Ollila <tomi.oll...@iki.fi> wrote: > > To fix the above, one could use (possibly better written) mkwrap() > implementation, or do all of those by hand: e.g. > > if command -v gdate >/dev/null; then date () { gdate "$@"; }; fi

Re: [PATCH] tests: add compatibility layer

On Mon, Jan 02 2017, mp39...@gmail.com wrote: > From: Mikhail > > Make test-lib-common.sh load test-lib-<$PLATFORM>.sh to create > additional shim for platform specifics. > > Use test-lib-FREEBSD.sh to call GNU utilities instead of native ones. Ok, now I've git a bit of time

[PATCH] configure: fix $prefix expansion for libdir_expanded

Since the sed expansion line which did $prefix expansion for libdir_expanded was changed from the legacy `...` format to the new $(...) expression, the subtle backslash expansion change went unnoticed -- \\$ which used to escape '$' now escapes '\' and the following '$prefix' was attempted to

Re: [PATCH] tests: add compatibility layer

On Thu, Dec 22 2016, mp39...@gmail.com wrote: > From: Mikhail > > Make test-lib-common.sh load test-lib-<$PLATFORM>.sh to create > additional shim for platform specifics. > > Use test-lib-FREEBSD.sh to call GNU utilities instead of native ones. I've been slow to respond,

Re: [PATCH] tests: add compatibility layer

On Wed, Dec 21 2016, David Bremner wrote: > mp39...@gmail.com writes: > >> >> +# OS independent functions >> +# >> +# Alias native BSD utilities to usable GNU equivalents. >> +case `uname` in >> +FreeBSD) >> +# allow using aliases in scripts >> +shopt -s

Re: [PATCH v6 0/2] Refactor config reading to support non-regular files

On Sat, Dec 10 2016, Ioan-Adrian Ratiu wrote: > Changes since v5 (based on Tomi's feedback): > * Return the same error message when config file is not found to > avoid breaking test T040-setup.1. > > Ioan-Adrian Ratiu (1): > notmuch-config: replace config reading

Re: Fix for notmuch-search autoload cookie

On Thu, Dec 08 2016, David Bremner wrote: > If your using the elpa packages (e.g. in recent debian packages), you might > have > noticed that the autoloading of notmuch-search was not working. > > This is a fix for that. You can test it by running: > > emacs -q > M-x

Re: NEWS/docs for insert tempfail changes

On Wed, Dec 07 2016, David Bremner wrote: > I went back and forth few times, but eventually decided to go with > Tomi's version of the test quoting, the better to share the blame. > The patches will be merged to release and master, in prep for another > bugfix release. Here

Re: [PATCH v5 2/2] notmuch-config: replace config reading function

On Thu, Dec 08 2016, Ioan-Adrian Ratiu wrote: > Config files are currently read using glib's g_key_file_load_from_file > function which is very inconvenient because it's limited by design to read > only from "regular data files" in a filesystem. Because of this limitation >

Re: [PATCH v4 2/2] notmuch-config: replace config reading function

On Mon, Dec 05 2016, Ioan-Adrian Ratiu wrote: > Config files are currently read using glib's g_key_file_load_from_file > function which is very inconvenient because it's limited by design to read > only from "regular data files" in a filesystem. Because of this limitation >

Re: v2 of insert tempfail series

On Tue, Nov 29 2016, David Bremner wrote: > This incorporates Tomi's patch of > > id:1480367228-22183-1-git-send-email-tomi.oll...@iki.fi > > verbatim, to sort out conflicts. > > It fixes the issues I alread sent mail about, and puts back the --keep > tests for various

Re: [PATCH v3 2/2] notmuch-config: replace config reading function

On Sun, Dec 04 2016, Ioan-Adrian Ratiu wrote: > Config files are currently read using glib's g_key_file_load_from_file > function which is very inconvenient because it's limited by design to read > only from "regular data files" in a filesystem. Because of this limitation >

Re: [PATCH v2 2/2] notmuch-config: replace config reading function

On Sun, Nov 06 2016, Ioan-Adrian Ratiu wrote: > Config files are currently read using glib's g_key_file_load_from_file > function which is very inconvenient because it's limited by design to read > only from "regular data files" in a filesystem. Because of this limitation >

[PATCH 3/3] fix out of tree tests

Use $NOTMUCH_SRCDIR/ instead of $TEST_DIRECTORY/../ (in those 2 places) where refecence to source directory instead of build directory is required. --- test/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index

<    2   3   4   5   6   7   8   9   10   11   >