[PATCH] News: add entry for unthreaded mode

2020-09-05 Thread Mark Walters
A belated NEWS entry for the new un-threaded mode introduced in Notmuch 0.30. --- Sorry I didn't send this for the 0.30 release. I am not sure if the last sentence is appropriate for a NEWS item, so feel free to delete. I don't have a development item set up (I am still mainly using emacs 24) so

Re: call for NEWS entries for 0.31

2020-09-04 Thread Mark Walters
Hi > Here's a lightly edited output from git shortlog to jog your collective > memories. Please send patches for NEWS for any non-trivial user visible > changes. I think I should have sent a news patch for the "unthreaded mode" addition which went into the 0.30 release (sorry about that).

Re: [PATCH] emacs: split-window-sensibly in tree mode with open message

2020-05-22 Thread Mark Walters
Hi > For some historical context, split-window-sensibly was introduced in 2009 [1] > and the (split-window-vertically (/ (window-height) 4)) code in 2012 [2]. The > two functions seem pretty interchangeable. As far as I can see the split-window-sensibly version splits the window into two

[PATCH 1/6] notmuch-show.c: add an option for messages to be returned unthreaded

2020-02-27 Thread Mark Walters
This adds a --unthreaded option to notmuch show to tell it to return the matching messages in an unthreaded order (so just by date). To make it easier for users, in particular for notmuch-tree.el, we output each message with the same "nesting" as if it were an entire thread in its own right. ---

[PATCH 2/6] Introduce unthreaded mode

2020-02-27 Thread Mark Walters
This commit introduces a new 'unthreaded' search mode where each matching message is shown on a separate line. It shares almost all of its code with tree view. Subsequent commits will allow it to diverge slightly in appearance. --- emacs/notmuch-hello.el | 2 +- emacs/notmuch-lib.el | 1 +

[PATCH 4/6] Unthreaded mode: allow user to choose different `show out' than tree

2020-02-27 Thread Mark Walters
Tree mode allows the user to choose whether to use the split screen displaying just the current message or a full screen displaying the entire thread. As unthreaded mode is quite different in use the user may want a different customisation for this mode. --- emacs/notmuch-tree.el | 14

[PATCH 3/6] Unthreaded mode: allow different result format

2020-02-27 Thread Mark Walters
It is likely that the user will want a different line format for unthreaded mode from tree mode; in particular the thread structure graphics are unnecessary in unthreaded mode. Add a new customisable variable and set it to something sensible. --- emacs/notmuch-tree.el | 27

[PATCH 6/6] notmuch-hello/jump: allow saved searches to specify unthreaded mode

2020-02-27 Thread Mark Walters
Saved searches in notmuch-hello and notmuch-jump can specify whether to use search mode or tree mode. This adds an option for them to specify unthreaded mode. --- emacs/notmuch-hello.el | 29 +++-- emacs/notmuch-jump.el | 10 +++--- 2 files changed, 26 insertions(+),

[PATCH 5/6] Add a U binding to switch to unthreaded from other views

2020-02-27 Thread Mark Walters
We have shortcuts S and Z to let the user switch to Search view and Tree view with the current search. Add U to let the user switch to unthreaded view from the current search, and ensure that S and Z switch from unthreaded to search and tree veiew respectively. --- emacs/notmuch-show.el | 10

[PATCH 0/6] Add an unthreaded mode

2020-02-27 Thread Mark Walters
just the matching messages (not the entire threads) but still in threaded order, and this option can be used by pre-existing emacs functionality (depending on user settings); this is why I added a new --unthreaded option. Best wishes Mark Mark Walters (6): notmuch-show.c: add an option

Re: [PATCH] emacs: tree: support fold/unfold thread

2019-03-23 Thread Mark Walters
Hello > This patch allow the user to fold/unfold a thread in the current tree > buffer by pressing "t" key. This looks like a really nice feature! I will try and review the code properly soon, but have some preliminary comments. > By default a string is displayed at the beginning of the

Re: [emacs] message list view

2018-12-12 Thread Mark Walters
Dear All I think this could be very useful -- indeed I currently have been running some scruffy patches implementing this for the last couple of months. What I have done is modify notmuch-show.c so that you can pass a --unthreaded option and it returns each message as if it were a thread on

Re: [PATCH] lib: add support for thread: queries

2017-10-20 Thread Mark Walters
Hi On Mon, 16 Oct 2017, Jani Nikula wrote: > Add support for querying threads using message-ids in addition to > thread-ids. The main benefit is that thread queries via message-ids > are portable across databases, re-indexing, and thread joining, while > thread ids can be

Re: notmuch-emacs: Fcc to top-level directory given by database.path

2017-10-02 Thread Mark Walters
Hi On Sun, 01 Oct 2017, Arun Isaac <arunis...@systemreboot.net> wrote: > Mark Walters <markwalters1...@gmail.com> writes: > >> Incidentally, I think "/" is an alternative for the fcc line which >> already works, which is "\"/\" in notmuch-fc

Re: [PATCH 0/6] Sort by from and subject

2017-09-30 Thread Mark Walters
Hi On Sat, 30 Sep 2017, Jani Nikula wrote: > On Sat, 30 Sep 2017, William Casarin wrote: >> Jani Nikula writes: >> >>> I think there are two considerations here: >>> >>> First, is this something we want to have? Is this generally useful? >> >>

Re: Guess 'From:' when doing notmuch reply

2017-09-30 Thread Mark Walters
> One option would be for you to customize the output of notmuch-reply in > Emacs. I think the package message-templ (unfortunately only in > marmalade, debian, and my git repo) provides tools that could help with > that. If you want to investigate it's at: > >

Re: notmuch.el: "wash" date in message display

2017-09-30 Thread Mark Walters
On Thu, 21 Sep 2017, Tomi Ollila wrote: > On Wed, Sep 20 2017, Matt Armstrong wrote: > >> I miss some of the Gnus "wash" functions available for message display. >> There was one that either reformatted the Date: header into my time >> zone, or displayed the Date in terms of

Re: notmuch-emacs: Fcc to top-level directory given by database.path

2017-09-30 Thread Mark Walters
On Sun, 24 Sep 2017, David Bremner wrote: > Arun Isaac writes: > >>> In any case I've noted your feature request/bug-report. It doesn't sound >>> terribly difficult to change, but it will need someone motivated to >>> think about all of the related

Re: notmuch-emacs: Fcc to top-level directory given by database.path

2017-09-23 Thread Mark Walters
On Sat, 23 Sep 2017, David Bremner wrote: > Arun Isaac writes: > >> I am using notmuch-emacs, and I would like to Fcc my sent mail to the >> top-level directory given by database.path, instead of using a folder >> like "sent" relative to the

Re: [PATCH 2/2] emacs: show: allow user to insert rfc822 parts as messages

2017-08-28 Thread Mark Walters
> >> + (let* ((folder >> + (read-from-minibuffer "Folder/tags to insert part to: " >> +notmuch-show-part-notmuch-insert-folder))) >> +(mm-with-unibyte-buffer >> + (mm-insert-part handle) >> + (notmuch-maildir-fcc-with-notmuch-insert folder nil

Re: [PATCH 1/2] emacs: maildir fcc make insert more flexible

2017-08-28 Thread Mark Walters
Hi Thanks for the review. On Mon, 28 Aug 2017, David Edmondson <d...@dme.org> wrote: > On Monday, 2017-08-28 at 08:32:21 +0100, Mark Walters wrote: > >> This changeset makes the function >> notmuch-maildir-fcc-with-notmuch-insert slightly more flexible by >>

[PATCH 0/2] emacs: allow message/rfc822 to be inserted in the mailstore

2017-08-28 Thread Mark Walters
. This new version includes some better error checking, and allows the user to specify tags for the inserted message. The new version is not heavily tested but seems to work. Best wishes Mark Mark Walters (2): emacs: maildir fcc make insert more flexible emacs: show: allow user to insert rfc822

[PATCH 1/2] emacs: maildir fcc make insert more flexible

2017-08-28 Thread Mark Walters
This changeset makes the function notmuch-maildir-fcc-with-notmuch-insert slightly more flexible by allowing some of the prompts to be controlled by the caller. --- emacs/notmuch-maildir-fcc.el | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git

[PATCH 2/2] emacs: show: allow user to insert rfc822 parts as messages

2017-08-28 Thread Mark Walters
This adds a part-handler function that uses notmuch-insert to insert an rfc822 part as a message in its own right. This allows the user to reply directly to that message. We use notmuch-maildir-fcc-with-notmuch-insert as that has builtin error handling/retry functionality, and it allows the user

[PATCH] test: duplicate mids: add an extra broken search test

2017-08-27 Thread Mark Walters
--- Hi Many thanks to bremner for the parent patch. I thought it might be worth adding a search test after the broken show test demonstrating the distinction between show and search. When I added it I found it actually gives the other file as the answer! This applies on top of the parent patch.

Duplicate message ids

2017-08-27 Thread Mark Walters
Hi A concern for notmuch is some form of attack via someone sending a message with a duplicate message id. I think I have seen it asserted that it is not so much of a problem as the first message received by notmuch will have priority. However, I believe that this is not the case. The script

Re: [PATCH v2] emacs: Add notmuch-update-search-tags

2017-08-27 Thread Mark Walters
Hi OK I have now actually tested it, and I have read the patch more carefully, but I am afraid I still have concerns. The key problem is the patch assumes that the display of a thread in a search buffer depends only on the thread. And this is not true as the number of matching messages is

Re: [PATCH v2] emacs: Add notmuch-update-search-tags

2017-08-26 Thread Mark Walters
Hi On Sat, 26 Aug 2017, Vladimir Panteleev wrote: > From: Vladimir Panteleev > > Implement an option which, when enabled, causes any tag changes done > from within notmuch-emacs to instantly update matching threads in open > search buffers.

Re: High CPU usage on Tree View with many emails

2017-06-25 Thread Mark Walters
Hi > When I make a query that gives many results (e.g. "review", which hits > ~2200 emails with my Gerrit reviews) and want to display them in Tree > View, the CPU usage stays high for several seconds. > > While this happens, the Emacs window flickers, like it was busy with > redisplaying the

[PATCH] emacs: tree: bugfix: specify --format-version

2017-05-13 Thread Mark Walters
Previously notmuch tree did not specify the format-version when calling notmuch. This meant that when the structured output was slightly changed (in commit 14c60cf168ac3b0f277188c16e6012b7ebdadde7) stash filename broke. This fixes this breakage by specifying the format-version. --- Bremner

Re: [RFC patch 2/2] lib: index message files with duplicate message-ids

2017-03-16 Thread Mark Walters
Hi Just a comment on your last point: > It also occurs to me that one of the things i'd love to have is > well-indexed notes about any given e-mail. So if this was adopted, i > could presumably just write a file that has the same Message-Id as the > message, put my notes in it, and index it.

Re: [PATCH] emacs: remove use of message-send-hook

2017-03-10 Thread Mark Walters
On Fri, 10 Mar 2017, David Bremner <da...@tethera.net> wrote: > Mark Walters <markwalters1...@gmail.com> writes: > >> +(let (tag-change >> + post-send-tag-changes) >> + ;; post-send-tag-changes are tag-changes to apply after sending, >&g

[PATCH] NEWS for emacs

2017-03-06 Thread Mark Walters
--- This is the NEWS updates for most of my changes. I am not quite sure whether any of my other changes warranted news items -- prod me if you think they do. Note I changed the heading to Emacs not Emacs Interface to match previous releases but obviously that can be changed back if you prefer.

[PATCH v3 1/2] Test: emacs: test for folding long headers.

2017-03-04 Thread Mark Walters
Headers of more than 998 characters should be folded when sending. However, until recently, emacs did not do this. This adds a (known broken) test for this when sending messages in emacs. We will backport the fix to notmuch-emacs in the next changeset. --- test/T310-emacs.sh | 78

[PATCH v3 0/2] emacs: fold long headers when sending

2017-03-04 Thread Mark Walters
Version 2 of this series is at id:1488649637-19006-1-git-send-email-markwalters1...@gmail.com The change here is to split the folding headers function into an explicit function as this makes managing the hook simpler. Best wishes Mark Mark Walters (2): Test: emacs: test for folding long

[PATCH v3 2/2] emacs: compat: backport fix for folding long headers when sending

2017-03-04 Thread Mark Walters
This backports the fix from emacs master (commit 77bbca8c82f6e553c42abbfafca28f55fc995d00) to notmuch-emacs to wrap long headers. This fixes the test introduced in the previous changeset. --- emacs/notmuch-compat.el | 28 1 file changed, 24 insertions(+), 4

[PATCH v2 0/2] emacs: fold long headers when sending

2017-03-04 Thread Mark Walters
The only change from v1 (at id:1485684281-2760-1-git-send-email-markwalters1...@gmail.com ) is an updated test as suggested by Domo using echo {1..1000} instead of seq. Best wishes Mark Mark Walters (2): Test: emacs: test for folding long headers. emacs: compat: backport fix for folding

[PATCH v2 2/2] emacs: compat: backport fix for folding long headers when sending

2017-03-04 Thread Mark Walters
This backports the fix from emacs master (commit 77bbca8c82f6e553c42abbfafca28f55fc995d00) to notmuch-emacs to wrap long headers. This fixes the test introduced in the previous changeset. --- emacs/notmuch-compat.el | 28 1 file changed, 24 insertions(+), 4

[PATCH v2 1/2] Test: emacs: test for folding long headers.

2017-03-04 Thread Mark Walters
Headers of more than 998 characters should be folded when sending. However, until recently, emacs did not do this. This adds a (known broken) test for this when sending messages in emacs. We will backport the fix to notmuch-emacs in the next changeset. --- test/T310-emacs.sh | 78

Re: Github an licensing

2017-03-04 Thread Mark Walters
> On irc rlb pointed me to > https://joeyh.name/blog/entry/removing_everything_from_github/ > > IANAL so I don't know whether it is a real problem, a hypothetical > problem or not a problem. I got a couple of links sent to me privately which look relevant: *

Github an licensing

2017-03-04 Thread Mark Walters
Dear All On irc rlb pointed me to https://joeyh.name/blog/entry/removing_everything_from_github/ IANAL so I don't know whether it is a real problem, a hypothetical problem or not a problem. My guess is that it can't affect the main notmuch license as the bulk of notmuch's copyright is owned by

Re: [PATCH v2] emacs: show: stop display of application/* parts

2017-02-27 Thread Mark Walters
Hi >> But what will we do if the user has not customized it because she >> /wants/ to display all possible things inline. I have not seen that this >> patch is merged into master, and probably, when I have learned about >> this variable, I think maybe it's better not to do it in the notmuch >>

Re: [Patch v4] lib: regexp matching in 'subject' and 'from'

2017-02-10 Thread Mark Walters
On Thu, 09 Feb 2017, David Bremner wrote: > Jani Nikula writes: > >> >> Theoretically "/" is an acceptable character in message-ids [1]. Rare, >> unlikely, but acceptable. Searching for message-id's beginning with "/" >> would have to use regexps, which would

[PATCH] test: fix tests for content-disposition

2017-01-29 Thread Mark Walters
This fixes all tests for the recent addition of content-disposition to the structured format outputs of notmuch-show. --- Since Jani added the content-disposition as I wanted to use it from emacs (thanks Jani!) I thought I should fix the tests. I don't know if it should be folded in to the main

Re: [PATCH 2/2] cli/show: add content-disposition to structured output message parts

2017-01-29 Thread Mark Walters
On Sat, 28 Jan 2017, Jani Nikula wrote: > Help the clients decide how to display parts. This series looks good to me. I would say +1, but I am not sure my knowledge of C is really up to that. There are a bunch of tests to update; I will send a patch to do that in shortly. >

[PATCH 0/2] emacs: Fold long headers when sending

2017-01-29 Thread Mark Walters
, so if anyone who knows about that could check I would be grateful. (For example, is seq -s " " 1 1000 standard?) Best wishes Mark Mark Walters (2): Test: emacs: test for folding long headers. emacs: compat: backport fix for folding long headers when sending emacs/notmuch-comp

[PATCH 1/2] Test: emacs: test for folding long headers.

2017-01-29 Thread Mark Walters
Headers of more than 998 characters should be folded when sending. However, until recently, emacs did not do this. This adds a (known broken) test for this when sending messages in emacs. We will backport the fix to notmuch-emacs in the next changeset. --- test/T310-emacs.sh | 79

[PATCH 2/2] emacs: compat: backport fix for folding long headers when sending

2017-01-29 Thread Mark Walters
This backports the fix from emacs master (commit 77bbca8c82f6e553c42abbfafca28f55fc995d00) to notmuch-emacs to wrap long headers. This fixes the test introduced in the previous changeset. --- emacs/notmuch-compat.el | 28 test/T310-emacs.sh | 1 - 2 files

[PATCH] emacs: fully add the notmuch-address customize group

2017-01-28 Thread Mark Walters
We now have several customizable options for address completion. There is a customize group notmuch-address but it only contains one of these options. Add all the others, and make it part of the notmuch customize group. --- Bremner pointed out that many of these were not in the notmuch-addres

[PATCH] emacs: company: remove two build warnings

2017-01-28 Thread Mark Walters
This adds two defvars to avoid two build warnings in the notmuch emacs code. These were both introduced (by me) in commit 827c28a0. --- The defvar for notmuch-address-command is clearly correct as that is defined in notmuch-address so will definitely be defined when this code is run. The other,

[PATCH v2] emacs: show: stop display of application/* parts

2017-01-28 Thread Mark Walters
Gnus seems to display application/zip and application/tar by default. This doesn't seem desirable so we override it. We only override if the user has not customized mm-inline-override-types themselves. --- I think this fixes all the bugs (and typos). Thanks to Tomas and Tomi for finding and

Re: Q: notmuch emacs, fcc, maildir, notmuch insert and message-kill-buffer-on-exit

2017-01-25 Thread Mark Walters
Hi I am not sure what the full problem is (I will try and have a better look later), but I think the main problem is that the sending mail part is returning an error. The "Sending...failed to" is coming from emacs, and I think the "mail for [ -oi -t > ] : send was successful; " from

[PATCH] emacs: show: stop display of appliaction/* parts

2017-01-07 Thread Mark Walters
Gnus seems to display application/zip and application/tar by default. This doesn't seem desirable so we override it. We only override ifthe user has not customized mm-inline-override-types themselves. --- This was mentioned on irc today and this might be a reasonable way of doing this. It does

[WIP PATCH] emacs: tag-jump allow post tag functions

2016-12-15 Thread Mark Walters
This adds an option to the tag-jump defcustom to apply a post-tagging function. One natural option is to go to the next thread/message. --- This is a first attempt at this. The main change needed is to update the docstrings. The structure is a little weird (a list with a plist as an element).

Re: anyone uses notmuch-web?

2016-12-14 Thread Mark Walters
> i'm an user of notmuch already for some years (in fact from the beginning). > great product! i want to replace my roundcube installation on web server by > notmuch-web, which - at least in testing on local computer - looks great and > does exactly the job. > > my concerns are in the domain of

Re: [emacs] thread view is showing all messages

2016-11-20 Thread Mark Walters
Hi >> -- >> By default, various components of email messages, (citations, >> signatures, already-read messages), are hidden. >> -- I wonder if this text should be changed -- I am not sure what is meant by already-read

Re: Filtering completions

2016-11-20 Thread Mark Walters
Hi On Mon, 21 Nov 2016, Sebastian Fischmeister wrote: > Hi, > > Is there a variable defining a regex to filter harvested completions before > showing them? My completions include some outdated or invalid email addresses > for people and I would like to automatically

[PATCH 2/2] emacs: address: save hash

2016-11-20 Thread Mark Walters
This allows the user to save the address hash so that it is much faster for the first completion after a restart. This defaults to off as there are privacy implications to saving this information. The code tries hard to avoid overwriting the wrong file. It also notes if changes have been made to

[PATCH 0/2] emacs allow save and load of the address-completions

2016-11-20 Thread Mark Walters
e address completion is upgraded in some way (e.g., we store the frequency of each match in the map). By default the save/load is switched off: this avoids accidental privacy leaks, but does make it harder for users to discover. Best wishes Mark Mark Walters (2): emacs: address: move address-f

[PATCH 1/2] emacs: address: move address-full-harvest-finished to a function

2016-11-20 Thread Mark Walters
This makes the code access notmuch-address-full-harvest-finished via a helper function, notmuch-address--harvest-ready. Later we will use this to check whether we can load the harvest instead of regenerating it. --- emacs/notmuch-address.el | 8 ++-- emacs/notmuch-company.el | 4 ++-- 2 files

[PATCH] NEWS for notmuch-cycle-notmuch-buffers

2016-11-18 Thread Mark Walters
--- A first attempt at NEWS for 09caa0f. I am not fully happy with it, so any suggestions very welcome. It applies on top of id:20161117121820.23393-1-da...@tethera.net Best wishes Mark NEWS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS b/NEWS index e693da7..3413a9c 100644

[PATCH] emacs: remove use of message-send-hook

2016-11-17 Thread Mark Walters
We use message-send-hook for two things -- tagging drafts deleted, and tagging replied the parent message of a reply. We should not use message-send-hook as that will affect gnus etc too. Moreover, message-send-hook is run before the message is sent, even before the user confirms they want to send

[PATCH v3] emacs: add compatibility functions for emacs 23

2016-11-15 Thread Mark Walters
Some of the recent changes to the emacs code have used functions introduced in emacs 24. The functions used are read-char-choice and setq-local. This changeset adds a file notmuch-compat.el which contains compatibility functions so that it should work on emacs 23. Note, since these functions are

[PATCH] Test: fix draft test for emacs23

2016-11-14 Thread Mark Walters
emacs24 and emacs23 have different secure tag defaults: in particular, mml-secure-message-sign only signs the part on emacs23 but the whole message on emacs24. This difference makes one of the draft tests fail (which causes a cascade of later failures) on emacs23. It seems that travis uses emacs23

[PATCH v7 3/4] emacs: check drafts for encryption tags before saving

2016-11-13 Thread Mark Walters
From: David Bremner In general the user may not want to save plaintext copies of messages that they are sending encrypted, so give them a chance to abort. --- emacs/notmuch-draft.el | 39 +++ test/T630-emacs-draft.sh | 13 + 2

[PATCH v7 4/4] emacs: resume messages

2016-11-13 Thread Mark Walters
From: David Bremner Provide functionality to resume editing a message previously saved with notmuch-draft-save, including decoding the X-Notmuch-Emacs-Secure header. Resume gets the raw file from notmuch and using the emacs function mime-to-mml reconstructs the message

[PATCH v7 0/4] emacs postpone/resume patches

2016-11-13 Thread Mark Walters
wishes Mark David Bremner (2): emacs: check drafts for encryption tags before saving emacs: resume messages Mark Walters (2): emacs: tree: remove binding for pressing button in message pane emacs: postpone a message emacs/Makefile.local | 3 +- emacs/notmuch-draft.el | 268

[PATCH v7 2/4] emacs: postpone a message

2016-11-13 Thread Mark Walters
000..b8a5e67 --- /dev/null +++ b/emacs/notmuch-draft.el @@ -0,0 +1,167 @@ +;;; notmuch-draft.el --- functions for postponing and editing drafts +;; +;; Copyright © Mark Walters +;; Copyright © David Bremner +;; +;; This file is part of Notmuch. +;; +;; Notmuch is free software: you can redistribute

[PATCH v7 1/4] emacs: tree: remove binding for pressing button in message pane

2016-11-13 Thread Mark Walters
We want to use "e" for editting postponed messages in show, and in tree view, so remove the binding for the function which does (In message pane) Activate BUTTON or button at point --- emacs/notmuch-tree.el | 1 - 1 file changed, 1 deletion(-) diff --git a/emacs/notmuch-tree.el

[PATCH v6 4/4] emacs: resume messages

2016-11-13 Thread Mark Walters
From: David Bremner Provide functionality to resume editing a message previously saved with notmuch-draft-save, including decoding the X-Notmuch-Emacs-Secure header. Resume gets the raw file from notmuch and using the emacs function mime-to-mml reconstructs the message

[PATCH v6 3/4] emacs: check drafts for encryption tags before saving

2016-11-13 Thread Mark Walters
From: David Bremner In general the user may not want to save plaintext copies of messages that they are sending encrypted, so give them a chance to abort. --- emacs/notmuch-draft.el | 39 +++ test/T630-emacs-draft.sh | 13 + 2

[PATCH v6 0/4] emacs postpone/resume patches

2016-11-13 Thread Mark Walters
o rejigged Patch 3 (the secure tag checks). I think I like this version but i am happy to revert to the previous one if preferred. The diff from the previous version is below. Best wishes Mark David Bremner (2): emacs: check drafts for encryption tags before saving emacs: resume messages Ma

[PATCH v6 2/4] emacs: postpone a message

2016-11-13 Thread Mark Walters
000..b8a5e67 --- /dev/null +++ b/emacs/notmuch-draft.el @@ -0,0 +1,167 @@ +;;; notmuch-draft.el --- functions for postponing and editing drafts +;; +;; Copyright © Mark Walters +;; Copyright © David Bremner +;; +;; This file is part of Notmuch. +;; +;; Notmuch is free software: you can redistribute

[PATCH v6 1/4] emacs: tree: remove binding for pressing button in message pane

2016-11-13 Thread Mark Walters
We want to use "e" for editting postponed messages in show, and in tree view, so remove the binding for the function which does (In message pane) Activate BUTTON or button at point --- emacs/notmuch-tree.el | 1 - 1 file changed, 1 deletion(-) diff --git a/emacs/notmuch-tree.el

Re: [Patch v5 4/4] emacs: resume messages

2016-11-13 Thread Mark Walters
On Sat, 12 Nov 2016, David Bremner wrote: > David Bremner writes: > >> Provide functionality to resume editing a mesage previously saved with >> notmuch-draft-save, including decoding the X-Notmuch-Emacs-Secure >> header. > > s/mesage/message/ > >> +(defun

Re: [Patch v5 2/4] emacs: postpone a message

2016-11-13 Thread Mark Walters
On Sat, 12 Nov 2016, David Bremner <da...@tethera.net> wrote: > David Bremner <da...@tethera.net> writes: > >> From: Mark Walters <markwalters1...@gmail.com> > > This really Mark's work, that I have split out into a separate file. > >> +(defcustom notmu

Re: [PATCH] emacs: mua: add a pre-send-check-hook

2016-11-12 Thread Mark Walters
> For consistency with Emacs' own elisp, perhaps rename > notmuch-mua-pre-send-check-hooks to > notmuch-mua-pre-send-check-functions? Hi Yes you are correct. (Annoyingly I had thought about this and thought it was OK since I didn't need to pass an argument. I had missed the return value case).

Re: [PATCH v4] emacs: add notmuch-address-post-completion-hook

2016-11-12 Thread Mark Walters
On Sat, 12 Nov 2016, David Bremner wrote: > Tomi Ollila writes: > >> Like someone (whose message I cannot find just now) mentioned in another >> thread, just now it is right time to mention here too... >> >>

Re: [Patch v5 3/4] emacs: check drafts for encryption tags before saving

2016-11-07 Thread Mark Walters
On Mon, 07 Nov 2016, David Bremner wrote: > In general the user may not want to save plaintext copies of messages > that they are sending encrypted, so give them a chance to abort. > --- > emacs/notmuch-draft.el | 40 >

Re: [Patch v3 2/2] emacs: postpone/resume support

2016-11-06 Thread Mark Walters
> +(defun notmuch-draft--check-encryption-tag () > + "Query user if there an mml tag that looks like it might indicate > encryption. > + > +Returns t if there is no such tag, or the user confirms they mean > +it." > + (save-excursion > +(message-goto-body) > + (or > + ;; We are

Re: [Patch v3 2/2] emacs: postpone/resume support

2016-11-06 Thread Mark Walters
On Sun, 06 Nov 2016, David Bremner <da...@tethera.net> wrote: > From: Mark Walters <markwalters1...@gmail.com> > > This provides preliminary support for postponing and resuming in the > emacs frontend. On postponing it uses notmuch insert to put the > message in the no

Re: [PATCH] emacs: add check for encryption before saving.

2016-11-05 Thread Mark Walters
On Sat, 05 Nov 2016, David Bremner <da...@tethera.net> wrote: > Mark Walters <markwalters1...@gmail.com> writes: > >> >> I think this is an excellent thing to add. I agree that false positives >> aren't much of a worry. If someone bumps into them a lot

Re: [PATCH] emacs: add check for encryption before saving.

2016-11-05 Thread Mark Walters
On Sat, 05 Nov 2016, David Bremner wrote: > This is intended to decrease the chance of people ending up with a bunch > of plaintext drafts of encrypted messages without knowing it. > > The check is intentionally overcautious; I think the false positive of > misplaced #secure

[PATCH] emacs: mua: add a pre-send-check-hook

2016-11-04 Thread Mark Walters
This add a pre-send hook for any checks the user wants to run before sending the message. If any function in the hook returns nil then the send will abort. One use would be to check that the from address is appropriate for the recipients (i.e., test From: based on To: and Cc:), but many other

Re: [PATCH v4] emacs: add notmuch-address-post-completion-hook

2016-11-04 Thread Mark Walters
This version looks good to me +1 Best wishes Mark ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v2 0/2] add postpone support

2016-11-03 Thread Mark Walters
so for now. (Fixing this properly is a little tricky -- avoiding the use of message-send-hook is easy but we currently mark a message replied even if the user aborts sending the message.) Best wishes Mark Mark Walters (2): emacs: tree: move binding for pressing button in message pane to u ema

Re: [PATCH v3] emacs: add notmuch-address-post-completion-hook

2016-11-03 Thread Mark Walters
On Thu, 03 Nov 2016, David Bremner wrote: > This hook can be used to update the message based on the results of > address completion. For example using message-templ or gnus-alias to set > the From address based on the To address just completed. > > The post-completion command

Re: [PATCH] emacs: add notmuch-address-post-completion-hook

2016-11-03 Thread Mark Walters
On Thu, 03 Nov 2016, David Bremner wrote: > This hook can be used to update the message based on the results of > address completion. For example I use it to set the From address based > on the To address just completed. > > The post-completion command is added to the

Re: rfc for notmuch remote access script

2016-10-30 Thread Mark Walters
On Sun, 30 Oct 2016, David Bremner wrote: > Jani Nikula writes: > >> >> Personally, I prefer a simple script that assumes a certain type of ssh >> client configuration. We can typically reference documentation written >> by others how to do that, and just say

[PATCH v2] emacs: add compatability functions for emacs 23

2016-10-29 Thread Mark Walters
Some of the recent changes to the emacs code have used functions introduced in emacs 24. The functions used are read-char-choice and setq-local. This changeset adds compatability functions to notmuch-lib so that it should work on emacs 23. --- Version 1 of this patch (with some discussion) is at

Re: [PATCH] emacs: add compatability functions for emacs 23

2016-10-27 Thread Mark Walters
On Thu, 27 Oct 2016, Matt Armstrong <marmstr...@google.com> wrote: > Mark Walters <markwalters1...@gmail.com> writes: > >> +;; Compatability functions for emacs 23. >> + >> +(unless (fboundp 'setq-local) >> + (defmacro setq-local (var val) >

Re: [PATCH] emacs: add compatability functions for emacs 23

2016-10-25 Thread Mark Walters
On Tue, 25 Oct 2016, David Bremner <da...@tethera.net> wrote: > Mark Walters <markwalters1...@gmail.com> writes: > >> Some of the recent changes to the emacs code have used functions >> introduced in emacs 24. The functions used are read-char-choice and >

[PATCH v2] devel: Document emacs keybindings

2016-10-23 Thread Mark Walters
This adds a file under devel listing all the keybindings sorted by key in the main three modes (search, show and tree). To reduce clutter it only lists the single key "unmodified" keybindings: I think all our uses of prefixes and modifiers are natural variants of the unmodified binding (eg M-n

Re: [PATCH] cli: try to run external notmuch- prefixed commands as subcommands

2016-10-22 Thread Mark Walters
On Sat, 22 Oct 2016, Jani Nikula wrote: > If the given subcommand is not known to notmuch, try to execute > external notmuch- instead. This allows users to have their > own notmuch related tools be run via the notmuch command, not unlike > git does. Also notmuch-emacs-mua will

[PATCH] emacs: add compatability functions for emacs 23

2016-10-22 Thread Mark Walters
Some of the recent changes to the emacs code have used functions introduced in emacs 24. The functions used are read-char-choice and setq-local. This changeset adds compatability functions to notmuch-lib so that it should work on emacs 23. --- Hi I tried compiling under emacs 23 recently and

[PATCH] emacs: interesting-buffer bugfixes/updates

2016-10-22 Thread Mark Walters
The command notmuch-interesting-buffer has got out of date -- it doesn't mention notmuch-tree, and it still refers to message-mode not notmuch-message-mode. Update both of these. This fixes the bug that notmuch-cycle-notmuch-buffers does not include notmuch-tree or notmuch-message-mode buffers in

[PATCH] nmbug: allow excluded messages

2016-10-22 Thread Mark Walters
This makes nmbug work even if the notmuch mailing list messages are excluded (i.e., have a tag in the excluded tags list). --- I keep all my mailing list emails under an excluded tag (initially this was to test the exclude code thoroughly, but I find it convenient to keep day to day email and

[PATCH] NEWS for two bugfixes

2016-10-22 Thread Mark Walters
This adds news items for the two bugs emacs: search face bugfix and emacs: fix notmuch-search-line-faces defcustom --- Hi here is a NEWS update as requested. Best wishes Mark NEWS | 9 + 1 file changed, 9 insertions(+) diff --git a/NEWS b/NEWS index ac3ceb1..547b961 100644

Re: [PATCH v4] Add notmuch-show--build-queries.

2016-10-20 Thread Mark Walters
On Wed, 19 Oct 2016, Matt Armstrong wrote: > notmuch-show--build-buffer now queries a list of queries built by the > former. This simplifies the logic. It also provides an easy place to > experiment with alternate sets of queries for given notmuch-show-* > variables

Re: [PATCH v2] emacs: make faces clear on dark backgrounds.

2016-10-20 Thread Mark Walters
On Thu, 20 Oct 2016, Matt Armstrong wrote: > The notmuch-tag-flagged, notmuch-search-flagged-face and > notmuch-crypto-part-header faces defaulted to "blue", which is nearly > unreadable when a dark background is in use. This is addressed by using > "gold" for dark

  1   2   3   4   5   6   7   8   9   10   >