Re: [PATCH] emacs: Use `cl-lib' instead of deprecated `cl'
Jonas Bernoulli writes: > I have fixed the remaining issues and added two small commits. > See v3. > Great, thanks. I've pushed the main one, and tagged the other two for review. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] emacs: Use `cl-lib' instead of deprecated `cl'
I have fixed the remaining issues and added two small commits. See v3. > Or of course you can/should get the tests running locally. The problem was that there are incompatible changes in Emacs 27. I am using Emacs 26 for the time being but will look into these breaking changes later. The first one was easy to work around, but that just revealed a second one... Jonas ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] emacs: Use `cl-lib' instead of deprecated `cl'
Jonas Bernoulli writes: > David Bremner writes: > >> A quick git grep suggests there are still cl-isms in the test-harness. > > I've fixed that now, see v2. > >> I get 3 test failures > > I am having issues running the tests. Currently > notmuch-mua-send-and-exit in emacs_deliver_message from test-lib.sh > just hangs for me. I haven't investigated further yet. So I am > afraid you'll have to run the tests for me again. There are still 2 failures. There is a lingering 'second' in T450-notmuch-show.sh. and a failure that I don't really understand from T720-emacs-attachment-warnings (had to edit the embeded mml to send this message :() T720-emacs-attachment-warnings: Testing emacs attachment warnings FAIL notmuch-test-attachment-warning part 1 Expect: t Output: "nil <-- (lambda nil (insert \"Hello \") (insert \"#mml type=message/rfc822 disposition=inline> \") (insert \"X-Has-Attach: \") (insert \"#/mml> \"))" Expect: t Output: "nil <-- (lambda nil (insert \"> I sent you an attachment! \") (sit-for 0.01))" Expect: t Output: "nil <-- (lambda nil (insert \"#part filename=\\\"foo\\\" /> \"))" Expect: t Output: "nil <-- (lambda nil (insert \"Here is an attachment: \") (insert \"#part filename=\\\"foo\\\" /> \"))" Expect: t Output: "nil <-- (lambda nil (insert \"Nothing is a-tt-a-ch-ed! \"))" Expect: t Output: "nil <-- nil" I don't mind being your test runner, but I'm a bit slow for a CI system;). We also have a travis setup, so you could use that if you like. Of course by default we'll get IRC notifications of your failures unless you edit .travis.yml Or of course you can/should get the tests running locally. I don't recognize the problem description. It might be related to missing test prereqs. We depend on dtach which is less commonly installed. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] emacs: Use `cl-lib' instead of deprecated `cl'
David Bremner writes: > A quick git grep suggests there are still cl-isms in the test-harness. I've fixed that now, see v2. > I get 3 test failures I am having issues running the tests. Currently notmuch-mua-send-and-exit in emacs_deliver_message from test-lib.sh just hangs for me. I haven't investigated further yet. So I am afraid you'll have to run the tests for me again. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] emacs: Use `cl-lib' instead of deprecated `cl'
William Casarin writes: > From: Jonas Bernoulli > > Starting with Emacs 27 the old `cl' implementation is finally > considered obsolete. Previously its use was strongly discouraged > at run-time but one was still allowed to use it at compile-time. > > For the most part the transition is very simple and boils down to > adding the "cl-" prefix to some symbols. A few replacements do not > follow that simple pattern; e.g. `first' is replaced with `car', > even though the alias `cl-first' exists, because the latter is not > idiomatic emacs-lisp. I get 3 test failures T310-emacs "Incremental parsing of search results" not sure what the error is here, it just reports nil T450-emacs-show "Show handles subprocess errors" *ERROR*: Symbol’s function definition is void: second T720-emacs-attachment-warnings: " notmuch-test-attachment-warning part 1 *ERROR*: Symbol’s function definition is void: loop A quick git grep suggests there are still cl-isms in the test-harness. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
