On Mon 2019-06-24 21:44:13 +0300, Tomi Ollila wrote:
> If this suite speedup is merged, I'd suggest using original David's patch
> 2/2 due to consistency reasons -- $gen_test_filename is used likewise in
> other test_expect_code cases. and, unless $TEST_DIRECTORY contains '"'s,
> '$'s or '`'s it
* Daniel Kahn Gillmor:
> Do you think we could go ahead and apply these patches on master now
> anyway, and fix them up subsequently to make sure they apply to MacOS?
I still have not been able to set up any macOS based tests, because
contractual work has kept me busy. I suggest you go ahead
On Mon, Jun 24 2019, Daniel Kahn Gillmor wrote:
> On Fri 2019-06-14 08:16:14 -0300, David Bremner wrote:
>> Ralph Seichter writes:
>>
>>> * Daniel Kahn Gillmor:
>>>
Perhaps Ralph Seichter (explicitly cc'ed above) could comment on how
it'll affect homebrew?
>>>
>>> MacPorts, actually.
On Fri 2019-06-14 08:16:14 -0300, David Bremner wrote:
> Ralph Seichter writes:
>
>> * Daniel Kahn Gillmor:
>>
>>> Perhaps Ralph Seichter (explicitly cc'ed above) could comment on how
>>> it'll affect homebrew?
>>
>> MacPorts, actually. ;-) I have not yet been able to look into this patch
>>
Ralph Seichter writes:
> * Daniel Kahn Gillmor:
>
>> Perhaps Ralph Seichter (explicitly cc'ed above) could comment on how
>> it'll affect homebrew?
>
> MacPorts, actually. ;-) I have not yet been able to look into this patch
> series, but I hope to be able to do so soonish.
>
> -Ralph
* Daniel Kahn Gillmor:
> Perhaps Ralph Seichter (explicitly cc'ed above) could comment on how
> it'll affect homebrew?
MacPorts, actually. ;-) I have not yet been able to look into this patch
series, but I hope to be able to do so soonish.
-Ralph
___
On Sun 2019-05-26 10:08:54 -0300, David Bremner wrote:
> This removes the dependency of this test script on gdb, and
> considerably speeds up the running of the tests.
This series looks good to me. I've tested it with moreutils parallel
installed, and it reduces total CPU time for the parallel
One more nit-pick:
On Sun 2019-05-26 10:08:54 -0300, David Bremner wrote:
> +test_expect_code 0 "notmuch_with_shim shim-$code insert --keep <
> \"$gen_msg_filename\""
This kind of business breaks obscurely if $gen_msg_filename happens to
have U+0022 QUOTATION MARK in it. That's a pretty
