[PATCH] emacs: when archiving move the cursor depending on the sort order.

2010-04-14 Thread Sebastian Spaeth
On 2010-04-14, Michal Sojka wrote:
> On Tue, 13 Apr 2010, Servilio Afre Puentes wrote:
> > The current hardcoded behaviour will not take you to the next unread
> > thread when the sort order is set to newer-first from the default of
> > older-first.
> 
> Is this really what we want? If I sort messages by newest first, it
> menas that I want to process my emails from the newest to the oldest.
> I'm satisfied with the current behavour.

Agreed, I would be very surprised to get a different behavior.


[PATCH] emacs: when archiving move the cursor depending on the sort order.

2010-04-14 Thread Servilio Afre Puentes
On 14 April 2010 05:53, Sebastian Spaeth  wrote:
> On 2010-04-14, Michal Sojka wrote:
>> On Tue, 13 Apr 2010, Servilio Afre Puentes wrote:
>> > The current hardcoded behaviour will not take you to the next unread
>> > thread when the sort order is set to newer-first from the default of
>> > older-first.
>>
>> Is this really what we want? If I sort messages by newest first, it
>> menas that I want to process my emails from the newest to the oldest.
>> I'm satisfied with the current behavour.
>
> Agreed, I would be very surprised to get a different behavior.

Hmmm, interesting. I still want to process my messages from oldest to
newest but prefer them to be shown with the newest at the top.

I will create and send a second version of the patch later today that
takes this into account...

Servilio


Re: [PATCH] emacs: when archiving move the cursor depending on the sort order.

2010-04-14 Thread Michal Sojka
On Tue, 13 Apr 2010, Servilio Afre Puentes wrote:
 The current hardcoded behaviour will not take you to the next unread
 thread when the sort order is set to newer-first from the default of
 older-first.

Is this really what we want? If I sort messages by newest first, it
menas that I want to process my emails from the newest to the oldest.
I'm satisfied with the current behavour.

-Michal
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH] emacs: when archiving move the cursor depending on the sort order.

2010-04-14 Thread Servilio Afre Puentes
On 14 April 2010 05:53, Sebastian Spaeth sebast...@sspaeth.de wrote:
 On 2010-04-14, Michal Sojka wrote:
 On Tue, 13 Apr 2010, Servilio Afre Puentes wrote:
  The current hardcoded behaviour will not take you to the next unread
  thread when the sort order is set to newer-first from the default of
  older-first.

 Is this really what we want? If I sort messages by newest first, it
 menas that I want to process my emails from the newest to the oldest.
 I'm satisfied with the current behavour.

 Agreed, I would be very surprised to get a different behavior.

Hmmm, interesting. I still want to process my messages from oldest to
newest but prefer them to be shown with the newest at the top.

I will create and send a second version of the patch later today that
takes this into account...

Servilio
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


[PATCH] emacs: when archiving move the cursor depending on the sort order.

2010-04-13 Thread Servilio Afre Puentes
The current hardcoded behaviour will not take you to the next unread
thread when the sort order is set to newer-first from the default of
older-first.

Signed-off-by: Servilio Afre Puentes 
---
 emacs/notmuch.el |4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 517c53a..728aa2b 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -572,7 +572,9 @@ thread or threads in the current region."
 This function advances the next thread when finished."
   (interactive)
   (notmuch-search-remove-tag-thread "inbox")
-  (forward-line))
+  (if notmuch-search-oldest-first
+  (forward-line)
+(previous-line)))

 (defun notmuch-search-process-sentinel (proc msg)
   "Add a message to let user know when \"notmuch search\" exits"
-- 
1.7.0.4


[PATCH] emacs: when archiving move the cursor depending on the sort order.

2010-04-13 Thread Servilio Afre Puentes
The current hardcoded behaviour will not take you to the next unread
thread when the sort order is set to newer-first from the default of
older-first.

Signed-off-by: Servilio Afre Puentes servi...@gmail.com
---
 emacs/notmuch.el |4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 517c53a..728aa2b 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -572,7 +572,9 @@ thread or threads in the current region.
 This function advances the next thread when finished.
   (interactive)
   (notmuch-search-remove-tag-thread inbox)
-  (forward-line))
+  (if notmuch-search-oldest-first
+  (forward-line)
+(previous-line)))

 (defun notmuch-search-process-sentinel (proc msg)
   Add a message to let user know when \notmuch search\ exits
-- 
1.7.0.4
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch