[PATCH] test: test-lib.el: replace sleep-for with sit-for in notmuch-test-wait

2012-08-04 Thread Tomi Ollila
On Fri, Aug 03 2012, Austin Clements wrote: > Code LGTM, but maybe the comment should explain that this is a > workaround for a bug in Emacs, given that both sleep-for and sit-for > are supposed to process process output and run sentinels (which has > been stated in the Elisp reference at least

Re: [PATCH] test: test-lib.el: replace sleep-for with sit-for in notmuch-test-wait

2012-08-04 Thread Tomi Ollila
On Fri, Aug 03 2012, Austin Clements amdra...@mit.edu wrote: Code LGTM, but maybe the comment should explain that this is a workaround for a bug in Emacs, given that both sleep-for and sit-for are supposed to process process output and run sentinels (which has been stated in the Elisp

[PATCH] test: test-lib.el: replace sleep-for with sit-for in notmuch-test-wait

2012-08-03 Thread Austin Clements
Code LGTM, but maybe the comment should explain that this is a workaround for a bug in Emacs, given that both sleep-for and sit-for are supposed to process process output and run sentinels (which has been stated in the Elisp reference at least as far back as Emacs 21). In light of this (and our

[PATCH] test: test-lib.el: replace sleep-for with sit-for in notmuch-test-wait

2012-08-03 Thread Tomi Ollila
The function `notmuch-test-wait` called `get-buffer-process` and `sleep-for` in a loop. On some emacses neither of these cause emacs to check whether the process has exited and update it's status accordingly. In this case the loop does not exit. The function `sit-for` goes into event loop via

[PATCH] test: test-lib.el: replace sleep-for with sit-for in notmuch-test-wait

2012-08-03 Thread Tomi Ollila
The function `notmuch-test-wait` called `get-buffer-process` and `sleep-for` in a loop. On some emacses neither of these cause emacs to check whether the process has exited and update it's status accordingly. In this case the loop does not exit. The function `sit-for` goes into event loop via

Re: [PATCH] test: test-lib.el: replace sleep-for with sit-for in notmuch-test-wait

2012-08-03 Thread Austin Clements
Code LGTM, but maybe the comment should explain that this is a workaround for a bug in Emacs, given that both sleep-for and sit-for are supposed to process process output and run sentinels (which has been stated in the Elisp reference at least as far back as Emacs 21). In light of this (and our