Well, thanks for the quick review :)
I have updated all the patches to take your fixes into account, there is
still the discussion left about the GC integration. Once we get that
sorted out, I'll send the updated version.
Le 18/07/2012 23:51, Austin Clements a ?crit :
> This series looks good
Well, thanks for the quick review :)
I have updated all the patches to take your fixes into account, there is
still the discussion left about the GC integration. Once we get that
sorted out, I'll send the updated version.
Le 18/07/2012 23:51, Austin Clements a écrit :
This series looks good
The following patches fix some serious memory management issues with
the Go bindings, and add some missing functions as well.
Adrien Bustany (7):
go: Use iota in enum bindings
go: Add missing MESSAGE_FLAG_EXCLUDED in Flag enum
go: Allow notmuch objects to be garbage collected
go: Make
This series looks good to me other than the few things I commented on.
It's nice to see the Go bindings get a bit of love!
Quoth Adrien Bustany on Jul 18 at 9:34 pm:
> The following patches fix some serious memory management issues with
> the Go bindings, and add some missing functions as well.
The following patches fix some serious memory management issues with
the Go bindings, and add some missing functions as well.
Adrien Bustany (7):
go: Use iota in enum bindings
go: Add missing MESSAGE_FLAG_EXCLUDED in Flag enum
go: Allow notmuch objects to be garbage collected
go: Make
This series looks good to me other than the few things I commented on.
It's nice to see the Go bindings get a bit of love!
Quoth Adrien Bustany on Jul 18 at 9:34 pm:
The following patches fix some serious memory management issues with
the Go bindings, and add some missing functions as well.
