Re: [PATCH 9/9] add has: query prefix to search for specific properties

2016-08-13 Thread David Bremner
Jameson Graef Rollins writes: > Super minor annoying comment, but I wonder if there's a missing colon in > the above addition: > >> + **tag:**, **id:**, **thread:**, **folder:**, **path:**, **has:** annoying, but correct ;). d ___ notmuch mailing li

Re: [PATCH 9/9] add has: query prefix to search for specific properties

2016-08-13 Thread Jameson Graef Rollins
On Sat, Aug 06 2016, David Bremner wrote: > @@ -217,7 +224,7 @@ exact matches like "tag:inbox" or **probabilistic**, > supporting a more flexible > > > Boolean > - **tag:**, **id:**, **thread:**, **folder:**, **path:** > + **tag:**, **id:**, **thread:**, **folder:**, **path:**, **has**

Re: [PATCH 9/9] add has: query prefix to search for specific properties

2016-08-13 Thread David Bremner
Jani Nikula writes: >> I don't really understand the comment on the next line (since it seems >> that no : is added to XPROPERTY by Xapian), but I guess we should >> probably be consistent. Maybe Jani can explain the comment? > > My recollection is vague, but it has to do with user-defined prefix

Re: [PATCH 9/9] add has: query prefix to search for specific properties

2016-08-13 Thread Jani Nikula
On Sat, 06 Aug 2016, David Bremner wrote: > David Bremner writes: > >> >> +The **has:** prefix searches for messages with a particular >> += property pair. Properties are used internally by notmuch >> +(and extensions) to add metadata to messages. A given key can be >> +present on a given messa

Re: [PATCH 9/9] add has: query prefix to search for specific properties

2016-08-06 Thread David Bremner
David Bremner writes: > > +The **has:** prefix searches for messages with a particular > += property pair. Properties are used internally by notmuch > +(and extensions) to add metadata to messages. A given key can be > +present on a given message with several different values. > + I probably s

[PATCH 9/9] add has: query prefix to search for specific properties

2016-08-06 Thread David Bremner
From: Daniel Kahn Gillmor We want to be able to query the properties directly, like: notmuch count has:foo=bar which should return a count of messages where the property with key "foo" has value equal to "bar". --- doc/man7/notmuch-search-terms.rst | 9 - lib/database.cc