Re: [PATCH v3 2/3] emacs: Add simple make target to compile emacs lisp tests
David Bremner writes: > Jonas Bernoulli writes: > >> +compile-elisp-tests: >> +$(EMACS) --batch -L emacs -L test -l notmuch.el -l test-lib.el -f \ >> +batch-byte-compile test/*.el >> + > > Can you explain a bit (perhaps in an updated commit message) why we need > this target? The tests might have issues that can be detected by the byte-compiler. The only issue that I actually did detect was the one fixed by 3/3, which is a very minor cosmetic issue. However if someone modified the tests, then they might of course add more serious issues. If they ran this target, then they might detect that. But they might forget to do so. They might also forget to re-run this target after making changes. Therefore I retract this commit at least in the current form. I might include an improved more thoroughly described version of this in a later patch series. For now please just apply 3/3. Jonas ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v3 2/3] emacs: Add simple make target to compile emacs lisp tests
Jonas Bernoulli writes: > > +compile-elisp-tests: > + $(EMACS) --batch -L emacs -L test -l notmuch.el -l test-lib.el -f \ > + batch-byte-compile test/*.el > + Can you explain a bit (perhaps in an updated commit message) why we need this target? thanks! David ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
[PATCH v3 2/3] emacs: Add simple make target to compile emacs lisp tests
--- test/Makefile.local | 4 1 file changed, 4 insertions(+) diff --git a/test/Makefile.local b/test/Makefile.local index 47244e8f..3c043717 100644 --- a/test/Makefile.local +++ b/test/Makefile.local @@ -78,6 +78,10 @@ endif check: test +compile-elisp-tests: + $(EMACS) --batch -L emacs -L test -l notmuch.el -l test-lib.el -f \ + batch-byte-compile test/*.el + SRCS := $(SRCS) $(test_srcs) CLEAN += $(TEST_BINARIES) $(addsuffix .o,$(TEST_BINARIES)) \ $(dir)/database-test.o \ -- 2.26.0 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch