[RFC] lib: add support for date:..! to mean date:..
Jani Nikula writes: > Up to debate: > > 1) Is something like this useful at all as an intermediate step before > we can have support for date:? (This can be done with a future > version of Xapian, or with a custom query query parser.) > > 2) If yes, are there better alternatives to "!" as the end point? (Or > should the special case be the start point?) Also "@" and "same" have > been suggested. Examples: date:yesterday..! date:today..@ > date:@..monday date:january..same. > >From the comments I guess it just needs a small man page update. d
Re: [RFC] lib: add support for date:..! to mean date:..
Jani Nikula writes: > Up to debate: > > 1) Is something like this useful at all as an intermediate step before > we can have support for date:? (This can be done with a future > version of Xapian, or with a custom query query parser.) > > 2) If yes, are there better alternatives to "!" as the end point? (Or > should the special case be the start point?) Also "@" and "same" have > been suggested. Examples: date:yesterday..! date:today..@ > date:@..monday date:january..same. > From the comments I guess it just needs a small man page update. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[RFC] lib: add support for date:..! to mean date:..
Gaute Hope writes: > > I am probably missing something, but why do you need the end > point? > > date:2015-04-16 mean date:2015-04-16..2015-04-16? > date: -> date:.. means according to humans yes, but not according to the xapian query parser we use. d
[RFC] lib: add support for date:..! to mean date:..
Excerpts from Mark Walters's message of April 17, 2015 20:57: > > Hi > > On Sat, 07 Mar 2015, Jani Nikula wrote: >> Up to debate: >> >> 1) Is something like this useful at all as an intermediate step before >> we can have support for date:? (This can be done with a future >> version of Xapian, or with a custom query query parser.) > > This looks good to me. Yes it may not be needed in the future but the > patch is very small. It passes all tests. +1 from me. > >> 2) If yes, are there better alternatives to "!" as the end point? (Or >> should the special case be the start point?) Also "@" and "same" have >> been suggested. Examples: date:yesterday..! date:today..@ >> date:@..monday date:january..same. > > I would be happy with any of these. I am probably missing something, but why do you need the end point? date:2015-04-16 mean date:2015-04-16..2015-04-16? date: -> date:.. - gaute
Re: [RFC] lib: add support for date:..! to mean date:..
Gaute Hope writes: > > I am probably missing something, but why do you need the end > point? > > date:2015-04-16 mean date:2015-04-16..2015-04-16? > date: -> date:.. means according to humans yes, but not according to the xapian query parser we use. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [RFC] lib: add support for date:..! to mean date:..
Excerpts from Mark Walters's message of April 17, 2015 20:57: Hi On Sat, 07 Mar 2015, Jani Nikula wrote: Up to debate: 1) Is something like this useful at all as an intermediate step before we can have support for date:? (This can be done with a future version of Xapian, or with a custom query query parser.) This looks good to me. Yes it may not be needed in the future but the patch is very small. It passes all tests. +1 from me. 2) If yes, are there better alternatives to "!" as the end point? (Or should the special case be the start point?) Also "@" and "same" have been suggested. Examples: date:yesterday..! date:today..@ date:@..monday date:january..same. I would be happy with any of these. I am probably missing something, but why do you need the end point? date:2015-04-16 mean date:2015-04-16..2015-04-16? date: -> date:.. - gaute ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[RFC] lib: add support for date:..! to mean date:..
On Sat, Mar 07 2015, Jani Nikula wrote:
> Up to debate:
>
> 1) Is something like this useful at all as an intermediate step before
> we can have support for date:? (This can be done with a future
> version of Xapian, or with a custom query query parser.)
>
> 2) If yes, are there better alternatives to "!" as the end point? (Or
> should the special case be the start point?) Also "@" and "same" have
> been suggested. Examples: date:yesterday..! date:today..@
> date:@..monday date:january..same.
I'd rather see a temporary ugly hack in implementation (to expand
date: to date:..) than permanent interface feature.
But this looks simple enough... and I'd go just with this implementation
(i.e. ..!)
Tomi
> diff --git a/lib/parse-time-vrp.cc b/lib/parse-time-vrp.cc
> index 33f07db3410e..03804cf50fa8 100644
> --- a/lib/parse-time-vrp.cc
> +++ b/lib/parse-time-vrp.cc
> @@ -31,6 +31,7 @@ Xapian::valueno
> ParseTimeValueRangeProcessor::operator() (std::string &begin, std::string
> &end)
> {
> time_t t, now;
> +std::string b;
>
> /* Require date: prefix in start of the range... */
> if (STRNCMP_LITERAL (begin.c_str (), PREFIX))
> @@ -38,6 +39,7 @@ ParseTimeValueRangeProcessor::operator() (std::string
> &begin, std::string &end)
>
> /* ...and remove it. */
> begin.erase (0, sizeof (PREFIX) - 1);
> +b = begin;
>
> /* Use the same 'now' for begin and end. */
> if (time (&now) == (time_t) -1)
> @@ -51,6 +53,9 @@ ParseTimeValueRangeProcessor::operator() (std::string
> &begin, std::string &end)
> }
>
> if (!end.empty ()) {
> + if (end == "!" && ! b.empty ())
> + end = b;
> +
> if (parse_time_string (end.c_str (), &t, &now,
> PARSE_TIME_ROUND_UP_INCLUSIVE))
> return Xapian::BAD_VALUENO;
>
[RFC] lib: add support for date:..! to mean date:..
Hi, On Fri, Apr 17, 2015 at 07:57:27PM +0100, Mark Walters wrote: > > > 2) If yes, are there better alternatives to "!" as the end point? (Or > > should the special case be the start point?) Also "@" and "same" have > > been suggested. Examples: date:yesterday..! date:today..@ > > date:@..monday date:january..same. > > I would be happy with any of these. Many shells use ! for history expansion; maybe one of the other characters would be better (no need to escape)? I like @, purely aesthetic preference :). Cheers, -- Suvayu Open source is the future. It sets us free.
Re: [RFC] lib: add support for date:..! to mean date:..
On Sat, Mar 07 2015, Jani Nikula wrote:
> Up to debate:
>
> 1) Is something like this useful at all as an intermediate step before
> we can have support for date:? (This can be done with a future
> version of Xapian, or with a custom query query parser.)
>
> 2) If yes, are there better alternatives to "!" as the end point? (Or
> should the special case be the start point?) Also "@" and "same" have
> been suggested. Examples: date:yesterday..! date:today..@
> date:@..monday date:january..same.
I'd rather see a temporary ugly hack in implementation (to expand
date: to date:..) than permanent interface feature.
But this looks simple enough... and I'd go just with this implementation
(i.e. ..!)
Tomi
> diff --git a/lib/parse-time-vrp.cc b/lib/parse-time-vrp.cc
> index 33f07db3410e..03804cf50fa8 100644
> --- a/lib/parse-time-vrp.cc
> +++ b/lib/parse-time-vrp.cc
> @@ -31,6 +31,7 @@ Xapian::valueno
> ParseTimeValueRangeProcessor::operator() (std::string &begin, std::string
> &end)
> {
> time_t t, now;
> +std::string b;
>
> /* Require date: prefix in start of the range... */
> if (STRNCMP_LITERAL (begin.c_str (), PREFIX))
> @@ -38,6 +39,7 @@ ParseTimeValueRangeProcessor::operator() (std::string
> &begin, std::string &end)
>
> /* ...and remove it. */
> begin.erase (0, sizeof (PREFIX) - 1);
> +b = begin;
>
> /* Use the same 'now' for begin and end. */
> if (time (&now) == (time_t) -1)
> @@ -51,6 +53,9 @@ ParseTimeValueRangeProcessor::operator() (std::string
> &begin, std::string &end)
> }
>
> if (!end.empty ()) {
> + if (end == "!" && ! b.empty ())
> + end = b;
> +
> if (parse_time_string (end.c_str (), &t, &now,
> PARSE_TIME_ROUND_UP_INCLUSIVE))
> return Xapian::BAD_VALUENO;
>
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
[RFC] lib: add support for date:..! to mean date:..
Hi
On Sat, 07 Mar 2015, Jani Nikula wrote:
> Up to debate:
>
> 1) Is something like this useful at all as an intermediate step before
> we can have support for date:? (This can be done with a future
> version of Xapian, or with a custom query query parser.)
This looks good to me. Yes it may not be needed in the future but the
patch is very small. It passes all tests. +1 from me.
> 2) If yes, are there better alternatives to "!" as the end point? (Or
> should the special case be the start point?) Also "@" and "same" have
> been suggested. Examples: date:yesterday..! date:today..@
> date:@..monday date:january..same.
I would be happy with any of these.
Best wishes
Mark
>
> Idea from Mark Walters .
> ---
> lib/parse-time-vrp.cc| 5 +
> test/T500-search-date.sh | 4
> 2 files changed, 9 insertions(+)
>
> diff --git a/lib/parse-time-vrp.cc b/lib/parse-time-vrp.cc
> index 33f07db3410e..03804cf50fa8 100644
> --- a/lib/parse-time-vrp.cc
> +++ b/lib/parse-time-vrp.cc
> @@ -31,6 +31,7 @@ Xapian::valueno
> ParseTimeValueRangeProcessor::operator() (std::string &begin, std::string
> &end)
> {
> time_t t, now;
> +std::string b;
>
> /* Require date: prefix in start of the range... */
> if (STRNCMP_LITERAL (begin.c_str (), PREFIX))
> @@ -38,6 +39,7 @@ ParseTimeValueRangeProcessor::operator() (std::string
> &begin, std::string &end)
>
> /* ...and remove it. */
> begin.erase (0, sizeof (PREFIX) - 1);
> +b = begin;
>
> /* Use the same 'now' for begin and end. */
> if (time (&now) == (time_t) -1)
> @@ -51,6 +53,9 @@ ParseTimeValueRangeProcessor::operator() (std::string
> &begin, std::string &end)
> }
>
> if (!end.empty ()) {
> + if (end == "!" && ! b.empty ())
> + end = b;
> +
> if (parse_time_string (end.c_str (), &t, &now,
> PARSE_TIME_ROUND_UP_INCLUSIVE))
> return Xapian::BAD_VALUENO;
>
> diff --git a/test/T500-search-date.sh b/test/T500-search-date.sh
> index 70bcf344b4f7..18a47b114fa9 100755
> --- a/test/T500-search-date.sh
> +++ b/test/T500-search-date.sh
> @@ -8,6 +8,10 @@ test_begin_subtest "Absolute date range"
> output=$(notmuch search date:2010-12-16..12/16/2010 |
> notmuch_search_sanitize)
> test_expect_equal "$output" "thread:XXX 2010-12-16 [1/1] Olivier Berger;
> Essai accentué (inbox unread)"
>
> +test_begin_subtest "Absolute date range with 'same' operator"
> +output=$(notmuch search date:2010-12-16..! | notmuch_search_sanitize)
> +test_expect_equal "$output" "thread:XXX 2010-12-16 [1/1] Olivier Berger;
> Essai accentué (inbox unread)"
> +
> test_begin_subtest "Absolute time range with TZ"
> notmuch search date:18-Nov-2009_02:19:26-0800..2009-11-18_04:49:52-06:00 |
> notmuch_search_sanitize > OUTPUT
> cat --
> 2.1.4
>
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
Re: [RFC] lib: add support for date:..! to mean date:..
Hi, On Fri, Apr 17, 2015 at 07:57:27PM +0100, Mark Walters wrote: > > > 2) If yes, are there better alternatives to "!" as the end point? (Or > > should the special case be the start point?) Also "@" and "same" have > > been suggested. Examples: date:yesterday..! date:today..@ > > date:@..monday date:january..same. > > I would be happy with any of these. Many shells use ! for history expansion; maybe one of the other characters would be better (no need to escape)? I like @, purely aesthetic preference :). Cheers, -- Suvayu Open source is the future. It sets us free. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [RFC] lib: add support for date:..! to mean date:..
Hi
On Sat, 07 Mar 2015, Jani Nikula wrote:
> Up to debate:
>
> 1) Is something like this useful at all as an intermediate step before
> we can have support for date:? (This can be done with a future
> version of Xapian, or with a custom query query parser.)
This looks good to me. Yes it may not be needed in the future but the
patch is very small. It passes all tests. +1 from me.
> 2) If yes, are there better alternatives to "!" as the end point? (Or
> should the special case be the start point?) Also "@" and "same" have
> been suggested. Examples: date:yesterday..! date:today..@
> date:@..monday date:january..same.
I would be happy with any of these.
Best wishes
Mark
>
> Idea from Mark Walters .
> ---
> lib/parse-time-vrp.cc| 5 +
> test/T500-search-date.sh | 4
> 2 files changed, 9 insertions(+)
>
> diff --git a/lib/parse-time-vrp.cc b/lib/parse-time-vrp.cc
> index 33f07db3410e..03804cf50fa8 100644
> --- a/lib/parse-time-vrp.cc
> +++ b/lib/parse-time-vrp.cc
> @@ -31,6 +31,7 @@ Xapian::valueno
> ParseTimeValueRangeProcessor::operator() (std::string &begin, std::string
> &end)
> {
> time_t t, now;
> +std::string b;
>
> /* Require date: prefix in start of the range... */
> if (STRNCMP_LITERAL (begin.c_str (), PREFIX))
> @@ -38,6 +39,7 @@ ParseTimeValueRangeProcessor::operator() (std::string
> &begin, std::string &end)
>
> /* ...and remove it. */
> begin.erase (0, sizeof (PREFIX) - 1);
> +b = begin;
>
> /* Use the same 'now' for begin and end. */
> if (time (&now) == (time_t) -1)
> @@ -51,6 +53,9 @@ ParseTimeValueRangeProcessor::operator() (std::string
> &begin, std::string &end)
> }
>
> if (!end.empty ()) {
> + if (end == "!" && ! b.empty ())
> + end = b;
> +
> if (parse_time_string (end.c_str (), &t, &now,
> PARSE_TIME_ROUND_UP_INCLUSIVE))
> return Xapian::BAD_VALUENO;
>
> diff --git a/test/T500-search-date.sh b/test/T500-search-date.sh
> index 70bcf344b4f7..18a47b114fa9 100755
> --- a/test/T500-search-date.sh
> +++ b/test/T500-search-date.sh
> @@ -8,6 +8,10 @@ test_begin_subtest "Absolute date range"
> output=$(notmuch search date:2010-12-16..12/16/2010 |
> notmuch_search_sanitize)
> test_expect_equal "$output" "thread:XXX 2010-12-16 [1/1] Olivier Berger;
> Essai accentué (inbox unread)"
>
> +test_begin_subtest "Absolute date range with 'same' operator"
> +output=$(notmuch search date:2010-12-16..! | notmuch_search_sanitize)
> +test_expect_equal "$output" "thread:XXX 2010-12-16 [1/1] Olivier Berger;
> Essai accentué (inbox unread)"
> +
> test_begin_subtest "Absolute time range with TZ"
> notmuch search date:18-Nov-2009_02:19:26-0800..2009-11-18_04:49:52-06:00 |
> notmuch_search_sanitize > OUTPUT
> cat --
> 2.1.4
>
> ___
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
[RFC] lib: add support for date:..! to mean date:..
Up to debate:
1) Is something like this useful at all as an intermediate step before
we can have support for date:? (This can be done with a future
version of Xapian, or with a custom query query parser.)
2) If yes, are there better alternatives to "!" as the end point? (Or
should the special case be the start point?) Also "@" and "same" have
been suggested. Examples: date:yesterday..! date:today..@
date:@..monday date:january..same.
Idea from Mark Walters .
---
lib/parse-time-vrp.cc| 5 +
test/T500-search-date.sh | 4
2 files changed, 9 insertions(+)
diff --git a/lib/parse-time-vrp.cc b/lib/parse-time-vrp.cc
index 33f07db3410e..03804cf50fa8 100644
--- a/lib/parse-time-vrp.cc
+++ b/lib/parse-time-vrp.cc
@@ -31,6 +31,7 @@ Xapian::valueno
ParseTimeValueRangeProcessor::operator() (std::string &begin, std::string &end)
{
time_t t, now;
+std::string b;
/* Require date: prefix in start of the range... */
if (STRNCMP_LITERAL (begin.c_str (), PREFIX))
@@ -38,6 +39,7 @@ ParseTimeValueRangeProcessor::operator() (std::string &begin,
std::string &end)
/* ...and remove it. */
begin.erase (0, sizeof (PREFIX) - 1);
+b = begin;
/* Use the same 'now' for begin and end. */
if (time (&now) == (time_t) -1)
@@ -51,6 +53,9 @@ ParseTimeValueRangeProcessor::operator() (std::string &begin,
std::string &end)
}
if (!end.empty ()) {
+ if (end == "!" && ! b.empty ())
+ end = b;
+
if (parse_time_string (end.c_str (), &t, &now,
PARSE_TIME_ROUND_UP_INCLUSIVE))
return Xapian::BAD_VALUENO;
diff --git a/test/T500-search-date.sh b/test/T500-search-date.sh
index 70bcf344b4f7..18a47b114fa9 100755
--- a/test/T500-search-date.sh
+++ b/test/T500-search-date.sh
@@ -8,6 +8,10 @@ test_begin_subtest "Absolute date range"
output=$(notmuch search date:2010-12-16..12/16/2010 | notmuch_search_sanitize)
test_expect_equal "$output" "thread:XXX 2010-12-16 [1/1] Olivier Berger;
Essai accentu? (inbox unread)"
+test_begin_subtest "Absolute date range with 'same' operator"
+output=$(notmuch search date:2010-12-16..! | notmuch_search_sanitize)
+test_expect_equal "$output" "thread:XXX 2010-12-16 [1/1] Olivier Berger;
Essai accentu? (inbox unread)"
+
test_begin_subtest "Absolute time range with TZ"
notmuch search date:18-Nov-2009_02:19:26-0800..2009-11-18_04:49:52-06:00 |
notmuch_search_sanitize > OUTPUT
cat
[RFC] lib: add support for date:..! to mean date:..
Up to debate:
1) Is something like this useful at all as an intermediate step before
we can have support for date:? (This can be done with a future
version of Xapian, or with a custom query query parser.)
2) If yes, are there better alternatives to "!" as the end point? (Or
should the special case be the start point?) Also "@" and "same" have
been suggested. Examples: date:yesterday..! date:today..@
date:@..monday date:january..same.
Idea from Mark Walters .
---
lib/parse-time-vrp.cc| 5 +
test/T500-search-date.sh | 4
2 files changed, 9 insertions(+)
diff --git a/lib/parse-time-vrp.cc b/lib/parse-time-vrp.cc
index 33f07db3410e..03804cf50fa8 100644
--- a/lib/parse-time-vrp.cc
+++ b/lib/parse-time-vrp.cc
@@ -31,6 +31,7 @@ Xapian::valueno
ParseTimeValueRangeProcessor::operator() (std::string &begin, std::string &end)
{
time_t t, now;
+std::string b;
/* Require date: prefix in start of the range... */
if (STRNCMP_LITERAL (begin.c_str (), PREFIX))
@@ -38,6 +39,7 @@ ParseTimeValueRangeProcessor::operator() (std::string &begin,
std::string &end)
/* ...and remove it. */
begin.erase (0, sizeof (PREFIX) - 1);
+b = begin;
/* Use the same 'now' for begin and end. */
if (time (&now) == (time_t) -1)
@@ -51,6 +53,9 @@ ParseTimeValueRangeProcessor::operator() (std::string &begin,
std::string &end)
}
if (!end.empty ()) {
+ if (end == "!" && ! b.empty ())
+ end = b;
+
if (parse_time_string (end.c_str (), &t, &now,
PARSE_TIME_ROUND_UP_INCLUSIVE))
return Xapian::BAD_VALUENO;
diff --git a/test/T500-search-date.sh b/test/T500-search-date.sh
index 70bcf344b4f7..18a47b114fa9 100755
--- a/test/T500-search-date.sh
+++ b/test/T500-search-date.sh
@@ -8,6 +8,10 @@ test_begin_subtest "Absolute date range"
output=$(notmuch search date:2010-12-16..12/16/2010 | notmuch_search_sanitize)
test_expect_equal "$output" "thread:XXX 2010-12-16 [1/1] Olivier Berger;
Essai accentué (inbox unread)"
+test_begin_subtest "Absolute date range with 'same' operator"
+output=$(notmuch search date:2010-12-16..! | notmuch_search_sanitize)
+test_expect_equal "$output" "thread:XXX 2010-12-16 [1/1] Olivier Berger;
Essai accentué (inbox unread)"
+
test_begin_subtest "Absolute time range with TZ"
notmuch search date:18-Nov-2009_02:19:26-0800..2009-11-18_04:49:52-06:00 |
notmuch_search_sanitize > OUTPUT
cat
