[RFC PATCH] nmbug help w/o perldoc

2011-11-16 Thread Tomi Ollila
--- notmuch help runs pod2usage with -verbose = 2, which by default tries to run perldoc. Adding -noperldoc = 1 disables this use but there is no pre-verifying interface (or so) available. In one of my systems there was no 'perldoc' script, which basically contains: use Pod::PerlDoc; exit(

Re: the present and future of patch tracking for notmuch.

2011-11-16 Thread David Bremner
On Sun, 13 Nov 2011 10:53:40 -0400, David Bremner da...@tethera.net wrote: As some of you probably know, I have been using nmbug [1], now in git master, to help track the state of notmuch patches. At this point I think I am about ready to declare the experimental deployment of nmbug a

Re: [PATCH] emacs: Use a single buffer invisibility spec to fix quadratic search cost.

2011-11-16 Thread servilio
Hi, Given that this change is about display of search results, I have the suspicion that the following two factors might be more relevant: - size of the Emacs frame: bigger would mean more threads to show - composition of the search results, specially length of the threads displayed, as the

Re: [PATCH] test: use dtach(1) instead of screen(1) in emacs tests.

2011-11-16 Thread Pieter Praet
On Fri, 11 Nov 2011 10:09:17 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: On Fri, 11 Nov 2011 01:17:37 +0100, Pieter Praet pie...@praet.org wrote: On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: From: Tomi Ollila tomi.oll...@iki.fi dtach

Re: [PATCH] emacs: Use a single buffer invisibility spec to fix quadratic search cost.

2011-11-16 Thread Pieter Praet
On Thu, 10 Nov 2011 23:53:41 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Pieter Praet on Nov 11 at 4:04 am: On Thu, 10 Nov 2011 14:22:30 -0500, servilio servi...@gmail.com wrote: On 10 November 2011 08:33, Sebastian Spaeth sebast...@sspaeth.de wrote: On Tue,  8 Nov 2011

[PATCH v7 0/6] lib/cli: limit number of messages in search results

2011-11-16 Thread Jani Nikula
v7, s/--first/--offset/ and s/--maxitems/--limit/ and rebased against master since since id:cover.1321217854.git.j...@nikula.org BR, Jani. Jani Nikula (6): lib: add function to get the number of threads matching a search cli: add options --offset and --limit to notmuch search cli: drop

Re: [PATCH] emacs: Use a single buffer invisibility spec to fix quadratic search cost.

2011-11-16 Thread Pieter Praet
On Fri, 11 Nov 2011 00:27:16 -0500, Austin Clements amdra...@mit.edu wrote: Quoth myself on Nov 10 at 11:53 pm: Quoth Pieter Praet on Nov 11 at 4:04 am: I've tried getting some hard numbers using #+begin_src sh time emacs --eval '(progn (notmuch)

[PATCH v7 1/6] lib: add function to get the number of threads matching a search

2011-11-16 Thread Jani Nikula
Add function notmuch_query_count_threads() to get the number of threads matching a search. This is done by performing a search and figuring out the number of unique thread IDs in the matching messages, a significantly heavier operation than notmuch_query_count_messages(). Signed-off-by: Jani

Re: [PATCH v7 0/6] lib/cli: limit number of messages in search results

2011-11-16 Thread Jani Nikula
On Tue, 15 Nov 2011 19:41:57 -0400, David Bremner da...@tethera.net wrote: On Tue, 15 Nov 2011 22:08:47 +0200, Jani Nikula j...@nikula.org wrote: v7, s/--first/--offset/ and s/--maxitems/--limit/ and rebased against master since since id:cover.1321217854.git.j...@nikula.org Pushed, and

Re: [PATCH] emacs: add insisible space after the search widget field in notmuch-hello

2011-11-16 Thread Pieter Praet
On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: It is very convenient when C-e (bound to `widget-end-of-line') ignores trailing spaces inside the search widget. But it only does so if a widget is not followed by a newline (that is why it works in the

[PATCH v7 2/6] cli: add options --offset and --limit to notmuch search

2011-11-16 Thread Jani Nikula
Add options --offset=[-]N and --limit=M to notmuch search to determine the first result and maximum number of results to display. Option --limit=M limits the maximum number of results to display to M. Option --offset=[-]N skips the first N results; with the leading '-' skip until the Nth result

[PATCH v7 3/6] cli: drop unused code from notmuch count

2011-11-16 Thread Jani Nikula
Remove unused code within #if 0 blocks from notmuch count. Signed-off-by: Jani Nikula j...@nikula.org --- notmuch-count.c | 32 1 files changed, 0 insertions(+), 32 deletions(-) diff --git a/notmuch-count.c b/notmuch-count.c index 0d700a9..a35be40 100644 ---

[PATCH v7 6/6] test: add tests for notmuch search --offset and --limit

2011-11-16 Thread Jani Nikula
Signed-off-by: Jani Nikula j...@nikula.org --- test/notmuch-test|1 + test/search-limiting | 71 ++ 2 files changed, 72 insertions(+), 0 deletions(-) create mode 100755 test/search-limiting diff --git a/test/notmuch-test

Re: [PATCH v7 0/6] lib/cli: limit number of messages in search results

2011-11-16 Thread David Bremner
On Tue, 15 Nov 2011 22:08:47 +0200, Jani Nikula j...@nikula.org wrote: v7, s/--first/--offset/ and s/--maxitems/--limit/ and rebased against master since since id:cover.1321217854.git.j...@nikula.org Pushed, and thanks for referring back to the other thread. d

Re: Winter is coming [upcoming release 0.10]

2011-11-16 Thread David Bremner
On Sun, 13 Nov 2011 10:19:14 -0400, David Bremner da...@tethera.net wrote: According to our sortof-schedule, we should release 0.10 soonish. I'd like to freeze for a few days first, so that means we have time for maybe one or two more non-trivial patches before the freeze. We are now frozen

Re: [PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-16 Thread Pieter Praet
On Sat, 12 Nov 2011 13:24:40 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Sat, 12 Nov 2011 23:07:38 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: 1) add line { echo QUIT /dev/tcp/127.0.0.1/25025; } 2/dev/null I have no directory called /dev/tcp on my system.

Re: [PATCH 00/13] Test prereqs and screen-based Emacs tests

2011-11-16 Thread Pieter Praet
On Sun, 13 Nov 2011 13:46:30 -0400, David Bremner da...@tethera.net wrote: On Tue, 01 Nov 2011 20:54:49 +0100, Pieter Praet pie...@praet.org wrote: I'll be commenting on these modified commits where needed, and have re-submitted my original series (rebased to current master) in a new

Re: [PATCH 6/6] emacs: make `notmuch-search-operate-all' operate on threads, not messages

2011-11-16 Thread Pieter Praet
On Sat, 12 Nov 2011 11:35:02 -0500, Austin Clements amdra...@mit.edu wrote: Quoth David Bremner on Nov 12 at 11:13 am: On Sun, 10 Jul 2011 17:55:35 +0200, Pieter Praet pie...@praet.org wrote: In order to be consistent with `notmuch-search-{add,remove}-tag' (+/-),

Re: [PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

2011-11-16 Thread Pieter Praet
On Sat, 12 Nov 2011 04:08:45 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi all. Any objections to this trivial patch? Can we get it pushed? Appears to have been deprecated in favor of the original patch: id:1309762025-1172-1-git-send-email-dmitry.kuroch...@gmail.com See

[PATCH] NEWS: discuss contrib and nmbug

2011-11-16 Thread David Bremner
From: David Bremner brem...@debian.org I mention the possibility of a seperate license here because currently notmuch-deliver is licensed GPL v2 only. --- NEWS | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 7bd9987..98e07eb 100644 ---

[PATCH 1/6] test: define a helper function for defining prereqs on executables

2011-11-16 Thread Thomas Jost
While test_expect_success could be used to define these prereqs, this is probably not a good idea: if a prereq is not available, using test_expect_success would result in a test being reported as FAILED at the end of the test suite (and its dependencies as skipped). (Thanks to Pieter Praet for

[PATCH 0/6] Rebase of Pieter's set test prereqs

2011-11-16 Thread Thomas Jost
Hello list, This is another rebased version of Pieter's series to add GPG and Emacs as test prereqs, plus some additions on my own. (Rebased and posted as requested by Pieter [1].) Changes as compared to Pieter's patches (including parts from [2]): - prereqs are not tested using

[PATCH 3/6] test: add 'GnuPG' prereq to dependent 'crypto' tests

2011-11-16 Thread Thomas Jost
From: Pieter Praet pie...@praet.org Adds a new test that checks for the presence of 'gpg', and adds that test as a prereq to all subsequent tests that rely on GnuPG. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet pie...@praet.org --- test/crypto | 35

[PATCH 6/6] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests

2011-11-16 Thread Thomas Jost
From: Pieter Praet pie...@praet.org Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet pie...@praet.org ---

[PATCH 4/6] test: add 'Emacs' prereq to dependent 'crypto' tests

2011-11-16 Thread Thomas Jost
From: Pieter Praet pie...@praet.org Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Right now, all crypto tests do depend on Emacs, because it is used to

[PATCH 5/6] test: add 'Emacs' prereq to dependent 'emacs' tests

2011-11-16 Thread Thomas Jost
From: Pieter Praet pie...@praet.org Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet pie...@praet.org Conflicts:

Re: Winter is coming [upcoming release 0.10]

2011-11-16 Thread Tomi Ollila
On Tue, 15 Nov 2011 23:11:49 -0400, David Bremner da...@tethera.net wrote: On Sun, 13 Nov 2011 10:19:14 -0400, David Bremner da...@tethera.net wrote: According to our sortof-schedule, we should release 0.10 soonish. I'd like to freeze for a few days first, so that means we have time for

Re: Winter is coming [upcoming release 0.10]

2011-11-16 Thread David Bremner
On Wed, 16 Nov 2011 10:43:54 -0500, Austin Clements amdra...@mit.edu wrote: Quoth David Bremner on Nov 15 at 11:11 pm: Austin Clements: emacs: Use a single buffer invisibility spec to fix quadratic search cost. To avoid conflicts on NEWS, here's the text to put under

Re: [PATCH v2] tag: Automatically limit to messages whose tags will actually change.

2011-11-16 Thread Tomi Ollila
On Wed, 9 Nov 2011 08:44:35 -0500, Austin Clements amdra...@mit.edu wrote: This optimizes the user's tagging query to exclude messages that won't be affected by the tagging operation, saving computation and IO for redundant tagging operations. For example, notmuch tag +notmuch

Re: [RFC PATCH] nmbug help w/o perldoc

2011-11-16 Thread Jameson Graef Rollins
On Tue, 15 Nov 2011 18:11:16 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: --- Hey, Tomi. Your '---' separator is in the wrong place! You wrote this nice long log message, but it won't be attached to the commit because it's below the body separator. jamie. pgp9C3RvkZCTf.pgp Description:

Re: [RFC PATCH] nmbug help w/o perldoc

2011-11-16 Thread Tomi Ollila
On Wed, 16 Nov 2011 09:44:03 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Tue, 15 Nov 2011 18:11:16 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: --- Hey, Tomi. Your '---' separator is in the wrong place! You wrote this nice long log message, but it won't be

[PATCH 0/2] Missing NEWS entries

2011-11-16 Thread Daniel Schoepe
Here are the two missing news entries for the two patches of mine that were applied recently. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/2] NEWS entry for adding tab-completion to notmuch-search

2011-11-16 Thread Daniel Schoepe
Add a news entry for commit6a280088e6769015ade7758b9790384997a21ff3. --- NEWS |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index f236505..ff12ca6 100644 --- a/NEWS +++ b/NEWS @@ -33,6 +33,14 @@ Add notmuch count --output option The count command

[PATCH 2/2] NEWS entry for id-links

2011-11-16 Thread Daniel Schoepe
This adds a NEWS entry for commit 4a4ada73b751b1916c5dc4d408a8056411566e38 --- NEWS |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/NEWS b/NEWS index ff12ca6..a2fa69f 100644 --- a/NEWS +++ b/NEWS @@ -41,6 +41,11 @@ Add tab-completion for notmuch-search and

Re: [PATCH 2/2] NEWS entry for id-links

2011-11-16 Thread Dmitry Kurochkin
On Wed, 16 Nov 2011 18:53:13 +0100, Daniel Schoepe dan...@schoepe.org wrote: This adds a NEWS entry for commit 4a4ada73b751b1916c5dc4d408a8056411566e38 --- NEWS |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/NEWS b/NEWS index ff12ca6..a2fa69f 100644 ---

[PATCH v2 1/2] NEWS entry for adding tab-completion to notmuch-search

2011-11-16 Thread daniel
From: Daniel Schoepe dan...@schoepe.org Add a news entry for commit6a280088e6769015ade7758b9790384997a21ff3. --- NEWS |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index f236505..ff12ca6 100644 --- a/NEWS +++ b/NEWS @@ -33,6 +33,14 @@ Add notmuch

Re: [PATCH 2/2] NEWS entry for id-links

2011-11-16 Thread David Bremner
On Wed, 16 Nov 2011 22:04:05 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Wed, 16 Nov 2011 18:53:13 +0100, Daniel Schoepe dan...@schoepe.org wrote: There is an unrelated white space change here... Sigh. I should have caught that. OK, cleaned up now.

Re: [PATCH 0/2] Missing NEWS entries

2011-11-16 Thread David Bremner
On Wed, 16 Nov 2011 18:53:11 +0100, Daniel Schoepe dan...@schoepe.org wrote: Here are the two missing news entries for the two patches of mine that were applied recently. pushed ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH 0/6] Rebase of Pieter's set test prereqs

2011-11-16 Thread Jameson Graef Rollins
On Wed, 16 Nov 2011 15:33:49 +0100, Thomas Jost schno...@schnouki.net wrote: Hello list, This is another rebased version of Pieter's series to add GPG and Emacs as test prereqs, plus some additions on my own. (Rebased and posted as requested by Pieter [1].) Changes as compared to

Re: [PATCH] test: create TEST_TMPDIR for holding temporary files

2011-11-16 Thread Jameson Graef Rollins
On Wed, 16 Nov 2011 21:09:00 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: +# Note: TEST_TMPDIR *NOT* exported! +TEST_TMPDIR=$(mktemp -d ${TMPDIR:-/tmp}/notmuch-test-$$.XX) Hi, Tomi. I don't think you need to do any of the variable gymnastics if you use the mktemp --tempdir option, which

Re: Winter is coming [upcoming release 0.10]

2011-11-16 Thread Pieter Praet
Thanks David, awesome job! Peace -- Pieter ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/2] NEWS: add entries for stashing-related keybinding and tests

2011-11-16 Thread Pieter Praet
Add news entries for commits: f9764bfacc97457d1154c2d2a6001a6564f13ec3 64febdf71c4184ca369f5d11d7f196704a3ec1a6 --- NEWS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 044a51e..6c064da 100644 --- a/NEWS +++ b/NEWS @@ -8,6 +8,8 @@ Emacs tests

Re: [PATCH 2/2] NEWS: fix some old typos and trailing whitespace

2011-11-16 Thread Tomi Ollila
On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet pie...@praet.org wrote: No further explanation needed. --- NEWS | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) The 'No further explanation needed.' should be *BELOW* the waistline (---) ;); now it goes to the commit

[PATCH v2] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-16 Thread Tomi Ollila
If mail sending from emacs fails before it has chance to connect to the smtp-dummy mail server, the opportunistic QUIT message sending makes smtp-dummy to exit. --- Version 2 of the same feature. Now uses BASH's /dev/tcp/host/port feature instead of external 'nc' command. test/test-lib.sh |

Re: [PATCH] emacs: Use a single buffer invisibility spec to fix quadratic search cost.

2011-11-16 Thread Pieter Praet
On Tue, 15 Nov 2011 12:17:59 -0500, servilio servi...@gmail.com wrote: Hi, Given that this change is about display of search results, I have the suspicion that the following two factors might be more relevant: - size of the Emacs frame: bigger would mean more threads to show -

Re: [PATCH] emacs: breakout notmuch-show-advance functionality from notmuch-show-advance-and-archive

2011-11-16 Thread Pieter Praet
On Sun, 13 Nov 2011 13:16:48 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: This patch breaks out much of the functionality of notmuch-show-advance-and-archive into a new function: notmuch-show-advance. This new function does all the advancing through a show buffer that

Re: Winter is coming [upcoming release 0.10]

2011-11-16 Thread Pieter Praet
On Wed, 16 Nov 2011 18:17:46 -0400, David Bremner da...@tethera.net wrote: On Wed, 16 Nov 2011 21:37:48 +0100, Pieter Praet pie...@praet.org wrote: Thanks David, awesome job! You're very welcome. I hope you still feel that way when you see how I amended your commits ;). If not, send

[PATCH 0/9] test: (hopefully) better test prerequisites

2011-11-16 Thread Dmitry Kurochkin
Hi all. The following patch series is an attempt to introduce proper dependencies for external binaries in a less intrusive way than [1]. The primary aim was to avoid changing every subtest that uses external binaries. There are still failing tests if a dependency is missing (e.g. Verify that

[PATCH 1/9] test: move subtest variables reset into a dedicated function

2011-11-16 Thread Dmitry Kurochkin
Currently, there is only one such variable test_subtest_known_broken_. But more will be added in the future. --- test/test-lib.sh | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 1ea7fa9..222b5e4 100755 ---

[PATCH 2/9] test: set EMACS_SERVER variable only after dtach(1) was successfully started

2011-11-16 Thread Dmitry Kurochkin
Otherwise, we can set the EMACS_SERVER and return with an error. And subsequent calls to test_emacs would assume that emacs server is running. --- test/test-lib.sh |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index

[PATCH 3/9] test: add test state reset to test_expect_* functions that did not have it

2011-11-16 Thread Dmitry Kurochkin
--- test/test-lib.sh |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index ff85848..f21e45e 100755 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -622,82 +622,85 @@ test_skip () { test_reset_state_

[PATCH 5/9] test: fix skipping test verbose output

2011-11-16 Thread Dmitry Kurochkin
--- test/test-lib.sh |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index ab8c6fd..acac8ca 100755 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -635,41 +635,42 @@ test_skip () { test_report_skip_ $@

[PATCH 4/9] test: add support for external executable dependencies

2011-11-16 Thread Dmitry Kurochkin
There is existing support for general prerequisites in the test suite. But it is not very convenient to use: every test case has to keep track for it's dependencies and they have to be explicitly listed. The patch aims to add better support for a particular type of external dependencies: external

[PATCH 6/9] test: skip all subtests if external dependencies are missing during init

2011-11-16 Thread Dmitry Kurochkin
Some tests (e.g. crypto) do a common initialization required for all subtests. The patch adds a check for missing external dependencies during this initialization. If any prerequisites are missing, all subtests are skipped. The check is run on the first call of test_reset_state_ function, so no

Re: [PATCH 2/2] NEWS: fix some old typos and trailing whitespace

2011-11-16 Thread Jani Nikula
On Nov 16, 2011 11:39 PM, Pieter Praet pie...@praet.org wrote: On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet pie...@praet.org wrote: No further explanation needed. --- NEWS | 14 +++--- 1 files

[PATCH v7 0/6] lib/cli: limit number of messages in search results

2011-11-16 Thread Jani Nikula
On Tue, 15 Nov 2011 19:41:57 -0400, David Bremner wrote: > On Tue, 15 Nov 2011 22:08:47 +0200, Jani Nikula wrote: > > v7, s/--first/--offset/ and s/--maxitems/--limit/ and rebased against master > > since since id:"cover.1321217854.git.jani at nikula.org" > > > > Pushed, and thanks for

[PATCH] add `tag:' prefix to `--output=tags' results

2011-11-16 Thread Pieter Praet
On Sun, 13 Nov 2011 16:14:35 +0200, Jani Nikula wrote: > On Sat, 12 Nov 2011 10:17:30 -0500, David Bremner > wrote: > > On Thu, 30 Jun 2011 10:20:29 +0200, Pieter Praet > > wrote: > > > Alter `do_search_tags()' to prepend each result with `tag:', > > > and update affected test. > > > > > >

[PATCH 00/13] Test prereqs and screen-based Emacs tests

2011-11-16 Thread Pieter Praet
On Sun, 13 Nov 2011 13:46:30 -0400, David Bremner wrote: > On Tue, 01 Nov 2011 20:54:49 +0100, Pieter Praet wrote: > > > > I'll be commenting on these modified commits where needed, and have > > re-submitted my original series (rebased to current master) in a new > > thread [1]. > > > > I'm

[PATCH 6/6] emacs: make `notmuch-search-operate-all' operate on threads, not messages

2011-11-16 Thread Pieter Praet
On Sat, 12 Nov 2011 11:35:02 -0500, Austin Clements wrote: > Quoth David Bremner on Nov 12 at 11:13 am: > > On Sun, 10 Jul 2011 17:55:35 +0200, Pieter Praet > > wrote: > > > In order to be consistent with `notmuch-search-{add,remove}-tag' > > > ("+"/"-"), > > > `notmuch-search-operate-all'

[PATCH 2/6] test: check if emacs and dtach are available in test_emacs()

2011-11-16 Thread Thomas Jost
The test_emacs() function is run by the emacs tests even if the EMACS prereq is not available. This causes an issue when running the test suite on a system where dtach is not installed: the emacs server will not start, but since the $EMACS_SERVER variable is set on the first call to test_emacs,

[PATCH 3/6] test: add 'GnuPG' prereq to dependent 'crypto' tests

2011-11-16 Thread Thomas Jost
From: Pieter Praet Adds a new test that checks for the presence of 'gpg', and adds that test as a prereq to all subsequent tests that rely on GnuPG. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet --- test/crypto | 35

[PATCH 6/6] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests

2011-11-16 Thread Thomas Jost
From: Pieter Praet Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet --- test/emacs-large-search-buffer |

[PATCH 4/6] test: add 'Emacs' prereq to dependent 'crypto' tests

2011-11-16 Thread Thomas Jost
From: Pieter Praet Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Right now, all crypto tests do depend on Emacs, because it is used

[PATCH 5/6] test: add 'Emacs' prereq to dependent 'emacs' tests

2011-11-16 Thread Thomas Jost
From: Pieter Praet Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet Conflicts: test/emacs ---

[PATCH 1/6] test: define a helper function for defining prereqs on executables

2011-11-16 Thread Thomas Jost
While test_expect_success could be used to define these prereqs, this is probably not a good idea: if a prereq is not available, using test_expect_success would result in a test being reported as FAILED at the end of the test suite (and its dependencies as skipped). (Thanks to Pieter Praet for

[PATCH 0/6] Rebase of Pieter's "set test prereqs"

2011-11-16 Thread Thomas Jost
Hello list, This is another rebased version of Pieter's series to add GPG and Emacs as test prereqs, plus some additions on my own. (Rebased and posted as requested by Pieter [1].) Changes as compared to Pieter's patches (including parts from [2]): - prereqs are not tested using

Winter is coming [upcoming release 0.10]

2011-11-16 Thread Tomi Ollila
On Tue, 15 Nov 2011 23:11:49 -0400, David Bremner wrote: > On Sun, 13 Nov 2011 10:19:14 -0400, David Bremner > wrote: > > > According to our sortof-schedule, we should release 0.10 soonish. I'd > > like to freeze for a few days first, so that means we have time for > > maybe one or two more

Winter is coming [upcoming release 0.10]

2011-11-16 Thread Austin Clements
Quoth David Bremner on Nov 15 at 11:11 pm: > Austin Clements: > emacs: Use a single buffer invisibility spec to fix quadratic search > cost. To avoid conflicts on NEWS, here's the text to put under "Optimizations" (which should perhaps be "Performance" instead?): Emacs now constructs

Winter is coming [upcoming release 0.10]

2011-11-16 Thread David Bremner
On Wed, 16 Nov 2011 10:43:54 -0500, Austin Clements wrote: > Quoth David Bremner on Nov 15 at 11:11 pm: > > Austin Clements: > > emacs: Use a single buffer invisibility spec to fix quadratic search > > cost. > > To avoid conflicts on NEWS, here's the text to put under > "Optimizations"

[PATCH v2] tag: Automatically limit to messages whose tags will actually change.

2011-11-16 Thread Tomi Ollila
On Wed, 9 Nov 2011 08:44:35 -0500, Austin Clements wrote: > This optimizes the user's tagging query to exclude messages that won't > be affected by the tagging operation, saving computation and IO for > redundant tagging operations. > > For example, > notmuch tag +notmuch to:notmuch at

[RFC PATCH] nmbug help w/o perldoc

2011-11-16 Thread Jameson Graef Rollins
n-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/2016/2886f4b5/attachment.pgp>

[RFC PATCH] nmbug help w/o perldoc

2011-11-16 Thread Tomi Ollila
On Wed, 16 Nov 2011 09:44:03 -0800, Jameson Graef Rollins wrote: > On Tue, 15 Nov 2011 18:11:16 +0200, Tomi Ollila wrote: > > > > --- > > Hey, Tomi. Your '---' separator is in the wrong place! You wrote this > nice long log message, but it won't be attached to the commit because > it's below

[PATCH 0/2] Missing NEWS entries

2011-11-16 Thread Daniel Schoepe
Here are the two missing news entries for the two patches of mine that were applied recently.

[PATCH 1/2] NEWS entry for adding tab-completion to notmuch-search

2011-11-16 Thread Daniel Schoepe
Add a news entry for commit6a280088e6769015ade7758b9790384997a21ff3. --- NEWS |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index f236505..ff12ca6 100644 --- a/NEWS +++ b/NEWS @@ -33,6 +33,14 @@ Add "notmuch count --output" option The count command

[PATCH 2/2] NEWS entry for id-links

2011-11-16 Thread Daniel Schoepe
This adds a NEWS entry for commit 4a4ada73b751b1916c5dc4d408a8056411566e38 --- NEWS |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/NEWS b/NEWS index ff12ca6..a2fa69f 100644 --- a/NEWS +++ b/NEWS @@ -41,6 +41,11 @@ Add tab-completion for notmuch-search and

[PATCH 2/2] NEWS entry for id-links

2011-11-16 Thread Dmitry Kurochkin
On Wed, 16 Nov 2011 18:53:13 +0100, Daniel Schoepe wrote: > This adds a NEWS entry for commit 4a4ada73b751b1916c5dc4d408a8056411566e38 > --- > NEWS |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/NEWS b/NEWS > index ff12ca6..a2fa69f 100644 > --- a/NEWS > +++

[PATCH v2 1/2] NEWS entry for adding tab-completion to notmuch-search

2011-11-16 Thread dan...@schoepe.org
From: Daniel Schoepe Add a news entry for commit6a280088e6769015ade7758b9790384997a21ff3. --- NEWS |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index f236505..ff12ca6 100644 --- a/NEWS +++ b/NEWS @@ -33,6 +33,14 @@ Add "notmuch

[PATCH v2 2/2] NEWS entry for id-links

2011-11-16 Thread dan...@schoepe.org
From: Daniel Schoepe This adds a NEWS entry for commit 4a4ada73b751b1916c5dc4d408a8056411566e38 --- NEWS |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index ff12ca6..044a51e 100644 --- a/NEWS +++ b/NEWS @@ -41,6 +41,11 @@ Add

[PATCH 2/2] NEWS entry for id-links

2011-11-16 Thread David Bremner
On Wed, 16 Nov 2011 22:04:05 +0400, Dmitry Kurochkin wrote: > On Wed, 16 Nov 2011 18:53:13 +0100, Daniel Schoepe > wrote: > > There is an unrelated white space change here... > Sigh. I should have caught that. OK, cleaned up now.

[PATCH 0/2] Missing NEWS entries

2011-11-16 Thread David Bremner
On Wed, 16 Nov 2011 18:53:11 +0100, Daniel Schoepe wrote: > Here are the two missing news entries for the two patches of > mine that were applied recently. pushed

[PATCH 0/6] Rebase of Pieter's "set test prereqs"

2011-11-16 Thread Jameson Graef Rollins
ry look. Is this just a rebase flub, or is there something I'm missing? jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/2016/11f48b4d/attachment.pgp>

[PATCH] test: create TEST_TMPDIR for holding temporary files

2011-11-16 Thread Tomi Ollila
The TEST_TMPDIR if first needed to hold dtach's socket (due to 108-character limit in socket file names). Later it can be used to hold other temporary files; directory deleted at exit. --- I'm not fully satisfied with variable name -- compare to the use of TEST_DIRECTORY. Anyway it is the best I

[PATCH] test: create TEST_TMPDIR for holding temporary files

2011-11-16 Thread Jameson Graef Rollins
able URL: <http://notmuchmail.org/pipermail/notmuch/attachments/2016/af2a39ab/attachment-0001.pgp>

[PATCH 0/6] Rebase of Pieter's "set test prereqs"

2011-11-16 Thread Thomas Jost
COMMAND, expecting it to succeed - test_expect_success PREREQ COMMAND --> skip if PREREQ is not set, else run the test as before (and same thing with the other test_expect_* functions) Does it make more sense now? Regards, -- Thomas/Schnouki -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 489 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/2016/41cbc4ea/attachment.pgp>

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

2011-11-16 Thread Pieter Praet
No further explanation needed. --- NEWS | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/NEWS b/NEWS index 6c064da..daec4ad 100644 --- a/NEWS +++ b/NEWS @@ -130,7 +130,7 @@ Ruby bindings changes - - Wrap new library functions

[PATCH] test: create dtach's session socket in $TEST_TMPDIR

2011-11-16 Thread Tomi Ollila
Due to 108-character limit in unix domain socket path this change is required; it is more probable that length of ${TMPDIR:-/tmp} is shorter than length of path to the current directory of notmuch test source directory. One can expect to create reasonable-length unix domain sockets wherever

[PATCH 0/6] Rebase of Pieter's "set test prereqs"

2011-11-16 Thread Pieter Praet
- > 1.7.7.3 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch -- next part -- A non-text attachment was scrubbed... Name: sed-prereq-fix.patch Type: text/x-

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

2011-11-16 Thread Tomi Ollila
On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet wrote: > No further explanation needed. > --- > NEWS | 14 +++--- > 1 files changed, 7 insertions(+), 7 deletions(-) The 'No further explanation needed.' should be *BELOW* the waistline (---) ;); now it goes to the commit message which

[PATCH v2] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-16 Thread Tomi Ollila
If mail sending from emacs fails before it has chance to connect to the smtp-dummy mail server, the opportunistic QUIT message sending makes smtp-dummy to exit. --- Version 2 of the same feature. Now uses BASH's /dev/tcp/host/port feature instead of external 'nc' command. test/test-lib.sh |

[PATCH] emacs: Use a single buffer invisibility spec to fix quadratic search cost.

2011-11-16 Thread Pieter Praet
On Tue, 15 Nov 2011 12:17:59 -0500, servilio wrote: > Hi, > > Given that this change is about display of search results, I have the > suspicion that the following two factors might be more relevant: > > - size of the Emacs frame: bigger would mean more threads to show > > - composition of the

[PATCH 2/2] NEWS: fix some old typos and trailing whitespace

2011-11-16 Thread Pieter Praet
On Wed, 16 Nov 2011 22:54:35 +0200, Tomi Ollila wrote: > On Wed, 16 Nov 2011 21:37:50 +0100, Pieter Praet wrote: > > No further explanation needed. > > --- > > NEWS | 14 +++--- > > 1 files changed, 7 insertions(+), 7 deletions(-) > > The 'No further explanation needed.' should be

Winter is coming [upcoming release 0.10]

2011-11-16 Thread David Bremner
On Wed, 16 Nov 2011 21:37:48 +0100, Pieter Praet wrote: > Thanks David, awesome job! > > You're very welcome. I hope you still feel that way when you see how I amended your commits ;). If not, send updates. d

[PATCH] emacs: breakout notmuch-show-advance functionality from notmuch-show-advance-and-archive

2011-11-16 Thread Pieter Praet
On Sun, 13 Nov 2011 13:16:48 -0800, Jameson Graef Rollins wrote: > This patch breaks out much of the functionality of > notmuch-show-advance-and-archive into a new function: > notmuch-show-advance. This new function does all the advancing > through a show buffer that