Re: [PATCH] test: test-lib.el: replace sleep-for with sit-for in notmuch-test-wait

On Fri, Aug 03 2012, Austin Clements amdra...@mit.edu wrote: Code LGTM, but maybe the comment should explain that this is a workaround for a bug in Emacs, given that both sleep-for and sit-for are supposed to process process output and run sentinels (which has been stated in the Elisp

[PATCH v2 1/7] build: drop the -Wswitch-enum warning

-Wswitch-enum is a bit awkward if a switch statement is intended to handle just some of the named codes of an enumeration especially, and leave the rest to the default label. We already have -Wall, which enables -Wswitch by default, and per GCC documentation, The only difference between -Wswitch

[PATCH v2 0/7] notmuch search date:since..until query support

Hi all, immediate v2 of id:cover.1344028781.git.j...@nikula.org just to rebase patch 3 against master. No other changes. BR, Jani. Jani Nikula (7): build: drop the -Wswitch-enum warning lib: add a date/time parser module test: add new test tool parse-time for date/time parser test: add

[PATCH v2 3/7] test: add new test tool parse-time for date/time parser

Add a tool to support testing the date/time parser module directly and independent of the rest of notmuch. --- test/Makefile.local |7 ++- test/basic |2 +- test/parse-time.c | 145 +++ 3 files changed, 152 insertions(+), 2

[PATCH v2 2/7] lib: add a date/time parser module

Build a date/time parser as part of the notmuch lib, to be used for adding date range query support later on. Signed-off-by: Jani Nikula j...@nikula.org --- lib/Makefile.local |1 + lib/parse-time-string.c | 1384 +++ lib/parse-time-string.h |

[PATCH v2 4/7] test: add smoke tests for the date/time parser module

Test the date/time parser module directly. Just a small sanity test initially. --- test/notmuch-test |1 + test/parse-time-string | 26 ++ 2 files changed, 27 insertions(+) create mode 100755 test/parse-time-string diff --git a/test/notmuch-test

[PATCH v2 5/7] lib: add date range query support

Add a custom value range processor to enable date and time searches of the form date:since..until, where since and until are expressions understood by the previously added date/time parser, to restrict the results to messages within a particular time range (based on the Date: header). If since or

[PATCH v2 6/7] test: add tests for date:since..until range queries

A brief initial test set. --- test/notmuch-test |1 + test/search-date | 21 + 2 files changed, 22 insertions(+) create mode 100755 test/search-date diff --git a/test/notmuch-test b/test/notmuch-test index 80e687e..1654eb6 100755 --- a/test/notmuch-test +++

[PATCH v2 7/7] man: document the date:since..until range queries

--- man/man7/notmuch-search-terms.7 | 147 +++ 1 file changed, 135 insertions(+), 12 deletions(-) diff --git a/man/man7/notmuch-search-terms.7 b/man/man7/notmuch-search-terms.7 index b8ab52d..cec3785 100644 --- a/man/man7/notmuch-search-terms.7 +++

[PATCH v2] notmuch-restore: replace positional argument for input with option

From: David Bremner brem...@debian.org Since notmuch dump doesn't use positional arguments anymore, it seems better to be consistent. --- dunno how I missed the failing test in maildir-sync man/man1/notmuch-restore.1 |2 +- notmuch-restore.c |2 +- test/dump-restore |

Re: Remove positional arguments to dump and restore

On Fri, Aug 03 2012, da...@tethera.net wrote: The positional argument to dump was deprecated quite a while ago. For restore, we never formally deprecated it. It seems a bit more consistent this way, but I don't mind leaving restore alone if people feel strongly about it. LGTM. jamie.

Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected

Quoth Adrien Bustany on Jul 24 at 1:03 am: Le 20/07/2012 06:23, Austin Clements a écrit : Quoth Adrien Bustany on Jul 19 at 9:25 pm: Le 18/07/2012 23:40, Austin Clements a écrit : This is subtle enough that I think it deserves a comment in the source code explaining that tracking the talloc

[PATCH 0/7] notmuch search date:since..until query support

Hi all, this series adds a decent date range query support to the notmuch lib. For example: $ notmuch search date:2012-01-01..2012-02-01 $ notmuch search date:10:00..13:00 $ notmuch search date:monday..friday $ notmuch search date:2months5days..2weeks5hours $ notmuch search

[PATCH 1/7] build: drop the -Wswitch-enum warning

-Wswitch-enum is a bit awkward if a switch statement is intended to handle just some of the named codes of an enumeration especially, and leave the rest to the default label. We already have -Wall, which enables -Wswitch by default, and per GCC documentation, "The only difference between -Wswitch

[PATCH 3/7] test: add new test tool parse-time for date/time parser

Add a tool to support testing the date/time parser module directly and independent of the rest of notmuch. --- test/Makefile.local |9 +++- test/basic |2 +- test/parse-time.c | 145 +++ 3 files changed, 153 insertions(+), 3

[PATCH 4/7] test: add smoke tests for the date/time parser module

Test the date/time parser module directly. Just a small sanity test initially. --- test/notmuch-test |1 + test/parse-time-string | 26 ++ 2 files changed, 27 insertions(+) create mode 100755 test/parse-time-string diff --git a/test/notmuch-test

[PATCH 5/7] lib: add date range query support

Add a custom value range processor to enable date and time searches of the form date:since..until, where "since" and "until" are expressions understood by the previously added date/time parser, to restrict the results to messages within a particular time range (based on the Date: header). If

[PATCH 6/7] test: add tests for date:since..until range queries

A brief initial test set. --- test/notmuch-test |1 + test/search-date | 21 + 2 files changed, 22 insertions(+) create mode 100755 test/search-date diff --git a/test/notmuch-test b/test/notmuch-test index 80e687e..1654eb6 100755 --- a/test/notmuch-test +++

[PATCH 2/7] lib: add a date/time parser module

Build a date/time parser as part of the notmuch lib, to be used for adding date range query support later on. Signed-off-by: Jani Nikula --- lib/Makefile.local |1 + lib/parse-time-string.c | 1384 +++ lib/parse-time-string.h | 95 3

[PATCH 7/7] man: document the date:since..until range queries

--- man/man7/notmuch-search-terms.7 | 147 +++ 1 file changed, 135 insertions(+), 12 deletions(-) diff --git a/man/man7/notmuch-search-terms.7 b/man/man7/notmuch-search-terms.7 index b8ab52d..cec3785 100644 --- a/man/man7/notmuch-search-terms.7 +++

Remove positional arguments to dump and restore

The positional argument to dump was deprecated quite a while ago. For restore, we never formally deprecated it. It seems a bit more consistent this way, but I don't mind leaving restore alone if people feel strongly about it.

[PATCH 1/2] notmuch-dump: remove deprecated positional argument for output file

From: David Bremner The syntax --output=filename is a smaller change than deleting the output argument completely, and conceivably useful e.g. when running notmuch under a debugger. --- man/man1/notmuch-dump.1 |5 ++--- notmuch-dump.c |3 +--

[PATCH 2/2] notmuch-restore: replace positional argument for input with option

From: David Bremner Since notmuch dump doesn't use positional arguments anymore, it seems better to be consistent. --- man/man1/notmuch-restore.1 |2 +- notmuch-restore.c |2 +- test/dump-restore |8 3 files changed, 6 insertions(+), 6

[PATCH] test: test-lib.el: replace sleep-for with sit-for in notmuch-test-wait

On Fri, Aug 03 2012, Austin Clements wrote: > Code LGTM, but maybe the comment should explain that this is a > workaround for a bug in Emacs, given that both sleep-for and sit-for > are supposed to process process output and run sentinels (which has > been stated in the Elisp reference at least

[PATCH v2 1/7] build: drop the -Wswitch-enum warning

-Wswitch-enum is a bit awkward if a switch statement is intended to handle just some of the named codes of an enumeration especially, and leave the rest to the default label. We already have -Wall, which enables -Wswitch by default, and per GCC documentation, "The only difference between -Wswitch

[PATCH v2 0/7] notmuch search date:since..until query support

Hi all, immediate v2 of id:"cover.1344028781.git.jani at nikula.org" just to rebase patch 3 against master. No other changes. BR, Jani. Jani Nikula (7): build: drop the -Wswitch-enum warning lib: add a date/time parser module test: add new test tool parse-time for date/time parser test:

[PATCH v2 3/7] test: add new test tool parse-time for date/time parser

Add a tool to support testing the date/time parser module directly and independent of the rest of notmuch. --- test/Makefile.local |7 ++- test/basic |2 +- test/parse-time.c | 145 +++ 3 files changed, 152 insertions(+), 2

[PATCH v2 2/7] lib: add a date/time parser module

Build a date/time parser as part of the notmuch lib, to be used for adding date range query support later on. Signed-off-by: Jani Nikula --- lib/Makefile.local |1 + lib/parse-time-string.c | 1384 +++ lib/parse-time-string.h | 95 3

[PATCH v2 4/7] test: add smoke tests for the date/time parser module

Test the date/time parser module directly. Just a small sanity test initially. --- test/notmuch-test |1 + test/parse-time-string | 26 ++ 2 files changed, 27 insertions(+) create mode 100755 test/parse-time-string diff --git a/test/notmuch-test

[PATCH v2 5/7] lib: add date range query support

Add a custom value range processor to enable date and time searches of the form date:since..until, where "since" and "until" are expressions understood by the previously added date/time parser, to restrict the results to messages within a particular time range (based on the Date: header). If

[PATCH v2 6/7] test: add tests for date:since..until range queries

A brief initial test set. --- test/notmuch-test |1 + test/search-date | 21 + 2 files changed, 22 insertions(+) create mode 100755 test/search-date diff --git a/test/notmuch-test b/test/notmuch-test index 80e687e..1654eb6 100755 --- a/test/notmuch-test +++

[PATCH v2 7/7] man: document the date:since..until range queries

--- man/man7/notmuch-search-terms.7 | 147 +++ 1 file changed, 135 insertions(+), 12 deletions(-) diff --git a/man/man7/notmuch-search-terms.7 b/man/man7/notmuch-search-terms.7 index b8ab52d..cec3785 100644 --- a/man/man7/notmuch-search-terms.7 +++

[PATCH v2] notmuch-restore: replace positional argument for input with option

From: David Bremner Since notmuch dump doesn't use positional arguments anymore, it seems better to be consistent. --- dunno how I missed the failing test in maildir-sync man/man1/notmuch-restore.1 |2 +- notmuch-restore.c |2 +- test/dump-restore

Remove positional arguments to dump and restore

LGTM. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120804/dd80099c/attachment.pgp>

[PATCH 3/7] go: Allow notmuch objects to be garbage collected

Quoth Adrien Bustany on Jul 24 at 1:03 am: > Le 20/07/2012 06:23, Austin Clements a ?crit : > >Quoth Adrien Bustany on Jul 19 at 9:25 pm: > >>Le 18/07/2012 23:40, Austin Clements a ?crit : > >>>This is subtle enough that I think it deserves a comment in the source > >>>code explaining that