[PATCH] test: run uncrustify

2019-06-25 Thread Daniel Kahn Gillmor
This is the result of running: $ uncrustify --replace --config ../devel/uncrustify.cfg *.cc *.c *.h in the test directory. Signed-off-by: Daniel Kahn Gillmor --- test/arg-test.c | 72 + test/ghost-report.cc| 10 +++--- test/hex-xcode.c

Re: [PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display

2019-06-25 Thread Daniel Kahn Gillmor
On Mon 2019-06-24 20:02:13 -0700, William Casarin wrote: > dkg wrote: >> +if ((protected_headers = g_mime_object_get_header_list (payload), >> protected_headers) && >> +(legacy_display = GMIME_TEXT_PART (first), legacy_display) && >> +(legacy_display_header_text = g_mime_text_part_get_

Re: [PATCH 1/7] mime-node: split out _mime_node_set_up_part

2019-06-25 Thread Daniel Kahn Gillmor
On Mon 2019-06-24 19:43:58 -0700, William Casarin wrote: >> +static bool >> +_mime_node_set_up_part (mime_node_t *node, GMimeObject *part, int numchild); >> + > > nit: Instead of a forward declaration, could _mime_node_create be moved after > _mime_node_set_up_part instead? yep, we could definitel

Re: [PATCH 1/2] test: provide machinery to make and use test_shims

2019-06-25 Thread Tomi Ollila
On Sun, May 26 2019, David Bremner wrote: > These can be used e.g. to override return values for functions, in > place of the existing scripting of gdb. > --- > test/test-lib.sh | 16 > 1 file changed, 16 insertions(+) > > diff --git a/test/test-lib.sh b/test/test-lib.sh > index

Re: [PATCH] vim: Patch Ruby Mail's depracated method

2019-06-25 Thread Daniel Kahn Gillmor
On Mon 2019-03-18 15:10:51 +0100, Tarvi Verro wrote: > Method is not supported in Ruby's Mail 2.8.0+. > --- > vim/notmuch.vim | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/vim/notmuch.vim b/vim/notmuch.vim > index ad8b7c80..541698cd 100644 > --- a/vim/notmuch.vim > +++ b

Re: [PATCH 1/2] test: provide machinery to make and use test_shims

2019-06-25 Thread Daniel Kahn Gillmor
On Wed 2019-06-26 00:05:09 +0300, Tomi Ollila wrote: > LD_PRELOAD=./${shim_file}${LD_PRELOAD:+:$LD_PRELOAD} notmuch-shared "$@" > > So that if LD_PRELOAD is already set and is non-empty then ':' and its > old value is appended to new value of LD_PRELOAD before this > notmuch-shared invocation. agr