Re: [PATCH v2 4/5] cli/show: reindex when we learned new session keys about a message

On Wed 2018-05-09 14:42:35 -0400, Daniel Kahn Gillmor wrote: > I avoided #if'ing out these sections because i thought the general > strategy was to avoid preprocessor shenanigans where possible, as it > makes the code harder to think about given the combinatorial explosion > of #define options.

Re: [PATCH v2 4/5] cli/show: reindex when we learned new session keys about a message

On Tue 2018-05-01 22:36:31 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> + >> +if (params->crypto.decrypt == NOTMUCH_DECRYPT_TRUE && >> session_key_count_error == NOTMUCH_STATUS_SUCCESS) { >> +unsigned int new_session_keys = 0; >> +if

Re: [PATCH v2 4/5] cli/show: reindex when we learned new session keys about a message

Daniel Kahn Gillmor writes: > + > +if (params->crypto.decrypt == NOTMUCH_DECRYPT_TRUE && > session_key_count_error == NOTMUCH_STATUS_SUCCESS) { > + unsigned int new_session_keys = 0; > + if (notmuch_message_count_properties (message, "session-key", >

[PATCH v2 4/5] cli/show: reindex when we learned new session keys about a message

If the number of session keys for a given message increased after running "notmuch show" then we just learned something new that might let us do automatic decryption. We should reindex this message using our newfound knowledge. --- notmuch-show.c | 20 1 file changed, 20