Duplicate message ids

2017-08-27 Thread Mark Walters
, and then runs notmuch search and notmuch show . The former shows the subject of the first message, and the latter the subject of the second message. Best wishes Mark #!/usr/bin/env bash test_description='Do duplicate message ids get shown in arrival order' . ./test-lib.sh ||

[Patch v4 06/12] lib: index message files with duplicate message-ids

2017-07-21 Thread David Bremner
.@example.com [filename]=copy2 [date]="Fri, 05 Jan 2001 15:43:52 +"' cat < EXPECTED [ [ diff --git a/test/T670-duplicate-mid.sh b/test/T670-duplicate-mid.sh index ced28a21..137cb6a5 100755 --- a/test/T670-duplicate-mid.sh +++ b/test/T670-duplicate-mid.sh @@ -5,8 +5,14

[PATCH] fixup! lib: index message files with duplicate message-ids

2017-06-10 Thread David Bremner
-duplicate-mid.sh @@ -5,6 +5,13 @@ test_description="duplicate message ids" add_message '[id]="duplicate"' '[subject]="message 1" [filename]=copy1' add_message '[id]="duplicate"' '[subject]="message 2" [filenam

Re: [patch v3 06/12] lib: index message files with duplicate message-ids

2017-06-09 Thread David Bremner
ge >> files with duplicate message-ids". that's a bit odd, no? > > Yes, I agree that's a bit strange. We should make some effort to > display the subject that belongs with a given message body. I think it's > not too hard [1] to preserve the old behaviour of ke

Re: [patch v3 06/12] lib: index message files with duplicate message-ids

2017-06-05 Thread David Bremner
give it a subject "Re: [patch v3 06/12] lib: do *not* index message > files with duplicate message-ids". that's a bit odd, no? Yes, I agree that's a bit strange. We should make some effort to display the subject that belongs with a given message body. I think it's not to

Re: [patch v3 06/12] lib: index message files with duplicate message-ids

2017-06-05 Thread Daniel Kahn Gillmor
the current message with another message with Message-Id: 20170604123235.24466-7-da...@tethera.net and give it a subject "Re: [patch v3 06/12] lib: do *not* index message files with duplicate message-ids". that's a bit odd, no? I'm not saying it's wrong, i'm just hoping t

[patch v3 06/12] lib: index message files with duplicate message-ids

2017-06-04 Thread David Bremner
The corresponding xapian document just gets more terms added to it, but this doesn't seem to break anything. Values on the other hand get overwritten, which is a bit annoying, but arguably it is not worse to take the values (from, subject, date) from the last file indexed rather than the first. ---

[PATCH 06/12] lib: index message files with duplicate message-ids

2017-05-13 Thread David Bremner
The corresponding xapian document just gets more terms added to it, but this doesn't seem to break anything. Values on the other hand get overwritten, which is a bit annoying, but arguably it is not worse to take the values (from, subject, date) from the last file indexed rather than the first. ---

[PATCH 06/10] lib: index message files with duplicate message-ids

2017-05-13 Thread David Bremner
The corresponding xapian document just gets more terms added to it, but this doesn't seem to break anything. Values on the other hand get overwritten, which is a bit annoying, but arguably it is not worse to take the values (from, subject, date) from the last file indexed rather than the first. ---

[PATCH 06/10] lib: index message files with duplicate message-ids

2017-05-13 Thread David Bremner
The corresponding xapian document just gets more terms added to it, but this doesn't seem to break anything. Values on the other hand get overwritten, which is a bit annoying, but arguably it is not worse to take the values (from, subject, date) from the last file indexed rather than the first. ---

[rfc patch v3 6/6] lib: index message files with duplicate message-ids

2017-04-03 Thread David Bremner
+2,10 @@ test_description="duplicate message ids" . ./test-lib.sh || exit 1 -add_message '[id]="id:duplicate"' '[subject]="message 1"' -add_message '[id]="id:duplicate"' '[subject]="message 2"' +add_message &

[rfc patch v2 5/5] lib: index message files with duplicate message-ids

2017-04-02 Thread David Bremner
+2,10 @@ test_description="duplicate message ids" . ./test-lib.sh || exit 1 -add_message '[id]="id:duplicate"' '[subject]="message 1"' -add_message '[id]="id:duplicate"' '[subject]="message 2"' +add_message &

Re: [RFC patch 2/2] lib: index message files with duplicate message-ids

2017-03-22 Thread Jani Nikula
On Thu, 16 Mar 2017, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> On Wed 2017-03-15 21:57:28 -0400, David Bremner wrote: >>> The corresponding xapian document just gets more terms added to it, >>> but this doesn't seem to break anything. >> >> this is an interesting suggestion. thanks

Re: [RFC patch 2/2] lib: index message files with duplicate message-ids

2017-03-18 Thread David Bremner
Daniel Kahn Gillmor writes: > On Thu 2017-03-16 20:34:22 -0400, David Bremner wrote: >> Daniel Kahn Gillmor writes: >>> 0) what happens when one of the files gets deleted from the message >>> store? do the terms it contributes get removed from the index? >> >> That's a good guestion, and an

Re: [RFC patch 2/2] lib: index message files with duplicate message-ids

2017-03-17 Thread Daniel Kahn Gillmor
On Thu 2017-03-16 20:34:22 -0400, David Bremner wrote: > Daniel Kahn Gillmor writes: >> 0) what happens when one of the files gets deleted from the message >> store? do the terms it contributes get removed from the index? > > That's a good guestion, and an issue I hadn't thought about. > Curr

Re: [RFC patch 2/2] lib: index message files with duplicate message-ids

2017-03-16 Thread Mark Walters
Hi Just a comment on your last point: > It also occurs to me that one of the things i'd love to have is > well-indexed notes about any given e-mail. So if this was adopted, i > could presumably just write a file that has the same Message-Id as the > message, put my notes in it, and index it. t

Re: [RFC patch 2/2] lib: index message files with duplicate message-ids

2017-03-16 Thread David Bremner
Daniel Kahn Gillmor writes: > On Wed 2017-03-15 21:57:28 -0400, David Bremner wrote: >> The corresponding xapian document just gets more terms added to it, >> but this doesn't seem to break anything. > > this is an interesting suggestion. thanks for proposing it! > > A couple questions: > > 0)

Re: [RFC patch 2/2] lib: index message files with duplicate message-ids

2017-03-16 Thread Daniel Kahn Gillmor
On Wed 2017-03-15 21:57:28 -0400, David Bremner wrote: > The corresponding xapian document just gets more terms added to it, > but this doesn't seem to break anything. this is an interesting suggestion. thanks for proposing it! A couple questions: 0) what happens when one of the files gets del

[RFC patch 2/2] lib: index message files with duplicate message-ids

2017-03-15 Thread David Bremner
The corresponding xapian document just gets more terms added to it, but this doesn't seem to break anything. --- lib/database.cc| 3 +++ test/T670-duplicate-mid.sh | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index a679cbab..e83