Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show

2022-05-18 Thread David Bremner
Alexander Adolf writes: > > Ok, I have added the line as you suggest. I was wondering though, as in > principle the secret key of test_su...@notmuchmail.org could be > available (it's in the key-ring at least)? Yes, it's added to the test suite's temporary keyring. One of the messages in

Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show

2022-05-16 Thread Alexander Adolf
Hello David, admittedly being unfamiliar with the test suite, and not being able to run the tests at my end, this is a bit of a head scratcher for me. Thus up-front apologies, and thanks for bearing with me! David Bremner writes: > [...] > It seems that it is mostly working, but there are a

Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show

2022-05-11 Thread Alexander Adolf
David Bremner writes: > [...] > It seems that it is mostly working, but there are a few issues to iron out. > [...] Hello David, Apologies for the delay in getting back to you. I was busy with other stuff, and will tend to this shortly. Cheers, --alexander

Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show

2022-04-13 Thread David Bremner
Alexander Adolf writes: > Hello David, > > David Bremner writes: > >> [...] >> I'm not sure it's less effort, >> [...] > > Neither am I... ;-)) > > It might perhaps seem easier to run the tests I have added to the > attached, updated patch in your complete environment? > > --alexander It

Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show

2022-04-12 Thread Alexander Adolf
Hello David, David Bremner writes: > [...] > I'm not sure it's less effort, > [...] Neither am I... ;-)) It might perhaps seem easier to run the tests I have added to the attached, updated patch in your complete environment? --alexander >From ba6f00bbd1803f5cccfafdb262f17b79b6c95252

Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show

2022-04-11 Thread David Bremner
Alexander Adolf writes: > David Bremner writes: > >> [...] >> You could also run T355-smime with --debug and inspect >> tmp.T355-smime/mail afterwards, there should be some signed and >> encrypted mails. >> [...] > > $ ./T355-smime.sh --debug > Run tests in a subdir of built notmuch tree. > >

Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show

2022-04-11 Thread Alexander Adolf
David Bremner writes: > [...] > You could also run T355-smime with --debug and inspect > tmp.T355-smime/mail afterwards, there should be some signed and > encrypted mails. > [...] $ ./T355-smime.sh --debug Run tests in a subdir of built notmuch tree. Any way around the effort of building from

Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show

2022-04-07 Thread David Bremner
Alexander Adolf writes: > > Where can I find the S/MIME test key? test/smime directory? test/smime/0xE0972A47.p12 > Is there a better way for generating the test messages than importing > the test key into my "production" keychain? Look to T355-smime for > inspiration? The former is probably

Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show

2022-04-07 Thread Alexander Adolf
David Bremner writes: > [...] > I think something like the following test (but with an smime encrypted > message instead of the existing PGP/MIME encrypted message. > > test_begin_subtest "process cryptographic MIME parts" > ;; additional variables can be dynamically bound as needed, but

Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show

2022-04-07 Thread David Bremner
Alexander Adolf writes: > > I have had a look to both files, and I _think_ T450-emacs-show would > seem more appropriate. It seems that T355-smime is more aimed at the > pure mechanics of en-/decryption, and the handling of that in > libnotmuch. Neither of these have been a problem for me. > >

Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show

2022-04-06 Thread Alexander Adolf
Hello David, David Bremner writes: > [...] > Thanks for sending that. It's a bit tricky to review SMIME stuff as I > believe none of the devs is really using SMIME regularly. One thing that > would help is adding one or more tests. Basically the test suite already > has a SMIME certificate, so

Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show

2022-03-29 Thread David Bremner
Alexander Adolf writes: > The issue I saw with S/MIME encrypted messages was, that the processing > of the MIME tree stopped after decryption. It turned out there was no > handler for application/(x-)?pkcs-mime type entities in notmuch-show.el, > and the "handler of last resort"